From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABE88C433EF for ; Mon, 13 Jun 2022 11:03:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0B04D8D0179; Mon, 13 Jun 2022 07:03:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 039D68D0171; Mon, 13 Jun 2022 07:03:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DCE888D0179; Mon, 13 Jun 2022 07:03:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CDD578D0171 for ; Mon, 13 Jun 2022 07:03:20 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 9C13260E88 for ; Mon, 13 Jun 2022 11:03:20 +0000 (UTC) X-FDA: 79572926160.22.FDE1A36 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 17281A0093 for ; Mon, 13 Jun 2022 11:03:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655118199; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j5D3sK3qxzP9CGnwsiLKPN/J+KjY10e+k7sKDOcqT5o=; b=ArBYIoRqW7vUAkyCw4C0BKrq4hrfVWOrel+I0pW4ghFeNsaj2QEVr8PKVimBXVtladaYEo VhY0ItjAo5kRGz1BsEvsWb0bprH9OXa1bAR06jvPSMY2GLU/OPEITUl2I/OTF6pMG/ROyq eLevBxodryIpuBwVd1rT9vF2rwtVctc= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-574-IAzNofPoOzG3eoK0FLBU5Q-1; Mon, 13 Jun 2022 07:03:16 -0400 X-MC-Unique: IAzNofPoOzG3eoK0FLBU5Q-1 Received: by mail-wm1-f69.google.com with SMTP id o23-20020a05600c511700b0039743cd8093so3016066wms.6 for ; Mon, 13 Jun 2022 04:03:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=j5D3sK3qxzP9CGnwsiLKPN/J+KjY10e+k7sKDOcqT5o=; b=5JZaxQHRFH0BdqRppvcCM5SsRaRXuwS9tVu9f4oGzZcRJ/kYeG5vxd312b6Gz7Buyy dZ4+KvPB9UnvL+Emu2icgsqmBfRm/fYKyl4cFOkD2Gsgzq4n1EyXxc0XdtVRHfQ+yEmw 7/jNjW+gM23jk+MjUcLYebvpTjWunPszZaJ05cfobgD+HheUR0UpCkuy+VbEkxt7MRdw ra/leh9DnYS81sAh31G9tAtXPvAMzvvnII7ztuZbkNQY9oeRndAHThVZFLfxijKdv/AW CFuzm5wmAW+moCTbhT0nV1xcutLlYwqlaZnSzSP5RcZnpmdbJxzMbCGnVOc1qboi73ft QKiA== X-Gm-Message-State: AOAM530FE7XABo5Y5xBuJOAF0U2kWUn5JeoThOoMvXW7620mXFb6Alzj M4gZz3GHIWIzbK16J0j6JISlUSnf+vQXjwi/pbBvmu6ZSufDNFoFw0u3iBLLFVjxsa6Z3jy1Ad9 QRMrg2kghpPg= X-Received: by 2002:a05:600c:3508:b0:39c:8240:5538 with SMTP id h8-20020a05600c350800b0039c82405538mr13049419wmq.165.1655118195263; Mon, 13 Jun 2022 04:03:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyDoO2UACoWH0XUMegJUwRA9D70xt70UBbXMGCQlKNX3UWoHBV/NMn9vGGLzctDprJh1GcUdg== X-Received: by 2002:a05:600c:3508:b0:39c:8240:5538 with SMTP id h8-20020a05600c350800b0039c82405538mr13049370wmq.165.1655118194993; Mon, 13 Jun 2022 04:03:14 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:bd00:963c:5455:c10e:fa6f? (p200300cbc706bd00963c5455c10efa6f.dip0.t-ipconnect.de. [2003:cb:c706:bd00:963c:5455:c10e:fa6f]) by smtp.gmail.com with ESMTPSA id s7-20020a5d4247000000b0021018642ff8sm8136796wrr.76.2022.06.13.04.03.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jun 2022 04:03:14 -0700 (PDT) Message-ID: <4c4cf0a8-aab6-2a17-e1f9-59d6700821b7@redhat.com> Date: Mon, 13 Jun 2022 13:03:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v4 4/6] mm: Limit warning message in vmemmap_verify() to once To: Wupeng Ma , corbet@lwn.net, will@kernel.org, ardb@kernel.org, catalin.marinas@arm.com Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, dvhart@infradead.org, andy@infradead.org, rppt@kernel.org, akpm@linux-foundation.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, paulmck@kernel.org, keescook@chromium.org, songmuchun@bytedance.com, rdunlap@infradead.org, damien.lemoal@opensource.wdc.com, swboyd@chromium.org, wei.liu@kernel.org, robin.murphy@arm.com, anshuman.khandual@arm.com, thunder.leizhen@huawei.com, wangkefeng.wang@huawei.com, gpiccoli@igalia.com, chenhuacai@kernel.org, geert@linux-m68k.org, vijayb@linux.microsoft.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org References: <20220613082147.183145-1-mawupeng1@huawei.com> <20220613082147.183145-5-mawupeng1@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220613082147.183145-5-mawupeng1@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655118200; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j5D3sK3qxzP9CGnwsiLKPN/J+KjY10e+k7sKDOcqT5o=; b=24iMpJCjXXqyb24SOHDO6TtQ317Hnp4lRtLZkgDqkwOsYixxp2FZpzBW4/e/lHPPMK4NAb OU0wUPYAhzcNe00+30dLlVpg8CMxBhZePanujWWbTzf0seYZJ9RBXYu0EpRLlb6+GzUM1n 4w3wdWCgLX0r81F2I0eeHWqhCqnWNgs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655118200; a=rsa-sha256; cv=none; b=UdZdjHT+DKzHNdjmccoeCHek3zIXC5V/D+LI9rvAwr0yF+h7ubo85Mt/V01jlPHx5lt8W7 VLFRNtlIbuvFfzET36E44Bj+OVqxyE8PhZbwZ2uutgLXVK/CWZJ41S6koMb5lQTzDA+OxF KXRUOsoSwPj+wvMdoPTnIAqzQVm/dro= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ArBYIoRq; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf25.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam11 X-Rspam-User: Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ArBYIoRq; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf25.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-Stat-Signature: of94jypwrhuksxgeyqjigei5ghb44aum X-Rspamd-Queue-Id: 17281A0093 X-HE-Tag: 1655118199-724409 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 13.06.22 10:21, Wupeng Ma wrote: > From: Ma Wupeng > > For a system only have limited mirrored memory or some numa node without > mirrored memory, the per node vmemmap page_structs prefer to allocate > memory from mirrored region, which will lead to vmemmap_verify() in > vmemmap_populate_basepages() report lots of warning message. > > This patch change the frequency of "potential offnode page_structs" warning > messages to only once to avoid a very long print during bootup. > > Signed-off-by: Ma Wupeng > --- > mm/sparse-vmemmap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/sparse-vmemmap.c b/mm/sparse-vmemmap.c > index f4fa61dbbee3..f34c6889b0a6 100644 > --- a/mm/sparse-vmemmap.c > +++ b/mm/sparse-vmemmap.c > @@ -528,7 +528,7 @@ void __meminit vmemmap_verify(pte_t *pte, int node, > int actual_node = early_pfn_to_nid(pfn); > > if (node_distance(actual_node, node) > LOCAL_DISTANCE) > - pr_warn("[%lx-%lx] potential offnode page_structs\n", > + pr_warn_once("[%lx-%lx] potential offnode page_structs\n", > start, end - 1); > } > Acked-by: David Hildenbrand -- Thanks, David / dhildenb