From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21D7CC54798 for ; Tue, 27 Feb 2024 09:11:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6470294000A; Tue, 27 Feb 2024 04:11:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F7B2940008; Tue, 27 Feb 2024 04:11:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4BF8894000A; Tue, 27 Feb 2024 04:11:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3B626940008 for ; Tue, 27 Feb 2024 04:11:41 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0EAE612052C for ; Tue, 27 Feb 2024 09:11:41 +0000 (UTC) X-FDA: 81837016002.25.2B39F02 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf27.hostedemail.com (Postfix) with ESMTP id 660A640022 for ; Tue, 27 Feb 2024 09:11:38 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf27.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709025098; a=rsa-sha256; cv=none; b=xihEgjFlmB1Zz7hdSpzG6OAtFCNfp7YgmqSdqpHkXtRP599TUG/w/0WIiiaodQPrmTV40i I22gQjRkuqo7kNP51ulzDDnYttkzLuGU9yXhR3sM7E1/iovDQ0k263hiVNA1H21WNvuoVZ g9g2tC3aNUJ9GG66l5EOoDXayN+oRbM= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf27.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709025098; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=el80kYtmZhhRPD7Q8o3YzcBeJPvcrYCvtEcltm9M3R0=; b=P3v8HuPji0ky+gS/RL5bycos1ZNnhSo7WK5CcR0TA0VnIgwQRbHXoL4t/8enPFkvrvkf/6 zHFDhJOaRvKg3SMpP4mdk1gTokRwHfFDoIaO0yxxj6s3WpNEmTpL9NQW91dsLt4ZovM37L TPzTkRIxUc5ShS36P7ZuVujO9k/ihh0= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8C163DA7; Tue, 27 Feb 2024 01:12:15 -0800 (PST) Received: from [10.57.67.4] (unknown [10.57.67.4]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CB49E3F762; Tue, 27 Feb 2024 01:11:35 -0800 (PST) Message-ID: <4c3d1891-e784-4599-9640-4ff092ba7a31@arm.com> Date: Tue, 27 Feb 2024 09:11:35 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: export folio_pte_batch as a couple of modules might need it Content-Language: en-GB To: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org, David Hildenbrand Cc: linux-kernel@vger.kernel.org, Barry Song , Lance Yang , Yin Fengwei References: <20240227024050.244567-1-21cnbao@gmail.com> From: Ryan Roberts In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 660A640022 X-Stat-Signature: mwhy5in55txxmy4qous6ztop9n44t7yj X-Rspam-User: X-HE-Tag: 1709025098-467772 X-HE-Meta: U2FsdGVkX19e86KLoNNr6KIjXZwSxqzzRP866fQZM3K6Xxr9LOx18oYujIJ7GSMcyOVP4eHAn57dPqebmG0TlWAClejOSM4Kx1blbMdBbyArAcHEqxFPQbinmKWQ3PFENvsufikF5GS4yJo9PHCATF3pZ6AfxBNnk/y4fw7cnBObZH19H/9TnITJMqFlAvN2JVW9rHjQtuohw4pdblAHJgPsJf81uRptOfRHI+o3W5hIPV89TCiOG9S0npAYzFC/Q9M2NHM80ncqt9Sjc5YYvnBqLFMvt3ThxvLqaMd6HSH/CBarKFYz1oWckiYi087zfrzplNkw8ptntCN9NjD+ORFkTCWd4Zy9J2JPN12NBo1GwZey10+X6NHYDj9LaAw2r+tGNrZAHFNtjHZJLj1LAJ3nTSyXOLMBebusOdiGOaAfSAdAAYTOtBRmcSEoq3A9CvpL5qfQwa1Gpt3iSY+dv0QUgoowgKcvG2Hb65+hKasG7EqOK7XMHvaRfpO5mWrNtmsNXc55ffm12hQd6sK8Js6yVz1MXjbWDYIM8H6sAFZk4n/hskQ62BQcDkjbr90q1ulBnL6T1I3dOfUndLpqk3WHiGiQX8B3S+4EREtG9ovyASns9Dhs8A6OITDkNq3X2YWymIXRHUZOh5HWx7AapmDeoAsmFdTB+zSckzAwf67LEBwtgd7XbfXgBLYJN4hNWHnZOOkqxgSRJVHuKeW8qmXvmFs+i6gXv1DQft7N0FzOJJ7XTskStIemBPsmtwYXi8otcfaKy/m1mM5aSkXzhzdUFOOowoaQlVw7OAj48oexUZSzKJHrHwS6Mvzv2PyaS+ZqKQH58YvB6nb2r4dojpHIRJq8pPiAYSLFIJ5d9XbJ0NYThQp3G2Ai/4RZ4f4ytzk02CTdlmc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 27/02/2024 03:18, Barry Song wrote: > On Tue, Feb 27, 2024 at 3:41 PM Barry Song <21cnbao@gmail.com> wrote: >> >> From: Barry Song >> >> madvise and some others might need folio_pte_batch to check if a range >> of PTEs are completely mapped to a large folio with contiguous physcial >> addresses. Let's export it for others to use. >> >> Cc: Lance Yang >> Cc: Ryan Roberts >> Cc: David Hildenbrand > > Hi David, Ryan, > > Sorry, I realize I just made a mistake and your tags should be both > Suggested-by. Please feel > free to review the patch and give comments. I will fix the tags > together with addressing your > review comments in v2. Don't worry about it. Don't feel you need to update it on my account. > >> Cc: Yin Fengwei >> Signed-off-by: Barry Song >> --- >> -v1: >> at least two jobs madv_free and madv_pageout depend on it. To avoid >> conflicts and dependencies, after discussing with Lance, we prefer >> this one can land earlier. >> >> mm/internal.h | 13 +++++++++++++ >> mm/memory.c | 11 +---------- >> 2 files changed, 14 insertions(+), 10 deletions(-) >> >> diff --git a/mm/internal.h b/mm/internal.h >> index 13b59d384845..8e2bc304f671 100644 >> --- a/mm/internal.h >> +++ b/mm/internal.h >> @@ -83,6 +83,19 @@ static inline void *folio_raw_mapping(struct folio *folio) >> return (void *)(mapping & ~PAGE_MAPPING_FLAGS); >> } >> >> +/* Flags for folio_pte_batch(). */ >> +typedef int __bitwise fpb_t; >> + >> +/* Compare PTEs after pte_mkclean(), ignoring the dirty bit. */ >> +#define FPB_IGNORE_DIRTY ((__force fpb_t)BIT(0)) >> + >> +/* Compare PTEs after pte_clear_soft_dirty(), ignoring the soft-dirty bit. */ >> +#define FPB_IGNORE_SOFT_DIRTY ((__force fpb_t)BIT(1)) >> + >> +extern int folio_pte_batch(struct folio *folio, unsigned long addr, >> + pte_t *start_ptep, pte_t pte, int max_nr, fpb_t flags, >> + bool *any_writable); >> + >> void __acct_reclaim_writeback(pg_data_t *pgdat, struct folio *folio, >> int nr_throttled); >> static inline void acct_reclaim_writeback(struct folio *folio) >> diff --git a/mm/memory.c b/mm/memory.c >> index 1c45b6a42a1b..319b3be05e75 100644 >> --- a/mm/memory.c >> +++ b/mm/memory.c >> @@ -953,15 +953,6 @@ static __always_inline void __copy_present_ptes(struct vm_area_struct *dst_vma, >> set_ptes(dst_vma->vm_mm, addr, dst_pte, pte, nr); >> } >> >> -/* Flags for folio_pte_batch(). */ >> -typedef int __bitwise fpb_t; >> - >> -/* Compare PTEs after pte_mkclean(), ignoring the dirty bit. */ >> -#define FPB_IGNORE_DIRTY ((__force fpb_t)BIT(0)) >> - >> -/* Compare PTEs after pte_clear_soft_dirty(), ignoring the soft-dirty bit. */ >> -#define FPB_IGNORE_SOFT_DIRTY ((__force fpb_t)BIT(1)) >> - >> static inline pte_t __pte_batch_clear_ignored(pte_t pte, fpb_t flags) >> { >> if (flags & FPB_IGNORE_DIRTY) >> @@ -982,7 +973,7 @@ static inline pte_t __pte_batch_clear_ignored(pte_t pte, fpb_t flags) >> * If "any_writable" is set, it will indicate if any other PTE besides the >> * first (given) PTE is writable. >> */ >> -static inline int folio_pte_batch(struct folio *folio, unsigned long addr, >> +int folio_pte_batch(struct folio *folio, unsigned long addr, >> pte_t *start_ptep, pte_t pte, int max_nr, fpb_t flags, >> bool *any_writable) >> { >> -- >> 2.34.1 >> > > Thanks > Barry