From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 822EFC76196 for ; Tue, 11 Apr 2023 15:51:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B9AF16B0072; Tue, 11 Apr 2023 11:51:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B23C2900002; Tue, 11 Apr 2023 11:51:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 976196B0078; Tue, 11 Apr 2023 11:51:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 820716B0072 for ; Tue, 11 Apr 2023 11:51:39 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 59475120D70 for ; Tue, 11 Apr 2023 15:51:39 +0000 (UTC) X-FDA: 80669550318.17.9487501 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf23.hostedemail.com (Postfix) with ESMTP id F3AB5140002 for ; Tue, 11 Apr 2023 15:51:35 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-03-30 header.b="p6+OXRS/"; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b="gx/IvU1R"; spf=pass (imf23.hostedemail.com: domain of joao.m.martins@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=joao.m.martins@oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=none) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681228296; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kaUyOIYKsuuzv1yvFgQzBZA9aSlaZjRd8Woe9B46za8=; b=d/92C0lnKGKd8OzhdkRqt+eYHsoDyX/wlfuYUo0onepxnKLIBVIVxUItwRIozQqN8kSuK8 vecQBjxZjD++QACssBTtyA9fZCq9MivPQeVFJEMcaYwg8kGPaH+NU6bDQJ5jbLzpjeVRng x4nIzsH25xwgAVaZaWSoMNPuAIziUWU= ARC-Authentication-Results: i=2; imf23.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-03-30 header.b="p6+OXRS/"; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b="gx/IvU1R"; spf=pass (imf23.hostedemail.com: domain of joao.m.martins@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=joao.m.martins@oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=none) header.from=oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1681228296; a=rsa-sha256; cv=pass; b=vFQxdh1zg2zRhC8z9o2Yz/cKzgD10A2UroM7eSeHe0dfvgbocZxQybUxjKb54wdxjpaNgf Ofpy/rEKOKH9vAlXzL3gLPug1oKG30t/+/etxYi89ALu6C+ZeiLZvgEVQkLR2hOqElItZZ pDsUAhrJKvc1ZAe9Ro6j6QlSTnfcifo= Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33BEx9Zg023132; Tue, 11 Apr 2023 15:51:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-03-30; bh=kaUyOIYKsuuzv1yvFgQzBZA9aSlaZjRd8Woe9B46za8=; b=p6+OXRS/qeWqIkaqD7kPPrZ9FogQjgg6ydRutuGxo9vmM3v4DlBB7efTRsb8u4PUDm64 bTMORnzIySj3KhYQ1uOGRHOeUKIxMZudnxcgtP8Hv+niEYoZPXsebADM9Lo+X5btCfVd 2sDGlXCD3sSZ3icrNSJ4PVAFIKf2Gr2ShJQq77Z1VRVwDeqgwEHVeq5ShLoN4JYsPkZO Wy87fvig+eZhQdRlv3pdgwrrbus7HD8n7NzHegmS7rqrzJ2YXYJPi2XMSFrPhAvVkFEp vKBjySgtWUre0MN8zZeeqkOjonmngJGIpPgvmQjKW+b2s8p0IiTOph8HxsDi7LPHVDAi OA== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3pu0eq5twe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 11 Apr 2023 15:51:19 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 33BFoFSv031007; Tue, 11 Apr 2023 15:51:18 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2171.outbound.protection.outlook.com [104.47.55.171]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3puwbnarh6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 11 Apr 2023 15:51:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f0sU4zYdq43qXDC1vLt4k+X+cPB68g62BXIebC+KVg1WXOVvhWBF0bmq01pJtxMMOcLT8K56oJdiVdEVnG82mZlozHySgjTg0S7r7otDg3UflFg8rVxqsh+P2nvW3Y/rLTL/ygYL7rTGxgtwuo3t1C25/qn0Ulg1YFTPy4bc24xlgiWMS46KMJU+bP1VFNmyIsaz7ymvy6rcH9u2IQh5FI/2bSIS50m5ZQ5EJif0qfWYCz2S37buY0cE3RPT7xEnWqKJREmz7KWHRHOkK9duSo6vFHhzYpPOvlw+C0rs47iK4pM0aP8y76LvWFi/R2RaIBE8ihLTm1dutI6Tyd+nLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kaUyOIYKsuuzv1yvFgQzBZA9aSlaZjRd8Woe9B46za8=; b=SVl5LK9b+FlnGJ5sCBmjLMDpDwHDLveUnft2OKBzKNsFDCw/sFBYhLTbRSqhoF1z7XwgDZpSlOMllzTjgfPawx14CKx9o7NneFuHajlunqEN/sgilMPLQjf4/ZCHdF7firXcETXAGKWWZ6k+TBLTbRvtY6MRgHWpV4EIOodKPBRGBpbFB+HyEZXpPjHMHKf4zDs5C2YzZUQHHI1Xds0mPUODcGzcRsf/jcqUnJA1ZpRSrkQgsrXqMvXI0hmzVZJvUjPtY9M1MyaxkikVfN+mHAcefUyGZYPizPD9EMmIhdqz04Xm0tBhxcNBm6ddsOPRQdn6SoxdAGW6BjTx8xSZhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kaUyOIYKsuuzv1yvFgQzBZA9aSlaZjRd8Woe9B46za8=; b=gx/IvU1RxMylukG0lExkorLOqOwCLpUo2eHKiR8c062M8Bn1vQKeopO1UTyaGTYQ+eopHB7ZySB4LAF6sisziYWmDL9CCLe7R7olX90HbAY4XMnTgoWBU0qRaiiXuwznOS6vQFV7fYYgfsAYt+zZc3lS8bT1974kJ+/KFVlvN+o= Received: from BLAPR10MB4835.namprd10.prod.outlook.com (2603:10b6:208:331::11) by PH7PR10MB6987.namprd10.prod.outlook.com (2603:10b6:510:27b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.30; Tue, 11 Apr 2023 15:51:11 +0000 Received: from BLAPR10MB4835.namprd10.prod.outlook.com ([fe80::b176:d5b0:55e9:1c2b]) by BLAPR10MB4835.namprd10.prod.outlook.com ([fe80::b176:d5b0:55e9:1c2b%3]) with mapi id 15.20.6277.038; Tue, 11 Apr 2023 15:51:11 +0000 Message-ID: <4c3797a7-45d0-f876-2d44-3238e66d5b77@oracle.com> Date: Tue, 11 Apr 2023 16:50:58 +0100 Subject: Re: [PATCH v2 1/2] mm/vmemmap/devdax: Fix kernel crash when probing devdax devices Content-Language: en-US To: "Aneesh Kumar K.V" Cc: Muchun Song , Dan Williams , Tarun Sahu , linux-mm@kvack.org, akpm@linux-foundation.org References: <20230411141818.62152-1-aneesh.kumar@linux.ibm.com> <1d9e9377-d835-4b83-8770-adc3d1313228@oracle.com> <87y1mybg2s.fsf@linux.ibm.com> From: Joao Martins In-Reply-To: <87y1mybg2s.fsf@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SGAP274CA0005.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b6::17) To BLAPR10MB4835.namprd10.prod.outlook.com (2603:10b6:208:331::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BLAPR10MB4835:EE_|PH7PR10MB6987:EE_ X-MS-Office365-Filtering-Correlation-Id: 34320de5-710a-4316-780a-08db3aa49249 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oWoa9TSqUlFasy7y1y5pmI/3S3SaDbxLQmU8UukHDcHkMcwe3/DAY4K+2OSRxoUfJcLR/kbvJqHaQy4T8JEOB5mLJQGb5gksvB8SR8eNskpinVzAqZ+CXZfauymWG1jjBgvatUJJrshXjiXcXe41OLFaVPhuvZDa4ZwvG+krklEb2e6Y37VGC2FSYAmwXlEdCf6jjvhmQrIhgQQyDv7TbJ9Oxks2TbcXflWzHMQqNepTnLYG8zxlOpb57ggnahpvCnKEPEEFcPVS6O5fUG3vEqOggUe9d30FLTCLsT2Gel6+W0uJrxixf7HOHZgY0B+rNWNogBWB5iBO57fLpzsceoOopyQPeVvo2fOchBkT7j5+mPQM6qO1StyOokYvXOD9znZNkaQ7agJJob/Orv7zUF3Cm9a5NPqEFzR9WXFk9SjEtJOaRwFO3adLW8tyvx2qzU7jclFVuYbq70HduPwQMjfB19Mey0ZgrkJvzkYkDM5EJWQA0cb43mn5fLvgosfjFpu8zEAjb20w7xw8Q4WibwWLBxp4xuzPyEcYi7NNNQHJOKE2FqNf17NplOwS9iiWPpQDId/ImAyOonZjMH96En0wWfrqHwPqoHt/Nbut6sANup1E+SMbp5Fcf4gKuH2b X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB4835.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(136003)(396003)(346002)(376002)(39860400002)(451199021)(2906002)(478600001)(186003)(2616005)(36756003)(6512007)(53546011)(6506007)(6666004)(26005)(6486002)(31696002)(6916009)(38100700002)(86362001)(5660300002)(316002)(54906003)(41300700001)(4326008)(8936002)(31686004)(66556008)(66476007)(8676002)(66946007)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TG1ITGhkZTNaNm4zckw5bTY4OHV6NmZPZ1FvYzZJTHVpS1hZRFE4VGFhWDdi?= =?utf-8?B?NkoyTXA4T0NGWUtYYWJPR3I5R3FmUTh0eFNGNHUyTHNJU1piS0hZY216SGtO?= =?utf-8?B?c0NMNkhIdkluSS9lRXFuZWlDbktzakwwY09ZcmZnUmVTU0VQekt0dkJacEYw?= =?utf-8?B?cXdMdmRPYkhGWjJ5aHI4VCtacjhrUUxOZkpPcFQydHZRNmJDdmpIcjFrODUx?= =?utf-8?B?K1pvY3RGQjM0RjEyMURoVDBudDlRMEI3QUYrV0hSaUVJcmlaT3ZEY2YzYis0?= =?utf-8?B?aFJDdlRud3V0RHFOY0NRZUQzWUNEVU1kRHdjeVp5eXBTdUFxTTl5STFpcWlh?= =?utf-8?B?cXVnMkY1WnZBOHVzSlpUdGpKakErMjBSWTBCN2NCSXpsWkd2QUdyVUdPak84?= =?utf-8?B?MUZ2TWhMN1RVdVo5TVNvSHVpd3I1aWwzTmh6T1dkY2FacU5mREUyNHJ6OVZX?= =?utf-8?B?di9tSThZc29aZllZc1lhckRjTzB4WWZ0TDNNYk9Ra0ozRWtNd3dGMnhPT29h?= =?utf-8?B?R01SWU9aVUlGZ3VERWI5SzRnclBhbWx2QUdGdGhxN25iUFcvVFBPcXovUkRo?= =?utf-8?B?bXp4R1cyN0JZNkxBNHV6Q045cDdIWG0wZjhmNW5JVDV0SWtuc3NibWRpbFhs?= =?utf-8?B?V2xRVWU5NU1yT3g1c3Vhd0NLb1FZNWlGMHlVcXRQcFVUZTlyUkRZdWF5bnVt?= =?utf-8?B?V3NUeStORkpqcWt4Z0JEcUNWNEhocVEya2ZXS0NZeGs2SGFiZkVxTDFqWVdO?= =?utf-8?B?S0Jaanp1eVcxRno5UHhJSmo2bmVnM2lSTTgzZ0VoSUttQVJYK2xCQ24xUG1M?= =?utf-8?B?R3pnZThRR3IwMFpJaUZNRU5oQ2tKS1pCd0V3QVN3SURLY0JkZldLNXo3d2NY?= =?utf-8?B?YlNRSHZZNW5wajlXL3NkRlVYaG84SkEvTnUzSDhtNjkvdFZIcHl0WmUxUEIz?= =?utf-8?B?emNUclFIVUJTNkQvdzFLbW5venl5Q1ZFNVBKLzBadXBVL2ZpSUNPM1I2NDhS?= =?utf-8?B?U1h1andmSVc3Z20rMzYwSVRwMkFXQTZhY1Z6VnRxVzdKN3k0RFdSYVNaRVlD?= =?utf-8?B?NEVXMmlIK0ZCVVNuWUVORmxQdi9qMDlkTVhKNnR6cVZFUlVhYlNVRC9lSlNv?= =?utf-8?B?L1kweklBU2hoS0M2UnR1Q3lQN3pPMHhWakEvNERzU2YwSjJ0ak91dTBNN0FP?= =?utf-8?B?K1pyM0NhVStUUHdKNTR4aFh0OHVJWU1BQzd3ZkNGeEFTWGN0ZDI4aG5vSGRw?= =?utf-8?B?RVUyWC83d0syaUVMb1Z6Slc5QlJRdEExeU5DYTRQNEdBZ3JoQ1htcFc1alcv?= =?utf-8?B?bWoxbEhTd2tQSlpQb3h0aUFzUFNibUQ3clNuQlp1eFVuODduTllKVWcvUFBE?= =?utf-8?B?eXcwVnhuY0RPSGhRMTJ2Z0hWN2xjQ2RFS2lMMWFKTFJwN3V5cjEvRHRSbWpv?= =?utf-8?B?WVpxZ1BFVkRZYXF1dzJFWFZsNFJuMVd4c0RnU0F1T3R6Zkw0WFZxcllScjFn?= =?utf-8?B?eUhrcE5XWWV5S2dQcjY5a1AvTVNqUTVicERkVkZ0TmR5NkdJNGhtditQSTFr?= =?utf-8?B?OU5OODNxNXovQ2tSSER1R29paFZvcXh2VFJBajF2bG1QS3pIejhjQWZVWDZE?= =?utf-8?B?SkFyTHZ5aXRYeVVRQnZvZ001c2tHb2RrSEQwNWpDNFh5RnBRMm1kY0tGSG1S?= =?utf-8?B?RUtSWUJpSTJVS3FBc09BWnpnZXN5R0U3ZVdTQnozVFYvcHNZSWw4QUxobVd2?= =?utf-8?B?V2kwUENyUXBDYmtEOEdlbDBRNDNtclRub0U1cWU5Z1Q0dmFoY09xSFFXbkRB?= =?utf-8?B?anBBcWJLcWUyb0Zab0NPVlBkdjVkaDhuTEZRSnNJRU1zNWZ5RFlWRmFEQ1ow?= =?utf-8?B?Nys5bUxtVmhlaDh5QW4rci91emRmZTBHNGd3N21XUGZ1am1iMXJ6TmVFak45?= =?utf-8?B?ei8rRjhjbjduNXJkZ3N4Y3lXZGlQSmlLeERNUkUvblU3NVJrSlFVSGxHZCtu?= =?utf-8?B?RUt4Q2ZCRDlKd2QyV1M5RmlSb3ppVHcyZ3dJOUxlaUtyTUJBdWtDU1B4SFBw?= =?utf-8?B?dUJuSUduLzFoWVIzeVIwNUZrVVNjV0JqZ1pPNStOSGFVeXZGQVpBNmpOSEdH?= =?utf-8?B?VGFMTG9ZQ0ZLZW5icUY4ZkVFZklYWW41WVV3aGRNNE1XaHJvVmlZZFExNThD?= =?utf-8?B?MGc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: UfaGBRn/cWGXHcdAS7wLiVpSsARDE2ZZPl7TAltXZSc11uDUbPSWSISOVVMM4s0YQ56V7wm7lNPCnUTr+Q+9ZDEJz3rZOJlM0a+KpqsMAAqovS4170PVTf6hgUPeVpbsUldLmeOTJdrKZ7Wl3LkiPHgyx4aUOafEyhiZku1Qs3RfH9rECBSeSFESWgXnlBe5lKaHpb/1OggUsdxoY87PW0hcRzzAQ1V3SRkbwgv0kUUsTY4IlhFGEKah0kEONv9dASCLalBWxGdY2ak635EwYxI+FVmd2dDufWdoAu9xIqIbS6PMKQ9kSsVXVHLYsMiD6dnMY5KVWSi6FUsVx6nMgtxcBR0AcSwoYQDhddzytfN9cpFbAgMXbfWi26FT/YbNQx7g5LROImEp8yozVnFZL23s4ziYNISBhDSvuWBntSzdIVJtps3+eZ4oA1MdDcIBOiLI1iDovvbhhuD5qMZABVThKCHM2+5qltu2YoPk7xfIUE+8U3ac+BsapI2t8llvYaXmLkI+CLTR98JfEtwItMYm5YG/VqtcVSO3619MNPFgVOpZcsoU2KKy63lTBRy6IcV4vQ2va5FqhbdUQvXaFiFOhp9wp/HLZnODU6t9KNGY+4m/CgDiwN50sKRKuGTZZXnniswjQoMuouM0J/ZukVca2ufxDi+cMDerSeNwmc1VQYuXiKFxsv8XnAm5b0s8C6mcYgmvGOORY6DdWe0FVcyooZWuM31o3i+SpSyqwocU5IlMW7VgsPb6Qx8DIbg7Bnw3t1eIw+I6y9ej/YNVeYtxByfkAo/n4S+ZRYPp4ocEcupyxB7mm2EEMPol+Z4NicQn26u4tVlWOILi6JB5NOWHihYWgHgdFTNvAaOE3+MH8uZXchZZUHw+1pSgivzDeqZsXUXlwQHToUn++8KsoA== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 34320de5-710a-4316-780a-08db3aa49249 X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB4835.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 15:51:11.1506 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JTMrfvQQdVYOslTy1twDuBMDwV5aOLdZFszos1m3OAknyeZPTQfCVJKrJ9zNntJR9nJIiYlBr/Q0+Ws9t5syaB7ztqtiww11jbsf496kEls= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6987 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-11_10,2023-04-11_02,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0 malwarescore=0 suspectscore=0 bulkscore=0 spamscore=0 phishscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304110144 X-Proofpoint-GUID: 5KkzgDi8q1TuxPGgj0EeZf10aYGd53Rq X-Proofpoint-ORIG-GUID: 5KkzgDi8q1TuxPGgj0EeZf10aYGd53Rq X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: F3AB5140002 X-Stat-Signature: ob3eca9askympomzea8j6cniuutumxut X-HE-Tag: 1681228295-373979 X-HE-Meta: U2FsdGVkX1+pCJAy+BLzzUxCcv6CHhLWRsBBAIC5Juts+dsDIW89eVljKV4bCAiGowP5V7xmHzlKwHQ0x7IqhQ759VBiMUhjAYV2gaPUVZ4WIvDZQFwCCKzNzWF15IuyVs6QMUBNzhpMFywBb36EUT1qF0LQLXcBYmS1D+2Q27LL7pWFrt2SCG5B2+U/ub9/QEx4Wgs9c+zc4gKutq/ABaWXY0/z6BRDz4MGB/qnCG74RABJh2+Cfe9S45uE1V7VEm4+TuM2iCpDSxbvq5ksWycnIeWoiV57syOa1jftL6FCkaFkUd2coRMxNGL0sux3CWnIvRJN+UQ/Uji/hmzjZb/TETAo7g6ZMVRhRYF6VpDCR965db6IrNme/qNsC9uWIAbznhS2TO/b4Tr5fSNo8n4eXhtULAzEooQuaLGU3amsQCse7/JBSG1fBN6cABaZtLmspY6GtysMRXQiHyPvcgpjtSJ5koUOnJBQZGYZ29GgF/5Z+J/WITTOXitaoBnOTBEMRP4iN6RCxr8u4uqFAJX9TK2CQpRVrc77phVIzOv2OalnMeaAryKk/qC1KRmPtfwNQWseaUTx2maUUK+iMgT8oEeqhNEjerpU1ne0nSsrshnaSr2tEC6mZXXOBfdpXML8nIYHm6Qj8Mt9TNVwJnRbPj7VYtKlsuWTM0UOqQbdiUHKBRIOwebPfoA4e7VkrScDg1v3ShrhjsIHrlQO/2kbJVBUlQKSkIHUkGjS423QefbrvyEZPylt03kpGPy3bD+hbVRhRqj5unrLRZsvq+mTp8lH9KwyIZ7+eX7mha3Wj/nMR5mIC33Zf/IS/cwjNb1aXnlyH1GqUK5nOwGhEvsJVvTMiLKio454JPwANekUq1DRe/QG7VPqtB+f1qvdQSqNRYUCEsGwF+cDnTOfcoCNiqtog1p0ElkIDUQOV5HGwfNHZi8dshXzzc+wWe6U4vFTDIrLjmiqQlZvMWs 89fGzB4V TffWdzohBJJqTKMyc/nGN+Nolr+bvLYL5AmFSK9UpShcoflPn5USn6hFfssp4t6fDMPPQQ/u0dHyHeh8uF1sRXHN9NShnesQq+Chrh6Cmcz5gBE9BDrhm01dS3EPlqz6LXBwtbU3YhsfXzdsEReGnSN2tvZz/OFGvolQyfOiK2LCP+O3qRKuO7SBLBsvA0ExEmhr2RsTxR0CmVHSisnthNlnzs6NtB+txSdcvrMcD9bkN0rDyBUBi9wHVmt/paReiguCd83oDgrwHsI6cC8eebnAUWOTD6O/ybjc8u4O1mhClKqD7YS9EV4hKDKgqOn2wkehPqLXbDzj2LvdK6DquaNTBbhnMXyfKHMqO3LiNRVrUYYPHwnhquqkIfJ0ivhv9psuFOUrdwL3dQ1A+vLszRlXYAg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/04/2023 16:20, Aneesh Kumar K.V wrote: > Joao Martins writes: >> On 11/04/2023 15:18, Aneesh Kumar K.V wrote: >>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c >>> index 3bb3484563ed..292411d8816f 100644 >>> --- a/mm/page_alloc.c >>> +++ b/mm/page_alloc.c >>> @@ -6844,10 +6844,13 @@ static void __ref __init_zone_device_page(struct page *page, unsigned long pfn, >>> * of an altmap. See vmemmap_populate_compound_pages(). >>> */ >>> static inline unsigned long compound_nr_pages(struct vmem_altmap *altmap, >>> + struct dev_pagemap *pgmap, >>> unsigned long nr_pages) >>> { >>> - return is_power_of_2(sizeof(struct page)) && >>> - !altmap ? 2 * (PAGE_SIZE / sizeof(struct page)) : nr_pages; >>> + if (vmemmap_can_optimize(altmap, pgmap)) >>> + return 2 * (PAGE_SIZE / sizeof(struct page)); >>> + else >>> + return nr_pages; >>> } >>> >> >> Keep the ternary operator as already is the case for compound_nr_pages to avoid >> doing too much in one patch: >> >> return vmemmap_can_optimize(altmap, pgmap) ? >> 2 * (PAGE_SIZE / sizeof(struct page)) : nr_pages; >> >> Or you really want to remove the ternary operator perhaps take the unnecessary >> else and make the long line be less indented: >> >> if (!vmemmap_can_optimize(altmap, pgmap)) >> return nr_pages; >> >> return 2 * (PAGE_SIZE / sizeof(struct page)); >> >> I don't think the latter is a significant improvement over the ternary one. But >> I guess that's a matter of preferred style. > > How about > > static inline unsigned long compound_nr_pages(struct vmem_altmap *altmap, > struct dev_pagemap *pgmap) > { > > if (!vmemmap_can_optimize(altmap, pgmap)) > return pgmap_vmemmap_nr(pgmap); > > return 2 * (PAGE_SIZE / sizeof(struct page)); > } > I am a bit more fond of the ternary option. But this snip above is fine as well, including with the s/nr_pages/pgmap_vmemmap_nr(pgmap)/ change you added.