From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A49EEB64DC for ; Sun, 25 Jun 2023 07:39:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ECBEA8D0002; Sun, 25 Jun 2023 03:39:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E7B358D0001; Sun, 25 Jun 2023 03:39:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D42ED8D0002; Sun, 25 Jun 2023 03:39:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C24D38D0001 for ; Sun, 25 Jun 2023 03:39:14 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 8C7991C8C43 for ; Sun, 25 Jun 2023 07:39:14 +0000 (UTC) X-FDA: 80940469428.08.E96E2F0 Received: from out-38.mta0.migadu.com (out-38.mta0.migadu.com [91.218.175.38]) by imf26.hostedemail.com (Postfix) with ESMTP id B85B914000A for ; Sun, 25 Jun 2023 07:39:12 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=umaE3q0A; spf=pass (imf26.hostedemail.com: domain of yajun.deng@linux.dev designates 91.218.175.38 as permitted sender) smtp.mailfrom=yajun.deng@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687678752; a=rsa-sha256; cv=none; b=eh8acOwE0OREnFZlQRAG5r7KUycYuhkN7y+YQtwJJmeXLVIWv7UXbDLolyszOT0rCfg6Is 8NHFdTHW/C98d12VdoNAUhpMjHm8PlA8K9ilUMcVCLJvbI/QTO2+NdNxIZW5XOIe6qmerj jlO+2jOunwUrwItmQ7Nq8XVAUW/5vAA= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=umaE3q0A; spf=pass (imf26.hostedemail.com: domain of yajun.deng@linux.dev designates 91.218.175.38 as permitted sender) smtp.mailfrom=yajun.deng@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687678752; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i4wN0oKOWHuCd0fTyy5YavBofFk5HORNO1i9De4tuIU=; b=Mz1Qie7WE5PRGbRTYIYQxtYOicI6ex91Ds/5tkYew1uGwLfrnzMpWt14VcTYjei3ureXOA tFjFHzzhmQ83ALO4C41MW10esrF0CZHLUfPArBiWCG60pKU2DRVDmV3ljnrnz9e34CmHao 2O7X0sjU8GCWJzhK8Z7/Sr/VmFoGVXs= MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1687678750; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i4wN0oKOWHuCd0fTyy5YavBofFk5HORNO1i9De4tuIU=; b=umaE3q0Als9RX48cxcIF2rGGehn1O0+58zR/2OcnTiYwxnAAaB+cnW1pYc9W2CIXE1pD1U Ofx98usgryEIaEU1PxwCSLltAAs+Fho7hJC3TBzR5H7lotra4vEh4gNcvHxerbZdmfvNX4 3ZYHAk6M8BA7rm/by2Pu2UmqjgWwJkw= Date: Sun, 25 Jun 2023 07:39:10 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Yajun Deng" Message-ID: <4c361d62e0b77242fe4b8592c82c4d90@linux.dev> Subject: Re: [PATCH] memblock: Introduce memblock_reserve_node() To: "Mike Rapoport" Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org In-Reply-To: <20230625050850.GJ52412@kernel.org> References: <20230625050850.GJ52412@kernel.org> <20230624024622.2959376-1-yajun.deng@linux.dev> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: B85B914000A X-Stat-Signature: qatgks5z9mfbyumz7snu3t7mbrhmn7rs X-Rspam-User: X-HE-Tag: 1687678752-861942 X-HE-Meta: U2FsdGVkX19u0hJEexMzx2ikiP5O3vGVbcGDoU/ILViikWrHJLRILlDiLVNAm23DRxv9gNeanDdIStFHTwRuNkO2emxmr6eiVXQqhHsI7Tc6AEcKQ5XReh3JS+4dHeJ4ThI+yfxeEzkH2JSenQ7D0669w0qi20mLqPtLbMY4cMgbdfuyXHG4uZpXaec0YP7oyzgqSAPL8rN9Q5gBr4n6fw4A9g5wws1XmOJpEOegzkHB54/XSx9Ovon1q1HSbfRSQRDV1Yk3H9gk7DFb/Qpl8ITNKVIUvt1fDKXj8zcEYHrS/KlxliK4cPqKbgxm8DFPJYtJHOEo9VPrF8p+FKEa1n0D0SRY277/633wL2LiZSwlc4FOeh9RGQe7g5cNMXnTRrgohoPM1QSopmStNQdogmoGqtPF1vqpXAyOuIcWcmkuZd5gmpe74qPNCn478hd6HadzbU/6wlHAH925a5/irlUGt3342h1HWkqBdB9nvJ8Yr8/WXp8Z0VgryBMxMXEhpJbtkHsBqM9n3baHl3V5OnVIbBjsUIK9omeYkSMBL5VN7iG3QTgKMoN/tImJJbHnLYZ12xtMXf9A++qfo/v0g5d2ajowgX2Aw762YRdD738PiTh6hfPEZh0kuJO2KwNK7+kXCpHOHB063E/vreeXYq4+C61jjJCV/9I+g1mGkSHP1q/Q6fErD3x+/G8qStLfhTNGgoEt0S4fv2Z7s+JdtT7I/sAJx5wPkJu10BkFDSe6dSlvKN8AYU9Bg8/7fY78Ln4dZzf0mMYhXo3ARSWQEfzYnawD/eeEEnXAgGzDCpatxTMdauBauvv9Bq1LyUuBy2Siz+C/MmKVwsVM3EnDPK2vpJRK36XKBhBqCdmIIh5Nw7QYRebkJmErw9cl7sAe6O+lvowb7y3uUQsO1XJ5NzvB7zH7cxtP43tOsxLWOo1hVlfyxscKcLrt8Y7DGi7uJwVoTyyrT6GnapVZ++N Q+R40cYt txDMV9RLMl0nJLs0FzgXaS+14VwVJ646Ocb2YKNyUGzu8O7xw72/DDsO+k3VjGphtujG6QbPTyDQ2GWMdmhxxpj9AWx4j6KDxXPcZ0pV2IOg14Lqhp1KL+haCrCeWKJbi916+tMQVg34FhoasQvusEdV/BBev+sJR3HSZLBe3OEoL75rVPWoThAfHXQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000033, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: June 25, 2023 1:08 PM, "Mike Rapoport" wrote:=0A=0A> On= Sat, Jun 24, 2023 at 10:46:22AM +0800, Yajun Deng wrote:=0A> =0A>> It on= ly returns address now in memblock_find_in_range_node(), we can add a=0A>= > parameter pointing to integer for node id of the range, which can be us= ed=0A>> to pass the node id to the new reserve region.=0A>> =0A>> Introdu= ce memblock_reserve_node() so that the node id can be passed to=0A>> the = reserve region in memblock_alloc_range_nid().=0A>> =0A>> Signed-off-by: Y= ajun Deng =0A> =0A> What problem does this patch so= lve?=0A>=0A=0AIf we set nid and flags in memblock_alloc_range_nid(), we m= ay not need=0Amemblock_set_node() in memmap_init_reserved_pages().=0A=0AI= tested this patch and delete memblock_set_node() in memmap_init_reserved= _pages().=0AIt works fine. I did not delete memblock_set_node() in this p= atch just in case.=0A =0A> --=0A> Sincerely yours,=0A> Mike.