From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B879C76196 for ; Mon, 3 Apr 2023 13:43:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D94616B0071; Mon, 3 Apr 2023 09:43:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D43426B0072; Mon, 3 Apr 2023 09:43:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE5E06B0074; Mon, 3 Apr 2023 09:43:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B0FE56B0071 for ; Mon, 3 Apr 2023 09:43:37 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6C66540B33 for ; Mon, 3 Apr 2023 13:43:37 +0000 (UTC) X-FDA: 80640197274.09.DBC901C Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf01.hostedemail.com (Postfix) with ESMTP id 5856440013 for ; Mon, 3 Apr 2023 13:43:34 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=TPNVXHVE; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=hfwjJzjG; spf=pass (imf01.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680529414; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PYHhbD4MHsOrgjUSCx36DUU/r9Dt3i0n6aCrmkt21ps=; b=tZLBWIf3O4QX2hebj9mAGLBuqPa7jcoi7QOMyISB61AfIgVPmm7ixIsBdyYKNmQABDr+5k 01jdZ0JZMYGl565dSCbSUwVFaP9OYhrb5A/Dl3mAkEJANFpMTiE/PfqusvTgAOPUmToI10 AmexW8SmaaTpYVld1b+Htm+GkJ4jUBk= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=TPNVXHVE; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=hfwjJzjG; spf=pass (imf01.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680529414; a=rsa-sha256; cv=none; b=CljUND77+v1N2eAjLe18FiJUUizyyhjBeWEh+SuubhdNgXS31gV3cjYcf3bHf7nfnBpH/A ILo4uaZr+5Q5b2VtKxLkp0LERNreboqn99sLqSdDJjv7UPK4FY5vDmq+NpWPrcbbuOl1Ug kTc05/fO/FASoyiyz85Pp9X/tc5uhR4= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1F8C521D6B; Mon, 3 Apr 2023 13:43:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1680529413; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PYHhbD4MHsOrgjUSCx36DUU/r9Dt3i0n6aCrmkt21ps=; b=TPNVXHVEPbTqKvrgilc4LHktaPlNBN4lfeGo2MCYTNy/y54aVAoXASVa8AO/8qrCvlx7Bw F/OcJLhrSdpUQVK8WTVQVWKdf5LI29HrO2A6sgfXh4gc3R915vcGapkwEdFQH8HTW/BwiW e24kAjh90STHS47LoXPbD5uctHHdAPE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1680529413; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PYHhbD4MHsOrgjUSCx36DUU/r9Dt3i0n6aCrmkt21ps=; b=hfwjJzjGEn9VdgG14TUxyRzf8C5IBckNpnpL7i3pldeLTFJSQXGLzvhQ6HML/EUgvDzmGp JQd6/VUwZl24apCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9E7FF13416; Mon, 3 Apr 2023 13:43:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 2VD0JQTYKmRyegAAMHmgww (envelope-from ); Mon, 03 Apr 2023 13:43:32 +0000 Message-ID: <4c319a60-c1fb-fe43-65be-9729f0261dab@suse.cz> Date: Mon, 3 Apr 2023 15:43:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCHv9 04/14] mm/page_alloc: Add sysfs handle to accept accept_memory Content-Language: en-US To: "Kirill A. Shutemov" , Borislav Petkov , Andy Lutomirski , Sean Christopherson , Andrew Morton , Joerg Roedel , Ard Biesheuvel Cc: Andi Kleen , Kuppuswamy Sathyanarayanan , David Rientjes , Tom Lendacky , Thomas Gleixner , Peter Zijlstra , Paolo Bonzini , Ingo Molnar , Dario Faggioli , Dave Hansen , Mike Rapoport , David Hildenbrand , Mel Gorman , marcelo.cerri@canonical.com, tim.gardner@canonical.com, khalid.elmously@canonical.com, philip.cox@canonical.com, aarcange@redhat.com, peterx@redhat.com, x86@kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230330114956.20342-1-kirill.shutemov@linux.intel.com> <20230330114956.20342-5-kirill.shutemov@linux.intel.com> From: Vlastimil Babka In-Reply-To: <20230330114956.20342-5-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 5856440013 X-Rspam-User: X-Stat-Signature: xq9bmrqg5eucm4h6p4swfnzj9pcczwys X-HE-Tag: 1680529414-432847 X-HE-Meta: U2FsdGVkX18mhnb6H5WYHhTinjvtJYuspLtUGuoz6bmk8UmHQLPpZhjRjtYNuzHoaSObWWhJcDBCPdYCTALqFQ+IRR1Cr3VngAGwxKjWIl7WqcGyY+IYs62KhPLP6BCapheWXq/wrwohlQR/+6uULQY48972x0bVSKaSlBFr6srzx/dSx6r7SbzmFDGawSHsllOgXdh+De/ppTLAEfXRjSIJ5GNVkq0u5ErcpJzX8+k0lP0QtDMVdm5/zROUN7uSCnvKTfqfi8hhXC8ZQwczFosZXqTgZFGfCIHru4axptUnF3z5pR/uou1wnrrftVeu00fNYQMO1UZDWKM2ZAc9PK4F/9ft4UKSqhMVyZIn1tWyfBQLAIWDv35D0Um7mY0vr9XIGPh21NoDaAbmYQt/bhaBSmreVdUDhYpmU5St/jXJw3XOuDZ/61fqISf9kbE3yfV1WtfGOjaKCr24K45cRO2qib11ZozxNsil04pF/9mC1hq0HDyO9iNoRwt8f6wLv8Umbbea+/AId6dQbK+Bar4V8w4DsC1oWw0q60xY2BFe0rqBRVKOSIzanXUIHJ/k1Ep1RiQnJYBn8cb/zSfdy7IAcIIGONmMShDOP66qMKUMZR121Y+pIC2Led0YoN03D5+iuZyNqTRxSaE/xy5NOSllIRef1VWZMWUy/fdHaShOZBsDG+XYcQV3XSCT/G3qmDWhPRnT4Vdgnia4lp69RG5gLSPdb/KqJ5jPoFBM4JVDtFe0/UqPaKnifggFg6XNKIS2JTtGbI5SZlMFsbzpJeMCWmrtw30Katz5bafEQC0/rfT2hBt5g5oS+rG/WiOlxKVY2FMoCTve+nxZkx22zR35aaszaKffIa7CMjLBeAoHw5sD9PQ3P0r2kMGB/fp3vHjJl8sRHeCi5gLcPhdKyOm6g7SK2Ai26Q8weYl2Q5qqk8D4Z89whfU6E2Si2QldlW9cLfSw04hcY/K0Vnu KeRoug0d oJhdN90vQCLokTugVB3SUtCZemRPx0UWJ80oul4sMz4rp0rJuDfHXhmDpvq+WUimvK5Fvu7Da0ZulxgwbHSBKjwJKHOoSfn61iC1v9e5W/ORD8BW6bbsRk0v//rITSpk8pDTea9IHfNDTiYP6k91KvamGOSUzVa1gJTJJ9wBGfC8VyAuxr6PZanuz0i+VF6TJ63VVxP28AWsVuPj1jaUEZ7Rm0/yHaTZ2qMc8yanhAxUk5+S3JBSShdPcgie04zXA9iAwNxs7iHSZbUFwE0i1brw8vYkV1ARNiNf5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/30/23 13:49, Kirill A. Shutemov wrote: > Write amount of memory to accept into the new sysfs handle > /sys/kernel/mm/page_alloc/accept_memory. > > Write 'all' to the handle to accept all memory in the system. > > It can be used to implement background memory accepting from userspace. > It is also useful for debugging. > > Signed-off-by: Kirill A. Shutemov Somewhat similarly to patch 3, I'd think we don't need this patch in mainline without clear usecases first, although it's good to post for testing/debugging. > --- > mm/page_alloc.c | 64 +++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 64 insertions(+) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 509a93b7e5af..07e16e9b49c4 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -7343,6 +7343,45 @@ static bool __free_unaccepted(struct page *page) > return true; > } > > +static ssize_t accept_memory_store(struct kobject *kobj, > + struct kobj_attribute *attr, > + const char *buf, size_t count) > +{ > + unsigned long to_accept = 0; > + struct zone *zone; > + char *retptr; > + > + if (sysfs_streq(buf, "all")) { > + to_accept = ULONG_MAX; > + } else { > + to_accept = memparse(buf, &retptr); > + > + /* Get rid of trailing whitespace, including '\n' */ > + retptr = skip_spaces(retptr); > + > + if (*retptr != 0 || to_accept == 0) > + return -EINVAL; > + } > + > + for_each_populated_zone(zone) { > + while (try_to_accept_memory_one(zone)) { > + if (to_accept <= PAGE_SIZE << MAX_ORDER) > + return count; > + > + to_accept -= PAGE_SIZE << MAX_ORDER; > + } > + } > + > + return count; > +} > + > +static struct kobj_attribute accept_memory_attr = __ATTR_WO(accept_memory); > + > +static struct attribute *page_alloc_attr[] = { > + &accept_memory_attr.attr, > + NULL > +}; > + > #else > > static bool page_contains_unaccepted(struct page *page, unsigned int order) > @@ -7366,3 +7405,28 @@ static bool __free_unaccepted(struct page *page) > } > > #endif /* CONFIG_UNACCEPTED_MEMORY */ > + > +static const struct attribute_group page_alloc_attr_group = { > +#ifdef CONFIG_UNACCEPTED_MEMORY > + .attrs = page_alloc_attr, > +#endif > +}; > + > +static int __init page_alloc_init_sysfs(void) > +{ > + struct kobject *page_alloc_kobj; > + int err; > + > + page_alloc_kobj = kobject_create_and_add("page_alloc", mm_kobj); > + if (!page_alloc_kobj) > + return -ENOMEM; > + > + err = sysfs_create_group(page_alloc_kobj, &page_alloc_attr_group); > + if (err) { > + kobject_put(page_alloc_kobj); > + return err; > + } > + > + return 0; > +} > +late_initcall(page_alloc_init_sysfs);