From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55B71CF9C6F for ; Mon, 23 Sep 2024 22:08:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D61C26B007B; Mon, 23 Sep 2024 18:08:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D12A06B0083; Mon, 23 Sep 2024 18:08:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B8B5A6B0085; Mon, 23 Sep 2024 18:08:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9AABC6B007B for ; Mon, 23 Sep 2024 18:08:39 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 19BA2C163F for ; Mon, 23 Sep 2024 22:08:39 +0000 (UTC) X-FDA: 82597393158.07.413EE0E Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by imf28.hostedemail.com (Postfix) with ESMTP id 0ADA3C000C for ; Mon, 23 Sep 2024 22:08:36 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZP672g+6; spf=pass (imf28.hostedemail.com: domain of groeck7@gmail.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727129198; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V3//eEMxbsgUSahWoP7K716GeLpmNt2GzuMEZxOwtXQ=; b=m4vptKWyywXSXCh3+BCvdkvGuSIolgGts1kDlZfJ3POI7eGuCj0hb5w19c0dHp9eZu5gv4 2ryM/tzPFIvOxwMgb02JCoBe8aJiWAOB9xjoThi/IyBRIkzShsr9i6EvRG+mn5q0U9Oo9D 0Qsj/zzNH2LqAQvXQWHK1qdgrdpl7gw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727129198; a=rsa-sha256; cv=none; b=yqsuT9LMcGgL4Lu/l/ufGHstEvkvkjphEwW2Fj79zV3H2VJX+AbLQdnh939xckKZo1nsyj wGT5sNCoLRsFMj2mmmUlRl8umRbWsJvU97tNzDWbw2KEksqN+KIqcOtUELy+IA/+RTnHfa fM6AmDv/ktiUbz1m2qRLhGyx7UhTyo0= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZP672g+6; spf=pass (imf28.hostedemail.com: domain of groeck7@gmail.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2068a7c9286so48313655ad.1 for ; Mon, 23 Sep 2024 15:08:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727129316; x=1727734116; darn=kvack.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=V3//eEMxbsgUSahWoP7K716GeLpmNt2GzuMEZxOwtXQ=; b=ZP672g+67ND/WofwMq+il1xzx2o2UCXgTStY/3DVpqL3XlUr08lfEhCCbQnFNUm4aV qLnfD84njJwZ4bY/b2kq8bwwSZivRoJA1GX0j4mAupjGiLd0OxmXBnm4uLZOB0jstrob pAoWWa2fvkm3Oc6LE7Br2sohCplEBY6zGTPRgJWvZSEh66jprHXq2S+30D/BtnmZ4/Up jXO+bIlWb1P9sdg8BfzMaAc+LqOmAoIfr0CLCmXNKFcd16K91D5fvKmaw0ww+2oJ9XVS lpiEW6lWh8N7HIJGDytgj+aX5k4j77DEMsHu6KOJ1/7k/1gBLDXz7dxmEvnkUtaQk72d Mf4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727129316; x=1727734116; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=V3//eEMxbsgUSahWoP7K716GeLpmNt2GzuMEZxOwtXQ=; b=K8UFzsS5L1VZe+DYjj0KUnF0usGdsTpu2wm/6jmV7+9ggm89xmpq0OUEERBxFIj3yj 8d1Cd8xTR0iatYAuKh29CjCemxnLXMKkOqMEDbAgJ1x2NX63lRdI/0Z5CpDBnXMPCxWG XNFmqNh00AAenZaxWAs1vSvie0T8h8GxIVJmB0l1vxlw+x/PfcuNgQItemtkwo8AvTUS qq7FLt7eHzd1EeKPHXS3KAUC12UjLoxSJ8rWqYQcZWLosWefdM+jkDu+eamvYqjvWeM8 2+PlH1mxLg9CRt8qIjsvirF5lWbAnTfIblHrc4KggzpapvUqsFDD1gLzL0dUlvMIzJdM S1FA== X-Gm-Message-State: AOJu0YwVjVLLR62O+PFRbXwMWG5rpfkB4wUbANuypj9ZPF5FvFAexTFs 8bsZd0eeLLQN70RQHpimOOM9kB3mMvpMqSkqqodq7c3FrSLO5w4J X-Google-Smtp-Source: AGHT+IEdQQTT7l97c+EIqCCTDQGZIiQunAvA+FHxb9lDhCcKbpsJOwMcALfmB6zDaP6Y7i+Sza2RTQ== X-Received: by 2002:a17:902:e551:b0:202:2d:c87 with SMTP id d9443c01a7336-208d833b3ebmr215572725ad.12.1727129315592; Mon, 23 Sep 2024 15:08:35 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20af17e25c2sm435545ad.128.2024.09.23.15.08.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Sep 2024 15:08:34 -0700 (PDT) Message-ID: <4c2cdf84-9794-4722-8417-cf924f890797@roeck-us.net> Date: Mon, 23 Sep 2024 15:08:33 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: Make SPLIT_PTE_PTLOCKS depend on the existence of NR_CPUS To: David Hildenbrand , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven References: <20240923142533.1197982-1-linux@roeck-us.net> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: afbfyk7ddrzwdyz3omjqzxnm4erbar5r X-Rspamd-Queue-Id: 0ADA3C000C X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1727129316-350905 X-HE-Meta: U2FsdGVkX1/QEmXqunT0bl1GiQuw48o//zk+TbX3OTbOi+cdXSCn34/B0y7PnjttLOQZtcuOaNs8hc+CSj59R1zDs0C31X2V/m5EXV2MF+4+l+p418I9jgcrwChTvihPAdBgHS756eeWDU7N4dokDyxTW0apXi79dPRgMnlSpQDUu6MqciOrsCOVy5KwO7DxcUbH/M2bca9LCJgLMPeAr5FZeyTAL7pvpc7AG7fg1ICfJgC6hesP/k9X3GdIL76u8Azps1+4vqybsudlDqAaOxz/atx5j1tTnJJ+uHK3J+cu4iHJriWKtC14dcSulqxn1G/QlHB7+5crgiaNY5R1xxAMxyLHTPI3hYz9fea9/uGOB9/Fhvtgs0LiGIpGrY23/Y///GCOKg7f4d5bWB5dwVzYBdBjlbHV4r7X1cMcC8rZA1xWO388vzlEWzOLoabhOb6hExCX+Nb3XuQw8PyIXG/uj5rb4E5DsNgfGjBjMBWjeO1RTDmJFLyIqdeJoY3UYeIU4JYSZAee47wuZJ9hdll90X4pA9UszpdlFDyxbsg4HMUuHMwfbIsJskKNw3pnD/FHdCt+Os5MsYkrJxwy+CUcFVVqXCeyUQ/uPfluZQmOKwtr7VgSqfYuFaJPcCrbPNua4lHXOALLK2xDClBiWIx6RW2IculwSjupLclolg6IQkmuikptXSPCUKG+8dfdD1KwNkTb3UPXV6gOHSFvGrmUp+jYM+JKt+AC+cD08pTh6/t578VDJEoI6DRlxRlMOvcPoI9YVLvUqO/kQulAlZYA3pg+p4f11oq36Y/GPGmPalsoxnPGlWyQvQIEq9pvk8AbKucE7qo0cWq42QI5gvzcjyhHxjIinrNM1n0caokgTbOB+9wY3iRxZVzmxtVIU/wKiSiHDn5w4o8vAkINfuPVNqtNCNsVPIYkqBg12zPmqnadkxg1OJzbelyQ3ddOH0aMyf0FGFqa9oVVN93 fyqjF67D 0Wn6/NtP/c5Paybx7Ru67zioFTmb0QGpNmdE1X09uQ71BEldbFpSn0wsQG0hVnWx8J+mdBsiW/XwWceRC9z6di5caUtYh+Ew/0NBg6TcX7tiPmz604bggJNdVfJfzH5raDlV18hnvpcwCgCZknOko8O0lRI5vvc3U3wj2jo3oV8UtJpNi0R07WolCBeQaOMlBGIudE+Zsz/hhlE0WiFeEEY8HgGloZszbmuT3xma5rrdboeo7En047vJpJ36HdBBeiCWxQmkag/QMAlYeeREShrIFkHtlJoRYLZzCT74ZIR9hR4RLyvQE9534lFKEwKRITZzzaVOGR6V7Uy7RFSIGJb6F0/S63Av2w1IRN3xGKvyBPapvRU5J9BTDegGQ4+B+UwCUZ3yhjlZ3NYszsg0FUWo/9Z3UwhO1tL8BqLJili3Ks9x/PbUtalR9zouOa/hp8EZMVaVR4ta6/Sgslu2Zm3XFWNJl++LlWaRHu0TNOKVzJk0P4OQFDfREnHc3zprIEZfa/9aJIntdYMzrpGjc/qr6jlcqGegCxKSWh9ESwdzKr+Ri1oVV3bzIq3QYfiOxn0KgJTNMG+5QA/w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/23/24 08:23, David Hildenbrand wrote: > On 23.09.24 16:25, Guenter Roeck wrote: >> SPLIT_PTE_PTLOCKS already depends on "NR_CPUS >= 4", but that evaluates >> to true if there is no NR_CPUS configuration option (such as for m68k). >> This results in CONFIG_SPLIT_PTE_PTLOCKS=y for mac_defconfig. >> This in turn causes the m68k "q800" machine to crash in qemu. > > Oh, that's why my compile tests still worked ... I even removed the additional NR_CPUS check, assuming it's not required ... > > Thanks for debugging and fixing! > > Acked-by: David Hildenbrand > Apparently it wasn't that simple :-(. 0-day reports a build failure with s390 builds. arch/s390/mm/gmap.c:357:16: error: implicit declaration of function 'pmd_pgtable_page'. Turns out that depends on NR_CPUS && NR_CPUS >= 4 doesn't work and disables SPLIT_PTE_PTLOCKS even if NR_CPUS _is_ defined. I have no idea how to declare the dependency correctly. Sorry, I did not expect that. Guenter