From: Guenter Roeck <linux@roeck-us.net>
To: David Hildenbrand <david@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH] mm: Make SPLIT_PTE_PTLOCKS depend on the existence of NR_CPUS
Date: Mon, 23 Sep 2024 15:08:33 -0700 [thread overview]
Message-ID: <4c2cdf84-9794-4722-8417-cf924f890797@roeck-us.net> (raw)
In-Reply-To: <f15ff981-e725-40f0-8d2f-856b4b6a65b3@redhat.com>
On 9/23/24 08:23, David Hildenbrand wrote:
> On 23.09.24 16:25, Guenter Roeck wrote:
>> SPLIT_PTE_PTLOCKS already depends on "NR_CPUS >= 4", but that evaluates
>> to true if there is no NR_CPUS configuration option (such as for m68k).
>> This results in CONFIG_SPLIT_PTE_PTLOCKS=y for mac_defconfig.
>> This in turn causes the m68k "q800" machine to crash in qemu.
>
> Oh, that's why my compile tests still worked ... I even removed the additional NR_CPUS check, assuming it's not required ...
>
> Thanks for debugging and fixing!
>
> Acked-by: David Hildenbrand <david@redhat.com>
>
Apparently it wasn't that simple :-(. 0-day reports a build failure
with s390 builds.
arch/s390/mm/gmap.c:357:16: error: implicit declaration of function 'pmd_pgtable_page'.
Turns out that
depends on NR_CPUS && NR_CPUS >= 4
doesn't work and disables SPLIT_PTE_PTLOCKS even if NR_CPUS _is_ defined.
I have no idea how to declare the dependency correctly.
Sorry, I did not expect that.
Guenter
next prev parent reply other threads:[~2024-09-23 22:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-23 14:25 Guenter Roeck
2024-09-23 15:23 ` David Hildenbrand
2024-09-23 22:08 ` Guenter Roeck [this message]
2024-09-23 23:52 ` Guenter Roeck
2024-09-24 7:45 ` Geert Uytterhoeven
2024-09-24 7:52 ` David Hildenbrand
2024-09-24 14:16 ` Guenter Roeck
2024-09-23 21:09 ` kernel test robot
2024-09-23 21:51 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c2cdf84-9794-4722-8417-cf924f890797@roeck-us.net \
--to=linux@roeck-us.net \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox