From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0E3FC54FA6 for ; Wed, 28 Aug 2024 12:28:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B06A6B0093; Wed, 28 Aug 2024 08:28:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7869E6B0095; Wed, 28 Aug 2024 08:28:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 600E06B0096; Wed, 28 Aug 2024 08:28:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3C81D6B0093 for ; Wed, 28 Aug 2024 08:28:40 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E756A1A1F05 for ; Wed, 28 Aug 2024 12:28:39 +0000 (UTC) X-FDA: 82501582758.09.3737290 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 9B95F1A001D for ; Wed, 28 Aug 2024 12:28:37 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="I6D2jH/j"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724848097; a=rsa-sha256; cv=none; b=2AvzPMw9VCCqSE+9Ov5b0u1yfgSKAaR5JCyeU+45DpSRQwn47oq/jA/a+UkDhUCg3Ck6WK SXpJIrSGqRZugEkgY5XRmaUB4bttQScPGOm4LqZmjk7Yrd5rJ/ExpHmyf5xUYExk3am/UQ xessGoiaZv7U1zvJQ5Kk00VOrKkwmU4= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="I6D2jH/j"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724848097; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BqX6w+nxa0Qp9v+HZKp/Y1aADrBubG2rT48f4/d5loc=; b=jl4vp69SadRYnIV6Cir/UsUT7TRif0q2FyR/j0gezw6dEON3ua19mC8yzJ8J5QS5CbVlHd E7aUG4rd4G/Qks2OnOXXhN6REZXWUQekagymd12nO2Op4sg/gJ5WENsWQ414u2eFeYfJD7 CYQGpipHQm2E2e17GQFOXcwr8CnzTvM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724848116; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=BqX6w+nxa0Qp9v+HZKp/Y1aADrBubG2rT48f4/d5loc=; b=I6D2jH/jJY4wmd9TOwo1apL1B8OXPLEuwM51oZrN1Vg5AzUBI84ACip7ERyRSqa32uKV7V Fq49VmRzEyeHl8DTWgtBLlgD6gjCit6z7Hg38Dx70HyxXwEZ1PqUcV5u9fsHoqJA9a1x4K FBX5F41dVwehbJxQLXh8On374XfiZkU= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-266-I6S0uwCgM6yj0ru0USMLSA-1; Wed, 28 Aug 2024 08:28:35 -0400 X-MC-Unique: I6S0uwCgM6yj0ru0USMLSA-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-429e937ed39so62197455e9.1 for ; Wed, 28 Aug 2024 05:28:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724848114; x=1725452914; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=BqX6w+nxa0Qp9v+HZKp/Y1aADrBubG2rT48f4/d5loc=; b=VDd7vN6BWdelFcQsqPXX1jIzxdpjxApmOEF+Es+IjoTQfuCLRxnI1brKJNzm+9U0CH R+L+uEx0xvjB/LFxb8IkgoepHt1b8gcrIXGY6Mq9wEj/jttDoRknAoc85KjudbNd1f1I QRtSL51Uc/yUyFiK/ajHU9YIUYV80NYxUNscRIXZTv1+h0vPoLPf5N8cjwQEjRM9CcAQ NuEXsZtlcr3A8sRGFSTE4m+RzZBRIHSA+/MPooP/VYXUgT3c5kn/nYI7Iu9WiNDrQUAw M474dJJwClLNEKiNdam3Xrr1dxhOwX27uC28vHlE0NugXtg4awL2xbVLvG8g3mp8mC+s H/jQ== X-Forwarded-Encrypted: i=1; AJvYcCVxrwndxgEc7jVE50GhLIarSxmwvC4CWkTGxrSyCtvKWHrLZkJpDFpoXJ+GuEShGBchGseMAOLcgg==@kvack.org X-Gm-Message-State: AOJu0YzxV+zrbhAhB7icB5WP07iZAPUdMiwaiV4uGhVh7oay8/ylXiHC RKQwrr5qPKXjELv2OY1vCvOGMN+YN6poHm5sKZyf55+9XIP+lfnjMQjMqBMgJ19nugcTxwjj0Mm S4e0Rk6vt5s9eAxPjQvoJlpCEtbSxEuUpGUVsPLVZZmPSjkkb X-Received: by 2002:a5d:6145:0:b0:36b:a404:500b with SMTP id ffacd0b85a97d-37496858c20mr1342884f8f.51.1724848114481; Wed, 28 Aug 2024 05:28:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFOf/BYvfRgQ5cJ50FN/hulBy60s/Q4D00y4o0VyWz/OP4adkwJeHioihaI5pWwgE7/jvvoPA== X-Received: by 2002:a5d:6145:0:b0:36b:a404:500b with SMTP id ffacd0b85a97d-37496858c20mr1342850f8f.51.1724848113600; Wed, 28 Aug 2024 05:28:33 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:1700:6b81:27cb:c9e2:a09a? (p200300cbc70617006b8127cbc9e2a09a.dip0.t-ipconnect.de. [2003:cb:c706:1700:6b81:27cb:c9e2:a09a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3730817a5acsm15434076f8f.64.2024.08.28.05.28.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Aug 2024 05:28:33 -0700 (PDT) Message-ID: <4c190c79-401e-43a9-a4d1-e64f78110e0b@redhat.com> Date: Wed, 28 Aug 2024 14:28:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [LTP] [linux-next:master] [mm/migrate] b28dd7507f: ltp.move_pages04.fail To: Cyril Hrubis Cc: kernel test robot , Claudio Imbrenda , Ryan Roberts , lkp@intel.com, Vasily Gorbik , Jonathan Corbet , "Kirill A. Shutemov" , Matthew Wilcox , Linux Memory Management List , Sven Schnelle , Zi Yan , Gerald Schaefer , oe-lkp@lists.linux.dev, Andrew Morton , Christian Borntraeger , Alexander Gordeev , ltp@lists.linux.it, Janosch Frank References: <202408211026.636ade1a-oliver.sang@intel.com> <767d1908-dc30-42ae-9a8a-d2ad42a4d491@redhat.com> <8bde28af-3401-4d72-b821-d8cf01bbcd64@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 9B95F1A001D X-Rspamd-Server: rspam01 X-Stat-Signature: buawc4q8sa8hxup8rntwdzy9cqbwmfjc X-HE-Tag: 1724848117-795421 X-HE-Meta: U2FsdGVkX1/gocKtnUC6ofINbxj1vkNcnjemyhfnF+kWZAgC2lVSfGkAyxKuWUJQMDS0yb0wYEX4diFrMtVIY8lQTOth5KaO+gyo3n2VRG++HSAIgsTRqAqvzNEZz240chweMc+wjDj+FDL2U+1Ue43168ryaDyBcv3ykrEN3J5lV3dyCxZoHOd9kmIUE0d4D6ytl7Crn71ms4u398wvIySJa9Pyk31jQvApjFskCjTrmv2S31qzQnUGEAOCv2KAjDOsyMrVp835JSYg+V4YRvgMtka4EKY2QNrBkw+4a2ACPLSssQCykY/py8O2ZhhxQhxrQWD8ifFoU+CCqNrbXu9lG8SWU+Ng44Iopim8MMHiTYK5RzEISkyBkx8vATMutI6qUeVqG810PD+31G1t3LjjHDhIPc3q+uosTuPdl7r4JGbXTKak2orkUgmcm+jPbvQhlGEH/xYTXzLfgfLhAOLuz0/8AN1+oG8pNmSh1cf/os/nQKu0e644lJegfz26Ikh8kTbt9/49cIt8xe7PdsMKGaJP0QxPLT1vurxvJEMOYEMhwcJu43BN2pKpw9H1tl1eM7ocZdnak++QFzGCE/SmlemjmwWT2vtG5YZjXy8Xm01Vr+QW0mslMF48ASuLZjzhcmZRIJ+lpJVbWa/Tg0ur58mpREBqh79Ym9nvLSfSDeXyOjCAzlOcf5Dxo0ddsAinscFcV8iwWR12eYUGI/rwqw+zVo5Xb/ECoV++88nph5WfJzrK6exG7qYNZbywiQYeUVRHH5T23ydpxyqIetUVAikP0pzmOqGowB9C5SAgx61I/z605PiCzJSB0DQn2aLh9+Ux1+qNPfsp+E/LSJ2OyB/2l5+4nne1ZOE/FNYSF+NOYeGTK2cEgl8Lw58Nye50BtK9CcMr9AfYA+ZQnGxhZlL8Nv8BLjE6ezlk59gIu1XdsPC8L2YGSfzwibRDoi016PvoCvp/ZJdl44A +h64ra8Z g1AN6eyyxsA6tOjW7maJWr4g47TW9hUpTYx7ujXCP4wr8kj1+xfe0tc/+BFcx4jcqBbiTxLVdL1zlLnyoBqaMzH/JcVCqI1IW/J0xkv5uPMJS0n+Dg2eRnQyxnLk+wsX4KRMgWnmteUFw3kYYtXdPsvvcmBtwsqlcnBv409jznZLYPZNd9oDyHTtFjtFO7F1lTO9xG6FBTYK4EGpb+sY9XGyMRSWjAiGk1FsAs+q+RVka28H07xuSCGfJD3YNBQXTp+wSpGow6V+z8RKil2J/gygBtmc8mvriM11jhvxwcJQOfKPo3Sl/MV90vcWyfkdoEGkQ1sl3fZpudWvCU8H7qUvEHG40Go5aaIoe3KslA9gO29K9WO/Rz2MC7DAA+WBJ16d+e2twiaNhmZunqijhbaZgwzx1w1WWrs4iGIp0rr/iM51YagyQuMYQSsyEcwe9FmIo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 28.08.24 14:23, Cyril Hrubis wrote: > Hi! >> I am not yet sure if we should simply allow either -EFAULT or -ENOENT for >> the "nothing mapped" case in the check (below). >> >> Alternatively, I agree, wee need to have this in the kernel so we can >> check for versions. >> >> What would be your preference? > > If we are going to stick to ENOENT for page that wasn't faulted in the > kernel from now on we should stick to it in the test as well. Right, it will make kernels >= 4.3 fail, though, until this series is upstream. I mean, it highlights a BUG, but we had a similar condition with the zeropage and worked around it in the test to keep it passing. > > Also I think there is a third case that we do not cover either, what > happens when we pass an address that is not mapped at all, e.g. NULL? Do > we get EFAULT as well? Yes, that's documented as EFAULT and should behave that way. I can extend the test to handle that as well. -- Cheers, David / dhildenb