From: Vlastimil Babka <vbabka@suse.cz>
To: "Ritesh Harjani (IBM)" <ritesh.list@gmail.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Michal Hocko <mhocko@suse.com>
Cc: akpm@linux-foundation.org, david@redhat.com,
shakeel.butt@linux.dev, lorenzo.stoakes@oracle.com,
Liam.Howlett@oracle.com, rppt@kernel.org, surenb@google.com,
donettom@linux.ibm.com, aboorvad@linux.ibm.com, sj@kernel.org,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm: fix the inaccurate memory statistics issue for users
Date: Mon, 9 Jun 2025 10:52:41 +0200 [thread overview]
Message-ID: <4c113d58-c858-4ef8-a7f1-bae05c293edf@suse.cz> (raw)
In-Reply-To: <87a56h48ow.fsf@gmail.com>
On 6/9/25 10:31 AM, Ritesh Harjani (IBM) wrote:
> Baolin Wang <baolin.wang@linux.alibaba.com> writes:
>
>> On 2025/6/9 15:35, Michal Hocko wrote:
>>> On Mon 09-06-25 10:57:41, Ritesh Harjani wrote:
>>>>
>>>> Any reason why we dropped the Fixes tag? I see there were a series of
>>>> discussion on v1 and it got concluded that the fix was correct, then why
>>>> drop the fixes tag?
>>>
>>> This seems more like an improvement than a bug fix.
>>
>> Yes. I don't have a strong opinion on this, but we (Alibaba) will
>> backport it manually,
>>
>> because some of user-space monitoring tools depend
>> on these statistics.
>
> That sounds like a regression then, isn't it?
Hm if counters were accurate before f1a7941243c1 and not afterwards, and
this is making them accurate again, and some userspace depends on it,
then Fixes: and stable is probably warranted then. If this was just a
perf improvement, then not. But AFAIU f1a7941243c1 was the perf
improvement...
> -ritesh
next prev parent reply other threads:[~2025-06-09 8:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-05 12:58 Baolin Wang
2025-06-05 13:34 ` Vlastimil Babka
2025-06-09 5:27 ` Ritesh Harjani
2025-06-09 7:35 ` Michal Hocko
2025-06-09 8:04 ` Baolin Wang
2025-06-09 8:31 ` Ritesh Harjani
2025-06-09 8:52 ` Vlastimil Babka [this message]
2025-06-09 8:56 ` Vlastimil Babka
2025-06-10 0:17 ` Andrew Morton
2025-06-10 0:45 ` Shakeel Butt
2025-06-10 9:59 ` Michal Hocko
2025-07-04 18:22 ` Luiz Capitulino
2025-07-04 20:11 ` Andrew Morton
2025-07-04 20:14 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c113d58-c858-4ef8-a7f1-bae05c293edf@suse.cz \
--to=vbabka@suse.cz \
--cc=Liam.Howlett@oracle.com \
--cc=aboorvad@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=donettom@linux.ibm.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=ritesh.list@gmail.com \
--cc=rppt@kernel.org \
--cc=shakeel.butt@linux.dev \
--cc=sj@kernel.org \
--cc=surenb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox