From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D32FBE7716C for ; Thu, 5 Dec 2024 14:33:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 46EB48D0010; Thu, 5 Dec 2024 09:33:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 41E438D0007; Thu, 5 Dec 2024 09:33:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2BEEC8D0010; Thu, 5 Dec 2024 09:33:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0F4058D0007 for ; Thu, 5 Dec 2024 09:33:56 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8CC19815EA for ; Thu, 5 Dec 2024 14:33:55 +0000 (UTC) X-FDA: 82861148496.20.DEEF557 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 27D20180013 for ; Thu, 5 Dec 2024 14:33:37 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CHU5tGVm; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of gmonaco@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=gmonaco@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733409225; a=rsa-sha256; cv=none; b=WwZ0Yt0dRtYKBZmFanhd0xIPe2HcjSwmkJPVQFfTCGsmSTPE18xHin9gZ50/Jy7bpgJbse wtGjeJsXqm4gXzId/90t66PC1clPnPiJ3vtDfhak44oGHmS0n/bpSA4CpP0goQMCubHmnc UZq/IL7/AR3t7+DvVC68DEFGmX/xWuA= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CHU5tGVm; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of gmonaco@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=gmonaco@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733409225; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Jir3FCnl+lGf2P0N/mk9HvX/Ubt1jFBrjXpyS2UCHdM=; b=h6W66smPw2UT6sDDkZN/9QPB3btgZGNClwKFALfGq3cnIMt07z3XQD3IYijgX2iHPDMmrW USnpsF0afwHrNzjTCwv81Ah5QEWdLiAdN/7bqgncZ22yZ7TmNEpe+D6NxjLi/RKeFxzkJI VuDDXmR4igoqH10lO60V53yEA6TFz0s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733409232; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Jir3FCnl+lGf2P0N/mk9HvX/Ubt1jFBrjXpyS2UCHdM=; b=CHU5tGVmrtk+8y3JtN1mYeesBp8L04SSCzdxzkVMpLOcwfHlk5O7eZjkth6pw4v8TCPP2r nYY3hSTiG0CRV7KgEB5/84AjBxfxHt7YAd1s8sNjVSRkS8kA0RjRzQtamQP3F6Ucg0xQzn +s9mklZ0jiwJ0965hvvuKlwdkknu/+4= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-35-Le94hablOpKJxugoXC_X3A-1; Thu, 05 Dec 2024 09:33:51 -0500 X-MC-Unique: Le94hablOpKJxugoXC_X3A-1 X-Mimecast-MFC-AGG-ID: Le94hablOpKJxugoXC_X3A Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-385d52591d6so514214f8f.1 for ; Thu, 05 Dec 2024 06:33:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733409230; x=1734014030; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Jir3FCnl+lGf2P0N/mk9HvX/Ubt1jFBrjXpyS2UCHdM=; b=eGlUuvbCUtCOgu+du0Hno7PKzORFVcCTiYSMZQ5/H8b7ZNAY4X090WEuFcdOlGCFZ8 rphd99hG2CzWGLuOSd8ZQhE8DK9bAIzyiwhIRAN7A0qvDErMfPpdI2nXChC9zBHmprg3 GuKJ6Qlq10nxrho7agU7CJ7uf6JGO4L0cLObcd/WDfZcC8v4KsuYGUIJi5zg+GUaNtSf PjzXYRoCE34g6PxkTdmg1nZeCTQovMPKbm97kBzX7m6f3vKcaS9A7TWcpe+OgtGoq2dB xNhawpVfF0w9MjRTtqstzlfnzIy71F3WB81x/UxwKtpg5uFb8NY9+prARK1P/OMekPcl xBlg== X-Forwarded-Encrypted: i=1; AJvYcCWeFje102FK3Mj7xcX0mcOkuEok8Ae1yqFH358OvYcYgP7NqTJZn+ezFNgHjFYQATkqLPCXRhnoVw==@kvack.org X-Gm-Message-State: AOJu0YzeMchNPf6Zsd6tz8mnK7FUE1yt3fski6eU2/vDPDvnYe2MpU5x fvSb1v7LuAuQLhyJzs9aCtynruYNJuzMMdBDc3Elnws7VN2ixB7XuENURb91plBkHAk1vtcQguv cVto7cYGBiqzkLBE3N8oDpV58VdHAD7aGMdKbdbNlLyjW+9L6 X-Gm-Gg: ASbGncsIddz76AnjMFMiPFImrJPcLcPMw1LTmEp8R98oQzUIHpqOHCH30n3m1gITOyz 3Cd6iRq/9j5Ahb552ivlnwbYmgaay4k20xDNEThp0/fDaHUkEBB48Z1K6myvsVN1Lifysjr9MfQ QpHOIZ1ueBD8MRLeY4pr8hb0jj+1d83YT6Ym1GEUTkhaX8wEu3xkbymdr8YtziFRKLgjGmfxABq kVa0TdF47/fCv0jAuKKS3rtwsItkZP0KjYZN7xyOaj+sXzEEMIU9+gsaHD5rpcsBHANa+YKZemo X-Received: by 2002:a5d:5f4b:0:b0:385:d72b:98 with SMTP id ffacd0b85a97d-3861bb4c74amr2735493f8f.5.1733409230195; Thu, 05 Dec 2024 06:33:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IFaZG2BYTZ2RT1a9dY4OQPOx6sg1N6RVN85ljPKoLzCBr5cmOjWR7+C6rxdKP+5jhE/Vmx4Iw== X-Received: by 2002:a5d:5f4b:0:b0:385:d72b:98 with SMTP id ffacd0b85a97d-3861bb4c74amr2735477f8f.5.1733409229829; Thu, 05 Dec 2024 06:33:49 -0800 (PST) Received: from gmonaco-thinkpadt14gen3.rmtit.csb ([185.107.56.30]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434d5280746sm63050865e9.21.2024.12.05.06.33.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Dec 2024 06:33:49 -0800 (PST) Message-ID: <4c067b75e06aadd34eff5b60fc7c59967aa30809.camel@redhat.com> Subject: Re: [PATCH] sched: Move task_mm_cid_work to mm delayed work From: Gabriele Monaco To: Mathieu Desnoyers , Ingo Molnar , Peter Zijlstra , Andrew Morton , Mel Gorman , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Juri Lelli , Vincent Guittot Date: Thu, 05 Dec 2024 15:33:46 +0100 In-Reply-To: <20241205083110.180134-2-gmonaco@redhat.com> References: <20241205083110.180134-2-gmonaco@redhat.com> Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0ByZWRoYXQuY29tPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmbiuWMCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfJzZgD/TXjnqCyqaZH/Y2w+YVbvm93WX2eqBqiVZ6VEjTuGNs8A/iPrKbzdWC7AicnK xyhmqeUWOzFx5P43S1E1dhsrLWgP User-Agent: Evolution 3.54.2 (3.54.2-1.fc41) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: szpHrY3iEvNvgiLHIctYf11F6ZPSAvev6lN-K8m5f_4_1733409230 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 27D20180013 X-Stat-Signature: 11c959do14zpdiqa9hrydykpo3hjhjxp X-HE-Tag: 1733409217-816157 X-HE-Meta: U2FsdGVkX1/uJb7w5Hj9x1xs6lvym+54r73mH7O8WdB83W7BJjYggelJaI4q0+4AlPxdSVayvY+xDodpb1eEU1xtP6oEaU4zz4DwtArStD/Wrx8edLt2o3NIF4z73Yt9wIQpIkrIRkdj0BybZtXKih9Ns+mVsx2JtqbP1nTSFmtd0Era0XwtmckEkM2VL+/OXZ6w37CWRkn81i1hxn8kofwLs8OidGOtqJQjmqpD8iS0AGgmHJj+G9pCODylyROd9IJ7MDxps3NrTY6DNHcOzB8wwazf+WCbylZtJHOd91N1KjxaB9PH3HdVkOwbuEqIvcXXYbgQHZwmibVnLKhozh/8Ulf/I9TV0hBO26xmDQ6s41ossP8JnIYxrUoOCyr+UrstY3lMo7lIfrbUDIeGReVWLdhsxu9abYMXmBxSpy99a/M8GyZSnZe8Z+hIim7i5oZdT6uSdiL886djaqreoDf5mnSxgJPtX3QS2C3x1uMA4aRiaOHh2PZ+9JjRxAyqaX+37VD6NJ06BRQvIMbanJEgf81Z/fvkNhIw5zoqgxS2Fp1v0IHfT52H8bGvlMg1GKhV1UH3bsZz1sfeX9UbB66GupkqRNQUCJHwuyjAshAu+xkycfU+dKXVJjUQgKPRg4nVrA7TMTnJN7DURVfG2AiXAismhI7j5RZuDFl93Qb8bA7EvqM9PoI5K0GL1BCvth8JE+o/u753Ayr2Wq9k+9y3rKSgtGgFn1mTdNXGwxcZEhYj497U83hyLVchl1af5XGToxGt4Lwuu2TsUNsNYYqZPlJbLkhE1ab1uJM3MFCGL7mMWK/XIJI0HAlhVA9E3ElcU59M5mrPec6lUKR3TOZFwhIvvTs1MMJLIrtj+DR8yFfxP5S9solVksFtSwsmqCaAKbnjytiPrVf+oNWxmX6aEOv+PyAPFyrKJvz06gzv4Sa4qpNfzq+7qbrkWOiOqvPzNXgNT+FKyfbkIIc cQ3Ong0C CqdsnnfP3EUAYqlpu4GWCz6sL0pO91AoA/IzJ6ButRlVcrJ0nFZOkHHE+OlJIxTHvy1yxzKDaVf5iFCpzJzRvzXJAJkGy4AtKgsEfoipnsBOdVM56ENRSfLJSXoRRuOulrhGXaWtBkSiC2eRuaW5+8ZDaa6yUjDDYyicfGzf4VfgxIED44ktSmkaZvNXc6Psr4Rbh5A9H7zXAvGhtGP+Mp3DXRx20Gic+EbciIPEV5WkaynlagpxloToWaFr+DvmBpeLC6kphpoRqg+jrI0jnU2o9AMO33JsHdR9FBiQH2fb0Gcpd7IgaIh0plXaM4B8XMKRa6EO/HqyfpwRFJT4Cql4enA9UgmaYrp/pxJQ1aFnNFA6B6mqY9FWe6y3iIsm/wi/q X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The patch is fundamentally broken since I somehow lost the line calling schedule_delayed_work in task_mm_cid_work to re-schedule itself. Before sending a V2, however, I'd like to get some more insights about the requirements of this function. The current behaviour upstream is to call task_mm_cid_work for the task running after the scheduler tick. The function checks that we don't run too often for the same mm, but it seems possible that some process with short runtime would rarely run during the tick. The behaviour imposed by this patch (at least the intended one) is to run the task_mm_cid_work with the configured periodicity (plus scheduling latency) for each active mm. This behaviour seem to me more predictable, but would that even be required for rseq or is it just an overkill? In other words, was the tick chosen out of simplicity or is there some property that has to be preserved? P.S. I run the rseq self tests on both this and the previous patch (both broken) and saw no failure. Thanks, Gabriele