From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACF9BC00140 for ; Fri, 12 Aug 2022 09:16:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E02C8E0001; Fri, 12 Aug 2022 05:16:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4680B6B0075; Fri, 12 Aug 2022 05:16:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 309788E0001; Fri, 12 Aug 2022 05:16:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1C9EE6B0073 for ; Fri, 12 Aug 2022 05:16:09 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E0B67141A94 for ; Fri, 12 Aug 2022 09:16:08 +0000 (UTC) X-FDA: 79790384016.07.AA5B12D Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf29.hostedemail.com (Postfix) with ESMTP id 6CBD912018B for ; Fri, 12 Aug 2022 09:16:08 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 204B03F6B2; Fri, 12 Aug 2022 09:16:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1660295767; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kjBhkz6lsl1nfN6f0JT0oQPdTTdWRPlVXz3Chj0I2Bg=; b=Y3e6oISQ1fvRQDWxdH0FsFY3Vs/bAtbi7nen2Q6IhHcfb1SpelXs+woPDL3mD2592eL9ye uJgF991wBeSJ+2Gx2sQSo2Y5M/ZVGtdmD3StjeVBYXNlF8F6tYjLTMhMPf7QDwv4m4GVk1 zCl+hpzNMdbstxhm9uRLEvhQcxpXYAI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1660295767; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kjBhkz6lsl1nfN6f0JT0oQPdTTdWRPlVXz3Chj0I2Bg=; b=aU1Tzfxz2Dw+3TACVP2osB4ivjUkFW4f4ojo7v6SDbmnKYk1fPY7OyqceiJxbRhro+rGAW 6UC5rWIbMa5NiwBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F0FDC13AAE; Fri, 12 Aug 2022 09:16:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id xvRPOlYa9mKyOgAAMHmgww (envelope-from ); Fri, 12 Aug 2022 09:16:06 +0000 Message-ID: <4bfcd6b0-2781-8e1e-673a-4d36ef573ecf@suse.cz> Date: Fri, 12 Aug 2022 11:16:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.1.0 Subject: Re: [PATCH 0/5] fix validation races and cleanup locking Content-Language: en-US To: Rongwei Wang , Christoph Lameter , Joonsoo Kim , David Rientjes , Pekka Enberg Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>, Roman Gushchin , linux-mm@kvack.org, Sebastian Andrzej Siewior , Thomas Gleixner , Mike Galbraith References: <20220812091426.18418-1-vbabka@suse.cz> From: Vlastimil Babka In-Reply-To: <20220812091426.18418-1-vbabka@suse.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660295768; a=rsa-sha256; cv=none; b=cO1xn61cp78hf8n+dM1oUlwyAt2vaR2gWm8tWqr/w+dJ33qvjKcMZu+ttygXPS7LeP96c/ 5lBgzB5Dcv/mMf0TlD0amr1fbwp5ibcfhwAtHmvkAfhn022haIj9Dfl7nqcJ1Vim1ZmlXt tM9bGnZPYGUOT+CxRBjAGoVduJg2xaY= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Y3e6oISQ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=aU1Tzfxz; dmarc=none; spf=pass (imf29.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660295768; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kjBhkz6lsl1nfN6f0JT0oQPdTTdWRPlVXz3Chj0I2Bg=; b=mVjJb98Kdjq3rGVal8xsy69Xd3fwgJY9hWykQ9qhU6FPQFUKp5zmklly2fBtfrHKsoEoE7 +LLqgRrZElGRfX6ml7LFpwN/EqUnjWq6i4CrAihrNHdVXiaokxLPahbvcTDWGfrScLsax7 RFIsYpzTKtm8SNe1JJh2FMVZVca01L8= X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 6CBD912018B Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Y3e6oISQ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=aU1Tzfxz; dmarc=none; spf=pass (imf29.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-Rspam-User: X-Stat-Signature: 73yq55en4hmxh4kohgz6mkhwfj338144 X-HE-Tag: 1660295768-16960 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/12/22 11:14, Vlastimil Babka wrote: > This series builds on the validation races fix posted previously [1] > that became patch 2 here and contains all the details in its > description. > > Thanks to Hyeonggon Yoo's observation, patch 3 removes more slab_lock() > usage that became unnecessary after patch 2. > > This made it possible to further simplify locking code in patches 4 and > 5. Since those are related to PREEMPT_RT, I'm CCing relevant people on > this series. Forgot the link to the git version of this: https://git.kernel.org/pub/scm/linux/kernel/git/vbabka/linux.git/log/?h=slub-validate-fix-v2r1 > [1] https://lore.kernel.org/all/20220809140043.9903-1-vbabka@suse.cz/ > > Vlastimil Babka (5): > mm/slub: move free_debug_processing() further > mm/slub: restrict sysfs validation to debug caches and make it safe > mm/slub: remove slab_lock() usage for debug operations > mm/slub: convert object_map_lock to non-raw spinlock > mm/slub: simplify __cmpxchg_double_slab() and slab_[un]lock() > > mm/slub.c | 417 +++++++++++++++++++++++++++++++++--------------------- > 1 file changed, 252 insertions(+), 165 deletions(-) >