From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB299E95A91 for ; Mon, 9 Oct 2023 10:03:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 26A748D0047; Mon, 9 Oct 2023 06:03:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F4AF8D0031; Mon, 9 Oct 2023 06:03:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 094748D0047; Mon, 9 Oct 2023 06:03:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id ECD808D0031 for ; Mon, 9 Oct 2023 06:03:26 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C696EB47DF for ; Mon, 9 Oct 2023 10:03:26 +0000 (UTC) X-FDA: 81325485612.08.A10C76E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 94AEF1C0005 for ; Mon, 9 Oct 2023 10:03:24 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UL1o74Rw; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696845804; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6ZDq+KacwLqN89Pgcuf93P7pKqhNHzHwi+dO6s3fMZs=; b=C50qBKuzOCvHnhlNlbhegr00Q2Xsd4LDA+Kitp6UPOoQyQLC/LzUYpRBAnNrd6VEDBMDmS TuquDx8tz8evvPT/NoFnXNDmXnyZrmAynX+5Jq5RYlSVh1fH1Iirx+HfhWje3aHUw9cj/A yeS/DrvpLaUlmC9LGWUrlur4RvPkWQg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696845804; a=rsa-sha256; cv=none; b=F8mhQ4tQj/NJiqbOhbURkWy7BdRn8FE0jwimawejsgR44lWDIsKjwrt92xLkAvHLnl/0Ic i6BieMyvZKi+OnvkmVVPTWT0VnbmlOrtAQFDu995R2t/gOt+oBazksO0K5RyrbU2NCdRmp vKnSO/GHFzvfQwwHOSoO3cXcwzwbDAM= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UL1o74Rw; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696845803; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6ZDq+KacwLqN89Pgcuf93P7pKqhNHzHwi+dO6s3fMZs=; b=UL1o74Rw8g4win4Ih4ECQKGz5ci4i9VBJfLZfyYJ5kUuuOE9AFibZXI1ufzD4qTGo6IOqp B6X4/7ZjeULrK3HRbT3TFqIXTKwfgjqbHu2vSsxZxzUeFfVE2YYJicpRqoBkFol2bAHGmY TYneA5Gj3ybCylMjisylx6gSFU5bmAM= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-133-M90IkMYiOcOTt0f5X6dFFA-1; Mon, 09 Oct 2023 06:03:22 -0400 X-MC-Unique: M90IkMYiOcOTt0f5X6dFFA-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-3f5df65f9f4so27961545e9.2 for ; Mon, 09 Oct 2023 03:03:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696845801; x=1697450601; h=content-transfer-encoding:in-reply-to:subject:organization:from :references:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6ZDq+KacwLqN89Pgcuf93P7pKqhNHzHwi+dO6s3fMZs=; b=DwTHce4U8fzShw6MmwZgAzrgE6b1It/NrudSxWGaGkyenkwe+FHDREsZktedTVGeQV 0dG2/goWWhtr2tl4LBis8GeQaxca+Fp0MG+rc11jVib9OvLlJ7GY2LEqfEFLUGfXM6sm QyiE9S/MwiqPnnlf+RcM8gGOZUOuBDO0i6zzHeu9PcwqBmFRey4+Dk9G61RtnuNd5AYM XclB2sMWe1FHxTTRSgiJXlITg+owpLng+D9OtjaSQuGPY0DlobJ/N3fnSSaKEYboh2PD kJTSt9ODzQZijAaGaIOxwpQ875OOQ7+V+mRu/v3fGyzP+rte4Q8/uLdNpm5/7ymwVbC0 ZKXA== X-Gm-Message-State: AOJu0Yyl1WpzRTem79d0tYMBe+zJzNUIozfcvGQEkYJEt6MYn8qNx9kw GH2XZGgvOpNISl7IAONBbRBqA4vQsy88FBCtXt3I5YXuDk5IdxOAMgYlqH9GkivQyikTvH08/eT 1IZjMgDasmM8= X-Received: by 2002:a1c:7917:0:b0:401:d803:624f with SMTP id l23-20020a1c7917000000b00401d803624fmr13718987wme.4.1696845801325; Mon, 09 Oct 2023 03:03:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFId6FWrCaw17rUDTNitUjp67GHOR1xHsUpjh7dUepuwDNGG0RB5tNnyfIWHhfq4QTievZWLA== X-Received: by 2002:a1c:7917:0:b0:401:d803:624f with SMTP id l23-20020a1c7917000000b00401d803624fmr13718970wme.4.1696845800872; Mon, 09 Oct 2023 03:03:20 -0700 (PDT) Received: from ?IPV6:2003:cb:c733:6400:ae10:4bb7:9712:8548? (p200300cbc7336400ae104bb797128548.dip0.t-ipconnect.de. [2003:cb:c733:6400:ae10:4bb7:9712:8548]) by smtp.gmail.com with ESMTPSA id e11-20020adfe7cb000000b003176c6e87b1sm9175744wrn.81.2023.10.09.03.03.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Oct 2023 03:03:20 -0700 (PDT) Message-ID: <4bf9f174-2d0e-554a-c01f-7188ccde0f3f@redhat.com> Date: Mon, 9 Oct 2023 12:03:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 To: Suren Baghdasaryan Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Mike Kravetz , Muchun Song References: <20231002142949.235104-1-david@redhat.com> <20231002142949.235104-4-david@redhat.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH v1 3/3] memory: move exclusivity detection in do_wp_page() into wp_can_reuse_anon_folio() In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: hcrpkwikn96kax9q1gfphnfbcywg7jgo X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 94AEF1C0005 X-Rspam-User: X-HE-Tag: 1696845804-597903 X-HE-Meta: U2FsdGVkX18GLBgk4v+GuziMj23TpIpBEt1JbYiYfIyHZWWxa1c/DlOeWF7duNM4Z/LkZMHj/fxP9cqwcStHojkR4WBrwn0fYOa9cPVELX10q6Mzk0UWlaNhECLsckw+hKGtjQBrR0c6ou7vxSACla5Y2mzZgO/g9/QA+8rTqLvpcRGytAhR3VMfqY3cPeA0suOa/+wdnu+3LGU1Ml9/pSkqDFL2AbwMqDJcBjN4PWclm5gANrnL6zXEmcoKCNfVk8jJzf2L0gTjCP3NpcDBRkJY6uPSaJghqLf8BlYulaWWU84akF9NAkKRjc7gyZQOL0th1yOlXo2/2TS+DECYQCohM5gSOUR7zy7cArix0az7gynqFMHx/eFhRAOMFvS92mqprPA/MZdp3diXemA7EjEf6eS8na3LU1DI/QefnXLStMRALr3+DZzfTklau34KuWWhVVcwkYESg1z6TVWlGCseKoX4Rwuq7yPZB269Gh5pXE6KGDfF/05YhKUIw+eT7meg1IrCmUwB5Npfftc2/birlbKgX5uEn0XlYP4/sM9WBZrvc3zVRk0Sog/iAI+7xv0VYD5L76Lu18TmICswqK30iTDrLEYeGzheNNj/r5/q9ry94bMZxw0hJ6wZAoMJB6Su39PFP1efK95WHN1eN03rFwHrmJZ+XOdzjEajkIb3gph8+7I25NnPKH/l9JP+/MWhhZiiYFXYLPiekPgEKykolSVMh4Rb/ffMwee5RXNMgvm0MJdQeCJGhEdyb3djZeooeEXZSgUpkiWCaeUaxkHsvktptp3amRnhkWWbYhrNpgjHcI7YGY3DFoz7BTSTqJU0txkSJz5jsneZN5XyAwgfr+W5dTSvpqUVstJ/oHWSuBgXqN8thn/3L0++nblia6wUQJ2kQdlz9aWXhqEefwHGSNI3KeVps4wE9qDpXOKHCzrOW2TRGLPge0vD6ADFLSA9/Cb1z80Vw9b/UmR HE4IArKf myhFbVGRA5ndzo3cMQ2OEwIPpMaTH/pQkHqwDqm6dmhKeqUKNKOV50Fp6Qo9qvYI5kKOtYc7LiZayVW8I7SN2yZNTCsWtEqIZ1vWiyRnIXic9by6dQYKPjIPW6jEhzlz/EYUUc4IzQSYpXs2aoaWVkCeq0xnS5d790ZicKQrG5A2FnqsAi3Lw0mWpxR/uzgm6EV9Fm8DJCSOQTG5C3cjaIbHRhtHAYUuQg2CXSO6HYHn7J3pEj1A81no6lV+nSu6LFq+i6ehCCCJZaumfGP3UymjlIpbjbF3GQUJN4c3xEjUZuxaJnHJVslpoujiK4gDlXoQYBTq9OCwebY0gSWlJeWoRHV15OHop2OtyOALgwodFm6zrKb3BICeziPwwrzTEmNl4hUp6YGmQRxOxz65LF9Nku0FIcnLH5KjuZdUcgkrwx4eR/YpcdhIwMxcpIagspRDusN9AwjlwqEY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 03.10.23 19:05, Suren Baghdasaryan wrote: > On Mon, Oct 2, 2023 at 7:29 AM David Hildenbrand wrote: >> >> Let's clean up do_wp_page() a bit, removing two labels and making it >> a easier to read. >> >> wp_can_reuse_anon_folio() now only operates on the whole folio. Move the >> SetPageAnonExclusive() out into do_wp_page(). No need to do this under >> page lock -- the page table lock is sufficient. >> >> Signed-off-by: David Hildenbrand >> --- >> mm/memory.c | 88 +++++++++++++++++++++++++++-------------------------- >> 1 file changed, 45 insertions(+), 43 deletions(-) >> >> diff --git a/mm/memory.c b/mm/memory.c >> index 1f0e3317cbdd..512f6f05620e 100644 >> --- a/mm/memory.c >> +++ b/mm/memory.c >> @@ -3358,6 +3358,44 @@ static vm_fault_t wp_page_shared(struct vm_fault *vmf, struct folio *folio) >> return ret; >> } >> Sorry for the late response. >> +static bool wp_can_reuse_anon_folio(struct folio *folio, >> + struct vm_area_struct *vma) > > Since this function is calling folio_move_anon_rmap(), I would suggest > changing its name to wp_reuse_anon_folio(). This would clarify that folio_move_anon_rmap() is *not* the reuse part, it's just an rmap optimization. You could remove the call here and the whole thing would still work :) In fact, we can call folio_move_anon_rmap() whenever we sure the folio belongs to a single VMA only and we're holding the page lock. ... but we cannot always reuse a folio in that case because there might be GUP references from another process. Reuse is * Setting PageAnonExclusive * Write fault: wunprotect the page -> wp_page_reuse() I went a bit back and forth while cleaning that function up, but calling it wp_reuse_anon_folio() would end up being confusing with wp_page_reuse() called afterwards [we should probably rename that one to wp_page_wunprotect() independently]. So I prefer to leave the actual (sub)page reuse part in the caller. > it's actually doing that operation instead of just checking if it's > possible. That would also let us keep unconditional > SetPageAnonExclusive() in it and do that under folio lock like it used > to do (keeping rules simple). Other than that, it looks good to me. I really want to avoid passing a "struct page" to that function; once we're dealing with PTE-mapped THP, the page might actually be a tail page of the folio. Thanks! -- Cheers, David / dhildenb