From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 363F3CF8877 for ; Sat, 5 Oct 2024 08:58:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A4E96B01B3; Sat, 5 Oct 2024 04:58:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 354916B01F0; Sat, 5 Oct 2024 04:58:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21D886B01F1; Sat, 5 Oct 2024 04:58:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id F14EE6B01B3 for ; Sat, 5 Oct 2024 04:58:06 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7170EC0654 for ; Sat, 5 Oct 2024 08:58:06 +0000 (UTC) X-FDA: 82638946572.16.AE333A5 Received: from mout.web.de (mout.web.de [212.227.17.11]) by imf30.hostedemail.com (Postfix) with ESMTP id 58FDE80007 for ; Sat, 5 Oct 2024 08:58:04 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=web.de header.s=s29768273 header.b=SQuO+kO3; spf=pass (imf30.hostedemail.com: domain of spasswolf@web.de designates 212.227.17.11 as permitted sender) smtp.mailfrom=spasswolf@web.de; dmarc=pass (policy=quarantine) header.from=web.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728118553; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ulhG9dUDnG+bEUry+0gDLabDRVWAfLiOByQhvtovb10=; b=5OxOKK+XQrOaOZ7UxC9KUGMVkr8wwAm89lIDyc8NLjiS1oNs/2NJQafmgJhYdGFuYvL/mN OSGAVCen2DFnMSo7JFi+NM0gtkefpQUlC04QqDclPY1n6njO/qdwvaJuBn9vGmcTdtWw/E LT7o19E+hyldTO87yYrxZOn3ayEldkk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728118553; a=rsa-sha256; cv=none; b=uV41HKmQTgp2UfRvze/D3yE7pFKw+WNWvKtyVffp7jTdkPWSYJBbvInH1Ez0MDoLDWvM39 1qnw9HM4mjbDqroZ0F/ErwEQjVdIjEMVpykklAPIjIOjBzkSNjKLLdCn3RduFtz77BhJej VQTZMeargdsRRmD4vTFwOAwDZlMAcTc= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=web.de header.s=s29768273 header.b=SQuO+kO3; spf=pass (imf30.hostedemail.com: domain of spasswolf@web.de designates 212.227.17.11 as permitted sender) smtp.mailfrom=spasswolf@web.de; dmarc=pass (policy=quarantine) header.from=web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1728118681; x=1728723481; i=spasswolf@web.de; bh=ulhG9dUDnG+bEUry+0gDLabDRVWAfLiOByQhvtovb10=; h=X-UI-Sender-Class:Message-ID:Subject:From:To:Cc:Date:In-Reply-To: References:Content-Type:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=SQuO+kO3El0nXsU0LadckGZ6MqZvqKpzrPiAueg5bB/Nhqrm+3TcuyAIZSkX9zFM revR4WQZAR2U5dbSbqKitWYxPA0YT+AqD2PfDQPvXZoFxdV6AsqU7MhoeiirDLcOU CvobcN7ajrZVXMd4AeOGeDCSpBRAopC9o9wTnm1uf3sBlyQI3D9le5SOuuJ8QToB5 qcJJIZvvzxLQqRPZtpVdcY9q3sWaMCdXkW/2XEEIpxdWLX5nLwPlSsj2g342jVZxh TUFy9RV7ibQ/Y2ysgT/oXfSn7jZd7s5UKw/F+MASwNToNdq8yfvJ5FPk7tyhE+DAu jQ3J3YjaImkvAUIjqw== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.0.101] ([84.119.92.193]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MElZB-1tDAZO1ihf-00EbQE; Sat, 05 Oct 2024 10:58:01 +0200 Message-ID: <4bf6139bed2b7ed04ed0b599391dbff9272d33ce.camel@web.de> Subject: Re: [PATCH v8 14/21] mm/mmap: Avoid zeroing vma tree in mmap_region() From: Bert Karwatzki To: Lorenzo Stoakes Cc: "Liam R . Howlett" , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, spasswolf@web.de Date: Sat, 05 Oct 2024 10:57:59 +0200 In-Reply-To: <9e1f326d-7740-4f4c-baf5-45f9eae0048d@lucifer.local> References: <20241004093546.3232-1-spasswolf@web.de> <3b83746d-b73e-4b89-9b74-5aba5a827f45@lucifer.local> <088a3541b85b783ef68337bd4bb790d62f200dfa.camel@web.de> <9e1f326d-7740-4f4c-baf5-45f9eae0048d@lucifer.local> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.54.0-1+b1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:9BGjez5Zt+A20hxoenbC3l7+5i6TSs5okgZQyi7lVf/uoL4QAe0 vd8OMnBmDVemPhezPufHu4QXmEtyi4X9E6hI8F4F2IQjzG24q8U7VCigBGMywGprakgb9WC cQsP8J3J56kK+Wu5Ae8hH0POccZPgIPSd81MrR2Y3VwkGLOL6Q1tbDBhMFtXnok25ksid9L jHfZZB4LayonSlV4c5MIQ== UI-OutboundReport: notjunk:1;M01:P0:FqcPeFtM28w=;DDWfrcAvYItuaCubNyn0FUQldEm jP0ayM5wIcUp/40LiC7hSnJoCx1kbWiJ62LqyGJDigp8YUrNjtjPM/GJBTi0QGYwS6RcOoQTT 8AeTENYj3JPdXDBvYaxAsX9IYM0kgBBPbgt9J4s+RzM91YSbHWxArgnYAIxe5ozDXkH8RMWFa U6ILIwRPfALOWG1Xx+qMmrKGQuoO3OKUejo/kLg5KKBMH9RRlSyvVlKNdt42L3y6eonKwZyGg CtC/ZzQJ+6Z+HIyZerVbEUdGGyg3mJPjc3et7wvR+XYRkgpHkkLdqfpNM4ZpRPBfCeNfPFzFl 3G7S7BdrGW9O5Ui+OTGUQm5I3IhZUhUgXdHU0p1WtxL9jPilDY2X8nBFK+yQvJU2EuiSGOCQC EsyJbtHGfjpbCqezGgNs34TQTvlip3zxAbWSmLup907Mmt9z4LsQtO19mfs832V+0obNfGQw0 dvV9rtp1IF5EjzAY8WhhlmHWOPREfTp5UxSkr49jgAmKlrpFZkYsaNtNbUhloR58QXCHYVocZ iH1mUiTbNGaQzKZqqhYMSwsRqqYkXYi+QLcjnNxDSZC82ncAXbM8RNahj8SjHp8mDri64j4Wa f7OAdLMeYlvz7umEstMzMsdNPx9hhjhFpfQ8382icWxsWppp5zDUJiu6g7kIM1+iV/4hOaN+R RC8KRahQFKctKz8+p0Inp12vqBQvKfGljN1JgdmdF3jE0K1LyEU6rN9D3MRgyXa4maJ+cL+uO Q5ftD2/bAFRNWTHhEO9LXoySuqc+7HQakNeB0QXSRW/DejxJONsxBr9Sl0jZ0y/aOaWN1Ncor 9qLXldFjM1V7G3iRMSwucY0w== X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 58FDE80007 X-Stat-Signature: uk63od5jm66ybcnsp3opyp7jn7xow3om X-HE-Tag: 1728118684-724386 X-HE-Meta: U2FsdGVkX18/JaHwerWgA7dNPF+ak7KRB6enB1tq6Mj09B9JgluwHiBzQqWBwnTAEf1poeV3lSCqNFECJVO5v4Goj1lQLMkZLDuT/EV9k4zpt9uIehn5fXpWuyeAkQMYYgAKXsUmkoenmS7JBQzanQChAbpiFnIQDOA842DJ0jPE+zUrOkhri7z9plNHjNURGHHe6Vn27lJtchdQBOGNoK3GyiOOpUSF3CrOzosc/ChFINiZPiKzqSz6ql9+YeMjfJoAJaEcPj5YIiXq/4wKI9B4hmqnXIb509n5HM2WrunWrNYcVXUdsVn/r/d9zfKYnQbfc8tGV/7LpKpTSvefeB+Vsyr8kNW/rQiSlFUqppplRoN6EfrUpBBuPKkW+Kpnkw9xMJ2a9s1H5aK7GWM1WEDnPkXwquIfF+JVGpfOlxhtm1JY38W22r9D9GfHn2w3yV1snjAmbomW9rUEMwT+hXyEEqbhsBJLKqeFG9aSS0vBmlmP9Cl6/Go7W4W3fPn4wrr/4Kh+cNpAM7u4gzkw2fsFG/X9TrgTg8mHJR5izI0ZUkjvlLyBeBeJbOkwDxdTourgEAx97J02TqtymnLwxxOHxmJd7dsEh28tjkWByEGkx0ipgeeKfW0+HEThmyldv19JndRKjxV0dOWoROhC8nQcylIeKH4UXGT7uF37SD3XxmVTleAgVOzuoImpXhWLXu6sIoVSSh/p4Q//hGAdqMnsI+9dOTLu6u97FEYtzQlV2VM+QAyq6aIDjtpJtltj3w5Ni3wx1eAM5ff533mLhZGcckRL6gJ8ndOW/L9J4W1FWUrxvh2/sLlNYAlTAl56MMGWRwDluUJscQ+i5ttrq3SUMJB5/0S507exQbNZIeSIyuDSe9nrCAb5dk5JIB0CNodrDBK+P72sEKhCAzaD1uUQ7P4FHq6wJh6TShajoWTWlggpchLVk2l/8dljflAQ/VDrrCTMLT0+iD7NfwK zezApUEi 7AkHj+1Z1kLqQnuOnHF4oyJa80f5STnDuvKmySPrS0AajaFH98H/ZhIO/FLaKlGEIkw6MsZI8JGUePz++tsKAach6v7l/nYgekCqvUbSrYCRMW6LodicUTLkcSJa4sZ6/MEwSxRRXbVrpGgYRSClVHEMG/jrR/gfAGkfeX+VzKiLaLJltUgKF/sqEscZii4Giu7nryfo0H87quNU1a2vx8xLUUza7hh9+sWjW4sC0M7Z3aojZ/fUTGzp1eGxRqmt9InQ66ZMfznhH9mNxoPbo4Rv28c8PlG/2jrD26lG8qkcY0HaYdD7N2efoRVZqauvDZRI5eAYPzrPOggg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000015, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > > > I just tested this and it passed ten tests (i.e. upgrading the proton = version i > > steam) in a row. > > > > Bert Karwatzki > > Perfect :) will send the fix upstream then as a hotfix for 6.12! Thanks > very much for helping out with this, your help has been absolutely > invaluable and HUGELY appreciated. > > Cheers, Lorenzo I also tried another debugging patch: diff --git a/lib/maple_tree.c b/lib/maple_tree.c index e6f0da908ba7..35b0fe3e02f7 100644 =2D-- a/lib/maple_tree.c +++ b/lib/maple_tree.c @@ -3773,6 +3773,8 @@ static noinline void mas_wr_spanning_store(struct ma_wr_state *wr_mas) /* Copy l_mas and store the value in b_node. */ mas_store_b_node(&l_wr_mas, &b_node, l_mas.end); /* Copy r_mas into b_node. */ + if (!r_populated && r_mas.offset <=3D r_mas.end) + printk(KERN_INFO "%s: avoiding maple tree corrution\n", __func__); if (r_populated && r_mas.offset <=3D r_mas.end) mas_mab_cp(&r_mas, r_mas.offset, r_mas.end, &b_node, b_node.b_end + 1); and when running the test this prints [ 293.477904] [ T5720] mas_wr_spanning_store: avoiding maple tree corru= tion [ 293.480202] [ T5720] mas_wr_spanning_store: avoiding maple tree corru= tion [ 293.482087] [ T5720] mas_wr_spanning_store: avoiding maple tree corru= tion [ 293.484786] [ T5720] mas_wr_spanning_store: avoiding maple tree corru= tion [ 293.486644] [ T5720] mas_wr_spanning_store: avoiding maple tree corru= tion in dmesg. Bert Karwatzki