From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88CAFC27C4F for ; Fri, 21 Jun 2024 07:34:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1F4038D0141; Fri, 21 Jun 2024 03:34:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1A50F8D0138; Fri, 21 Jun 2024 03:34:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 06C258D0141; Fri, 21 Jun 2024 03:34:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DD5EC8D0138 for ; Fri, 21 Jun 2024 03:34:19 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 834DE140725 for ; Fri, 21 Jun 2024 07:34:19 +0000 (UTC) X-FDA: 82254082638.29.F7707DF Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf28.hostedemail.com (Postfix) with ESMTP id A66ECC0012 for ; Fri, 21 Jun 2024 07:34:17 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718955253; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nIIahHsSI1euYUEVNoSaw50DUtvHmoiaTSQ4J1j7wOs=; b=mPIq3qNDlDz/MldeqC9GB4lp/n577dhfYMmutEzt21EBQBVaFnhjQXOYAUF9dwvuT/eGk3 YAwNZ1wEhtYQA9fiEae/wpb6NX8HqsSitcZ7rIrpXou5Q+fdA1PH5dmfMIkPtDaV6X8oHN Ru/6eX/qvckq9cLKOLOXKQ8z945iOA4= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718955253; a=rsa-sha256; cv=none; b=uO5VGUXH4wTxSysGkQ2gXvYLXMZEIwv+hh1PgJ0tBh+Wx9MGXwxOz7qnsuMWk5dtRLQaDQ /Cx30p5n/b+r8CcqbF/BSwY1hDmslLcGhagex5UDZ6sfoMIQXv3M/Lu/wPrH3Obuzv3JyS mMQBraKoF4IvhmSQF9TeKToQDee+DIE= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6AE4ADA7; Fri, 21 Jun 2024 00:34:41 -0700 (PDT) Received: from [10.57.74.104] (unknown [10.57.74.104]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AE5773F64C; Fri, 21 Jun 2024 00:34:14 -0700 (PDT) Message-ID: <4bf2aecc-1c7b-420c-aa82-8613e2422407@arm.com> Date: Fri, 21 Jun 2024 08:34:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/mm: Introduce a test program to assess swap entry allocation for thp_swapout Content-Language: en-GB To: Chris Li , Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, shuah@kernel.org, linux-mm@kvack.org, david@redhat.com, hughd@google.com, kaleshsingh@google.com, kasong@tencent.com, linux-kernel@vger.kernel.org, ying.huang@intel.com, linux-kselftest@vger.kernel.org, Barry Song References: <20240620002648.75204-1-21cnbao@gmail.com> From: Ryan Roberts In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: A66ECC0012 X-Stat-Signature: 764ocb6rjggcnjxonu54ac59ruioq5mj X-HE-Tag: 1718955257-224658 X-HE-Meta: U2FsdGVkX180nTG/7cWtPhTjnvQLyv3fUuVt7H1JuPHUmbbf3NseKrb09DlreraLm5RwYQv9Zxnt7rlv8aUj2WwzOHfetYqdVtZxLsfRDC3oTAA3CRtyA32PwADHbuK+hyrMzEAEiw56BK2n/mrfKhkv5IZFxvUl+57Dx+3AnkV7FB2wD9Ge3NxoJA3ZbyAHoWDHwPviKWFxX2M5JrdqIPrnUEEbhVR1/k5lTJ6iZ3cMAWcz82iJT831It9HSDGbDEu16s2vyW2nWdwxKGh8nHDKSj/Use+SvM58JVjV75K0xuQO/0kfDXGCaXDlZFZd8BwyM9HvoaX9zfAOaDLeut8xUktIcXoByDEroG6UImzu+m0SD4ovO24rt0Jd1cwFld9ERKHQkxk4Vg1HupgViaIOIaoqM8Ir7aErnQ1vM+6OOilozkPslF7BR4ZxAEd5/39XjsAcxjmbQhvCcatYk39sMgOdU45ZS+4DEz1wSCl6bS2yUIlMJavMJqlOT3Se4HRe0MWhZo2LkoC8pKTRx42B79O0oSOeNt/wJubJKZY/i3iNQGuuQZdA61ZWVbxH4YXR26YXjSdSVtbKE+f2z6mreNzcJbahtH6yz30ItgJlUQ+yC4GRarrypoiFlKZCHhYQBRV8CfgdGWq+wEUYuZzff9c13nDY7psUSIZ2zJH6QYRtPnWjugyIgaqKcwWSrPvs0/vvBswJXuDNcaeyS2Pka7Kk8MAfJ9twx2qxnJ2p/QvRyawnPG0e0Y2JNhHlyLdt4JzUoDjOR4mBm1OSLhlV+ganw5n9EZ2SMdQetmBKG5qF8QsGl6WKl3TtGJ4XYdqlHYQ2vuyaHybCiSEbsYqlCJ7Xl/OmcyqUCr+tcowKqB2hOr56e+33lijFKzKSvOCfJ30d9vE05nakKJPxjg2lajoWXV27uUuixmoVX/ef9vaPOa+kv667/F6sGGNlyiaQ+lEBkGV0F+XWDxs yAyuIAOq YCTY4zakQOKx5evOT1nyFFzz3wySGjmxLgfbv6IHUwFgr0PihqrwnkTTGq41zLJCfs3C1q3+V7DWb7w+bZL4wzCtwgeZqbv/lHhbujEVQ+qaDbZs0vsHenx5s/DK5Daz3nhRZh1Mop5xeJvjTPhAH/dKGigN01sHKSK75M/EZ6JLTHErpXUEP6dN2aHrM8+DSCvOv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 21/06/2024 00:34, Chris Li wrote: >> + * thp_swap_allocator_test >> + * >> + * The purpose of this test program is helping check if THP swpout >> + * can correctly get swap slots to swap out as a whole instead of >> + * being split. It randomly releases swap entries through madvise >> + * DONTNEED and do swapout on two memory areas: a memory area for >> + * 64KB THP and the other area for small folios. The second memory >> + * can be enabled by "-s". >> + * Before running the program, we need to setup a zRAM or similar >> + * swap device by: >> + * echo lzo > /sys/block/zram0/comp_algorithm >> + * echo 64M > /sys/block/zram0/disksize >> + * echo never > /sys/kernel/mm/transparent_hugepage/hugepages-2048kB/enabled >> + * echo always > /sys/kernel/mm/transparent_hugepage/hugepages-64kB/enabled >> + * mkswap /dev/zram0 >> + * swapon /dev/zram0 > > This setup needs to go into run_vmtest.sh as well. > > Also tear it down after the test. Additionally, if keeping this as a selftest, you'll want to add CONFIG_ZRAM=y to tools/testing/selftests/mm/config so that automated systems ensure zram is available in the kernel under test. And you will need to ensure that the zram device has a higher priority than any other already configured swap devices. Otherwise there will not even be an attempt to use it for mTHP. The easy way is to do "swapoff -a" as the first step but that makes cleanup tricky.