From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A9A2C74A5B for ; Fri, 17 Mar 2023 01:57:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 60167900003; Thu, 16 Mar 2023 21:57:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B0ED900002; Thu, 16 Mar 2023 21:57:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 478B0900003; Thu, 16 Mar 2023 21:57:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 399F0900002 for ; Thu, 16 Mar 2023 21:57:53 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 054D4C1680 for ; Fri, 17 Mar 2023 01:57:52 +0000 (UTC) X-FDA: 80576729226.13.ABE5E20 Received: from out-32.mta1.migadu.com (out-32.mta1.migadu.com [95.215.58.32]) by imf08.hostedemail.com (Postfix) with ESMTP id 166F1160007 for ; Fri, 17 Mar 2023 01:57:50 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=dUOguqoB; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf08.hostedemail.com: domain of vineet.gupta@linux.dev designates 95.215.58.32 as permitted sender) smtp.mailfrom=vineet.gupta@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679018271; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wJOU11SbL9/kaDnu46rJWsPZcBg70MspuwQ4F/vkNx0=; b=upJwrUT80+lvcesx8ZJ05H4viHlemYuX/dRBExAHsUdgndii0CrYuyQkrgBgo3jECAtgzI oYvwBNpeJNeQUJZ1NLba8HkrByZ6N0ScP4CO83pcuKtjE+tvj/xYmdiQ32GyMq7k3UNmt+ hCCl7NZlCzStSxM0EOddiWOiP+wePBM= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=dUOguqoB; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf08.hostedemail.com: domain of vineet.gupta@linux.dev designates 95.215.58.32 as permitted sender) smtp.mailfrom=vineet.gupta@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679018271; a=rsa-sha256; cv=none; b=xeNHVVXxNcOnfX5S0xlael9kCU7mV41O0quqT8KcLVFsNdtfrA+1sHjzv0mResroENn+Xs aPohDInqGXP6oti3gMVo0eVHCiE4Amy4vdmVilJ2oaHdJoircDsbHxcxp0E48D/B4VSM24 ThrLTfjFPleJnZ7OsXEm3TLMibATevA= Message-ID: <4be3cbb7-ef4f-69f9-7212-123faec96044@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1679018266; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wJOU11SbL9/kaDnu46rJWsPZcBg70MspuwQ4F/vkNx0=; b=dUOguqoBVgVvt0KVjF0g3kzsGkOY7pUxYxTjY1vpsZxafJemjI/kyNepPUg/LhkhLucorz q/lBlfygL4INZlAGCfNx2GPpMgptsSJHuW3upBDwHIuNncTDkkuDznRHonzDtjfPkCeuTO gCax/rVU3QO8+yf1CN5d8E2zI2lRrcQ= Date: Thu, 16 Mar 2023 18:57:35 -0700 MIME-Version: 1.0 Subject: Re: [PATCH 10/10] mm, treewide: Redefine MAX_ORDER sanely Content-Language: en-US To: "Kirill A. Shutemov" , Mike Kravetz , Vineet Gupta Cc: "Kirill A. Shutemov" , Andrew Morton , Mel Gorman , Vlastimil Babka , David Hildenbrand , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230315113133.11326-1-kirill.shutemov@linux.intel.com> <20230315113133.11326-11-kirill.shutemov@linux.intel.com> <20230316181547.GA6211@monkey> <20230316233053.iwsffmfxzzacnkuy@box.shutemov.name> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vineet Gupta In-Reply-To: <20230316233053.iwsffmfxzzacnkuy@box.shutemov.name> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 166F1160007 X-Stat-Signature: 7c8qmxzcasa5oq7nznnq9g98bffdpogd X-HE-Tag: 1679018270-964768 X-HE-Meta: U2FsdGVkX18qwGOY90ehRiViI1ox9gm+De1mWAWcWqX0nbEqkLPJJmgBqCEBD/2cNZMBY8PVW/t3bAvAxYDENFjA+mcqETTuYe6rd6aEnwBMPznYdgYFZTMEMJUEuMr+qjtfj1gl5zxGbUrzwDIDx/l+pDRWdrnzChJFQTxaKdpU/WROgMxr+iH9jMFeH2QOho4MaLhdJmJ5/LuVT1dwMFK5mjNAC8mfuH7lTaSZZilXiqcW5FGXmtM5v2HKPE+EANKYbRaRMgudDZxQ+g0AFS4h3aDaWLDCdjgxPgvn1x3kbkau/4/0C46oHVjrozN9AiFwE+dGKKmiAICpBgX1JT8Er0DrTcxojR3PpIY4gGWwk4H05YRlLA7vkBblk8wpKXHz0lAipX1buXXmcrMuUfHj6Cr+wZ5csUmONnZAhOet1cXomLiUfpQX14wOu3UZS8ym87XlwrNyojYmg+/iPY1YWcNj4Sjy5/fnn6NnHOXXyhDwYQ+6POTDUvAUWfGjihoio5bzut7wB4C31yoew1hVK+q8egr6T0EhQ7EKcy4FW0fao4Sua9JJA5ER1oxo6p3lwa+pcULKPlAkuTK1xutCHr5MUyRTBhE4+9TtkrA82/+k1o2+l3xM3gV6lSeU1oTJPjSAT2r47L4fIQNvfeg1b5AtCCvJ5At8OpdoAO49dIEA9GHHNW3F7c+JvzwFORQ2NJ1iU4wgtl5znDsZzaHTTnkIZBEd8/lcnmqkezU/DbqdGBGoEne+a7X4267I1GvUFRTjIQxL9LV2QJG9patvNB+W3qTGLbNm/U86pimZgujgioYTWF1Ocurvobr8vmABCoZ3prO1xv1q1czT9kaYrhlW3oDJ0VxMT7CeY9Sqk1sFvI6Y4EsQBCrzMM7WWlyRQirAIHWyquH32q0+UTqi/3Q4XSrvvF39zhBVs+fnktqMJb7EagBI9TDtepfMF/6VXe8tQ8TLIbLag6t Mo8uwQLt i18l8Q/stcXRz9IUQqCOqLyI3B6Bq6pfzNlmyX6fnV8NN0oyjwxqUMp1KwRD+KkzAl1jGBky+kjjiMvhQsVwuPAi2pNCZbqvdIW6DVVPuvmj4SsSOG+SvB3xnFvjH2RblEucgZruAH4dZOoQoAhQPyOIrew== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/16/23 16:30, Kirill A. Shutemov wrote: > On Thu, Mar 16, 2023 at 11:15:47AM -0700, Mike Kravetz wrote: >> On 03/15/23 14:31, Kirill A. Shutemov wrote: >>> MAX_ORDER currently defined as number of orders page allocator supports: >>> user can ask buddy allocator for page order between 0 and MAX_ORDER-1. >>> >>> This definition is counter-intuitive and lead to number of bugs all over >>> the kernel. >>> >>> Change the definition of MAX_ORDER to be inclusive: the range of orders >>> user can ask from buddy allocator is 0..MAX_ORDER now. >>> >>> --- a/arch/arc/Kconfig >>> +++ b/arch/arc/Kconfig >>> @@ -556,7 +556,7 @@ endmenu # "ARC Architecture Configuration" >>> >>> config ARCH_FORCE_MAX_ORDER >>> int "Maximum zone order" >>> - default "12" if ARC_HUGEPAGE_16M >>> - default "11" >>> + default "11" if ARC_HUGEPAGE_16M >>> + default "10" >> Is this Kconfig file wrong (off by 1) today? It seems like it wants MAX_ORDER >> to be sufficiently large to allocate 16M if ARC_HUGEPAGE_16M. So, seems like >> it should be 13 today? > +Vineet. > > Hm. I think it is okay as long as CONFIG_ARC_PAGE_SIZE_8K=y which is > default, but breaks for other PAGE_SIZE. > > Looks like ARCH_FORCE_MAX_ORDER calculation should involve selected page > size. Thats right 8K is default for ARC. -Vineet