From: Florian Fainelli <f.fainelli@gmail.com>
To: Vladimir Oltean <olteanv@gmail.com>,
George McCollister <george.mccollister@gmail.com>
Cc: Souptick Joarder <jrdr.linux@gmail.com>,
kernel test robot <lkp@intel.com>,
kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
Linux Memory Management List <linux-mm@kvack.org>,
Jakub Kicinski <kuba@kernel.org>, Andrew Lunn <andrew@lunn.ch>
Subject: Re: [linux-next:master 3824/6048] drivers/net/dsa/xrs700x/xrs700x_i2c.c:127:34: warning: unused variable 'xrs700x_i2c_dt_ids'
Date: Tue, 9 Feb 2021 09:25:52 -0800 [thread overview]
Message-ID: <4bb90ce3-10cc-407a-2158-f860d535d728@gmail.com> (raw)
In-Reply-To: <20210209172351.ovvf6nhhagbiwzih@skbuf>
On 2/9/21 9:23 AM, Vladimir Oltean wrote:
> On Tue, Feb 09, 2021 at 11:18:12AM -0600, George McCollister wrote:
>> On Tue, Feb 9, 2021 at 10:33 AM Souptick Joarder <jrdr.linux@gmail.com> wrote:
>>> I think, this can defined under #ifdef CONFIG_OF.
>>
>> Was this robot reporting this warning for other DSA drivers? A lot of
>> them appear to use of_device_id in the same manner (unless I'm missing
>> something). Do we need to do something DSA wide to deal with this?
>
> Probably not DSA-wide since we still have drivers that probe on platform
> data and not OF (dsa_loop), but individual drivers should have "depends
> on OF" in Kconfig as far as I can tell.
Not necessarily, there is a runtime dependency on OF being available for
probing but as far as building goes there are stubs provided for when
CONFIG_OF=n which allow the driver to continue to build.
Adding either an #ifdef CONFIG_OF or __maybe_unused should silence those
warnings.
--
Florian
next prev parent reply other threads:[~2021-02-09 17:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-06 18:01 kernel test robot
2021-02-09 16:33 ` Souptick Joarder
2021-02-09 17:18 ` George McCollister
2021-02-09 17:23 ` Vladimir Oltean
2021-02-09 17:25 ` Florian Fainelli [this message]
2021-02-09 19:16 ` Souptick Joarder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4bb90ce3-10cc-407a-2158-f860d535d728@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=clang-built-linux@googlegroups.com \
--cc=george.mccollister@gmail.com \
--cc=jrdr.linux@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=kuba@kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=olteanv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox