From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37146C432BE for ; Tue, 31 Aug 2021 09:35:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A011D60F46 for ; Tue, 31 Aug 2021 09:35:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A011D60F46 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 112C36B0071; Tue, 31 Aug 2021 05:35:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 09C488D0001; Tue, 31 Aug 2021 05:35:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA4EE6B0073; Tue, 31 Aug 2021 05:35:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0099.hostedemail.com [216.40.44.99]) by kanga.kvack.org (Postfix) with ESMTP id D72DB6B0071 for ; Tue, 31 Aug 2021 05:35:06 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 7A9448249980 for ; Tue, 31 Aug 2021 09:35:06 +0000 (UTC) X-FDA: 78534867012.18.07B3565 Received: from out30-130.freemail.mail.aliyun.com (out30-130.freemail.mail.aliyun.com [115.124.30.130]) by imf06.hostedemail.com (Postfix) with ESMTP id CE0FE801A89B for ; Tue, 31 Aug 2021 09:35:04 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R111e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01424;MF=yun.wang@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0Umk8iQZ_1630402501; Received: from testdeMacBook-Pro.local(mailfrom:yun.wang@linux.alibaba.com fp:SMTPD_---0Umk8iQZ_1630402501) by smtp.aliyun-inc.com(127.0.0.1); Tue, 31 Aug 2021 17:35:01 +0800 Subject: Re: [PATCH] mm: fix panic caused by __page_handle_poison() To: =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= Cc: Andrew Morton , "open list:HWPOISON MEMORY FAILURE HANDLING" , open list References: <58b6b733-b021-7eb8-4226-1b98d50c8c82@linux.alibaba.com> <20210831091134.GA1075738@hori.linux.bs1.fc.nec.co.jp> From: =?UTF-8?B?546L6LSH?= Message-ID: <4bb8b27e-2926-82db-0da2-dbead13c9b69@linux.alibaba.com> Date: Tue, 31 Aug 2021 17:35:00 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210831091134.GA1075738@hori.linux.bs1.fc.nec.co.jp> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Authentication-Results: imf06.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf06.hostedemail.com: domain of yun.wang@linux.alibaba.com designates 115.124.30.130 as permitted sender) smtp.mailfrom=yun.wang@linux.alibaba.com X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: CE0FE801A89B X-Stat-Signature: 5yhq5gank749mksuieyqu36bke7ysjtm X-HE-Tag: 1630402504-432215 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2021/8/31 =E4=B8=8B=E5=8D=885:11, HORIGUCHI NAOYA(=E5=A0=80=E5=8F=A3 =E7= =9B=B4=E4=B9=9F) wrote: > On Mon, Aug 30, 2021 at 06:07:56PM +0800, =E7=8E=8B=E8=B4=87 wrote: >> By commit 510d25c92ec4 ("mm/hwpoison: disable pcp for >> page_handle_poison()"), __page_handle_poison() was >> introduced, and if we mark: >> >> RET_A =3D dissolve_free_huge_page(); >> RET_B =3D take_page_off_buddy(); >> >> then __page_handle_poison was supposed to return TRUE When >> RET_A =3D=3D 0 && RET_B =3D=3D TRUE >> >> But since it failed to take care the case when RET_A is >> -EBUSY or -ENOMEM, and just return the ret as a bool which >> actually become TRUE, it break the original logical. >=20 > s/logical/logic/ ? Will Fix it in v2. >=20 >> >> The following result is a huge page in freelist but was >> referenced as poisoned, and lead into the final panic: >> >> kernel BUG at mm/internal.h:95! >> invalid opcode: 0000 [#1] SMP PTI >> skip... >> RIP: 0010:set_page_refcounted mm/internal.h:95 [inline] >> RIP: 0010:remove_hugetlb_page+0x23c/0x240 mm/hugetlb.c:1371 >> skip... >> Call Trace: >> remove_pool_huge_page+0xe4/0x110 mm/hugetlb.c:1892 >> return_unused_surplus_pages+0x8d/0x150 mm/hugetlb.c:2272 >> hugetlb_acct_memory.part.91+0x524/0x690 mm/hugetlb.c:4017 >> >> This patch replace 'bool' with 'int' to handle RET_A correctly. >> >> Reported-by: Abaci >> Signed-off-by: Michael Wang >=20 > Thank you very much, this fix is totally right. >=20 > Acked-by: Naoya Horiguchi >=20 > Could you add the following tags, too? >=20 > Fixes: 510d25c92ec4 ("mm/hwpoison: disable pcp for page_handle_poison()= ") > Cc: # 5.14 Thanks for the review, will add in v2 and send out soon. Regards, Michael Wang >=20 > Thanks, > Naoya Horiguchi >=20