From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2081E77188 for ; Mon, 6 Jan 2025 17:54:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 57CC86B0082; Mon, 6 Jan 2025 12:54:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 52D3C6B0083; Mon, 6 Jan 2025 12:54:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3CE6D6B0088; Mon, 6 Jan 2025 12:54:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1D9AD6B0082 for ; Mon, 6 Jan 2025 12:54:34 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C61E71201AC for ; Mon, 6 Jan 2025 17:54:33 +0000 (UTC) X-FDA: 82977776826.01.20B0364 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by imf30.hostedemail.com (Postfix) with ESMTP id 93EDE80022 for ; Mon, 6 Jan 2025 17:54:30 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=MJUOAxXW; spf=pass (imf30.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.19 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736186071; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PysEDo5cpTU6Cz4m+U3VAM+2Z3mru+rFsCT7t69Cp3Y=; b=AaGMYUbzgcznFFLNXV/pVoGLGLoFXK30dIiH+Zyvo9KjydButDS9T8vKWs+eGGBTt5Qc6s 29n3G3EGbckW4S2PKY7VsUCo93ysq3PdV+MigluXSQlOfbprwCzoqeuO9Cg4aLEbWrT4Nr qwWXekS+2VElpu+FNy//t46wlqu1G4E= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736186071; a=rsa-sha256; cv=none; b=O5qWBqPydIoukRCGcvGngCXvcePrO/EZlzYbfZaOOtZ5P1z5t9jtGDsrEPJsOWlpO/atfv WVLDnqRz9+4o0tCz5/JQOjlK8ujGba0k4JJgalMbuFIRMEhXsBEYsem9XFXDxSxZtu5I5X 5+pyu2t9NoJJGzPiG8r0OEV/7bQn1WA= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=MJUOAxXW; spf=pass (imf30.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.19 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1736186071; x=1767722071; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=SiDzFkKlYBjtgxP1/JkKP3SyxRsyFhBkTzRk1sbUMtY=; b=MJUOAxXWQatf9SIwTB1YjoECTPWI9fim6RUahOCR9WidO5IeqgICiBYk jOu0aDW22VBjc9X6hUdgBlS9ryVK8PBXMxXmRR2+NNleBg6ZilGsqCIdJ kDSoED08L66arirXHMaeZzJbUNJdrqPrUzIYDyRFmKr2PaFaOgXvYA2fV mpkqUIiPOPrp73xVJpU1GEbMZwUFYEjNjMQ75poATT5kMjVkQvs+ZCu3L 09kTCd46btaSaDjUxXcG2PsZNCm5IZOgSjwbzYupeqvvDP1GyP3eOxw+I p7K9h5JOHmLWcdm+UiRCUK3qbjPoziMPpbT4Rls1K9P5FyXXRdMlaIzed Q==; X-CSE-ConnectionGUID: FcI2zBmsSIaDt2m4jX1hIw== X-CSE-MsgGUID: MM64KQbFRwyldLJC9lD/Hg== X-IronPort-AV: E=McAfee;i="6700,10204,11307"; a="36221292" X-IronPort-AV: E=Sophos;i="6.12,293,1728975600"; d="scan'208";a="36221292" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2025 09:54:29 -0800 X-CSE-ConnectionGUID: mDo2HQp1RKafrsInaARmsg== X-CSE-MsgGUID: XDFEtF3hRES2j33DyfNxPw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,293,1728975600"; d="scan'208";a="102701013" Received: from lbogdanm-mobl3.ger.corp.intel.com (HELO [10.124.220.224]) ([10.124.220.224]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2025 09:54:28 -0800 Message-ID: <4bb7d9e9-4e8b-4587-a8e0-3a3eb2eb6360@intel.com> Date: Mon, 6 Jan 2025 09:54:29 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 07/12] x86/tlb: use INVLPGB in flush_tlb_all To: Rik van Riel , x86@kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, akpm@linux-foundation.org, nadav.amit@gmail.com, zhengqi.arch@bytedance.com, linux-mm@kvack.org References: <20241230175550.4046587-1-riel@surriel.com> <20241230175550.4046587-8-riel@surriel.com> <194072ff-32af-4a5d-8e73-0a45f75290e7@intel.com> <978b4da7c7949e70a515fd04279e12a39e575f1b.camel@surriel.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <978b4da7c7949e70a515fd04279e12a39e575f1b.camel@surriel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 93EDE80022 X-Stat-Signature: bthzfkk8cm6rcpqcq3w5sppwoj8bmeqx X-Rspam-User: X-HE-Tag: 1736186070-644285 X-HE-Meta: U2FsdGVkX1/7UxdgKiREIStE5K/Iu5kmSX+Yd32p/n1IE1GF7tIUy+y3Gp6IbcPPWx1Ir7Fn6+5EM8evqxENiNxqfz0tkdBEkUOib+QBYzxL6F2gqAtF/yIXjbaRN+QbFvkiZyWOYPIoBQww3QiJ+D9C56wXxVPnUeqkl+5qOZVIFp0hyiFeFTbMJw+xyXbiv6gstzBmku8ALMelSoWSdROGnhuoXtu8yBTMEoHpQK3vlxTYx85R+sRqwh20PYi/m0wIUV+v48Jf22J44xPCxRrFUhqihbTVNdq7quW7wLkbmW1XB644gVhff9ONZccEkm/uG2VMf7ugyHErO/G5/H/zQKAJWNylogo58RdYLQlnzBlgGklI63qxgjK3vG3Q5gQiDyPjw/m4Sshdj1aMFsPKL96cHZKMFZjnVeJFbueQpoPNaGDTKFxfYwJg6of/uQksbJnTPEbj5L1XoQheQ8UQmtr810EWGDr8mhA/jJXCrVigtLyb/65kgofwramEbBzM0VDzcfkYVwgFTsuO7Nk1XlBqEvZYQkMe+BuU/XxM7PaFYvGUsuTofduabImwepZssf7vyK48vux80WGtI18gZfCL3w3EUXAYMeTfIM3yr6WkMdyKYov1VFX+DGiHNPvQeXx96LLApNohKsJgWnB5RozTXyswp5VHywx66GW7pTIlKTRwvS4j0ClOncz8P1EbaScz2u/tmuNs5yeWyqn4XTRoIKozEzuT5WV9asXIMSbrNgyxGkq89f5jQndxDVRDE+MBpae3RB9ta2gil9t/TOZWASztdwE9Vg/dMvTvHNcXFpTCcVRNs2ffwKc8ZygqSP0VhsHOeUsc69vY/53Np4Du63DRh4M45ggcNhFQL5uMLH3qNHw5Jjdp9Tge1+kMry4x3sggb3nKg/1EYfJ5NnsHuNajGtamRaiV11REHieJfXHFmXbPdLqOXPXJvfbX72lwP4JMjZdxMEs VdTFDyEB rlCYoFwYkpzEvzTykjkp/R9MSqbFxPEwD3W6sEPO5ZEpTTt/aEsmLcQtIASUVRdH9cMOSybvrQ0u7ym2P9lZ3jiAnW3Gnq4BV0DzMSIZ2QO6MD2K7dWaRfJMQWFI4b82PRVIi8AYJ/KKRNUqgl8YCaqZOidJ2XqP8HQxsdej0Fx6NWjSUsBT3bvv83/c1oPq8niEvCmimInSikQvrHsP8MKGxekPuawOrJVHWwAQ9yylApWMSTI6CApXEErzDZAhQ47iDhln2XOA3FEU8pFGhdcq2aXtyVHThUpE12qmSFXJj/M0Pr1z+iUVyXPeMw6UNRaVAvFkZzokZ2htBnK/lmekqMwRfrlp6AYLX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/6/25 09:35, Rik van Riel wrote: > On Mon, 2025-01-06 at 09:29 -0800, Dave Hansen wrote: >> On 12/30/24 09:53, Rik van Riel wrote: >>> --- a/arch/x86/mm/tlb.c >>> +++ b/arch/x86/mm/tlb.c >>> @@ -1074,6 +1074,12 @@ static void do_flush_tlb_all(void *info) >>>  void flush_tlb_all(void) >>>  { >>>   count_vm_tlb_event(NR_TLB_REMOTE_FLUSH); >>> + if (cpu_feature_enabled(X86_FEATURE_INVLPGB)) { >>> + guard(preempt)(); >>> + invlpgb_flush_all(); >>> + tlbsync(); >>> + return; >>> + } >> >> After seeing a few of these, I'd really prefer that the preempt and >> tlbsync() logic be hidden in the invlpgb_*() helper, or *a* helper at >> least. >> >> This would be a lot easier on the eyes if it were something like: >> >> flushed = invlpgb_flush_all(); >> if (flushed) >> return; > > One issue here is that some of the invlpgb helpers > are supposed to be asynchronous, because we can > have multiple of those flushes pending simultaneously, > and then wait for them to complete with a tlbsync. > > How would we avoid the confusion between the two > types (async vs sync) invlpgb helpers? It could be done with naming. Either preface things with __ or give them "sync" suffixes. We could also do it with a calling convention: struct invlpgb_seq; start_invlpgb(&invlpgb_seq); invlpgb_flush_addr(&invlpgb_seq, start, end); end_invlpgb(&invlpgb_seq); The things that can logically get done in sequence need to have the start/end, and need to have the struct passed in. The ones that have the internal sync don't have the argument.