From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52CBEC2BA4C for ; Wed, 26 Jan 2022 12:13:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DCE716B0072; Wed, 26 Jan 2022 07:13:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D7DC36B0074; Wed, 26 Jan 2022 07:13:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C6CAD6B0075; Wed, 26 Jan 2022 07:13:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0023.hostedemail.com [216.40.44.23]) by kanga.kvack.org (Postfix) with ESMTP id BBD246B0072 for ; Wed, 26 Jan 2022 07:13:04 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 6D04A86E6D for ; Wed, 26 Jan 2022 12:13:04 +0000 (UTC) X-FDA: 79072327488.19.B17C64B Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf21.hostedemail.com (Postfix) with ESMTP id 561A41C000B for ; Wed, 26 Jan 2022 12:13:03 +0000 (UTC) Received: from kwepemi100008.china.huawei.com (unknown [172.30.72.53]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4JkMvj3dtXz1FD5B; Wed, 26 Jan 2022 20:09:05 +0800 (CST) Received: from kwepemm600017.china.huawei.com (7.193.23.234) by kwepemi100008.china.huawei.com (7.221.188.57) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 26 Jan 2022 20:12:59 +0800 Received: from [10.174.179.19] (10.174.179.19) by kwepemm600017.china.huawei.com (7.193.23.234) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 26 Jan 2022 20:12:58 +0800 Content-Type: multipart/alternative; boundary="------------2sE5CklAQW5Skk0e821jJkdX" Message-ID: <4bb5e98f-83fe-4406-6a50-f3626af8cebb@huawei.com> Date: Wed, 26 Jan 2022 20:12:58 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PATCH RFC 3/3] kfence: Make test case compatible with run time set sample interval Content-Language: en-US To: Marco Elver CC: , , , , , , , , , , References: <20220124025205.329752-1-liupeng256@huawei.com> <20220124025205.329752-4-liupeng256@huawei.com> <261a5287-af0d-424e-d209-db887d952a74@huawei.com> From: "liupeng (DM)" In-Reply-To: X-Originating-IP: [10.174.179.19] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemm600017.china.huawei.com (7.193.23.234) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 561A41C000B X-Rspam-User: nil Authentication-Results: imf21.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf21.hostedemail.com: domain of liupeng256@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=liupeng256@huawei.com X-Stat-Signature: qf3q1ztjkyracan8ogoyhtexzcpsn4yz X-HE-Tag: 1643199183-291126 X-Bogosity: Ham, tests=bogofilter, spamicity=0.009448, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --------------2sE5CklAQW5Skk0e821jJkdX Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit On 2022/1/24 20:21, Marco Elver wrote: > On Mon, 24 Jan 2022 at 13:19, liupeng (DM) wrote: > [...] >> When KFENCE pool size can be adjusted by boot parameters(assumption), >> automatically test and train KFENCE may be useful. So far, exporting >> kfence.sample_interval is not necessary. > I'm not opposed to the patch (I've also run into this issue, but not > too frequently) - feel free to just send it with EXPORT_SYMBOL_GPL. > > Thanks, > -- Marco > . Good, I will send a revised patch latter. Thanks, -- Peng Liu . --------------2sE5CklAQW5Skk0e821jJkdX Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 7bit


On 2022/1/24 20:21, Marco Elver wrote:
On Mon, 24 Jan 2022 at 13:19, liupeng (DM) <liupeng256@huawei.com> wrote:
[...]
When KFENCE pool size can be adjusted by boot parameters(assumption),
automatically test and train KFENCE may be useful. So far, exporting
kfence.sample_interval is not necessary.
I'm not opposed to the patch (I've also run into this issue, but not
too frequently) - feel free to just send it with EXPORT_SYMBOL_GPL.

Thanks,
-- Marco
.
Good, I will send a revised patch latter.

Thanks,
-- Peng Liu
.
--------------2sE5CklAQW5Skk0e821jJkdX--