From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60D09C001B0 for ; Tue, 8 Aug 2023 05:16:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D9C06B0071; Tue, 8 Aug 2023 01:16:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3897D8D0001; Tue, 8 Aug 2023 01:16:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 229C66B0075; Tue, 8 Aug 2023 01:16:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0DC3B6B0071 for ; Tue, 8 Aug 2023 01:16:30 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id CD4ACB1B12 for ; Tue, 8 Aug 2023 05:16:29 +0000 (UTC) X-FDA: 81099776898.11.0113B2D Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by imf07.hostedemail.com (Postfix) with ESMTP id 6BCC94000A for ; Tue, 8 Aug 2023 05:16:27 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=DsVaD5tO; spf=pass (imf07.hostedemail.com: domain of quic_srichara@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_srichara@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691471787; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6ZpYYIt2np6keIa5ulfCQJosBJ95lN4ipIo9wBWLRgI=; b=BoiNtVLR6/d9XYAS9ebSDh0rR89YA8fhSNjxfWnCmAQWb/x09smxT3OZTB9Wa5y3ZtlqYk B2JUDuBRJVSDaosoBCsROiCinsnAbPMlF4ZT6YjZOkYMEEb3eMAlN2medHBVTIGCWzU3oj E3qUM6tMc2qXrtINDxtCyHlF83Xm3Tk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691471787; a=rsa-sha256; cv=none; b=1EDcqPxf6mCw2LRa7LIRfNQkU/p6PxlvEZ+XB3EsQNEX/VsikADtvSCPYzVeeK/S8dlMoj blMwFINz+huMy1yzbd3iK09X0Aj3eW7yvUmgOKt9OLeOq6rs+KdOi6hj0bFDrXx6p7W1k1 Yry5Ed3lbwUJVgbIaubcGV3ZckouqHA= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=DsVaD5tO; spf=pass (imf07.hostedemail.com: domain of quic_srichara@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_srichara@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3784PbrP011994; Tue, 8 Aug 2023 05:16:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=6ZpYYIt2np6keIa5ulfCQJosBJ95lN4ipIo9wBWLRgI=; b=DsVaD5tO+GtpEtTOwuJvr/PKylzklbmx3+4OGRk6leA1r+TvuBG/JqYjpAKtRXveBOZX PMOIKZ3UIg3FljDxs4bGFAtT1X6QFHbh9t0bVUdCNmgBiE7gilzPx6I9Mgs6fEGVLweG lRPaQTRXdnDC64WCz4mDjc+aQ89VtrEVnouLrblndPym1Hx5+NSBjKBimm/+jeaxjEfB LNVIfBLtCBUW788aw7GysvekcE9sOBZZZppoSdFaIKHMsmystp01HdYa1IxonFkQi8/T bzMbLJ+vuaaeiBkkgc0E5p50E2X/5kzrZbyDEvGRn3Y7mtQgm2hQzY7v7TI7vBodj8Dz iw== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3sb6pqgun6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 08 Aug 2023 05:16:21 +0000 Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3785GKfO032077 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 8 Aug 2023 05:16:20 GMT Received: from [10.216.1.26] (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Mon, 7 Aug 2023 22:16:17 -0700 Message-ID: <4b8607e8-4df8-3b15-693f-7d7478caedac@quicinc.com> Date: Tue, 8 Aug 2023 10:46:14 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [linux-next:master 1937/6910] drivers/mtd/nand/raw/qcom_nandc.c:2941 qcom_op_cmd_mapping() error: uninitialized symbol 'ret'. Content-Language: en-US To: Miquel Raynal CC: Manivannan Sadhasivam , Dan Carpenter , , Md Sadre Alam , , , Linux Memory Management List References: <7ad1160b-5f8c-47af-a1c5-51b34f656fab@kadam.mountain> <20230804184550.0cb12369@xps-13> <3604e2ed-8d30-4f7b-9e56-7af5b23b2ac5@kadam.mountain> <20230804190750.3367a044@xps-13> <20230805065510.GA18650@thinkpad> <908ee5e8-6213-5685-7094-8c4b1282015c@quicinc.com> <20230807211458.3de7c627@xps-13> From: Sricharan Ramabadhran In-Reply-To: <20230807211458.3de7c627@xps-13> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: PPjIip63PxDxaD5_ZqIfVrrwtLGyVRQE X-Proofpoint-ORIG-GUID: PPjIip63PxDxaD5_ZqIfVrrwtLGyVRQE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-08-08_03,2023-08-03_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 bulkscore=0 adultscore=0 malwarescore=0 suspectscore=0 spamscore=0 impostorscore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 mlxlogscore=999 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2308080046 X-Rspamd-Queue-Id: 6BCC94000A X-Rspam-User: X-Stat-Signature: jxmxrmu5r45quoh5sbygnwtf6hffpynj X-Rspamd-Server: rspam03 X-HE-Tag: 1691471787-582552 X-HE-Meta: U2FsdGVkX19E0Bq/WL12qnYrQjCSn2aB076xdjly0RmI//nhg7k8Y4SFB/T+RTocVo9p8bj3Iu+C/cc+6SwXhgZfY0QlAD75YyQQ2b/8czEjF9pz7PHFDhkRYiUyAlYLY0tNlQUV+efbsgKIZH3uj2aZOrRbgiESnjJ8QCuR0G48itOXDr5V1GHWWsHVVwwvEoNCKZ59d0nWmSkcNcaAvU4ulvH9o7Jvfsgdt9jX37GB/zg449Fgs+VI2vAqsq0ExkPB9KdfZcvrMZdT5ZdZcoX5jr37Fjle//9OthX0R87I2jlX0JBW3KN+ufE7Z42G1z24KvBwESutv34Ma8nZxdGsuRBHVp69uN2Rp0tthwWIya+QeNg0PmG/+QM+l9HfRlO92o/83uzaNN7ZrIg2SumSDuZxWVmd/09yh/RtQMvZlPXcjf2UyAqaz5dIYEwrxiedXswWqmbiJy/CglgcokGLzwNy6VEjNyStreHbsnaB95AvFZiHRNDZhuvgkVMcApEs32GO4DjfyrtPxM0RANEgb7L/OP6O9gtNz13QsaGBXQwSh/pKhHd7NSPc66+6kTQ3Ed05K4OwtRtQ7mw6S+c+kKpvWXY9fgOi+UcFdV0RNFdTlB9hsmf/u/pJ0hAmM8PYi/2FXsQXaGy4EwxeuQzi2K3xAlzfD+/00xDexHPTCXucAPygjkhl6tt8x6Dsaf++2HmcWEmLZjZOEkcCN+oeMRKM3DziUvuQxW/x+ENykTvUOQnvvpF46fax7KM/kFsptZq5uMIfMnwxxRhvme0ea3ET/vh2xF+hwT+BnmBQeOOX/fVFVFB3M1TXEnWiMYG4JctJ7VFjKOsLlMV1KVKeSkMP4CHQ4RlCp6dABku47DL9YDshNMcWiCl+yrIZjpCNyuHcSEfQdRR6MC1DqEDh/Hj7EjdVp+bMXwyHubGcHyKjpAor48xiY++KqsgPyhdgkRxkVR/kooIGl4t e3HV11bt UU2o0Cs2QVh76AZJlYft94Ac4fbsbR2LpsT+IvYesM3u0LljAybdKcH0iG2pNbaajWNu2lYuUWfVotJtxIELVuJ85k9hu2QrchjMuhAbSshKH1NITc6OhbRfB0UZXckwXj/CDWT9zb1dhmXJ4GWHQ0vVhwo7HGRtdAxbk3hUIwv6tkHXnf5T5f879J26q1v0DoDe9zeZd1rZv1dT576eGN81D7j4JQbtNpzD1lno5Y+aD9KPCg/y+A2i8fC8bXxKJriA3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <..> >> With this series applied on linux-next, started seeing the below >> messages flooded on console while doing mtd r/w. >> "xxx "Opcode not supported: 0" >> >> opcode '0' corresponds to NAND_CMD_READ0. This command inturn was >> invoked from qcom_nandc.c driver from below places. For read/write_page >> driver does not use the exec ops. Hence these calls just ends up >> being -ENOTSUPP and ignored. So removed their invocations. >> If this is fine, can this be added to your series ? (will send >> git-format patch to add to your cleanup series). So far, tested >> mtd raw/block read/writes and all works fine. Will do further tests >> as well. > > Unless I really don't understand the controller, this is non sense. > nand_read_page_op() is precisely what allows your NAND to perform a > read. Removing this call cannot work. > > What you need is a proper ->exec_op() implementation, and repeating > this becomes slightly annoying. > > Look at your qcom_op_cmd_mapping, you don't even have a path for reads. > I bet something along: > CMD_READ0: > ret = XXX_OPCODE_READ; > break; > will make it work. > > Please fix the driver and test with nandbiterrs -i. If this test works, > it is encouraging. Otherwise it is still broken. ok understand. Will fix this up. Regards, Sricharan