From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6204FC7EE23 for ; Tue, 23 May 2023 14:01:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD3A3900005; Tue, 23 May 2023 10:01:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B8414900002; Tue, 23 May 2023 10:01:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A724C900005; Tue, 23 May 2023 10:01:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 99B0F900002 for ; Tue, 23 May 2023 10:01:53 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0AA721A05BD for ; Tue, 23 May 2023 14:01:53 +0000 (UTC) X-FDA: 80821683306.08.D54C87C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf09.hostedemail.com (Postfix) with ESMTP id BD1191400B5 for ; Tue, 23 May 2023 14:00:44 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=L2sPOjdO; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684850445; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7/Nf0TavLbEChUWmWGM/CuAX+Plidrx/xwsde+Gi6m0=; b=zrGrqYrSpWEq1h4rUEn5KNA+BX/rJtSO7HPsvKVS1SVAym1eJ4aHfB5GvEvLOzk43GOwG+ baDnbiQbAo3WltHOmXXYUCR3dev9gqjjd1sTPL5pLVzNne9RMZtMRItmiF5nqEqQHzlTQX jv/QVFiDv3w68KUWT/cd0+g8Kf+bvDA= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=L2sPOjdO; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684850445; a=rsa-sha256; cv=none; b=Btf2QWQEmSrVAUUOdHHsDzIaeiL/cEoYp3o+xTc/WiHyvXvXUfKK/LiJRrJsbiXSevj5kM NYedKi2+c9gLeCDiBygwH0eY2OlxsrD7e8tIPhqzySAOoJIiZ6f/9t8UqqtuEHzYJAVTfD MpP3UwLtaeIx1yT1d2i2RLXEU4iKWDg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684850443; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7/Nf0TavLbEChUWmWGM/CuAX+Plidrx/xwsde+Gi6m0=; b=L2sPOjdO4mF5PrTPMinhy3Sf7NJAdt0XJIIySlq6dpqfceisIeUsoxSyIBkdPqfqin4iH4 ZudOrysgGn4v0kDiYc7l5qbmty7u/byDx76n4wbvlCaoHCCYeLycFeMhMqJW2aKFCvfzQr UgK2XcUhprSnjkOHf9aC6pCFnU3CHas= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-43-tChj9mWQNFmieic_jvOLYA-1; Tue, 23 May 2023 10:00:42 -0400 X-MC-Unique: tChj9mWQNFmieic_jvOLYA-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-30a64dbb2adso1226938f8f.2 for ; Tue, 23 May 2023 07:00:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684850441; x=1687442441; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7/Nf0TavLbEChUWmWGM/CuAX+Plidrx/xwsde+Gi6m0=; b=UOGZYjtPHREbdQ86zRa3uwXjeB7cEakTIIpRahrOJlvdIWd1VaDGZw9A2EYbVIDyYS jG/Jq301fzwrE+rpFz93mtFJvT0C0n7rI8XkpDeBaB6iQhg2GAhPLd2PdT2O5pRspOzn GEbbJ+1mpBM+NrArP3pRU6sIzw+s/jEOsl9JvwGbpRUADW3OQssH5OJy6ClXSdhyryVI Rck4Tn6ue6gqwUTN4AqtiNSKcBJyM3Kz6KK4oQFE+GzJcue8ijkgPwm0jDVlC4tp9Ntf VFyfpeIcMZ2LPTTl8FSLqxbn85y1g7wNvQTjCAQ4Z+fcmEUW3pWk+u6F/zFDFULwvBUU vScQ== X-Gm-Message-State: AC+VfDyirpy9y5pWDD6rV8wX0W+LXXcZE8B4cwo3ufPS+cP8EjP2SEIH sXw2RdWTIlfw7YUXhXu3b/Peq0eskjCRGE0V8dWrUSQKnb0hhM5sWXInYVBVYW/dCtQxP+9dGLi GOxi3E8zAwJY= X-Received: by 2002:a5d:4d4b:0:b0:309:4289:91c9 with SMTP id a11-20020a5d4d4b000000b00309428991c9mr11771034wru.17.1684850441406; Tue, 23 May 2023 07:00:41 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5tAvOtRXffvj1RZ0LbID8208d/vIh6WNXAn638Wa4VSjKA9mSnvfnq5oThGvWGfLVVCZMYhQ== X-Received: by 2002:a5d:4d4b:0:b0:309:4289:91c9 with SMTP id a11-20020a5d4d4b000000b00309428991c9mr11770997wru.17.1684850441041; Tue, 23 May 2023 07:00:41 -0700 (PDT) Received: from ?IPV6:2003:cb:c74c:b400:5c8b:a0b2:f57e:e1cd? (p200300cbc74cb4005c8ba0b2f57ee1cd.dip0.t-ipconnect.de. [2003:cb:c74c:b400:5c8b:a0b2:f57e:e1cd]) by smtp.gmail.com with ESMTPSA id z4-20020a056000110400b00307972e46fasm8983024wrw.107.2023.05.23.07.00.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 May 2023 07:00:40 -0700 (PDT) Message-ID: <4b7e4d48-f0f9-c0b0-e8e1-2678d0306252@redhat.com> Date: Tue, 23 May 2023 16:00:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v8 1/6] ksm: support unsharing KSM-placed zero pages To: xu xin Cc: akpm@linux-foundation.org, imbrenda@linux.ibm.com, jiang.xuexin@zte.com.cn, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ran.xiaokai@zte.com.cn, xu.xin16@zte.com.cn, yang.yang29@zte.com.cn References: <1925d301-462d-6b33-8867-4e1646b2dbd6@redhat.com> <20230523135709.6902-1-xu.xin16@zte.com.cn> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230523135709.6902-1-xu.xin16@zte.com.cn> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: BD1191400B5 X-Stat-Signature: i7n6iqibabc3d1bbaufpzjp611d4by61 X-Rspam-User: X-HE-Tag: 1684850444-378631 X-HE-Meta: U2FsdGVkX1975c3ixpAj86iSEbNpChHi3o7hqhEeArk+KYBA97Oq2Ea94537HlsrDTXMSfxIMaB0xMkXRDARvlm3KHISIRz6+zPWcBmdLNhwWrfMkyximkfiGXiZ3277aVuFLUyBZy2E2GGwDrTJy1rAQ1xbYZgQuIL0Ue0DVob2/8vmpXZ1+KXrpkq8EWOCsCUw8p1gvCSTE4kMrR/nDraCi+Pns2qWUgHA1PDbQ+DsNfXsaNBu8FOp6QSsKLKdYv6bHKA3QcDOmL3lbKaQ+M+qdxI5AL6ftW6CbFGrhs15grs5s/LJyCriQNiXJDjSDdF8QkwVSRpDXs1843A+drPKiqJu0Q71dEr6hTYv34J5pLST+QHbCPk+c+/EtVZrdgl2okxs479DY6Qp0UacnxzOF+td9KMfabSibfnf4Bus+D8nTr8mgtviZLbouxzLcj29k/oErP7UduQiMVNccSvi5FOgnPhu+wK1t0FanSWYjWft6Zrnqwle0gpnrYwK1WW3UZd+ROxq5fL+9oOh8xy0QpAk9AGAvAYwRC0zO/b+qZ7hx6Fmy/SS36SM24X+Ej7po97u+dLpCJ183kEDoVzNVgwjFQlCIQmH8xWMV95YyIosyV9Khjf5BGJ2+m19Cut1wmlTApIbedSYgqlvlNS8koHuuxpHwlakN9VVmmE7AQ7YkmbqgXNheBDvxs+2RWSIPKV+vTWtGq2e0pF2O6k2Z55QA8oIoS3ndvilH1Mdll747nY0TY7Mdro5yima5yrQ4DcocIeCFZD9oOX3SNLW0fhJ5zMhAianFtk5fFGfZTMjSupIt5fbyoKcaMJ6b9tvdBitHRwJHi5Dvf6wUIzhZq8sXVEz0l7La8lyKcBHyBrFD45cNTUcmYRXgkEOgiBSM+ErP7CD4mOn6ae/n6qFC8D+ySsVK0SqfVNTzqbIaGrYtRnS9aWJhFf5gVVWZM78NZVN4/40eE4Dwzc Qw3Fh+X1 kY/2pZSBCCSlFjPdU6AnrzthZtrEUp5iB1IfBn1Ko6R6DowwCv9c5eIOSeE2xBWsuQlXg+325C5cd3/346s7Y4nwEaj5YiQrt8/RQ5BZePiOSs6VYueP7H+n8nFlz1qPgyGpuwEzDV8PQQdOk0yZF2lrYEJ6e3j1rX4zchV9xVZFR5KPub4HjkvbMAPB1Rlywcy9RUCPQQ8I2z09qJ47zBN3EdVspXZUFOR5ksTEz/mmsE9ORNyd5ffKvkB0mU9vzpW4rF3WfmCQVracTfW953xe1qFS19mdZ5uh6nI74zUxl+AOyYHB878HMqGSnyy21alptMJU75rlooDejduA5SbD13xzYEgX8hSfBxdy83AbVRq4oGdX4mhy+BZl5OwSJ5NI03UtYjWl+jE3ExH4LTd8eu1P2Ywfu/xDZaewInyXxvzFdPMZWx037U7sszrKhjfmyyL0puB1J8P4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 23.05.23 15:57, xu xin wrote: >>> --- >>> include/linux/ksm.h | 6 ++++++ >>> mm/ksm.c | 5 +++-- >>> 2 files changed, 9 insertions(+), 2 deletions(-) >>> >>> diff --git a/include/linux/ksm.h b/include/linux/ksm.h >>> index 899a314bc487..7989200cdbb7 100644 >>> --- a/include/linux/ksm.h >>> +++ b/include/linux/ksm.h >>> @@ -26,6 +26,9 @@ int ksm_disable(struct mm_struct *mm); >>> >>> int __ksm_enter(struct mm_struct *mm); >>> void __ksm_exit(struct mm_struct *mm); >>> +/* use pte_mkdirty to track a KSM-placed zero page */ >>> +#define set_pte_ksm_zero(pte) pte_mkdirty(pte_mkspecial(pte)) >> >> If there is only a single user (which I assume), please inline it instead. > > Excuse me, I'm wondering why using inline here instead of macro is better. > Thanks! :) Just to clarify: not an inline function but removing the macro completely and just place that code directly into the single caller. Single user, no need to put that into ksm.h -- and I'm not super happy about the set_pte_ksm_zero() name ;) because we get the zero-pte already passed in from the caller ... -- Thanks, David / dhildenb