From: David Hildenbrand <david@redhat.com>
To: Yang Shi <shy828301@gmail.com>, Lance Yang <ioworker0@gmail.com>
Cc: akpm@linux-foundation.org, mhocko@suse.com, zokeefe@google.com,
songmuchun@bytedance.com, peterx@redhat.com, minchan@kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] mm/khugepaged: keep mm in mm_slot without MMF_DISABLE_THP check
Date: Tue, 27 Feb 2024 20:18:45 +0100 [thread overview]
Message-ID: <4b6b6f11-f9fe-401f-a1c9-0c6074bb5f84@redhat.com> (raw)
In-Reply-To: <CAHbLzkoQ1wFjA5aR51K-XMW+shSVFgujJjKK+-OG4OfVFvgOyQ@mail.gmail.com>
On 27.02.24 20:13, Yang Shi wrote:
> On Mon, Feb 26, 2024 at 7:51 PM Lance Yang <ioworker0@gmail.com> wrote:
>>
>> Previously, we removed the mm from mm_slot and dropped mm_count
>> if the MMF_THP_DISABLE flag was set. However, we didn't re-add
>> the mm back after clearing the MMF_THP_DISABLE flag. Additionally,
>> We add a check for the MMF_THP_DISABLE flag in hugepage_vma_revalidate().
>>
>> Fixes: 879c6000e191 ("mm/khugepaged: bypassing unnecessary scans with MMF_DISABLE_THP check")
>
> I think Andrew will fold this fix into your original patch.
Unlikely, it's already in mm-stable.
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
prev parent reply other threads:[~2024-02-27 19:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 3:51 Lance Yang
2024-02-27 19:13 ` Yang Shi
2024-02-27 19:18 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b6b6f11-f9fe-401f-a1c9-0c6074bb5f84@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=ioworker0@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=peterx@redhat.com \
--cc=shy828301@gmail.com \
--cc=songmuchun@bytedance.com \
--cc=zokeefe@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox