From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AD02C07545 for ; Tue, 24 Oct 2023 08:20:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C6C0A6B0195; Tue, 24 Oct 2023 04:20:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF3DE6B0196; Tue, 24 Oct 2023 04:20:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A94FB6B0197; Tue, 24 Oct 2023 04:20:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9A2B36B0195 for ; Tue, 24 Oct 2023 04:20:14 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 725F7160CBE for ; Tue, 24 Oct 2023 08:20:14 +0000 (UTC) X-FDA: 81379657548.02.4693683 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf10.hostedemail.com (Postfix) with ESMTP id 4AF21C0004 for ; Tue, 24 Oct 2023 08:20:12 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=iU912upV; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=321utMuP; dmarc=none; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698135612; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AvVbgMaT6cDNfVFtjRVpQ+LIKd3Iozxm21HmFOweANk=; b=gcP3KcmMVMFsX5qJuguf+z7c9MhxOKOAQJddDjHqz3RbZQF3b9ScSff+9RWmGgIvqq1Wcv vnjBhE/ucI9zEtQyI8YipNAv0CDB39peJqwY2UVvj5z0xaAdpOlhHfIJkgcUdL7EIke+vc pSDw8dT5QviPP6RUqWkfd0baWnJYNPw= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=iU912upV; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=321utMuP; dmarc=none; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698135612; a=rsa-sha256; cv=none; b=mFetGe41FbljpaTS2AZPOwVZ/KrzJsnf12KfeVQSx9SRmP43W6N8cFHVu9YllCDRSI6SOE HEl3Tpf8tDprYMzGYPg2YfzftzKVjxZp5P65FTol8N7n5rmnq2sUHMgXgM4WK7FsJbP8Lo Yq4M7fQiKO9/iLTs22mN+fa5grOgHr4= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D802B1FE61; Tue, 24 Oct 2023 08:20:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1698135610; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AvVbgMaT6cDNfVFtjRVpQ+LIKd3Iozxm21HmFOweANk=; b=iU912upV5klSqCuzCr3tutf69PU2ssvPEfGowY/jLenKYbDq6acrvFRoRviGK/AcIUyjfB 5LW0FbG9xyQ7q72H9CucIFrwPbVngIHDO890DEkg6y0HjMqoQbBS9WZfIR4V1FahMpNlg/ 42S+Rqi/mqB6a22gXcn4xFqcZH7QZb8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1698135610; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AvVbgMaT6cDNfVFtjRVpQ+LIKd3Iozxm21HmFOweANk=; b=321utMuP9cfe+M0NDWYUkHluxsSmLJZ8SrDN4KlhmBx3Lu3HbvIuWoxZMHgtoiBXugo0lp MRTJfbZpptb/7NAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8F84D134F5; Tue, 24 Oct 2023 08:20:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6v9qIjp+N2U8XwAAMHmgww (envelope-from ); Tue, 24 Oct 2023 08:20:10 +0000 Message-ID: <4b687334-9667-2655-ab5b-a1aecedb5591@suse.cz> Date: Tue, 24 Oct 2023 10:20:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [RFC PATCH v2 0/6] slub: Delay freezing of CPU partial slabs Content-Language: en-US To: Chengming Zhou , cl@linux.com, penberg@kernel.org Cc: rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, willy@infradead.org, pcc@google.com, tytso@mit.edu, maz@kernel.org, ruansy.fnst@fujitsu.com, vishal.moola@gmail.com, lrh2000@pku.edu.cn, hughd@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Chengming Zhou References: <20231021144317.3400916-1-chengming.zhou@linux.dev> <4134b039-fa99-70cd-3486-3d0c7632e4a3@suse.cz> <72361910-240f-4aa2-a695-117e1b14a804@linux.dev> From: Vlastimil Babka In-Reply-To: <72361910-240f-4aa2-a695-117e1b14a804@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4AF21C0004 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: w5x6gmne3k1up8g1stte4bqgws779znj X-HE-Tag: 1698135612-841087 X-HE-Meta: U2FsdGVkX19NKrhd5lIrJjGGq6N/Q5IGL+6gt4HRowBu08oU4PXmyW0spL64UjKIDUH1xwBv4bmfgdE86zQDTirS0eTCR5Fk8PKF2sR0jLU3G7BgdH0Eihvkb0G60E9Kak9qaY6woZxxNbaTZo6TA6tpL1jQhfPz+eCL6opwuM3fx7BMvKeZU/I+Rtp+PaDSO1ObMNDdPkDt0KkCpJba/gqDKiB/rp1VubLUkSms5CrUWlXcU8bRDJ1QEeu0oNuO/KPqIpAGhW8kMpb+xhXmswjSYM/7l0cAr/AYtliPgMLcvb+D2aOCK2kYEJ/AJ1QhmJjlq1QzPff8nUWaPBcQnNiqfx+iPQ0o9plrOgCvSOws4XDhRp/qISMMsRBDqATjnlSxwlGj7rrxCDYIaXsH8ZGUTNd2gJRmxAjq8+thZIsV3cHFx/MoZzViBpI9RLfafxf2fIb3c5PmqmrMr6pbpeOB2gvkMoLqdLGR/purURY3zOo/eQYHgCxpJeU1CJrxWdX3EejCxkNrY3p0cIvbhLz2elvconmM+h+vmDwN6Ap9t0ct20uhaQOT6z3F5QZ8XtlejWJcWq3p9lpc4yYXYyxCnKbornmIC2g8udUYra+uxQbUeWBZPKFrAjObIKA3xfu1IrIR8Dbjt8YQk3A8wXeaEuX90Tbt0dcgxAaTe8v9xVmwhqSryOD/aPtA7y34VHjP2jEJXqBS7s0XigqhtFMVXJuKkdLJeU6JDeSxmyodNvc0qwg2aZllKdmy6yONHsuXa7zlqyWtYbrH+dQG5Hst7NkbVBtZfnI/dQ1R3/HqLhEYs9ZBYkTsvqmdJU/2H+C3U93f4SP+Wiedf8IrymAWyocvPGEoTIus1w6va6qAnmLCA/u/5ul6j+9VO5B3OhcsQvZ/0pz50/rvfXKD7IwuZpVFCyvFqEbpkcnbLKbb4Kf1fsDMH1xM9ERcrDONreygBDbA+ryA28TwVjR 14gfZt5T HtjdPZVP4DDK31LVsNX3ZawjE85m/LKvRtpO6FFnzHLDuKEchCIfictZVxXEKUage9liPl6M0+e6xcJav3ZY5pDKM8b1Q1STwYqeaBSxL7oAFHQVLVrcexG+U8NVt8hRGXiowl1vkLwfpPQkX30AQmP/Zt0wx5V3aC3JYrGbSAfPq303VJ++KSpZujd63EYb6jVlggqtzqcuYxXkUiUn3A8Wiud5TiGPH1mvMY/UTce/AzaHd19V14h1PbTWRhAnZ3ws3tFe3baLux21VSoaPD7chk017D7gkfNTP4rWSWaEyRa0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/24/23 04:20, Chengming Zhou wrote: > On 2023/10/23 23:46, Vlastimil Babka wrote: >> Or more precisely, instead of returning the acquired "object" we would >> return the first slab removed from partial list. I think it would simplify >> the code a bit, and further reduce list_lock holding times. > > Ok, I will do this in the next version. But I find we have to return the object > in the "IS_ENABLED(CONFIG_SLUB_TINY) || kmem_cache_debug(s)" case, in which > we need to allocate a single object under the node list_lock. Ah, right. > Maybe we can use "struct partial_context" to return the object in this case? > > struct partial_context { > - struct slab **slab; > gfp_t flags; > unsigned int orig_size; > + void *object; > }; > > Then we can change all get_partial interfaces to return a slab. Do you agree > with this way? Yeah, good idea! Thanks!