From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52F38C7618E for ; Mon, 24 Apr 2023 03:41:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8BF166B0071; Sun, 23 Apr 2023 23:41:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 848946B0074; Sun, 23 Apr 2023 23:41:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C0EF6B0075; Sun, 23 Apr 2023 23:41:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 557F16B0071 for ; Sun, 23 Apr 2023 23:41:50 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 17D63C0343 for ; Mon, 24 Apr 2023 03:41:50 +0000 (UTC) X-FDA: 80714885580.10.0183CF0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 7E33014000E for ; Mon, 24 Apr 2023 03:41:46 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=faXCtIrA; spf=pass (imf23.hostedemail.com: domain of mpenttil@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=mpenttil@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682307707; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=x0/Gqmlp5F3e84VZzqWw27RJ/qxOUG7Vcqc9AjwjGKg=; b=fkikyzGfqELSiZuwD2wK7mYsofNn5AJqVJqlMlOBtAp2wGyo6PD4jOoKUCnu2P58RTaQiT OhWgiSC4aufgF/uZcXSf5MP0ZwyfX5GMj2qXYAzLei+UjzLoK6KehrxgtUbHD4Oi0EbDgF wsSRWktnd0FdRmBYQdHBu/RB7PLvEF4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682307707; a=rsa-sha256; cv=none; b=U5sQZ0PZS3msfZ9NEM7PmtvFURPWVfwlw1D/7BlO9Wf4m5xnXZOshTP5IUJOIcdpvCQe0R XvPQ4Q07cRoWFxeyPpW6Jtt21mqs9VEhKl8GM91Fdis7yeUs/qRZxq+j0t2xjbKgdFmjAm LA8Cc+S/5131pCR1LoGz9qacNaBjPMA= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=faXCtIrA; spf=pass (imf23.hostedemail.com: domain of mpenttil@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=mpenttil@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682307705; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x0/Gqmlp5F3e84VZzqWw27RJ/qxOUG7Vcqc9AjwjGKg=; b=faXCtIrAQLGBSeJkfELtc3dqMQO1HTLU5fsdenJDOjFAPUDcTIj47nTYenIfRpKA+ZRwsk XfkM9mxpx3ZJs1JkWlGaGAU1xCqr5y8QmVkk+DUjVqqNW3eDrN3m4HzwaxTnMkI26MbzWl KAyzfoUPy8DVDvSjjW4COtbzLqdVPY4= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-134-Wr4Oy52VPtyNbLBCSmi1qA-1; Sun, 23 Apr 2023 23:41:44 -0400 X-MC-Unique: Wr4Oy52VPtyNbLBCSmi1qA-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-4ecb06abc1aso1715356e87.3 for ; Sun, 23 Apr 2023 20:41:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682307701; x=1684899701; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=x0/Gqmlp5F3e84VZzqWw27RJ/qxOUG7Vcqc9AjwjGKg=; b=ePSGNN++N4zruN6w40XlcnzPCB883RJZtEw80Ooxf6kYDcMc/k289B0pm2S1bX1eXP HqpBRVaLDAEWOkWqwseb6s72rp82Pjz4M8+8673UvFauHeI5FkaQxhblZDcyIUR2dUHa ZlQOBEUM5yG/PkUMD2Jhga69bo5h80JZuv9p/4lXTCB8Cb9vUYyQr+MHoAuXNe1a7cN3 5ugNVLZI6DPS0g8oueoucIt3ZUSFSv80Wq6Cvym+sP9gVJkJnxWHn+qoGLL2O6wbLt97 qhTggxlHrwFD63DHq24gaSmUFFbzrtfSxMRXoPHXwJoog87pmhp+Tk7evC3HO93aeNuG xaxA== X-Gm-Message-State: AAQBX9cD2C7GL+l10Ro74qggo6d/K8vEfFWGDztqfF6HElG7xsW3A2H5 YZA12JwH0bWNcW1DkPhVx2o9cgRUZeKRSOvlpB1gWn7uYkkxIW/S1pIwK13RcupBNs0NYazeiFC LOjUAapTU6A== X-Received: by 2002:a19:c503:0:b0:4db:513b:6ef4 with SMTP id w3-20020a19c503000000b004db513b6ef4mr2801704lfe.11.1682307701267; Sun, 23 Apr 2023 20:41:41 -0700 (PDT) X-Google-Smtp-Source: AKy350akLmVLz77aNwLtIlKSi4nJUWSFQY6BgoD/WOht8xio4frsi16eCfgOgUB/LaSrLLzhy5Ej9A== X-Received: by 2002:a19:c503:0:b0:4db:513b:6ef4 with SMTP id w3-20020a19c503000000b004db513b6ef4mr2801666lfe.11.1682307700896; Sun, 23 Apr 2023 20:41:40 -0700 (PDT) Received: from [192.168.1.121] (85-23-48-202.bb.dnainternet.fi. [85.23.48.202]) by smtp.gmail.com with ESMTPSA id a5-20020a056512374500b004db3d57c3a8sm1510791lfs.96.2023.04.23.20.41.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 23 Apr 2023 20:41:40 -0700 (PDT) Message-ID: <4b599782-3512-a177-c5b5-c562a22886c7@redhat.com> Date: Mon, 24 Apr 2023 06:41:38 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] mm/gup: disallow GUP writing to file-backed mappings by default To: Lorenzo Stoakes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton Cc: Jason Gunthorpe , Jens Axboe , Matthew Wilcox , Dennis Dalessandro , Leon Romanovsky , Christian Benvenuti , Nelson Escobar , Bernard Metzler , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Bjorn Topel , Magnus Karlsson , Maciej Fijalkowski , Jonathan Lemon , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Christian Brauner , Richard Cochran , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , linux-fsdevel@vger.kernel.org, linux-perf-users@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org References: From: =?UTF-8?Q?Mika_Penttil=c3=a4?= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 7E33014000E X-Rspamd-Server: rspam09 X-Stat-Signature: ccp4pcgqbwxytti9jkzsjo87tfo5m8do X-HE-Tag: 1682307706-844534 X-HE-Meta: U2FsdGVkX18hEU5APMpDxkIWmGVc5mxY7E2pybMhrEIQheFmqXc5ovIFaI04x0TipmgHaWBbW27mCUVBhZuWSK+gVdioRmP4A5gB2f7U6rk8vb1U2sbDf92+6EBJjwdQEHNxlpenewyJuMucURQqHOmL6PdiZ9xnFIqCBQecckQlQgcMpEZIJh1+/yVihvxZHnuvoq8CLUR4vaVa5lokfhh5aNstHvhReeg5ZVJhDO3f9o2QHQnZwzyg7bFYB5sacPsoqDm/tRklJqNUmhPvix3DkzMapa1bDrIfUCBUSL7h5bZGsv8ZxklMijhkli/xkFUFn7LG0ExpSJV+fgmdRQbETZh09NBfVxkyCDXUpL4cQBcJv18WcynSEeSK5wzRk5QO/xc5GsPSjJ/nAmFgatkXUF/Dx4qbIlwRnh7/7arER0PKULe2Tp1T4JjWZ8enuFzm+coAsH3e3m3k08DzEhQrOT7koeo3+5kZ3KwANuZS98kMocSxB9EttaGKm5IJntaQSjmUVvl1pCtZAvrSTzWhHquUWGA8Il/zlaFELNh+uD+AsEebxWOpYvGEv9T+5MFjxwE0iPCSIFI4C4QFNPWyoZ2WAPlRoZu/DkmZAQVLO+E9L5TDsD/e9Us17eQaD8M105NLtGNtWVIqNtfnrsBC1Hz+QDL/KXZCZQJfIm9qORMf9YnQFqLuXXseiBS5p3mjZ3a6y5qLw0hN0kSo+LuMnCn1aMO3mYyFDJX5inPTNx7gzXjBc55wYB+9AYi1nqSDx5gvsGsxOZDWWT1GAubVFa+iDSvJyPIWw5+WXhl9juX6uNdI2r0PQK7NxXwA9ol/g/mc1Sziun33D52oqi2MBvl5klO9wVjoSN2LA3vzTEQx77bCS0Rxpi2pBassFB2jmQjqF7e5NqT2DJ52R2jqYs7oLyP9WJNxWXvZosHTehO1R1eqG3uE9VjrZZZcFbGdyagQtRsEVeor2IW wlVODDvV JlvTdPpZsl588Dl2y5UKAMzYurUBe1vR7eh5CUMlmJwYzxInoK+D5AtbzS9wPDcyu/J0YPJWVvVVYLoSD6Hgetd6SDmMJ+DRaBU9WKhYUcK/x9yrKpzduU5O5vIsGXdBVB3au5X9Ae/CPkCmY6BtNuFnGVJWIlmsOueqz6zbdOe9m8h1re8Jo3+esY1om1HKkqLwafO7Fyo53jejlWuBJvmtiMUYyllttE5F9KEuTxkAkX4tV+L7KlFX9BGllBExwneJF0/IV8GFvSRJpTPuedPErGuyP9vWBdp/H9m9n17gk9+HPl04GaTvPmc7sQdz2TqfDS/6NPo1n0zXrGvgZ5ggzHj2SjUANo+ogP3orG6MIc6fC0Hj2q/CHfSNLOu6sCVqhx+gaNrFDFAWfi4o9wgclwdXTQftPfwaMHVRgB+RNTKsEJkudrsYThAq9ubMymU4362LX0jbupz+mZtybCP03MIxsGh5FsO9m5wzzmdDT+J+HzoA5akObUvFRPaV6Hs15qDmW8tQeUK6WqkQ8mvVvxNZ7uecqhIQ6Cto5kgWBOyA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, On 22.4.2023 16.37, Lorenzo Stoakes wrote: > It isn't safe to write to file-backed mappings as GUP does not ensure that > the semantics associated with such a write are performed correctly, for > instance filesystems which rely upon write-notify will not be correctly > notified. > > There are exceptions to this - shmem and hugetlb mappings are (in effect) > anonymous mappings by other names so we do permit this operation in these > cases. > > In addition, if no pinning takes place (neither FOLL_GET nor FOLL_PIN is > specified and neither flags gets implicitly set) then no writing can occur > so we do not perform the check in this instance. > > This is an important exception, as populate_vma_page_range() invokes > __get_user_pages() in this way (and thus so does __mm_populate(), used by > MAP_POPULATE mmap() and mlock() invocations). > > There are GUP users within the kernel that do nevertheless rely upon this > behaviour, so we introduce the FOLL_ALLOW_BROKEN_FILE_MAPPING flag to > explicitly permit this kind of GUP access. > > This is required in order to not break userspace in instances where the > uAPI might permit file-mapped addresses - a number of RDMA users require > this for instance, as do the process_vm_[read/write]v() system calls, > /proc/$pid/mem, ptrace and SDT uprobes. Each of these callers have been > updated to use this flag. > > Making this change is an important step towards a more reliable GUP, and > explicitly indicates which callers might encouter issues moving forward. > > Suggested-by: Jason Gunthorpe > Signed-off-by: Lorenzo Stoakes > --- > drivers/infiniband/hw/qib/qib_user_pages.c | 3 +- > drivers/infiniband/hw/usnic/usnic_uiom.c | 2 +- > drivers/infiniband/sw/siw/siw_mem.c | 3 +- > fs/proc/base.c | 3 +- > include/linux/mm_types.h | 8 +++++ > kernel/events/uprobes.c | 3 +- > mm/gup.c | 36 +++++++++++++++++++++- > mm/memory.c | 3 +- > mm/process_vm_access.c | 2 +- > net/xdp/xdp_umem.c | 2 +- > 10 files changed, 56 insertions(+), 9 deletions(-) > > diff --git a/drivers/infiniband/hw/qib/qib_user_pages.c b/drivers/infiniband/hw/qib/qib_user_pages.c > index f693bc753b6b..b9019dad8008 100644 > --- a/drivers/infiniband/hw/qib/qib_user_pages.c > +++ b/drivers/infiniband/hw/qib/qib_user_pages.c > @@ -110,7 +110,8 @@ int qib_get_user_pages(unsigned long start_page, size_t num_pages, > for (got = 0; got < num_pages; got += ret) { > ret = pin_user_pages(start_page + got * PAGE_SIZE, > num_pages - got, > - FOLL_LONGTERM | FOLL_WRITE, > + FOLL_LONGTERM | FOLL_WRITE | > + FOLL_ALLOW_BROKEN_FILE_MAPPING, > p + got, NULL); > if (ret < 0) { > mmap_read_unlock(current->mm); > diff --git a/drivers/infiniband/hw/usnic/usnic_uiom.c b/drivers/infiniband/hw/usnic/usnic_uiom.c > index 2a5cac2658ec..33cf79b248a9 100644 > --- a/drivers/infiniband/hw/usnic/usnic_uiom.c > +++ b/drivers/infiniband/hw/usnic/usnic_uiom.c > @@ -85,7 +85,7 @@ static int usnic_uiom_get_pages(unsigned long addr, size_t size, int writable, > int dmasync, struct usnic_uiom_reg *uiomr) > { > struct list_head *chunk_list = &uiomr->chunk_list; > - unsigned int gup_flags = FOLL_LONGTERM; > + unsigned int gup_flags = FOLL_LONGTERM | FOLL_ALLOW_BROKEN_FILE_MAPPING; > struct page **page_list; > struct scatterlist *sg; > struct usnic_uiom_chunk *chunk; > diff --git a/drivers/infiniband/sw/siw/siw_mem.c b/drivers/infiniband/sw/siw/siw_mem.c > index f51ab2ccf151..bc3e8c0898e5 100644 > --- a/drivers/infiniband/sw/siw/siw_mem.c > +++ b/drivers/infiniband/sw/siw/siw_mem.c > @@ -368,7 +368,8 @@ struct siw_umem *siw_umem_get(u64 start, u64 len, bool writable) > struct mm_struct *mm_s; > u64 first_page_va; > unsigned long mlock_limit; > - unsigned int foll_flags = FOLL_LONGTERM; > + unsigned int foll_flags = > + FOLL_LONGTERM | FOLL_ALLOW_BROKEN_FILE_MAPPING; > int num_pages, num_chunks, i, rv = 0; > > if (!can_do_mlock()) > diff --git a/fs/proc/base.c b/fs/proc/base.c > index 96a6a08c8235..3e3f5ea9849f 100644 > --- a/fs/proc/base.c > +++ b/fs/proc/base.c > @@ -855,7 +855,8 @@ static ssize_t mem_rw(struct file *file, char __user *buf, > if (!mmget_not_zero(mm)) > goto free; > > - flags = FOLL_FORCE | (write ? FOLL_WRITE : 0); > + flags = FOLL_FORCE | FOLL_ALLOW_BROKEN_FILE_MAPPING | > + (write ? FOLL_WRITE : 0); > > while (count > 0) { > size_t this_len = min_t(size_t, count, PAGE_SIZE); > diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h > index 3fc9e680f174..e76637b4c78f 100644 > --- a/include/linux/mm_types.h > +++ b/include/linux/mm_types.h > @@ -1185,6 +1185,14 @@ enum { > FOLL_PCI_P2PDMA = 1 << 10, > /* allow interrupts from generic signals */ > FOLL_INTERRUPTIBLE = 1 << 11, > + /* > + * By default we disallow write access to known broken file-backed > + * memory mappings (i.e. anything other than hugetlb/shmem > + * mappings). Some code may rely upon being able to access this > + * regardless for legacy reasons, thus we provide a flag to indicate > + * this. > + */ > + FOLL_ALLOW_BROKEN_FILE_MAPPING = 1 << 12, > > /* See also internal only FOLL flags in mm/internal.h */ > }; > diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c > index 59887c69d54c..ec330d3b0218 100644 > --- a/kernel/events/uprobes.c > +++ b/kernel/events/uprobes.c > @@ -373,7 +373,8 @@ __update_ref_ctr(struct mm_struct *mm, unsigned long vaddr, short d) > return -EINVAL; > > ret = get_user_pages_remote(mm, vaddr, 1, > - FOLL_WRITE, &page, &vma, NULL); > + FOLL_WRITE | FOLL_ALLOW_BROKEN_FILE_MAPPING, > + &page, &vma, NULL); > if (unlikely(ret <= 0)) { > /* > * We are asking for 1 page. If get_user_pages_remote() fails, > diff --git a/mm/gup.c b/mm/gup.c > index 1f72a717232b..68d5570c0bae 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -959,16 +959,46 @@ static int faultin_page(struct vm_area_struct *vma, > return 0; > } > > +/* > + * Writing to file-backed mappings using GUP is a fundamentally broken operation > + * as kernel write access to GUP mappings may not adhere to the semantics > + * expected by a file system. > + * > + * In most instances we disallow this broken behaviour, however there are some > + * exceptions to this enforced here. > + */ > +static inline bool can_write_file_mapping(struct vm_area_struct *vma, > + unsigned long gup_flags) > +{ > + struct file *file = vma->vm_file; > + > + /* If we aren't pinning then no problematic write can occur. */ > + if (!(gup_flags & (FOLL_GET | FOLL_PIN))) > + return true; > + > + /* Special mappings should pose no problem. */ > + if (!file) > + return true; > + > + /* Has the caller explicitly indicated this case is acceptable? */ > + if (gup_flags & FOLL_ALLOW_BROKEN_FILE_MAPPING) > + return true; > + > + /* shmem and hugetlb mappings do not have problematic semantics. */ > + return vma_is_shmem(vma) || is_file_hugepages(file); > +} > + > static int check_vma_flags(struct vm_area_struct *vma, unsigned long gup_flags) > { > vm_flags_t vm_flags = vma->vm_flags; > int write = (gup_flags & FOLL_WRITE); > int foreign = (gup_flags & FOLL_REMOTE); > + bool vma_anon = vma_is_anonymous(vma); > > if (vm_flags & (VM_IO | VM_PFNMAP)) > return -EFAULT; > > - if (gup_flags & FOLL_ANON && !vma_is_anonymous(vma)) > + if ((gup_flags & FOLL_ANON) && !vma_anon) > return -EFAULT; > > if ((gup_flags & FOLL_LONGTERM) && vma_is_fsdax(vma)) > @@ -978,6 +1008,10 @@ static int check_vma_flags(struct vm_area_struct *vma, unsigned long gup_flags) > return -EFAULT; > > if (write) { > + if (!vma_anon && > + WARN_ON_ONCE(!can_write_file_mapping(vma, gup_flags))) > + return -EFAULT; > + > if (!(vm_flags & VM_WRITE)) { > if (!(gup_flags & FOLL_FORCE)) > return -EFAULT; > diff --git a/mm/memory.c b/mm/memory.c > index 146bb94764f8..e3d535991548 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -5683,7 +5683,8 @@ int access_process_vm(struct task_struct *tsk, unsigned long addr, > if (!mm) > return 0; > > - ret = __access_remote_vm(mm, addr, buf, len, gup_flags); > + ret = __access_remote_vm(mm, addr, buf, len, > + gup_flags | FOLL_ALLOW_BROKEN_FILE_MAPPING); > > mmput(mm); > > diff --git a/mm/process_vm_access.c b/mm/process_vm_access.c > index 78dfaf9e8990..ef126c08e89c 100644 > --- a/mm/process_vm_access.c > +++ b/mm/process_vm_access.c > @@ -81,7 +81,7 @@ static int process_vm_rw_single_vec(unsigned long addr, > ssize_t rc = 0; > unsigned long max_pages_per_loop = PVM_MAX_KMALLOC_PAGES > / sizeof(struct pages *); > - unsigned int flags = 0; > + unsigned int flags = FOLL_ALLOW_BROKEN_FILE_MAPPING; > > /* Work out address and page range required */ > if (len == 0) > diff --git a/net/xdp/xdp_umem.c b/net/xdp/xdp_umem.c > index 02207e852d79..b93cfcaccb0d 100644 > --- a/net/xdp/xdp_umem.c > +++ b/net/xdp/xdp_umem.c > @@ -93,7 +93,7 @@ void xdp_put_umem(struct xdp_umem *umem, bool defer_cleanup) > > static int xdp_umem_pin_pages(struct xdp_umem *umem, unsigned long address) > { > - unsigned int gup_flags = FOLL_WRITE; > + unsigned int gup_flags = FOLL_WRITE | FOLL_ALLOW_BROKEN_FILE_MAPPING; > long npgs; > int err; > Not sure about this in general, but seemss at least ptrace (ptrace_access_vm()) seems to be broken here.. --Mika