From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCE7CC77B7C for ; Wed, 2 Jul 2025 17:39:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 820336B00AC; Wed, 2 Jul 2025 13:39:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F7256B00AE; Wed, 2 Jul 2025 13:39:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E62F6B00C7; Wed, 2 Jul 2025 13:39:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5B1A56B00AC for ; Wed, 2 Jul 2025 13:39:33 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 263951A03A2 for ; Wed, 2 Jul 2025 17:39:33 +0000 (UTC) X-FDA: 83620036626.20.16B0B83 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf08.hostedemail.com (Postfix) with ESMTP id C6922160007 for ; Wed, 2 Jul 2025 17:39:30 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CS8Vmml2; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of luizcap@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=luizcap@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751477970; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gXYdOu9t/2c4Smnfi/pWqiq/G6JiiyTeh/9ILHeGg34=; b=8c2Y55M6J2fOr0hKKoQ+m5iATxn4WNWVWq+mu9rKSDfkYM6Px56tDyB7S21A/rZeavkgon 9qrkO1AbJD0Gi7tkTisOnpv2tLJY+q7n1qbNcrHkLbYlQmTj/ia4LvXVkf1y7hmsOKuB98 VRafL0KiFPdr96UT+1XgtLiNxpFu0Hk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751477970; a=rsa-sha256; cv=none; b=6f2XfREYvNMghKkqlZt1CsbYhsWciFDQK1GxQHNFzjTf0BFR/O9IjUuIef+C77Ws/Ok/Jb lxnMHZqxvN9eolXRnTXSS2ashxcAldgK5ke/BdZWERa1lE1orVNteHmNMA+ERMPkv1q4YD v51hR5JG+b3yo9OqkfKOZoYk2bgq1mg= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CS8Vmml2; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of luizcap@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=luizcap@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751477970; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gXYdOu9t/2c4Smnfi/pWqiq/G6JiiyTeh/9ILHeGg34=; b=CS8Vmml25/Ij8I/6RSAr1qgT8gF3XL4c/+yLX0T0IhF8mkxGdKPv/vH4xg6P47r/rsvXI1 raVu5xcqB0STKUgLQy4exP1R7TjQ+qWIl9i5jEFDNPWS2Jc5TQiCyIVfJoqMfnnDAi270J ADFZqzOK3r+Vlk1fdzDo0GWHeZXUbms= Received: from mail-oi1-f198.google.com (mail-oi1-f198.google.com [209.85.167.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-634-VH9Nk05dM82h4yEyyWJ9xQ-1; Wed, 02 Jul 2025 13:39:28 -0400 X-MC-Unique: VH9Nk05dM82h4yEyyWJ9xQ-1 X-Mimecast-MFC-AGG-ID: VH9Nk05dM82h4yEyyWJ9xQ_1751477968 Received: by mail-oi1-f198.google.com with SMTP id 5614622812f47-40b4d900decso4048226b6e.2 for ; Wed, 02 Jul 2025 10:39:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751477968; x=1752082768; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gXYdOu9t/2c4Smnfi/pWqiq/G6JiiyTeh/9ILHeGg34=; b=AKdMXGp3JdxXau8dSCb89cTkPJ628Qr+WUftpaQBlexaLweBAAZ6hunO/+I9bJ3DW5 dRZvXPkXXMx1z2MSu6fZZrz7v7v3vvbOaRpxUoh/qDPb0e4o+iTfyDaxVSvpU76v0dim YTJF3KwvdgEGAY0AMCqUUS2WtCBaVfyK7auWMSDw69wqem6dydEUDqVCzpcAOnI7NAA8 2BYdL9zNX6/0YLs9hHtFyI1U9ukwESHa0+yc3dWcvFSeEF0hzwwgdTh0LgFDqNqhwFZf LE1sU3pFjRd/Dr6ZGCZ3tStdOsVLL2cNNch96EnAPPe9DnpSE1CaspdEttAGJ6wQKesV wmCA== X-Forwarded-Encrypted: i=1; AJvYcCXftwBTd1hm5IXcS9QDnZikGzEAGEGX5/FWjx+VziYLfnOzBrgJDx9P7OFl9vj1Bv5DlHpZWAk5yA==@kvack.org X-Gm-Message-State: AOJu0YwdJX0kByCwSwzLr4Rk8S3bO82wJGg5PmQVOc6xcMta6VWSqIFD DIYtgBeLDPQfsxfyIoyAmLj6zj3sl0ZPCPcaOsUno5bsyk8al6ISBcPDHSrwG9PggMt9UO0DJD1 +iKg8mzdVZufHgoArPs+ngTtalF3ZSqrgIyBNDj8c4WLo+Z5ygKMd X-Gm-Gg: ASbGnctewnNs1YS7bywNVjB3zIxtQCrjyeqt5N94IQyrGe4Ed79tcjB6RlaGtiFCwfe n9jS5GPQKgXloOo/IQAxCWx7LCpcWWW/91ekhpo37vQa+KMRbI1E8OxBLATRL4qOPX8+nw7R/as W7VtOQJ8+pURa/Eek6uiY8CqePQVJP2tPkW0hF5BetQuOONJIeIs3Wi8nD/s9zwe27BRLXdxvFu ItJvhet9v2PCwDabj4NYHV/M1vxp5eHhO8MtD6g4pKM+a3TzvkgqAtgiEh6oVQpKDt+kM27KB76 W7LK/2Dqx4hyAvQGwHKudJ7ASeN4WEfMdAklRGiboNs7Du/DhxWSWZ5GuA9zX01Pqx/9P3VeKNs 930l/YMWhTJYN X-Received: by 2002:a05:6808:14c6:b0:406:7a50:947a with SMTP id 5614622812f47-40b88b1d153mr2179761b6e.27.1751477968107; Wed, 02 Jul 2025 10:39:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFNmpZ24Wax4edQZeFhqzzbQppSgQKKzaYKq698beKC5mr5tLU2YQgVUXsInJveSbcU3aGGdg== X-Received: by 2002:a05:6808:14c6:b0:406:7a50:947a with SMTP id 5614622812f47-40b88b1d153mr2179744b6e.27.1751477967682; Wed, 02 Jul 2025 10:39:27 -0700 (PDT) Received: from [192.168.2.110] (bras-base-aylmpq0104w-grc-65-69-156-206-24.dsl.bell.ca. [69.156.206.24]) by smtp.gmail.com with ESMTPSA id 5614622812f47-40b322ae4e9sm2610613b6e.17.2025.07.02.10.39.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Jul 2025 10:39:27 -0700 (PDT) Message-ID: <4b56c056-ad98-471f-8b5f-b7080d025b1a@redhat.com> Date: Wed, 2 Jul 2025 13:39:25 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] mm: introduce snapshot_page() To: Shivank Garg , david@redhat.com, willy@infradead.org Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lcapitulino@gmail.com References: <2af92b56-d344-4b22-8eba-872418efbe3b@amd.com> From: Luiz Capitulino In-Reply-To: <2af92b56-d344-4b22-8eba-872418efbe3b@amd.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 8r1vVMhPJMUNbkjmYTWNT0kDW58Mwy2ZBLWwYwUpcyY_1751477968 X-Mimecast-Originator: redhat.com Content-Language: en-US, en-CA Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: otybaz6yf3m8i8xor8fcqcm9zzf97g6u X-Rspamd-Queue-Id: C6922160007 X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1751477970-521120 X-HE-Meta: U2FsdGVkX19/fdVPy0ZgPtno9Yi65x5HGbAsmeoMOWGZnJ21LNFg3VUHcl+kJ1x0OfUYcin5JzYhIvryORhqrrGUP8cWeBg340s/Uru/r56WmDLOyHo6imXS3FioDCY6/2VVolvE78WR/fYbiFkONuSxnc4ekqXwL7grLVLsQs78Fqzc+st1TnOgZCdeVHi6jtGCgERfRk1pISoattggqtz1fzHV/4l/oWvr7u0pwuJPICO9tOw21yCoLvdm2fbh/s/HJyrDhD8IzrKMhrO+EW5KMYwRiZlmWvzg88GMmxso7Xvr970pDOnfw6ZCmGWXIB+oK+KoaABMMkfwd/wzyNJplxHIrDAdfpzKvPKnkNJZuS2IRQO/W4kUBPTwMb+GKRs+CY9aYIUprwYIrueT8R3Tn9Hr0weDOUgcvAb46rHm6dLk5o2BI2tH18PUfJIZetW7GnzDi0hlgEnB+indvNMkfiEcHc6DediNXz/0G6ekqGRsGbJo73A7un3rDu86Gwk3cPosMub/98WvQTEtBGF0lbjyc+8jiv+LifS199UMkJ9AIVG53kKYLL1eV7NTFNTsMInaRcq9AFwErhPm6UZ4Ka5KYdUYZieeQkDRvi0lIt+7uJJOxxPHvmw/EVFr1UweGcOHubaIZSjx+wYnh2wtlN/3O8HkFC4XQ3jcVmTpX2YSVWTVrwFT/38qulJQ9aWjXl9xH/7oHHgf+RFgZ0Sxd2NmCYtekhJeaOTk5Uu8h6AAdPAsR/p+wf1wDFUKscftnJqEtFEYoENPWPCK9xYSrznT7a506TTuRTi40SOWM+PMq0SLDAgTGWy9/s/uwiYy1Nh6wAWS9yVkPprKXDGABDyaGZPZqyM16zc4r3cirbKaIF0t1pM4lTYREuhwfTX7G2o/SAEKs/5im2WcUi1iTGGPA/yJsOBi+XSIUlVN1W1vgJ/dCOFQixS/uOhrkgQWymA4MyfLRrunxpN hC/eYnRR t6HhCXGFgspUV2IgTCP19VoJpDLZYwZWSr/RqhDX+JABPkBPM+cDMAhygGWfQaQC1ORUXXomQcGeRweXjSUnUhpGQTjlfoEddZZw9OftwSsscv9lkvowBWN1HfMLQw6M7Yt6v/wUkMTB0hrrOYj78nkzMv0jRZYr7XB1jycGgl5bIsbpFJEtHMt4G/SuuCAzRlTcDpxoyGQLgK2smZwjWqUvsvp6Qv/F3j5ENWaYBvnQcy/HsQkUfut+fWQdaO7iHKZCB2goM3sDRdDwPZnUvyjC/4Sk6fi/Hz6Cp8cbV6yi6OZG17LCH/rUHCnuQyq6v26nuST4tlDpdjEQW2iGRSu8FFAhUx4AAv/wVLcTVsg8uIMeuCMRuMqSTbhZK6as4LjrZ/RjyHnpEXCgDwUZSvSjm0YBjr5OaibFeDEZCJ8kmWhCHv8C8Cuma3QbhsUMc8h5NO88/cdVQpZ8iFlFeZgh9gwvmRnNOCiVPzuaaDFPv3ho4MpL+BjWcCVsaJ94EeYKvDpxtVklAV0GcUYvvDkejXNh46H1szzRZwMtn5XnOoE7a/FBIeuuQR8hvy45RyniYEqAxxOAec9SV1xlCACNPbNAcLtVnB0VD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025-07-02 02:40, Shivank Garg wrote: > > > On 6/26/2025 11:46 PM, Luiz Capitulino wrote: >> Hi, >> >> This series introduces snapshot_page(), a helper function that can be used >> to create a snapshot of a struct page and its associated struct folio. >> >> This function is intended to help callers with a consistent view of a >> a folio while reducing the chance of encountering partially updated or >> inconsistent state, such as during folio splitting which could lead to >> crashes and BUG_ON()s being triggered. > > We could consider adding a Reported-by: tag and a link to the syzbot report. > > I believe this is the relevant one: > https://lore.kernel.org/all/67812fbd.050a0220.d0267.0030.GAE@google.com I'll add it, thanks for the review.