From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3483DC02198 for ; Tue, 18 Feb 2025 13:53:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 90186280130; Tue, 18 Feb 2025 08:53:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 83C0228012B; Tue, 18 Feb 2025 08:53:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 705E7280130; Tue, 18 Feb 2025 08:53:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4C18A28012B for ; Tue, 18 Feb 2025 08:53:39 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B2E93141392 for ; Tue, 18 Feb 2025 13:53:27 +0000 (UTC) X-FDA: 83133207654.24.2B9AE7C Received: from out30-100.freemail.mail.aliyun.com (out30-100.freemail.mail.aliyun.com [115.124.30.100]) by imf04.hostedemail.com (Postfix) with ESMTP id C70EB40008 for ; Tue, 18 Feb 2025 13:53:23 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=LA6XmYEq; spf=pass (imf04.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.100 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739886805; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YtCd0F7R2Ociq9DloB/HtONRO/iL2JXm/ytjU64+K00=; b=Z19s0Nif/7gtKD2loiwetpRJaY0TeU4N17JTjEUpF4O66/6HXyGgfuo+zLuCNVBipazK41 FH5E2Npg0FYfX8qAlrLHjEaBwE3IIFcgatXY67NQUtSKH3h4NTP6kOJDU5xu9E89IFHffC 6JR1cN0mLRsxYnnCHoJmEyeU1VnBeqg= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=LA6XmYEq; spf=pass (imf04.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.100 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739886805; a=rsa-sha256; cv=none; b=e5mQWbNAd8CeM5vklGwyAolwvM8p1HmEUyXb+5QsIMi8LsjHxsreO4KyeVoExzcfe63ooW e6xcje6PSuXNZrJABhvwC3hFRfmbp4oxIqvd+cVER5YkxYS2HXrLCWgPcyx1uqbr58OgbB yZ5SQT8jkUzYNE4GxHjpwH+AWHsCsr4= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1739886800; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=YtCd0F7R2Ociq9DloB/HtONRO/iL2JXm/ytjU64+K00=; b=LA6XmYEqZIggAUlnIllMzc/FpnBDPTDoUKgRyiMbZekkvowNGolDZSu7uykFJQFapf+i/uwqzmWQ6xm52MAUKwufE8RglS+RU/qpLIAdreEECG2LUYtuOblII31Jjd+00IUWankUCwpcISHoUZwDdKx1TC51yhZRvOtHrv0O/sI= Received: from 30.246.161.128(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0WPm.KiR_1739886798 cluster:ay36) by smtp.aliyun-inc.com; Tue, 18 Feb 2025 21:53:19 +0800 Message-ID: <4b52e6cd-1315-4b0b-8b6e-95a3d4ed96cc@linux.alibaba.com> Date: Tue, 18 Feb 2025 21:53:17 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/5] mm/hwpoison: Fix regressions in memory failure handling To: Borislav Petkov Cc: tony.luck@intel.com, nao.horiguchi@gmail.com, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, linmiaohe@huawei.com, akpm@linux-foundation.org, peterz@infradead.org, jpoimboe@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, baolin.wang@linux.alibaba.com, tianruidong@linux.alibaba.com References: <20250217063335.22257-1-xueshuai@linux.alibaba.com> <20250218082727.GCZ7REb7OG6NTAY-V-@fat_crate.local> <7393bcfb-fe94-4967-b664-f32da19ae5f9@linux.alibaba.com> <20250218122417.GHZ7R78fPm32jKYUlx@fat_crate.local> <02164ab7-c65b-4b2e-8686-5539bdcb8f43@linux.alibaba.com> <20250218131753.GIZ7SIgRZBJokysBeX@fat_crate.local> From: Shuai Xue In-Reply-To: <20250218131753.GIZ7SIgRZBJokysBeX@fat_crate.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: fszd4nrh8aaech47zxts4k1ngqxuryjx X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: C70EB40008 X-HE-Tag: 1739886803-521788 X-HE-Meta: U2FsdGVkX1+TERylzGK4lAk/LsAdviF6e5Iei3c/jDLINsTq5oSbt3egVcsHfbsOvrvs2xvjJRHftgysJn6xBIzUH4eOcqGGRlPaCEoVFvrABlgn+hFB1icCivlKlEAvYeVRFrvKfhzPL+rAoghdJQ0OOBadu+px5+gB+Hjl/L/hjCkUIIaAX33vUr/KFRM2so3NIZB1KZ1TB51Q6d+wFtjZJU74o9wDzG5A/XGAW7+1tD3GoE1xWRzXfknTo0g6NEbBQiKm9HXiJUBor/RMjaT0fMafb8PvdjNPabZ+9hWL4x7LBfqqTC7t613LEL1zVRwShquMkCK7abKulAdQRtKAP49UKsLtfVLXyHlpkHfeL4KKVnTZJqjYvLOV1nzNYDgJaQcjUJ0j4sYTgrHnq0Ks0sS9g/4kdMW7+gUglpaAqOoinUlAcEvFo0HYk4LN3VfHPHb3ZIVLlN3tnociF3YPbeUzSUO40Kt7drCS4M7c1mpvykve/gVV73+Lk8bkU5hYwlvPboK/s++oRE0FE390EsbMx9mqixCnpae7UNkDXP0/1mMU5P+VtT6EYyw1Bip1IpHYmNFEsHO3ND0zJT/yrPP0oXZVKQSeCchamavU85IgXkQC9a6+1bczzYDhoAk/9IY7Zg2oHhRKMKmU8yV/V/lCKkmtL0Q+0rjYyiUBFad33hJVDLpBsVVGOdf4Mwt4taRHG+TZLmbXGtiq1HrAxYXWMoWrVpazRQg7604B0aGicoi7apNxQv86nlDlZq2Y6X3l3GknBSGkk9dxIq4bfltZIuJ450IpZZCIL6s8IQkdnGO781m4U6X7avxvOVXkuV04UOiuL5DCJzBvB9PSVegITWiITec7r7zM6QD8PGaWChFxznw60QTD4Ez5xGGKNKyjfH8DLbqmkqNChTdQdonfCNjry9TcQsjbYLQQOGDVHXxTJ8reBi4nYbpAHyrJwWFoqRgoltVDple DpHfus7z eel80GRe7RSiKv8iMz7JQQc2QYj1EB4WhYGQZ1vFG4MhZp/2zmwRHteUWQJHO7c+ftKfFEAQqqPSBXxCqCh3LLO5E/QKwPHI6AgGfiberV93a2Pz6Rr/tyVEpqHOizySMPth2cXx9nufQ8bWsfTTKxPJ1X46JCKKOa2qK4jAOQKmvjzAK65S2ZSaK78GFIvJnSGQzEnvHDv+QYrnxJ0Sjq6hJPf3D09pnyvGQt1+IEZ5dVJkb5BbwuxmWsWEmjiFVFqTL80uMA6lxeTbs898VciuOF/TCRnmhgZ7a3RsmVcqFTkup4NIzgXDjxoDur1B9Cy16O97J86hFeE3zCw5DjXDtLa3R/Qp11zaWO1kseiHBvLdzpwGiOpWHWOPCor5crKZ4vIcrvN4j2hg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000126, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2025/2/18 21:17, Borislav Petkov 写道: > On Tue, Feb 18, 2025 at 09:08:25PM +0800, Shuai Xue wrote: >> Yes, the poison is found on user pages. >> >> Form commit log, the mechanism is added by Tony and suggested by you. >> https://lkml.kernel.org/r/20210818002942.1607544-3-tony.luck@intel.com > > I'm not talking about how it is detected - I'm asking about *what* you're > doing exactly. I want to figure out what and why you're doing what you're > doing. > >> It's the same as with real issue. There's no magic to it. > > Magic or not, doesn't matter. The only question is whether this can happen in > real life and it is not just you using some tools and "fixing" things that > ain't broke. The regression is reported by end user and we also observed in the production. [5056863.064239] task: ffff8837d2a2a0c0 task.stack: ffffc90065814000 [5056863.137299] RIP: 0010:[] [] __get_user_8+0x21/0x2b ... [5056864.512018] Call Trace: [5056864.543440] [] ? exit_robust_list+0x33/0x110 [5056864.616456] [] mm_release+0x109/0x140 [5056864.682178] [] do_exit+0x159/0xb60 [5056864.744785] [] do_group_exit+0x43/0xb0 [5056864.811551] [] get_signal+0x289/0x630 [5056864.877277] [] do_signal+0x37/0x690 [5056864.940925] [] ? do_futex+0x205/0x520 [5056865.006651] [] ? SyS_futex+0x85/0x170 [5056865.072378] [] exit_to_usermode_loop+0x76/0xc0 [5056865.147464] [] do_syscall_64+0x171/0x180 [5056865.216311] [] entry_SYSCALL_64_after_swapgs+0x58/0xc6 > >>> What do futexes have to do with copying user memory? >> >> Return -EFAULT to userspace. > > This doesn't even begin to answer my question so I'll ask again: > > "What do futexes have to do with copying user memory?" > Sorry, I did not get your point. Thanks. Shuai