From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3CFAC2BD09 for ; Thu, 27 Jun 2024 20:39:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 43F536B00A4; Thu, 27 Jun 2024 16:39:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3EE2E6B00A6; Thu, 27 Jun 2024 16:39:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B5756B00A8; Thu, 27 Jun 2024 16:39:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 066606B00A4 for ; Thu, 27 Jun 2024 16:39:19 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9ACF9810EF for ; Thu, 27 Jun 2024 20:39:19 +0000 (UTC) X-FDA: 82277833638.30.C00955B Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by imf03.hostedemail.com (Postfix) with ESMTP id B2A212001B for ; Thu, 27 Jun 2024 20:39:17 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Pg2go8Ow; spf=pass (imf03.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719520741; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hxkqSPLSZ8WVJ8qA/5pMZTxdnGoTZa9LTxkjHCNUlZg=; b=sWCQ3P4x6+NBOJ/hmMQa6H5LucHlfAejH0oY42wXJwTqrRw0FQiD/pslIRzEGLaxe7qfwg BNkIxdzLgoBePZrmcIoYYu+RYbeg7T+VUgTl74F8IXiudYcRNkaLZ4TRqQD1raGs6nB06f 3x1WRRqMSp6fblc650Xtj0ea3aithZE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719520741; a=rsa-sha256; cv=none; b=v80bFnObq8qMtNVK8Dmfk0NIdQWmBqihiU7WrTJp27bQcbvJsrM17/CpDTOGaGLkhy1TNN UKzlCytpzXLmGqyrPthkjaPYnKBgLUePRmv11aaRoVI2lzQIIr8kA74RjRvN+Km+wqY/iq 1DF1j5CxXEJdA/FlOEVuTttVLZL/1mE= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Pg2go8Ow; spf=pass (imf03.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-42561c16ffeso15805715e9.3 for ; Thu, 27 Jun 2024 13:39:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719520756; x=1720125556; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=hxkqSPLSZ8WVJ8qA/5pMZTxdnGoTZa9LTxkjHCNUlZg=; b=Pg2go8Oww+b2VPXRF/alm2UO5K7xq1RM0BtHtGox76Lj2dk+4er1G8xZCYmttoxdwM aLwrocG+sTAQ1yQGzyUMoaiqYaIKeR+dc2snsng+YQ2mmfRn0Ukz80+SYl1bltSpgCGN HVsf5enbchJBSGY7t2IpsE+hh1MuIfXgH1tnHU4rsOEk0dZVs2vBUXZ4DXwQGC1xK0fz YRdL9sctKG4N8KNbPkvbLdb4pcgV6eaAXDeJ5+AoAhVhiCAA1IkdTNqackHNAYKk2LIV vCnQlR5BxunzmG4sFtxYmpwRWova1RR152Z58Av8LeqSNGl5N+jVpYeTuxw3IH5a6aJM hCoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719520756; x=1720125556; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hxkqSPLSZ8WVJ8qA/5pMZTxdnGoTZa9LTxkjHCNUlZg=; b=wGxWryasV0kFuP7yjhcuMVXVhQwHPENMYA6rogVxI+0tdD4DzDnINAhepUbIjnTJGa 9HlYlOhJLwi5hUWLg3AdnmWq9JFZzPjmA+gAo7iQp/2++47tpN9FboNQ1Mbq9YPB1eFU xxpsipkdN+6XrnvCad+8ph10527CQKAZSjXFdNiG8ukHGriz5/WGdBBtaWxA1PIRH50W XZSZszAbSfvzLu7V6DLmxZl33CsFiYLUu5XvjzD66Q4aBVgyDjtdy/EEzTGqk9BruEmj oeF9k7xAXwqxsIcJYQAeMimQDrh5cdVxv35BBGj+/+W/DdeFczLxHEhUabL33uNOid9V u0ZQ== X-Forwarded-Encrypted: i=1; AJvYcCU0R8xucmaA/MBroye04zRGkZ5kHrlwRCguxShFLL6RlrQmnnqvni8bovDBUEhwyzgkFKYgAuM2Binhk/ye4OOVix8= X-Gm-Message-State: AOJu0YwxXZ2KM0EJOosV3LHIyjrqEUzTOmWmbAdb2Sqb5bsSAcb8OoD8 8GT5FXMleBS0m315R0+3oEFxWvYIpAhNZp8zlxOeQHCPRParfvqD X-Google-Smtp-Source: AGHT+IFp6wy4V+XJozxcZ1RwiAljDE5gB959PiYO/3inJwovYyKVDd1cYakxkcuEl7/1ZPYf6tfKpg== X-Received: by 2002:a05:600c:3b16:b0:425:52c7:1f14 with SMTP id 5b1f17b1804b1-42552c71f73mr37988875e9.24.1719520755859; Thu, 27 Jun 2024 13:39:15 -0700 (PDT) Received: from localhost ([2a00:23cc:d20f:ba01:bb66:f8b2:a0e8:6447]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4256b097bd6sm6892345e9.30.2024.06.27.13.39.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jun 2024 13:39:14 -0700 (PDT) Date: Thu, 27 Jun 2024 21:39:14 +0100 From: Lorenzo Stoakes To: "Liam R. Howlett" , Andrew Morton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Vlastimil Babka , Matthew Wilcox , Alexander Viro , Christian Brauner , Jan Kara , Eric Biederman , Kees Cook , Suren Baghdasaryan Subject: Re: [RFC PATCH 6/7] tools: separate out shared radix-tree components Message-ID: <4b4361cc-3a29-4dbf-ad47-a1d8d05e7781@lucifer.local> References: <3kswdhugo2jmlkejboymem4yhakird5fvmnbschicaldwjwu7x@6c6z5lk4ctvy> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: B2A212001B X-Stat-Signature: wotbg7x8a8hqn1n6kx6uger5g5whjjb6 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1719520757-168832 X-HE-Meta: U2FsdGVkX1+DTknk03xcV1qiNSYQMD62cesykZ/yysKgjDtDWT8kFnjXdxKynBlVLs7FX8cf6lk3lvGqSCBMJIZQvC7wN/Cw8HIFuTJbC+fMNA9bSseeICnpI7zTEX9NhCtYo84ctAbttcPB3BvFznLo6uflHhR2LKIJ1fyed0pfWGa/LZmmsMVbYoiiBhPn3JdS6AfFdmj7mu33JSZA4biKPdUMsEWs3rQ5IzMaeok64RpfakvihaAcfA4lbePAJy4gsIHXDPZhUz9aHn7AuCrnri+ShhoLMU/9fk+bhuhQPTy/LrXlxjzKRZ/R6akvtPQBlp98mvzJjVCnlc5dkr3WqGiEH5IST+/cSJMT/quOURvX4BQXA6Npyk9wQcobsTf5GIuq3VN3SZ5B+b+9aH+u1ramTfLi4MjFpR5NQ1Drg5E5P4zwiURH+nYcizYrAxasAAapoxVAVj+HeV/X0lt7dop7Yk8nIE/cWomHYmfKtR9UkYAVwjicFf6FKRBCYaRa8NEwNbfB67+eeJgcWtRobMxuVI13X6hSuCK9h3f7ILX42s8vrZaFIXdIlFmrLOyhaGu3o3Dszi8hMnMHBw1nEz3qxqfPNWLPWKlFRJOlV4Tf28zshe720tIO5yWZf6xaawclA6KsD9f8/GeKTdvgjBT7vMmit7cAzcdW9/ElIZsP+KTeSqIswXG4YFon83zHUxfxQF67ver49MUQSUNvXUZe9gJupy+0MmedvacqJEjGc5SzmuuIdrk8nHEVkngumiP7ew24uLb7+DTeqyhQx3OBAwgM2VdoiPw7Ph6FfGRKJsvdrgNSWOFmbdxxANqhfOdInGKABanr6sWU1JuMLIRIQbeYua8dtzun3R6g3M62ULeiJIKwtWzni68KIWnjH/bG2w4VPRyO3lUfiK5ZKanmUq5qETaZ4w+4pQlP0ZKvGmvsibFzHop33R1SKXoCDcO9EpAQNY1o3U4 s9AfibzF +Ivv5xU90tj+T5PJJoU0cDkIBbuRvsJOTrxQ9d0CbuS+r9BmWAKrpyssHDwzd5Fk0jhcykbuda7dgZEVXicoEFCmszxQIyNrHmUUyxgHSsuu0aOupJA3aWFf5Ox/2Bo7EXRYun6Va87fn5G7+9fTpI6Lb5JX0cwESA66MwhArJ53gA763OcS7ZDtW9j8TlDZK2Y1G2dZscVqXJe1sCJ/6r1pFEfciUAum2gj6gWOMG1U/A+bWjKqMdmqiwhWZlKAgD0jd5kOnyH6FQQQQDIWyABVIyn/i9khL/OzvUi1mk08hpv7YkOsUN/uWDlTB/AjTI9KPJc1N0WT1ls/onahepvMwnRwOr6x0k2IbS4ZF8wSzn/XqiEi8d/DHiqPpWIjyY6Yump94BV4MuL3Gkq0NWt6+SotO/UF9sMgpVjiIdvXAE65MxM3Tk5Aqoun5rDAsy/nAzbuaRwbSfLg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 27, 2024 at 04:03:21PM -0400, Liam R. Howlett wrote: > * Lorenzo Stoakes [240627 15:47]: > > On Thu, Jun 27, 2024 at 01:59:18PM -0400, Liam R. Howlett wrote: > > > * Lorenzo Stoakes [240627 06:39]: > > > > The core components contained within the radix-tree tests which provide > > > > shims for kernel headers and access to the maple tree are useful for > > > > testing other things, so separate them out and make the radix tree tests > > > > dependent on the shared components. > > > > > > > > This lays the groundwork for us to add VMA tests of the newly introduced > > > > vma.c file. > > > > > > This separation and subsequent patch requires building the > > > xarray-hsared, radix-tree, idr, find_bit, and bitmap .o files which are > > > unneeded for the target 'main'. I'm not a build expert on how to fix > > > this, but could that be reduced to the minimum set somehow? > > > > I'm confused, the existing Makefile specified: > > > > CORE_OFILES := xarray.o radix-tree.o idr.o linux.o test.o find_bit.o bitmap.o \ > > slab.o maple.o > > > > OFILES = main.o $(CORE_OFILES) regression1.o regression2.o regression3.o \ > > regression4.o tag_check.o multiorder.o idr-test.o iteration_check.o \ > > iteration_check_2.o benchmark.o > > > > main: $(OFILES) > > > > Making all of the files you mentioned dependencies of main no? (xarray-shared > > being a subset of xarray.o which requires it anyway) > > After replacing main with vma and dropping the vma.c, I can generate the > vma executable. I had to generate map-shift.h and bit-lenght.h, then > execute: > > cc -O2 -g -Wall -I../shared -I. -I../../include -I../../../lib -g -Og -Wall -D_LGPL_SOURCE -fsanitize=address -fsanitize=undefined -c -o vma.o vma.c > cc -c -O2 -g -Wall -I../shared -I. -I../../include -I../../../lib -g -Og -Wall -D_LGPL_SOURCE -fsanitize=address -fsanitize=undefined ../shared/linux.c -o linux.o > cc -O2 -g -Wall -I../shared -I. -I../../include -I../../../lib -g -Og -Wall -D_LGPL_SOURCE -fsanitize=address -fsanitize=undefined -c -o slab.o ../../lib/slab.c > cc -c -O2 -g -Wall -I../shared -I. -I../../include -I../../../lib -g -Og -Wall -D_LGPL_SOURCE -fsanitize=address -fsanitize=undefined ../shared/maple-shim.c -o maple-shim.o > cc -O2 -g -Wall -I../shared -I. -I../../include -I../../../lib -g -Og -Wall -D_LGPL_SOURCE -fsanitize=address -fsanitize=undefined -c -o vma_stub.o vma_stub.c > cc -fsanitize=address -fsanitize=undefined vma.o linux.o slab.o maple-shim.o vma_stub.o -lpthread -lurcu -o vma > > Dropping a number of the pre-built items. When I looked at the list, it > seemed too numerous for what we were doing (why do we need idr, and > radix-tree?) So I tried removing as many as I could. I did see link errors at some point when radix-tree wasn't included there, I'll take another look and see if we can reduce to a smaller subset if posible. > > > > > I'm not sure this is a huge big deal as these are all rather small :) > > Yeah, maybe not worth the effort. > > Cheers, > Liam