From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95F12C282D1 for ; Mon, 3 Mar 2025 15:13:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 123EA280003; Mon, 3 Mar 2025 10:13:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D4A7280001; Mon, 3 Mar 2025 10:13:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E8FEA280003; Mon, 3 Mar 2025 10:13:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C9C3B280001 for ; Mon, 3 Mar 2025 10:13:04 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 80EBAC0B24 for ; Mon, 3 Mar 2025 15:13:04 +0000 (UTC) X-FDA: 83180582688.15.489BC73 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf30.hostedemail.com (Postfix) with ESMTP id 82D618002D for ; Mon, 3 Mar 2025 15:13:01 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=MM2IStl0; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=4ABTQyUG; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=MM2IStl0; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=4ABTQyUG; spf=pass (imf30.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741014782; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hDyzg2ZIaSEL1bLHsWzXdQZzkglvcop85Oj47qtiMxQ=; b=AO8FWeNmBrIJr3ZCnrAU4k3JPNXIUE+gsI2MGAPHFSjB40c3YI9Gv1qeLtj1+EjVgSwuJ5 gu7X3c3NocU6m7y1VQXnqTJ979M0zEHDj4lLBJgrQPKuzi8OKftRMUohzufTgJFzLMXZRg KK+6atRAPJMG0aGHGBqrhTs+5jsfwaI= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=MM2IStl0; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=4ABTQyUG; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=MM2IStl0; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=4ABTQyUG; spf=pass (imf30.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741014782; a=rsa-sha256; cv=none; b=RgSzXf6ZYcfwfWVwL1HEQ49HMmFPS5Hq0ei7t8bXqXNfEXTh8YiPxdeUoq+B7W3y0No/Rz dn4e5VDg4K8HLIVF56zkCP8f0ve+vsybazMJbZQqmvxGoQvE85D3eFu5vd8gu3WPns+2iu GmUlxHTM27pjTkSfNc60VhCbpQ7OZVk= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 78C8821189; Mon, 3 Mar 2025 15:12:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1741014779; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=hDyzg2ZIaSEL1bLHsWzXdQZzkglvcop85Oj47qtiMxQ=; b=MM2IStl0JxMvdBs4fsT4k7/XLzHBhsk4TM6MxZ2wKj+6vN59l2K4poBq3RNzKk0Ap6yej0 wIR1WgDWPTsDFRIncZ58T9EXpV+uXNjaEOGkxFKU6F8umvjMVU0u8S1nx+pSjozKuWTwvi /zor9qeSS4ZIreLF5uG7h6PU2UlPOew= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1741014779; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=hDyzg2ZIaSEL1bLHsWzXdQZzkglvcop85Oj47qtiMxQ=; b=4ABTQyUGWQ/q9DfkBMOqap9mMumiGtd1QSow+kYYn6w8jbB+VmEurHQVtGFV4MFxjtbUnr 9n+L8vLIj5IFG9Cg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1741014779; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=hDyzg2ZIaSEL1bLHsWzXdQZzkglvcop85Oj47qtiMxQ=; b=MM2IStl0JxMvdBs4fsT4k7/XLzHBhsk4TM6MxZ2wKj+6vN59l2K4poBq3RNzKk0Ap6yej0 wIR1WgDWPTsDFRIncZ58T9EXpV+uXNjaEOGkxFKU6F8umvjMVU0u8S1nx+pSjozKuWTwvi /zor9qeSS4ZIreLF5uG7h6PU2UlPOew= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1741014779; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=hDyzg2ZIaSEL1bLHsWzXdQZzkglvcop85Oj47qtiMxQ=; b=4ABTQyUGWQ/q9DfkBMOqap9mMumiGtd1QSow+kYYn6w8jbB+VmEurHQVtGFV4MFxjtbUnr 9n+L8vLIj5IFG9Cg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6595813A23; Mon, 3 Mar 2025 15:12:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id QiB1GPvGxWcoCQAAD6G6ig (envelope-from ); Mon, 03 Mar 2025 15:12:59 +0000 Message-ID: <4b3be2df-4d82-45d5-b2ec-b08b2625f9d6@suse.cz> Date: Mon, 3 Mar 2025 16:12:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Kernel oops with 6.14 when enabling TLS Content-Language: en-US To: Matthew Wilcox , Hannes Reinecke Cc: Sagi Grimberg , "linux-nvme@lists.infradead.org" , "linux-block@vger.kernel.org" , linux-mm@kvack.org References: <08c29e4b-2f71-4b6d-8046-27e407214d8c@suse.com> <509dd4d3-85e9-40b2-a967-8c937909a1bf@suse.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Queue-Id: 82D618002D X-Rspamd-Server: rspam09 X-Stat-Signature: pioxapacka1u9znnebfzaose3rbcgz5i X-HE-Tag: 1741014781-282624 X-HE-Meta: U2FsdGVkX1/yjY0fWh3+7RgFl2eKoXeOiLehobZJkxDr6ITfSiocdAmNsuGnOQav9xwYHwJNmDfpbecGiAbBpD6Rc8QpjJ+QrFjumqvepegjbNlZFUtoe9AxV83uZIu93kyIHKQhyg3dMWBSHTK1zP2jKrD/1mqLyoeTbZJS0TDA9jNy0ndL8WATONQCL0KWMQWI8cfWKndfiP3mukBMV3mxwHJRDyGfhDHDiMvRpSGFK+kCSel7K3DHQYoxV8V3qHD4XhkCmCC+WW/8kYIHqeX5kMFZh0HZrXqRZTcHxNaIhulfkJwNsuNBWNfe55TJdjHp1d6mZ4RGOj18aRL4ayo+CHO/pm76ctx9x79oSsLHPAlTy6L8kIQSMVTvLzrtJuN2KEzDw2ek0KhzJKPuKDNAccTXQRpDGRSX5F4SbPle0dqO0LrJDOkDVs7oW9PSaaVNNDjI+8P+PA1E/+A+pGHeKyQUbUwWw8Mdw2rqqDT2Th6mBLlqw3Ew0c2LVfPYwTJ5wbmtKdjPM8TFm1sYm0ZPhvNQJXVwSBhDFhmJ9tDf7vbzDAXnQco+Foet6tBMUb/mgIuMa6W50jXtXzbDtVkvEEuFI/4RTSK9p4KiQUtk0YzeD2sWPzcQCz9yhfEuiGj11pSoa3NcGHFS2q6fQ2dui2BHtZ0cTE/MZyS5Nq9e3uzvHzpy/zA6/lLPsLytSFw5xyCIms9k//wIOwIhpjgq4iPTLv/2h3SvGDHb+Wq1FpUMYZjF9kcIMysUBaxdTiro+qtSG+wCKKuLJlR3cdiZkGmWz8hPMkSrTWy8XWD4fRJDrFwut4j4y5joXfrwcwKMUWeygbvTqhFhTcKblDVcN01f0/n4pKQRfi7QZlcSm82XWR4WHZAaRNSySLj4KK8160aibA6JwDuz5PMsRCO9cK5HjyZto0KxGjGwUTfswjuPP3C+MBccZjjfvZvDrI9SFimO3+4CnarD7cj VPFaJiLk FG2b/TD92l3HrNCNwKdm3qzir1MEb6TJGJdHqMDgeCIFTPsjR/pPmsQoycOFkbyQR2sb8BKbJd0VfhpDPqJFsMz8E5MvXDK3zM61JtuvdQIkykJjEYPQeldiqa4SZ78H1utlctQZZb1YbC4QWqWQqQVYcPJBNFgJSEZmVN+c/px1N07YRnOtb3miH1L/0GbOM/f+NfJ+9h71cCx+Wk+8avN68exxMxhbUDtTIZSz0I2dE3Bv0koEzXfg1tgIqDzK/nGtPISwAoEm42FuJiQ+Em9wQFIQhkeRv4sPG98hcI4pl+SO41vNfzbGk1rm7RX2oEDu12PZhY+WXd2k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/3/25 15:42, Matthew Wilcox wrote: > On Mon, Mar 03, 2025 at 02:27:06PM +0000, Matthew Wilcox wrote: >> We have a _lot_ of page types available. We should mark large kmallocs >> as such. I'll send a patch to do that. > > Can you try this? It should fix the crash, at least. Not sure why the > frozen patch triggered it. Having CONFIG_PAGE_OWNER and booting with page_owner=on could make the dump more useful too, tell you where the dumped page was last allocated and freed. In addition CONFIG_DEBUG_PAGEALLOC and booting with debug_pagealloc=on could potentially catch a use-after-free sooner (if something accesses the page via direct mapping after it's kfree()'d. But if this is due to a tight race, it could also mask the bug etc. > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > index 36d283552f80..df9234e5f478 100644 > --- a/include/linux/page-flags.h > +++ b/include/linux/page-flags.h > @@ -925,14 +925,15 @@ FOLIO_FLAG_FALSE(has_hwpoisoned) > enum pagetype { > /* 0x00-0x7f are positive numbers, ie mapcount */ > /* Reserve 0x80-0xef for mapcount overflow. */ > - PGTY_buddy = 0xf0, > - PGTY_offline = 0xf1, > - PGTY_table = 0xf2, > - PGTY_guard = 0xf3, > - PGTY_hugetlb = 0xf4, > - PGTY_slab = 0xf5, > - PGTY_zsmalloc = 0xf6, > - PGTY_unaccepted = 0xf7, > + PGTY_buddy = 0xf0, > + PGTY_offline = 0xf1, > + PGTY_table = 0xf2, > + PGTY_guard = 0xf3, > + PGTY_hugetlb = 0xf4, > + PGTY_slab = 0xf5, > + PGTY_zsmalloc = 0xf6, > + PGTY_unaccepted = 0xf7, > + PGTY_large_kmalloc = 0xf8, > > PGTY_mapcount_underflow = 0xff > }; > @@ -1075,6 +1076,7 @@ PAGE_TYPE_OPS(Zsmalloc, zsmalloc, zsmalloc) > * Serialized with zone lock. > */ > PAGE_TYPE_OPS(Unaccepted, unaccepted, unaccepted) > +FOLIO_TYPE_OPS(large_kmalloc, large_kmalloc) > > /** > * PageHuge - Determine if the page belongs to hugetlbfs > diff --git a/mm/slub.c b/mm/slub.c > index 1f50129dcfb3..872e1bab3bd1 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -4241,6 +4241,7 @@ static void *___kmalloc_large_node(size_t size, gfp_t flags, int node) > ptr = folio_address(folio); > lruvec_stat_mod_folio(folio, NR_SLAB_UNRECLAIMABLE_B, > PAGE_SIZE << order); > + __folio_set_large_kmalloc(folio); > } > > ptr = kasan_kmalloc_large(ptr, size, flags); > @@ -4716,6 +4717,11 @@ static void free_large_kmalloc(struct folio *folio, void *object) > { > unsigned int order = folio_order(folio); > > + if (WARN_ON_ONCE(!folio_test_large_kmalloc(folio))) { > + dump_page(&folio->page, "Not a kmalloc allocation"); > + return; > + } > + > if (WARN_ON_ONCE(order == 0)) > pr_warn_once("object pointer: 0x%p\n", object); > > @@ -4725,6 +4731,7 @@ static void free_large_kmalloc(struct folio *folio, void *object) > > lruvec_stat_mod_folio(folio, NR_SLAB_UNRECLAIMABLE_B, > -(PAGE_SIZE << order)); > + __folio_clear_large_kmalloc(folio); > folio_put(folio); > } >