From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CAD2C2BD09 for ; Mon, 1 Jul 2024 07:55:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7D8526B0082; Mon, 1 Jul 2024 03:55:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 788506B008A; Mon, 1 Jul 2024 03:55:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6779C6B009D; Mon, 1 Jul 2024 03:55:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 47EAB6B0082 for ; Mon, 1 Jul 2024 03:55:18 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id EB8F7121A92 for ; Mon, 1 Jul 2024 07:55:17 +0000 (UTC) X-FDA: 82290423474.09.BC18D99 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf13.hostedemail.com (Postfix) with ESMTP id 2595020004 for ; Mon, 1 Jul 2024 07:55:15 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf13.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719820499; a=rsa-sha256; cv=none; b=CxLf7KDYR/RMmQGeFQzeq91aYmTNrFlLhrQixF8CkPJphEdMEE95Tt3Emy/CYKtV4PhyOp lSo1UejKn7QGJtHnDX4ysX95DrTmpKDvRAtYpgesfk+LyydmwkW0mCJGOJjAT1mbxU5jN3 11Y6PWGhzUV15EnNOL3Jz1bqME2ZpJo= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf13.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719820499; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WHWoUPKDyPe0FBMMMa5CMM8+grp/Pqe7QrNtsF0pi1g=; b=vQNBgPz0pzqRXK9o5L4yy06ku5gF6Rgbwac1z5cMINjVfSkEBlX35VX8LQSOyqWP4Sx0n9 xyr1y/6Y2H60ZbhtbSaLFeV1AHO3SMU66HR1YY8bKBzuuuM0x++DcKDVLqN94FqxyqEU+u U4eJ/tUtS0TRbB/gwvAeB+XjmxTl0Po= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 08F61339; Mon, 1 Jul 2024 00:55:39 -0700 (PDT) Received: from [10.57.72.41] (unknown [10.57.72.41]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A0E473F766; Mon, 1 Jul 2024 00:55:12 -0700 (PDT) Message-ID: <4b38db15-0716-4ffb-a38b-bd6250eb93da@arm.com> Date: Mon, 1 Jul 2024 08:55:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] support "THPeligible" semantics for mTHP with anonymous shmem Content-Language: en-GB To: Bang Li , hughd@google.com, akpm@linux-foundation.org Cc: david@redhat.com, wangkefeng.wang@huawei.com, baolin.wang@linux.alibaba.com, ziy@nvidia.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20240628104926.34209-1-libang.li@antgroup.com> From: Ryan Roberts In-Reply-To: <20240628104926.34209-1-libang.li@antgroup.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 2595020004 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: w6gwgh1ia3qzkedgc36w7m397t3c16i6 X-HE-Tag: 1719820514-353179 X-HE-Meta: U2FsdGVkX19I/QqJq9ViU7SAXWV9TlAMIGWdkxv5CyrRaFF14hPKQ9ariOPirgTUG5EP5+TSGMe3LmLMNWGgNp+kaW8PBcWGGGh8wQ0s16KXZp9CH1qHk80nxZw4S9+xBI2/3VovXwsSP5ZxSZrLyYbMOhDDg2z/5tB4HGFSOCGGG3p0R0ETdUGCKJDhA2bTT/JlAutDyx2tkyWfGmS0hOSDYxU1ZlWAUN/OPJcbcMOHD4qqxVf4BwlAxORpW1bfai8rUWyl5S+OYfOdK8d+PF2Gp15L+ZWPSPIJ6C81j1zm5E73/eix1d4Vvk/Y7Uj2t4Ez0uh1+woUHr3EZb/s7YVz1GP6TA1GYcNLxAjIra8xtv6YwEipdj+U0wJ+S00uvRuioG5cIvKw9X1JWN620qBI2PXmLP3+jpeIV/jCb/CsQxcLFrZl58udGXzRAVtvqV7fjfZXtOZEcqcL4qU8EpmgeUobZkCXf2Uw54STtq4p6YpwVlfEwMfg46nYPwuhhUvGAOTyBJD1zIDvTvniXhI5VMqpMkoH+Iq95xYPsHg1BCF8XohkZIu85ng7UgDQNAZQzSZVAz+d8hTFM88qfbtpVvYpGiqkh17bBPjD9by9JZHDuGkfSWLO4x08p3I1I6VmCIh5yiF5J1GGbQEqknX4Gws4kXP25UKtmXjoXl+JmB1cVPIapkwlZYjzfMsTwVBEgGEfrkt3jP4FARuzrmHK4xlN/ia97obntRdoDQdkoHssMHbAiuMPJaJEF/Rax1aJXeUQxkURw+kMzphMbmk0s2+GYIFGNTsnWPQLy91GitGbqqyaBf6xnLGRJYTc8YYQLpcT3xno6UmTaCqHyGFSUTviZzcakRyQs8eB1N7qQ3jThUU646y89ysd4nOp3JgFcdxVShrAozf6zVjCcKHuPJWYQX2oJoc9tLkvjjuTV5d/xzpJpqPKwaIQOITiakU0Jj8cG29pI3cpXKR PTFwh0DQ 6ho9JW/N6gLN7gIhjEHr6mYDv7etXIlKmOqHrA/uMOHkzjKQM9YnHh2bL/K70Z0fplFeLAgbIXi9tDkXrDKo+3ypNcPFErZvgDmrvilvLhc6kcPT7OCkygLA2Ihi3nUGYUfIQM+7Rh/qo2VGU+olLal98T/Qx2p4wHMHcfIKnz4D3Npn0Bn8t/6xcVR6qtQ/jybTq+y9uP1pdhhA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 28/06/2024 11:49, Bang Li wrote: > After the commit 7fb1b252afb5 ("mm: shmem: add mTHP support for > anonymous shmem"), we can configure different policies through > the multi-size THP sysfs interface for anonymous shmem. But > currently "THPeligible" indicates only whether the mapping is > eligible for allocating THP-pages as well as the THP is PMD > mappable or not for anonymous shmem, we need to support semantics > for mTHP with anonymous shmem similar to those for mTHP with > anonymous memory. > > Signed-off-by: Bang Li > --- > fs/proc/task_mmu.c | 10 +++++++--- > include/linux/huge_mm.h | 11 +++++++++++ > mm/shmem.c | 9 +-------- > 3 files changed, 19 insertions(+), 11 deletions(-) > > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c > index 93fb2c61b154..09b5db356886 100644 > --- a/fs/proc/task_mmu.c > +++ b/fs/proc/task_mmu.c > @@ -870,6 +870,7 @@ static int show_smap(struct seq_file *m, void *v) > { > struct vm_area_struct *vma = v; > struct mem_size_stats mss = {}; > + bool thp_eligible; > > smap_gather_stats(vma, &mss, 0); > > @@ -882,9 +883,12 @@ static int show_smap(struct seq_file *m, void *v) > > __show_smap(m, &mss, false); > > - seq_printf(m, "THPeligible: %8u\n", > - !!thp_vma_allowable_orders(vma, vma->vm_flags, > - TVA_SMAPS | TVA_ENFORCE_SYSFS, THP_ORDERS_ALL)); > + thp_eligible = !!thp_vma_allowable_orders(vma, vma->vm_flags, > + TVA_SMAPS | TVA_ENFORCE_SYSFS, THP_ORDERS_ALL); > + if (vma_is_anon_shmem(vma)) > + thp_eligible = !!shmem_allowable_huge_orders(file_inode(vma->vm_file), > + vma, vma->vm_pgoff, thp_eligible); Afraid I haven't been following the shmem mTHP support work as much as I would have liked, but is there a reason why we need a separate function for shmem? Couldn't (shouldn't) thp_vma_allowable_orders() be taught to handle shmem too? > + seq_printf(m, "THPeligible: %8u\n", thp_eligible); > > if (arch_pkeys_enabled()) > seq_printf(m, "ProtectionKey: %8u\n", vma_pkey(vma)); > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > index 212cca384d7e..f87136f38aa1 100644 > --- a/include/linux/huge_mm.h > +++ b/include/linux/huge_mm.h > @@ -267,6 +267,10 @@ unsigned long thp_vma_allowable_orders(struct vm_area_struct *vma, > return __thp_vma_allowable_orders(vma, vm_flags, tva_flags, orders); > } > > +unsigned long shmem_allowable_huge_orders(struct inode *inode, > + struct vm_area_struct *vma, pgoff_t index, > + bool global_huge); > + > struct thpsize { > struct kobject kobj; > struct list_head node; > @@ -460,6 +464,13 @@ static inline unsigned long thp_vma_allowable_orders(struct vm_area_struct *vma, > return 0; > } > > +static inline unsigned long shmem_allowable_huge_orders(struct inode *inode, > + struct vm_area_struct *vma, pgoff_t index, > + bool global_huge) > +{ > + return 0; > +} > + > #define transparent_hugepage_flags 0UL > > #define thp_get_unmapped_area NULL > diff --git a/mm/shmem.c b/mm/shmem.c > index d495c0701a83..aa85df9c662a 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -1622,7 +1622,7 @@ static gfp_t limit_gfp_mask(gfp_t huge_gfp, gfp_t limit_gfp) > } > > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > -static unsigned long shmem_allowable_huge_orders(struct inode *inode, > +unsigned long shmem_allowable_huge_orders(struct inode *inode, > struct vm_area_struct *vma, pgoff_t index, > bool global_huge) > { > @@ -1707,13 +1707,6 @@ static unsigned long shmem_suitable_orders(struct inode *inode, struct vm_fault > return orders; > } > #else > -static unsigned long shmem_allowable_huge_orders(struct inode *inode, > - struct vm_area_struct *vma, pgoff_t index, > - bool global_huge) > -{ > - return 0; > -} > - > static unsigned long shmem_suitable_orders(struct inode *inode, struct vm_fault *vmf, > struct address_space *mapping, pgoff_t index, > unsigned long orders)