From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A98E2C77B61 for ; Mon, 24 Apr 2023 18:35:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 43C636B0074; Mon, 24 Apr 2023 14:35:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3EC6A6B0075; Mon, 24 Apr 2023 14:35:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 30BF56B0078; Mon, 24 Apr 2023 14:35:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2292F6B0074 for ; Mon, 24 Apr 2023 14:35:07 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id EA1BAC0249 for ; Mon, 24 Apr 2023 18:35:06 +0000 (UTC) X-FDA: 80717136612.02.0A0DBC8 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf23.hostedemail.com (Postfix) with ESMTP id 33A3614000A for ; Mon, 24 Apr 2023 18:35:05 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=n7prQDYH; spf=pass (imf23.hostedemail.com: domain of paulmck@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=paulmck@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682361305; a=rsa-sha256; cv=none; b=63dGfRJoZIZoFXPJYmcHJ+nZhjIIe1QtLMJmAxYj26/AZIA6vzkCaNyp3kxaUpobbNCDj4 +ztpRcrKyYv4GOnZaxyTEiCqXCn6FFiobDtsYgoX+RMxPApkFxp+MMTjwa+XdtsCpMjAVK AmYkzj4ebhT/YlLS3tynlq8mWI7e5NY= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=n7prQDYH; spf=pass (imf23.hostedemail.com: domain of paulmck@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=paulmck@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682361305; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bZwu4BA6je+20Yjn1dkXfl14UIqX1AOKe1vxeEaXPpA=; b=qGQkrNiRtzj7IqTfePl+5KlkTlgZlIqQ0c4tVj8mk/TESJTxBBEe3aDp7kL/U+pMh5lAdO BU4pyfzhNJHney7QrlgMteychUNLhIathBbwVXlGyCwg8DOJKKpbQ6O3IocjF2Rt4HB4Qc C77RlxmQXO4QSiZPvl7I7IbcPFT8C+E= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 41E7461FD7; Mon, 24 Apr 2023 18:35:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7831C433EF; Mon, 24 Apr 2023 18:35:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682361303; bh=elWSjrPnEy4/ZkSa87Ap3uNz+gGryyRP1CEeaZxvihU=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=n7prQDYHw4UEl3PVKv2trX1MkkHdTJWItJZAfD1Dpvrpa4y6GNMJKSSOXuLt2RsQs ZwJ5wlJOlkQV1NSHQ8nqMCSZA6aHd490VmIttPS4yBv2TCy1mxkeLuYWZzTZzQlH0P FvTn1JiFgfHK73mgRW6qmUl8qkSzxGwN+y4xeeeX4aqgpqJYQLVyRgmXziD7Wupu81 8T5+l7VRlb3fK54uthgds9mMpfBM6JhLf+QtHq+jUcSnklskUF/PLqjhFbpzClzjLV L9sDowUufveYWwwbomKHUR8LG4D6afANEQwXBx7X4pnFIiN1eXVtoUUVaZInXbGzEn zf7ztc/zmXFcA== Received: by paulmck-ThinkPad-P72.home (Postfix, from userid 1000) id 4E25915404E7; Mon, 24 Apr 2023 11:35:03 -0700 (PDT) Date: Mon, 24 Apr 2023 11:35:03 -0700 From: "Paul E. McKenney" To: Vlastimil Babka Cc: SeongJae Park , akpm@linux-foundation.org, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] mm/slab: add a missing semicolon on SLAB_TYPESAFE_BY_RCU example code Message-ID: <4b3342d5-8407-49af-b4c8-b54d350be7a2@paulmck-laptop> Reply-To: paulmck@kernel.org References: <20230415033159.4249-1-sj@kernel.org> <20230415033159.4249-2-sj@kernel.org> <21cd0c00-4738-49f7-899f-ec3792520bfb@paulmck-laptop> <63f33512-f426-d808-5680-d5dfd8e0c9d2@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <63f33512-f426-d808-5680-d5dfd8e0c9d2@suse.cz> X-Rspam-User: X-Rspamd-Queue-Id: 33A3614000A X-Rspamd-Server: rspam01 X-Stat-Signature: pyu3tyyqzrf8bkdnmh1s73f87if8axxp X-HE-Tag: 1682361305-53461 X-HE-Meta: U2FsdGVkX18IC82iq2gIxrCz0stjW5y7i5fEilTyAdKfUjUXTA+kXkZSj2kq9SBcCQbY0XiuDdyJZeQui+UZ9gTuJqcsy7RdaC5Dnub6NGFGzXgGTpqGL27w8/UexdCyvFm+neC4LJxCEC8eafbio7EETCMIr21LLcCtTjnreAOmZ4Qz+Kjl0T+7U8CCQwnn5zUQo9++GD2l9bm/mBkCzJs91aXG93O6ovxfIlXnJIyjCdY1D1LzV33NC8SkhJprDLKIX+gbqGSXIduWHYrSCERqQRdXxX2Hz81/frpihA1wv9KdDec4T6w1mTBqrPqEy2tnDj9mQ4nzIyjG3yunM5WkfGqJl/jZ9lDNyuAonfEHIHjtvMZSrlD+2ADcFnqJuzFuMsTCOEqH97rLKfUfHDM61yMMvUIuTgBVTAl/QFlExggFRFmwex1qv7TA/Z2qosQ0kEABwP6Pn53by3Vopb33nORbdBO1eNO95DCCl+lS+vXOU/IXJwal2ootElf7npFRGxgbD+x3suaxy7psN/tmFKhzZlyrvyuRDprCmPw5gGdOYk+eNYa0qkJjmqNiVFpTyNAkgngnCnDXZo6qfXp3sBxrokh8/Fagc28uQO5QoTpJTRJ43zWgnpEVH+RJhcH2Nb+YuFQWtJKoWfPdy8qHhQ+UpiMA6AIWCeJ6GYWj0v3F3zGH9PoQKSKgLy3xlL7PHqRW5la96hFEpkTafZcuGK734iobUJcBxKH1hMERNNrmvSqcFG/2eyjz1m3/a9r4wHuVCEEpqWQcXiGv+fIGA/Zq2q74OFdaCMONFl42TiCX6UMQsf0BmjbQCmGAM6nHUHMCuMcLH34TUNNePN6twXYxOX87l55iybZrKg7qN6JV6m1/Vf+AFlQoDoxg5LMTrZTf/+L/e74NT4Td3a2BaPcdCw7yj7LTEcOX6umxexam4lFlS3DyHlq3EYk/mCbfl0kdhktcaWP/rtl VrY+yPWR xW7nQByVwbIDnSBVaLJuj4MKu+wh9AnD8I6V+zsliMLcIGf1Hl9zWGUsO5USDyp6isbQU2NiiZP48yYCot2yRlZaI/gqa6aUfoRbhzc7YjhnCJCCaSEN4Q9IH3r+hxe8F8NG/DAu85M0U+3xjBvlc6qyQrog0jA6SDJcL+/LMgRxx69B7uYKT1yocYDbMPYEFEy3ykXDhrKzQ2QsyHwEIMgv20nA9MXLHZz8OrArOUsrBebYY2oWGfzQWmmj7Tu6mTsQcjnnar9aWUtbO4mE/mxBB213IHiFPeL1xlMFgofXhU+naAswxBxlQ7mI7+IXNzXisqza8VzanXiZhXJjBOA5QQxcVm9r19b8KQJW9matoTeu2CYOqVPwMG74RwrZ188lMsPj4xgWz6iUsT1F3nhU9/azoGwerJVbgN9/Duc78WgAsHRCWSyUNaqG5lBFhDbVZLYcSI0kOx/5Uvd5mOEnOtjnk0bwVDUps8yMX9kLy5yc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 24, 2023 at 08:27:45PM +0200, Vlastimil Babka wrote: > On 4/24/23 19:43, Paul E. McKenney wrote: > > On Sat, Apr 15, 2023 at 03:31:58AM +0000, SeongJae Park wrote: > >> An example code snippet for SLAB_TYPESAFE_BY_RCU is missing a semicolon. > >> Add it. > >> > >> Signed-off-by: SeongJae Park > > > > Reviewed-by: Paul E. McKenney > > > > Or please let me know if you would like me to take it. (Probably better > > going up through the usual slab route, though.) > > Yeah will take it via slab after merge window, but was hoping you'd ack > that (mainly 2/2) as indeed the correct example first. You got it! ;-) Thanx, Paul > Thanks, Vlastimil > > > Thanx, Paul > > > >> --- > >> include/linux/slab.h | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/include/linux/slab.h b/include/linux/slab.h > >> index f8b1d63c63a3..b18e56c6f06c 100644 > >> --- a/include/linux/slab.h > >> +++ b/include/linux/slab.h > >> @@ -53,7 +53,7 @@ > >> * stays valid, the trick to using this is relying on an independent > >> * object validation pass. Something like: > >> * > >> - * rcu_read_lock() > >> + * rcu_read_lock(); > >> * again: > >> * obj = lockless_lookup(key); > >> * if (obj) { > >> -- > >> 2.25.1 > >>