From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B703FC38142 for ; Wed, 25 Jan 2023 02:35:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E1286B0071; Tue, 24 Jan 2023 21:35:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 190966B0072; Tue, 24 Jan 2023 21:35:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 030D96B0073; Tue, 24 Jan 2023 21:35:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E6ED76B0071 for ; Tue, 24 Jan 2023 21:35:13 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B8B711A0C4E for ; Wed, 25 Jan 2023 02:35:13 +0000 (UTC) X-FDA: 80391754506.06.DB50ADA Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2062.outbound.protection.outlook.com [40.107.94.62]) by imf04.hostedemail.com (Postfix) with ESMTP id 82D4340012 for ; Wed, 25 Jan 2023 02:35:10 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=YUTWSsFa; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf04.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.94.62 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674614110; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qVbdcLgZhbSa0fX9oIFTh8IDzl6eHNsa107YjUvJ6js=; b=fRKR4+xYVSd9CQyr3MGL7Y+kbRfE8jzrzpW7qCXLmws9sCpnfKTktAn+f08FlHJSrGwzL7 7Me0cmgsk3HmZOGen5fMWrLWyDLwt3grN94xdXGYJ3CU2yiruIjpCh9B3auVjt6QXge01n 3xRBDtW9LtQ4MOpN1q7v50QPAdE+dgA= ARC-Authentication-Results: i=2; imf04.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=YUTWSsFa; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf04.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.94.62 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1674614110; a=rsa-sha256; cv=pass; b=x49MoPKbbNWA6m2DDQfTHFdfZDlFqvzGOq3ylRiZp5b2iAeIAUnbbtpMAk+deet0PGvG7e ps3jquTtsoi0dFiC72QuJwNYUQmwLp8WB1YVZeKS77/j7uFx+D/+onftdHPUv+RFP/V0kX b9Ie8j+KUaaDfzVeimwMi6d6XrnJYTs= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XZeAIbUKO2Oil7hgqNXR53D0Eij/5Zbh6/t+930jd6IDzbZHxVqL9aQxLfOwuFql8dUxqT3yHtpbqbUxZsYWG0IAYrgGTPggH8KL6fGq6+6x+ij+VVP81UAOBgieAIGr436QxGpZUZt003RGh8yXE3WdMHmOEJLA7tQzz1sQNJcVS+gRccyx2fkHfFjwLgS1zsAI//qdabdhQhQlIfritKWPIPmjMQTWVvx5bevG5RtUcik7M4Hn6InqLNX7+HW2/rCesv8VzRR9kLXGoh6Q2RC6nScVdLqHTm9ot1dl14cR7ClmupvGeQK2cCvX0qyQRZQCyiQ9nUHbQzXXUNsG2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qVbdcLgZhbSa0fX9oIFTh8IDzl6eHNsa107YjUvJ6js=; b=ZiUsXVhQsIQ1ge9S0Ozo7S7MBghP2d4ybUVD55CnarNrozU2vDL2/6XOZ0KzWzo5QbpRjDd35IbgI8rR7hvOgb2ucdU78RyyvsL51zljBaBQlB0uvsJA1cO+1Pzj8ekVGGWQYZWxojhpej8iuceIzsNto4dYEg1XU4A1QrH98z9Pq+ABQKRHBFbneGIM9EIaIlnEjsV0VUlUiWGnk/toniIVzy/V5ZfaX++nO7YLBsM1MS6OWAHnut/5evFkWoImUf0HBKBq5qw5HP9acyG9chauDYy6Yd+qYI5+ReVxdSeNB5mkZ9tfhbMr83vUZZnx0ZB9Ki/HjfdiQaxCD+x8iw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qVbdcLgZhbSa0fX9oIFTh8IDzl6eHNsa107YjUvJ6js=; b=YUTWSsFau51nf79yH/OU3Aj4wwCt0UHg1+KIfhu+HzyZV8kyzb+2UD31bJBmLV9el1II71Tghy6agTfWeNtD7ZpSr1zz66RxSzK3NYEKqEpbZb7mllvyXT4r9+I70n4wxCLDX8ct1F3F9raez/xR0EjgSRYI+ay1/LcXplqsK+V2T1Nb/9YUebSHHduR8n3LmMvhrOyPbDwSl7Q8ldDUwpATam6kMvCRTjacFvvFuENNCCjLQ6Tx6NwioduPFwPbS/nKH2YPLXvRUKtF0R5uQxcxSpYkVWKj/noDPDK/1vqgIMQXtVcD+ifDZ2PVOggJUf4UZl98eILnuhoKISjaxw== Received: from DM6PR03CA0016.namprd03.prod.outlook.com (2603:10b6:5:40::29) by IA1PR12MB8333.namprd12.prod.outlook.com (2603:10b6:208:3fe::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.33; Wed, 25 Jan 2023 02:35:07 +0000 Received: from DM6NAM11FT062.eop-nam11.prod.protection.outlook.com (2603:10b6:5:40:cafe::9f) by DM6PR03CA0016.outlook.office365.com (2603:10b6:5:40::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.33 via Frontend Transport; Wed, 25 Jan 2023 02:35:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DM6NAM11FT062.mail.protection.outlook.com (10.13.173.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.17 via Frontend Transport; Wed, 25 Jan 2023 02:35:06 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Tue, 24 Jan 2023 18:34:56 -0800 Received: from [10.110.48.28] (10.126.230.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Tue, 24 Jan 2023 18:34:56 -0800 Message-ID: <4b270810-30e7-86ea-cbec-73d45fb53469@nvidia.com> Date: Tue, 24 Jan 2023 18:34:55 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 06/13] mm/gup: add an assertion that the mmap lock is locked Content-Language: en-US To: Jason Gunthorpe CC: Alistair Popple , David Hildenbrand , David Howells , Christoph Hellwig , , "Mike Rapoport (IBM)" References: <6-v2-987e91b59705+36b-gup_tidy_jgg@nvidia.com> From: John Hubbard In-Reply-To: <6-v2-987e91b59705+36b-gup_tidy_jgg@nvidia.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.126.230.37] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT062:EE_|IA1PR12MB8333:EE_ X-MS-Office365-Filtering-Correlation-Id: c6ecc831-1cb4-43fd-4c6a-08dafe7cc5a7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gYdsQeZPRJtKMtYGNCs5UsYDxgcw17piwpuHD3NbzvF+cw/OJS5zKp827fxcNwS7Z/3/etn1+lhqPfZuhk1rEXLkaZhuPtV8lE8TAsYxDK+/nfshtBvDrOLaQ6pD0bMv6tm6QIA2NlyfhLZqO0Hb43ekPAaDdlJVenKbLksks7F2pEL5MtSB0+vB8dEZnAAU5U1hyL2/h3xIFmrgvFW1YWJNhcAV0keUR/yWzPHB3Ue80mWEBaHAZ0RNjnexevtxqVgSNJqXgxDL+z4Td7WBvhpy4G7VCYP6w8eATLJfsmkvR8waPPx8hWu/Y1SxEL/88qBvbqUuUkXNyR0ej7O0rFSiUk4xDy2THcXVWOsJemb/H+9bNsVRqZfhQQ686gArcHIRzuLGA5F4NeZd3P7/yAN7jVcltTR6S6cucd+n9WygrUE6lQS1dNX3OpVtMprVFjse9mDIt0rWMg3NQ00XOpgo9f8UKg9YPN+dX2m2rcWXNERVUxKx6skHw33TbQrtUGCmoXsvmF9n00Pl6fpAIUKYhOMY0nYfpx+yFruI/v7OHu0A1sNUkyuKRRBtZtsUsWlc1qwmh8WMl7IMIsFH7Mw8pYhCO8MUno801sSR8upfb9ILxjMLZ4v89akddxVtJS4C2qDz7wS/nv7188vayhwm2aRGeW0dg1Wi0/9lvSw1VCbdijfiycvtPZdE6EdK0tG+ZgrkI+eRF78+Fie1SBEUP8wYZIarGSqa965ekK4= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230025)(4636009)(136003)(376002)(396003)(39860400002)(346002)(451199018)(40470700004)(36840700001)(46966006)(70586007)(7636003)(82740400003)(40480700001)(36756003)(40460700003)(356005)(2906002)(31696002)(336012)(316002)(6636002)(70206006)(16576012)(8676002)(4326008)(37006003)(2616005)(426003)(47076005)(54906003)(31686004)(478600001)(41300700001)(86362001)(53546011)(36860700001)(83380400001)(186003)(4744005)(82310400005)(16526019)(6862004)(26005)(8936002)(5660300002)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2023 02:35:06.9947 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c6ecc831-1cb4-43fd-4c6a-08dafe7cc5a7 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT062.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8333 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 82D4340012 X-Rspam-User: X-Stat-Signature: sqadktpnzuq7m4w9w5xmgdguam8az7rx X-HE-Tag: 1674614110-963168 X-HE-Meta: U2FsdGVkX18BCBgobwM6yTe8LWXZQIJZEe6csaZskLIw9JPfBiOmZrl8RuszTrb4ncKMd66jiREAVzl75QyW30sqW30dAmsh7CjrboYooSDWvo12DeWmGSTKfxiq1dWrxdVRFVY4Fidisl8H2nXmGhUxR16ZHHQ/7PeF9P1LHg4N4cSFsH+wjD7ft8KXS/hyv8PsNjjvzTI8f+5m/2tfHT1LQjG3xYedEamDWO46ts9kwTH4BfuK8jbiscXRTivKnKIKNKSmxzfPeTpEO8o6c83RJzndmliQmQQlHgyf1U1QcQ7ezq0LMo56fms+Dw+FD8KxJNeZ7pmdBIIlOU5pJhEg7LAi6j8diTSYWa6OYh/y04Y7AAXHvXAztdd9ljpVfDiCIwz0v1zrA4fod1rDdKWXG4EvHEUOe2WBcOp2BUOBd9iRN/AqnBEFIzU7q5MXBsdINSOXZfJ46GHG5yiahMvSlPALiluFGVcDEPwoOlNxdPT4TEopDeKELHa7Z8BA024gPV8jfsICkhZxXuXV2Qwthl2wEFoYSxrSYvfnJeVR8xEeIT/IpAKp0BnVUxNHQnUtalbODiIxHCQYQbOEIbLUC2Zoo8xIlp8OSTdI9BhsPekSqcXc7VOgDlCjc6HVZVlKgt+2swAblBVRoEvnjQkuJBHW27MQgbH7qeVhJrCqStCUIDF0O97A4ozxvQLzF4YdZDwlWGl8Z9cGt8ANECM8zTczbLLVSfQld4IYZ3EnK9UR86zSig6XYa6nPRtARfS0+j4dzRsqpLkkQe3jQi95X3YRMQ1J1xOROuQnYq8q24dowQ+Ux6Q+vUxoIeKVCiwhcfQtvKaywr6G1R435JeGbVdtPWFCrEwWUcQK1V4Poc6adeW6aKyB9T6wuwWg/uhoTXd9sgS93WGoSV5W27MBZ2zYj1BGJcyXwgepg5cRYSBeFJj3rtXey6IzmvdQzTkyGkQRdm0OU14Shoo DscKVv6z t4OT4UbQypIbgLb80PKAuPvsJob8Dp5Y7xVkfZS3smxy5OeebAfg0g7zHadnbSqkMCBGXbDaCukgV2Fqxs4vsGaDJyG5qWU/ZvVJelrppoCZ4eLXvyCjcG8EKLY2rveTtYfx1Dyxo1bp0cEMFMHkqxMUO+fdDZRd/Wy51wh0C9HtEJZAyIE3zHaiXPHmcrrlAA9UVDyyXskzRPKoI4IvMu2PCKaaPS3fYgFZ4pb600oR4hk8g/6S1G9qEhruaqxJfvBLfZvGggMmqA89SYCIhceDsnu1xTPXp+sOhnJ9tFGjMmVCnNQmWXC9yx7RbVcnvRaP31gZphwzYufRDxZXGmvHPESHEF84mnfa0JDD8oVfUpZvo/bRb8jwrvh9CekWC8t8tiq2H9EIOa9AFIR9c3fe0Aw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/24/23 12:34, Jason Gunthorpe wrote: > Since commit 5b78ed24e8ec ("mm/pagemap: add mmap_assert_locked() > annotations to find_vma*()") we already have this assertion, it is just > buried in find_vma(): > > __get_user_pages_locked() > __get_user_pages() > find_extend_vma() > find_vma() > > Also check it at the top of __get_user_pages_locked() as a form of > documentation. > > Signed-off-by: Jason Gunthorpe > --- > mm/gup.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: John Hubbard thanks, -- John Hubbard NVIDIA > > diff --git a/mm/gup.c b/mm/gup.c > index 4c236fb83dcd3e..de1a5c64fdfdcf 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -1360,6 +1360,8 @@ static __always_inline long __get_user_pages_locked(struct mm_struct *mm, > must_unlock = true; > *locked = 1; > } > + else > + mmap_assert_locked(mm); > > if (flags & FOLL_PIN) > mm_set_has_pinned_flag(&mm->flags);