From: Bart Van Assche <bvanassche@acm.org>
To: Richard Chang <richardycc@google.com>,
Minchan Kim <minchan@kernel.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Jens Axboe <axboe@kernel.dk>,
Andrew Morton <akpm@linux-foundation.org>
Cc: bgeffon@google.com, liumartin@google.com,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH v2 3/3] zram: enable asynchronous writeback
Date: Thu, 31 Jul 2025 08:29:42 -0700 [thread overview]
Message-ID: <4b24afa0-7e3c-411e-ae29-9ba58ed86386@acm.org> (raw)
In-Reply-To: <20250731064949.1690732-4-richardycc@google.com>
On 7/30/25 11:49 PM, Richard Chang wrote:
> + bio = bio_alloc(zram->bdev, 1, REQ_OP_WRITE, GFP_NOIO | __GFP_NOWARN);
> + if (!bio) {
> + err = -ENOMEM;
> + goto out_free_page;
> + }
> +
> + req = kmalloc(sizeof(struct zram_wb_request), GFP_NOIO | __GFP_NOWARN);
> + if (!req) {
> + err = -ENOMEM;
> + goto out_free_bio;
> + }
Why are 'req' and 'bio' allocated separately instead of creating a
bio_set with front padding? See also bioset_init().
Thanks,
Bart.
prev parent reply other threads:[~2025-07-31 15:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 6:49 [PATCH v2 0/3] zram: support " Richard Chang
2025-07-31 6:49 ` [PATCH v2 1/3] zram: refactor writeback helpers Richard Chang
2025-08-26 22:07 ` Minchan Kim
2025-07-31 6:49 ` [PATCH v2 2/3] zram: add async writeback infrastructure Richard Chang
2025-07-31 15:24 ` Bart Van Assche
2025-07-31 6:49 ` [PATCH v2 3/3] zram: enable asynchronous writeback Richard Chang
2025-07-31 15:29 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b24afa0-7e3c-411e-ae29-9ba58ed86386@acm.org \
--to=bvanassche@acm.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=bgeffon@google.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liumartin@google.com \
--cc=minchan@kernel.org \
--cc=richardycc@google.com \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox