From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65B2DC28CF5 for ; Wed, 26 Jan 2022 10:21:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E9C686B0072; Wed, 26 Jan 2022 05:21:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DFEB36B0074; Wed, 26 Jan 2022 05:21:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CECB46B0075; Wed, 26 Jan 2022 05:21:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0169.hostedemail.com [216.40.44.169]) by kanga.kvack.org (Postfix) with ESMTP id BC9886B0072 for ; Wed, 26 Jan 2022 05:21:32 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 8074B9369D for ; Wed, 26 Jan 2022 10:21:32 +0000 (UTC) X-FDA: 79072046424.22.DE1CE6E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 1F7C3100003 for ; Wed, 26 Jan 2022 10:21:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643192491; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=92KZPMW0jptBf5RLKOdQ+QTWZRzIJi7nuYsRDKcCMjs=; b=ZbHqZPTOUYmjgagRLdyLsMCIaubt/2BH+Uf9bFK5PToTzqGxnfpj+XMgmXKTf46uAIcBiK sufJZLAzdqoMzEvPfGgZr2xIlLV7t6jPPMDr3XEcqHA8DF341qWQKwajPkWqH30yTYehnV mfZ9Xat9sjy6tTY8RRwh6UrouQU5Bh0= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-49-3EHKi_76PEWr8xzA6CkCOQ-1; Wed, 26 Jan 2022 05:21:30 -0500 X-MC-Unique: 3EHKi_76PEWr8xzA6CkCOQ-1 Received: by mail-wr1-f72.google.com with SMTP id m17-20020adfa3d1000000b001dd66c10c0cso1575918wrb.19 for ; Wed, 26 Jan 2022 02:21:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=92KZPMW0jptBf5RLKOdQ+QTWZRzIJi7nuYsRDKcCMjs=; b=2C+k0w5mEdjUrM45gtrAcPch9hxIDnmT5A0XkXePihtoyu26v+WjiTXTBYS5BJ3s0W PjNMKffp3IjdDHpgrcn8SWxEMsAFYVT002lFaYfGTw+3jmR/JKRa8ouGKUJ29lfcKL4L xmQhtqmAhNyn8/ZyN2krfeE8DavMOptEq7/8iVa7Gszge21XLvYjnrUczTJ4edWHm2wF Uj3Lr3fWQ24/inu2f2/ObaWfCBl2P6lGPGi0AoFSg0gKotTAnAbf/1hNU1RcT54QV1Mn qBDU2iVLkXb25mWUb5Vk1kEXLhHlOKBZINu76DpiYofujYmO6ta21pRq+/1GCAFToqxG 7YFw== X-Gm-Message-State: AOAM531hfPCuxvMrw3cFdgQjGbH5WdUfIodK9UgzkPXXxk1U54MQDmJ8 YDaOnd9xQV5bJm7vE9d+Zq4KVuYlzEi3MJ9QKAZj2O1XJXpOMFvjW5u7N/16JhmEYdCXe3n91+d 29U6+2BC7au0= X-Received: by 2002:adf:df10:: with SMTP id y16mr16376804wrl.277.1643192489279; Wed, 26 Jan 2022 02:21:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJwEni0z4gqz5DzLcFFRuOR+CO55fI2vlOCnRMsOgYr3M4kj1IKrM0qdWis6q87sAMbohDhY6Q== X-Received: by 2002:adf:df10:: with SMTP id y16mr16376795wrl.277.1643192489086; Wed, 26 Jan 2022 02:21:29 -0800 (PST) Received: from ?IPV6:2003:cb:c709:2700:cdd8:dcb0:2a69:8783? (p200300cbc7092700cdd8dcb02a698783.dip0.t-ipconnect.de. [2003:cb:c709:2700:cdd8:dcb0:2a69:8783]) by smtp.gmail.com with ESMTPSA id c14sm1073474wri.56.2022.01.26.02.21.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Jan 2022 02:21:28 -0800 (PST) Message-ID: <4b1bf433-067b-ebfb-4603-2e31e1990f77@redhat.com> Date: Wed, 26 Jan 2022 11:21:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH] mm/highmem: remove unnecessary done label To: Miaohe Lin , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220126092542.64659-1-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220126092542.64659-1-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: nil X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 1F7C3100003 X-Stat-Signature: 87aeuyq8q74bmi3kcan9zgzc6xoug6a1 Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZbHqZPTO; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf05.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-HE-Tag: 1643192491-486888 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 26.01.22 10:25, Miaohe Lin wrote: > Remove unnecessary done label to simplify the code. > > Signed-off-by: Miaohe Lin > --- > mm/highmem.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/mm/highmem.c b/mm/highmem.c > index 762679050c9a..0cc0c4da7ed9 100644 > --- a/mm/highmem.c > +++ b/mm/highmem.c > @@ -736,11 +736,11 @@ void *page_address(const struct page *page) > list_for_each_entry(pam, &pas->lh, list) { > if (pam->page == page) { > ret = pam->virtual; > - goto done; > + break; > } > } > } > -done: > + > spin_unlock_irqrestore(&pas->lock, flags); > return ret; > } > @@ -773,13 +773,12 @@ void set_page_address(struct page *page, void *virtual) > list_for_each_entry(pam, &pas->lh, list) { > if (pam->page == page) { > list_del(&pam->list); > - spin_unlock_irqrestore(&pas->lock, flags); > - goto done; > + break; > } > } > spin_unlock_irqrestore(&pas->lock, flags); > } > -done: > + > return; > } > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb