From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D38FC433F5 for ; Tue, 19 Apr 2022 23:09:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 42FCE6B0072; Tue, 19 Apr 2022 19:09:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3DE3D6B0073; Tue, 19 Apr 2022 19:09:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A6716B0074; Tue, 19 Apr 2022 19:09:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 18A556B0072 for ; Tue, 19 Apr 2022 19:09:04 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id DF8281205AA for ; Tue, 19 Apr 2022 23:09:03 +0000 (UTC) X-FDA: 79375170966.17.61C07D8 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf19.hostedemail.com (Postfix) with ESMTP id CEC261A0017 for ; Tue, 19 Apr 2022 23:09:01 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5280860EF6; Tue, 19 Apr 2022 23:09:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55E3BC385A5; Tue, 19 Apr 2022 23:08:59 +0000 (UTC) Message-ID: <4b1acc9c-bb9b-e3c1-aa0e-58bd69374ccf@linux-m68k.org> Date: Wed, 20 Apr 2022 09:08:56 +1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] binfmt_flat; Drop vestigates of coredump support Content-Language: en-US To: "Eric W. Biederman" , Kees Cook Cc: Niklas Cassel , Alexander Viro , Mike Frysinger , Damien Le Moal , kernel test robot , "stable@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" References: <20220418200834.1501454-1-Niklas.Cassel@wdc.com> <202204181501.D55C8D2A@keescook> <87mtgh17li.fsf_-_@email.froward.int.ebiederm.org> From: Greg Ungerer In-Reply-To: <87mtgh17li.fsf_-_@email.froward.int.ebiederm.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: CEC261A0017 X-Stat-Signature: ohx95x4t9h3jcr6djxwbu43gr7kymy3j Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf19.hostedemail.com: domain of "SRS0=itNR=U5=linux-m68k.org=gerg@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=itNR=U5=linux-m68k.org=gerg@kernel.org" X-Rspam-User: X-HE-Tag: 1650409741-225744 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 20/4/22 00:16, Eric W. Biederman wrote: > There is the briefest start of coredump support in binfmt_flat. It is > actually a pain to maintain as binfmt_flat is not built on most > architectures so it is easy to overlook. > > Since the support does not do anything remove it. > > Signed-off-by: "Eric W. Biederman" > --- > > Apologies for hijacking this thread but it looks like we have people who > are actively using binfmt_flat on it. > > Does anyone have any objections to simply removing what little there > is of coredump support from binfmt_flat? No objections from me. Acked-by: Greg Ungerer > Eric > > fs/binfmt_flat.c | 22 ---------------------- > 1 file changed, 22 deletions(-) > > diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c > index 626898150011..0ad2c7bbaddd 100644 > --- a/fs/binfmt_flat.c > +++ b/fs/binfmt_flat.c > @@ -37,7 +37,6 @@ > #include > #include > #include > -#include > > #include > #include > @@ -98,33 +97,12 @@ static int load_flat_shared_library(int id, struct lib_info *p); > #endif > > static int load_flat_binary(struct linux_binprm *); > -#ifdef CONFIG_COREDUMP > -static int flat_core_dump(struct coredump_params *cprm); > -#endif > > static struct linux_binfmt flat_format = { > .module = THIS_MODULE, > .load_binary = load_flat_binary, > -#ifdef CONFIG_COREDUMP > - .core_dump = flat_core_dump, > - .min_coredump = PAGE_SIZE > -#endif > }; > > -/****************************************************************************/ > -/* > - * Routine writes a core dump image in the current directory. > - * Currently only a stub-function. > - */ > - > -#ifdef CONFIG_COREDUMP > -static int flat_core_dump(struct coredump_params *cprm) > -{ > - pr_warn("Process %s:%d received signr %d and should have core dumped\n", > - current->comm, current->pid, cprm->siginfo->si_signo); > - return 1; > -} > -#endif > > /****************************************************************************/ > /*