From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70826D2CDF6 for ; Tue, 22 Oct 2024 23:24:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7769F6B00B7; Tue, 22 Oct 2024 19:24:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 724D96B00B8; Tue, 22 Oct 2024 19:24:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C5FD6B00B9; Tue, 22 Oct 2024 19:24:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 359A86B00B7 for ; Tue, 22 Oct 2024 19:24:25 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5798FA0423 for ; Tue, 22 Oct 2024 23:23:54 +0000 (UTC) X-FDA: 82702818408.09.3812C30 Received: from gentwo.org (gentwo.org [62.72.0.81]) by imf28.hostedemail.com (Postfix) with ESMTP id A5129C000F for ; Tue, 22 Oct 2024 23:24:06 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gentwo.org header.s=default header.b=q5GDxAjn; spf=pass (imf28.hostedemail.com: domain of cl@gentwo.org designates 62.72.0.81 as permitted sender) smtp.mailfrom=cl@gentwo.org; dmarc=pass (policy=reject) header.from=gentwo.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729639386; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=df46+hVxIyNnxBhgzq0T85FqvkJuFV/+VQLfLjBhakU=; b=CoP4B+FU5kGpmGu7QXxonsQfULUItd02vGgrtHuGkk7ZK++WtZopXO+84yYejrhRHHNzVa e5/LiGAK7PVRWoVs/n+Vn32U6phOcVgsArotxNYa4y8zXQwkPV5IhiBydQtwfDd9jfahE4 1AbHvJdmpurCalQxBs2rZlTZHcy/7Rw= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gentwo.org header.s=default header.b=q5GDxAjn; spf=pass (imf28.hostedemail.com: domain of cl@gentwo.org designates 62.72.0.81 as permitted sender) smtp.mailfrom=cl@gentwo.org; dmarc=pass (policy=reject) header.from=gentwo.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729639386; a=rsa-sha256; cv=none; b=DJJAoPNZBnsSdZiOC8u9pzbYrcnBDiqx9ksiC6Q9loGr63xGjkxdSxQjVpCde/wLWUM6cr G2wnIeOBGjZe772Sll4Ud1n4Sa2Uy/Moh7y966NJlBeleiOUBcUINYWenK0EtODKkqZ73D 3ewHk1JnRWoAPNHNtCFrIpbnHKkunoQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gentwo.org; s=default; t=1729639462; bh=78Khv5juGgQH/Jy7dvVkLWEo852D6IKfW/q7DCFoFl8=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=q5GDxAjna6FBWfQDmtaBFPTjIwOoyueGOlWbgv86R29LmQubM2AP4+7+9WskTctIf gSh/GdV8I/FRAFKtZ2a/LYngiohwXo04TadoHEz7pWSTnC63do+KpCcTleCwkrXtiB NKEk2GIQGj3PP/d1xl8fm9RGvsH9PPG0YBiSBGiE= Received: by gentwo.org (Postfix, from userid 1003) id 0452040350; Tue, 22 Oct 2024 16:24:22 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id 0112B4022C; Tue, 22 Oct 2024 16:24:21 -0700 (PDT) Date: Tue, 22 Oct 2024 16:24:21 -0700 (PDT) From: "Christoph Lameter (Ampere)" To: Dave Hansen cc: Peter Zijlstra , Andy Shevchenko , Ingo Molnar , Uros Bizjak , linux-mm@kvack.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Dennis Zhou , Tejun Heo , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Subject: Re: [PATCH v1 1/1] x86/percpu: Cast -1 to argument type when comparing in percpu_add_op() In-Reply-To: Message-ID: <4b1a26b2-cccb-75d8-ee2f-f30ae211e598@gentwo.org> References: <20240905170356.260300-1-andriy.shevchenko@linux.intel.com> <20241016192011.GY17263@noisy.programming.kicks-ass.net> <20241017181859.GB17263@noisy.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY=------------j7icfEkLOSMelbrpKGR8X0pv Content-ID: <03be023f-9e1d-18f8-9dd3-0eb3ab270b65@gentwo.org> X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: A5129C000F X-Stat-Signature: 7wusm93616dqzkzbcbtxrg5bruzanzte X-HE-Tag: 1729639446-587102 X-HE-Meta: U2FsdGVkX1+H9NYy7vrRlJW54OwkFjuLQaYjtVSRre+FR4b7qy1V9OOi4PUgeLZmOJ/J7+PBEgP/+zJH3cfsdoHWMCotgzG4RHVEbiwunjuzK75C2LWv0JiB0veCxVvJ1D5cqILnALVeYLkG4u1M1tcsikuH5apwL8z5CcawESsZ4IMOL1PoE7h1z/DH0h+S+vSmxDlOdIwSRcORE59wICKeaZ5Mi2tI3YW38AQfADImt4htsxoxFZmMiE2fylvMFj1KuU+ORhfkbtIW6ph1I3Kv4HuCMb5OZWRYKby0TFjSJh+1ZfmlpoVIlp13LsjI/10MIUumB5Ap9bhlvkFFvSlMIQPV56U4SUEewOT+KZOfq3HRcwWxqoKhqWdbr+Vk4MhqysTVhXEcVXBe4AQT8FLqsMEUWan0jJvVCA6CDqJWl3upnMVO8dpp//wvl5dxIoqydDQCokxzXLuVtqqKfZV81mc/9iZZXooPbX7Qihl3Tu7ivYATiQ0qOzc/UN8kWXR/mLU7HSa0iITtdQdWZRvg0wI8necvk2s1ZW7hjafbUDUzG5vHs37TB3OcH4KIH03NqbFTgsqTDY2SK0/E73/K32zwSqzpZ12zFrx+2Dr+MCzNF9t7WowsfFDOzofOQdXLS8ksj3UiCXEYWWLKjcMzixbPPMC6OL0/z1N+1OmTZVLlSHyDHsSj/tb7LCQQbYvlf3zivUYmBat3YbbkFD3dV9xtZUs6ChDay9n7DJxA8aXweUs7NeYIIT1ieX2Mi2P42JtRacsBAMXIhTrLG9k1WEvk6muwaS8Bi23wLAclQr+9l1c7iI9ol0tQTBKO/Mho4Q2H9uKvGYgzcYQj/VsO2ogrK8yie2paivF9o7oeCZ4gi+JG00U7AnSYxMjKD0GWM5LOcyxVdwGEckJjK/3vMXrfETV7QMQlY40/N2/D6vcj4nQ2P47/zkBgo8iySw4VIDWL/ajrlR7IX7Y 7f7l3/rC le5A2d50jN97MjyvJLE/cK5tsiHciMdWG5WFVHhI7E1/JN10nc68KlKq1HQ3MyH/xt+BaEw8oLWlkNwGfzqDOYeH67YyaWvdqpzmtGoHesIRDvzEw0ee8R+v4ZUbVHacs4Llsb8uxMD40PY0052XWohbKpSNMe/xgQQeOe4C4y7YP2VQqJVRz0U0KxXgoGN9CfCSRa7VEZexW5S9OxGDj7sGkNUeRMkDLaRQiLopfvqsRtHlbZdfl1zT21FMDDfAc/4Lx9uOa6gQVfIHKVwZJWbwsvsW23heZZ8AN7FmMAGMDOEzrKJI4KCs+j48FIY3xHGCIa8EescfPXLNtDd8B6/P11kYPgpn48+TxL8rkIseaVWYEKBfB15a8xHeh/BpAXIOaQY2ldjWTeNmQCBlsI8Yiy9ZmhlfVBGYqojTjOQhN0WmjlzKQE2UEKNsJ0+mmQeo3G42ksKtYCPqRecFNhGbD+TXvtAyUy/3/80M/OoTggaX/KmJRyvOR/gyMAUTACVCq6NLlaRVvhxgJ1fdR/mH7Lv0kIZ4qF246iD5QYALaIwG/yXv8Y0pHcA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --------------j7icfEkLOSMelbrpKGR8X0pv Content-Type: text/plain; CHARSET=US-ASCII Content-ID: <5f92f215-6566-b2a4-c30c-23ba1b1cb31e@gentwo.org> On Tue, 22 Oct 2024, Dave Hansen wrote: > So I think Peter's version was the best. It shuts up clang and also > preserves the existing (good) gcc 'sub' behavior. I'll send it out for > real in a bit, but I'm thinking of something like the attached patch. The desired behavior is a "dec". "sub" has a longer op code AFAICT. --------------j7icfEkLOSMelbrpKGR8X0pv Content-Type: text/x-patch; CHARSET=UTF-8; NAME=0001-x86-percpu-Avoid-comparing-unsigned-types-to-1.patch Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: ATTACHMENT; FILENAME*0=0001-x86-percpu-Avoid-comparing-unsigned-types-to-1.patch RnJvbSBkNjNiY2QzNTBlMWEzYmE2MTk2ZGFkYjI2Y2IyZjM2ZjBiYTFlMTgyIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZlIEhhbnNlbiA8ZGF2ZS5oYW5zZW5AbGludXgu aW50ZWwuY29tPgpEYXRlOiBGcmksIDE4IE9jdCAyMDI0IDExOjA3OjQ3IC0wNzAwClN1Ympl Y3Q6IFtQQVRDSF0geDg2L3BlcmNwdTogQXZvaWQgY29tcGFyaW5nIHVuc2lnbmVkIHR5cGVz IHRvIC0xCgpjbGFuZyB3YXJucyB3aGVuIGNvbXBhcmluZyBhbiB1bnNpbmdlZCB0eXBlIHRv IC0xIHNpbmNlIHRoZSBjb21wYXJpc29uCmlzIGFsd2F5cyBmYWxzZS4KClRoaXMgY2FuIGJl IHF1aWNrbHkgcmVwcm9kdWNlZCBieSBzZXR0aW5nIENPTkZJR19XRVJST1I9eSBhbmQgcnVu bmluZzoKCgltYWtlIFc9MSBDQz1jbGFuZy0xNCBuZXQvaXB2NC90Y3Bfb3V0cHV0Lm8KCm5l dC9pcHY0L3RjcF9vdXRwdXQuYzoxODc6MzogZXJyb3I6IHJlc3VsdCBvZiBjb21wYXJpc29u IG9mIGNvbnN0YW50IC0xIHdpdGggZXhwcmVzc2lvbiBvZiB0eXBlICd1OCcgKGFrYSAndW5z aWduZWQgY2hhcicpIGlzIGFsd2F5cyBmYWxzZSBbLVdlcnJvciwtV3RhdXRvbG9naWNhbC1j b25zdGFudC1vdXQtb2YtcmFuZ2UtY29tcGFyZV0KICAxODcgfCAgICAgICAgICAgICAgICAg TkVUX0FERF9TVEFUUyhzb2NrX25ldChzayksIExJTlVYX01JQl9UQ1BBQ0tDT01QUkVTU0VE LAogICAgICB8ICAgICAgICAgICAgICAgICBefn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+ fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+CiAgMTg4IHwgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgdHAtPmNvbXByZXNzZWRfYWNrKTsKICAgICAgfCAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICB+fn5+fn5+fn5+fn5+fn5+fn5+Ci4uLgphcmNoL3g4Ni9pbmNs dWRlL2FzbS9wZXJjcHUuaDoyMzg6MzE6IG5vdGU6IGV4cGFuZGVkIGZyb20gbWFjcm8gJ3Bl cmNwdV9hZGRfb3AnCiAgMjM4IHwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKCh2 YWwpID09IDEgfHwgKHZhbCkgPT0gLTEpKSA/ICAgICAgICAgICAgXAogICAgICB8ICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIH5+fn5+IF4gIH5+CgpG aXggdGhpcyBieSBhdm9pZGluZyBhIGNvbXBhcmlzb24gb2YgYW4gdW5jYXN0IC0xIHRvICd2 YWwnLgoKRG9pbmcgdGhpcyBpbiBhZGRpdGlvbiB0byB0aGUgZXhpc3RpbmcgJ3Bhb19JRF9f JyBjYWxjdWxhdGlvbiB3b3VsZCBtYWtlIGl0CmV2ZW4gbW9yZSB1bnJlYWRhYmxlLiBSZW1v dmUgJ3Bhb19JRF9fJyBhbmQgcmVwbGFjZSBpdCB3aXRoIHRoZSB0aHJlZQpjb21wb25lbnRz IG9mIGl0cyBjYWxjdWxhdGlvbi4KClRoaXMgcHJlc2VydmVzIHNvbWUgdW5pbnR1aXRpdmUg YnV0IHVzZWZ1bCBiZWhhdmlvci4gIEZvciBpbnN0YW5jZSwgZ2NjIHNlZXM6CgoJcGVyY3B1 X2FkZF9vcCguLi4sIHZhciwgKHU4KS0xKTsKCmFuZCBjYW4gdHJhbnNmb3JtIHRoYXQgaW50 byBhICJkZWMiLiAgQ2xhbmcsIG9uIHRoZSBvdGhlciBoYW5kLCBzZWVzIHRoZSAndTgnCnR5 cGUgYW5kIGFzc3VtZXMgdGhhdCAiKHZhbCkgPT0gLTEiIGlzIGZhbHNlLCB3aGljaCB3YXMg dGhlIHJvb3Qgb2YgdGhlCndhcm5pbmcuCgpUaGlzIGlzIHVzZWZ1bCBnY2MgYmVoYXZpb3Ig YmVjYXVzZToKCgkjZGVmaW5lIHRoaXNfY3B1X3N1YihwY3AsIHZhbCkgIHRoaXNfY3B1X2Fk ZChwY3AsIC0odHlwZW9mKHBjcCkpKHZhbCkpCgpzbyBhbnkgY29kZSB0aGF0IGRvZXM6CgoJ dGhpc19jcHVfc3ViKEEsIDEpCgp3aGVyZSAnQScgaXMgYW4gdW5zaWduZWQgdHlwZSBnZW5l cmF0ZXMgYSAiZGVjIi4gIENsYW5nLCBvbiB0aGUgb3RoZXIKaGFuZCBnZW5lcmF0ZXMgYSBs ZXNzLWVmZmljaWVudCAiYWRkIi4KClJlcG9ydGVkLWJ5OiBBbmR5IFNoZXZjaGVua28gPGFu ZHJpeS5zaGV2Y2hlbmtvQGxpbnV4LmludGVsLmNvbT4KU2lnbmVkLW9mZi1ieTogRGF2ZSBI YW5zZW4gPGRhdmUuaGFuc2VuQGxpbnV4LmludGVsLmNvbT4KLS0tCiBhcmNoL3g4Ni9pbmNs dWRlL2FzbS9wZXJjcHUuaCB8IDExICsrKysrKy0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgNiBp bnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2FyY2gveDg2L2lu Y2x1ZGUvYXNtL3BlcmNwdS5oIGIvYXJjaC94ODYvaW5jbHVkZS9hc20vcGVyY3B1LmgKaW5k ZXggYzU1YTc5ZDVmZWFlLi41N2Q5NzU5YzY5MmUgMTAwNjQ0Ci0tLSBhL2FyY2gveDg2L2lu Y2x1ZGUvYXNtL3BlcmNwdS5oCisrKyBiL2FyY2gveDg2L2luY2x1ZGUvYXNtL3BlcmNwdS5o CkBAIC0yMzQsMTggKzIzNCwxOSBAQCBkbyB7CQkJCQkJCQkJXAogICovCiAjZGVmaW5lIHBl cmNwdV9hZGRfb3Aoc2l6ZSwgcXVhbCwgdmFyLCB2YWwpCQkJCVwKIGRvIHsJCQkJCQkJCQlc Ci0JY29uc3QgaW50IHBhb19JRF9fID0gKF9fYnVpbHRpbl9jb25zdGFudF9wKHZhbCkgJiYJ CVwKLQkJCSAgICAgICgodmFsKSA9PSAxIHx8ICh2YWwpID09IC0xKSkgPwkJXAotCQkJCShp bnQpKHZhbCkgOiAwOwkJCQlcCisJY29uc3QgaW50IHBhb19jb25zdF9fID0gX19idWlsdGlu X2NvbnN0YW50X3AodmFsKTsJCVwKKwljb25zdCBpbnQgcGFvX2luY19fICAgPSAodmFsKSA9 PSAxOwkJCQlcCisJY29uc3QgaW50IHBhb19kZWNfXyAgID0gKHR5cGVvZih2YXIpKSh2YWwp ID09CQkJXAorCQkJCSh0eXBlb2YodmFyKSktMTsJCQlcCiAJCQkJCQkJCQlcCiAJaWYgKDAp IHsJCQkJCQkJXAogCQl0eXBlb2YodmFyKSBwYW9fdG1wX187CQkJCQlcCiAJCXBhb190bXBf XyA9ICh2YWwpOwkJCQkJXAogCQkodm9pZClwYW9fdG1wX187CQkJCQlcCiAJfQkJCQkJCQkJ XAotCWlmIChwYW9fSURfXyA9PSAxKQkJCQkJCVwKKwlpZiAocGFvX2NvbnN0X18gJiYgcGFv X2luY19fKQkJCQkJXAogCQlwZXJjcHVfdW5hcnlfb3Aoc2l6ZSwgcXVhbCwgImluYyIsIHZh cik7CQlcCi0JZWxzZSBpZiAocGFvX0lEX18gPT0gLTEpCQkJCQlcCisJZWxzZSBpZiAocGFv X2NvbnN0X18gJiYgcGFvX2RlY19fKQkJCQlcCiAJCXBlcmNwdV91bmFyeV9vcChzaXplLCBx dWFsLCAiZGVjIiwgdmFyKTsJCVwKIAllbHNlCQkJCQkJCQlcCiAJCXBlcmNwdV9iaW5hcnlf b3Aoc2l6ZSwgcXVhbCwgImFkZCIsIHZhciwgdmFsKTsJCVwKLS0gCjIuMzQuMQoK --------------j7icfEkLOSMelbrpKGR8X0pv--