From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F995C3064D for ; Mon, 24 Jun 2024 15:56:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 00D786B0255; Mon, 24 Jun 2024 11:56:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EFDD66B02C4; Mon, 24 Jun 2024 11:56:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DEBC76B02C5; Mon, 24 Jun 2024 11:56:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BF05C6B0255 for ; Mon, 24 Jun 2024 11:56:01 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7CB00140F48 for ; Mon, 24 Jun 2024 15:56:01 +0000 (UTC) X-FDA: 82266233322.27.AB5E078 Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com [209.85.219.179]) by imf12.hostedemail.com (Postfix) with ESMTP id B87934000B for ; Mon, 24 Jun 2024 15:55:59 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=xR5pVzPg; spf=pass (imf12.hostedemail.com: domain of hughd@google.com designates 209.85.219.179 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719244541; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FfWZn1YU3dRvQeweqJc9tWpIC2Gz+zz9bEPN4e86euI=; b=tELCs6aYmDUZvel8WjqKjkDuX2SjOTSaheOLQTYrs+uzxDLa2+NaMyGRmYVwBN6hH1th3D 0ZpDn6GdpMpz614NrSAtGxaSnjFHIW84iudE6jhUzBDvtOWPDHJycquGsRMx+3vT7V4FUw yQAJeoFobRgEjR1Fe08nGCtlyco0kPs= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=xR5pVzPg; spf=pass (imf12.hostedemail.com: domain of hughd@google.com designates 209.85.219.179 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719244541; a=rsa-sha256; cv=none; b=tR3fq4XIsPbXIHLOeXq66XwXPJCpJx3fy9JKpf04S6XnVBos3g34R3UnzJRrC4qEnxrfbd fE19rn9uDgnVShHleyw7VCoUUFlZlULdp1ro9T7wXplga3AwgrGdCCjLkeMuebLaMh7MGA gSW3WY+RLnWnQBJIxVrbfQ1HUEdEnik= Received: by mail-yb1-f179.google.com with SMTP id 3f1490d57ef6-e026a2238d8so4428243276.0 for ; Mon, 24 Jun 2024 08:55:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719244559; x=1719849359; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=FfWZn1YU3dRvQeweqJc9tWpIC2Gz+zz9bEPN4e86euI=; b=xR5pVzPgIqYc0aHfcHNqlY4Rg+5IeLKQnFSQBGnAQIwtC/aIaVWpvjTvDVe+1dHlsS b0TKzFY1ulwe8NQCyX4tbqWwLYeaZdxCjHcpvAA00KYTjNQzALP22glBFyCG6sqQKda7 MMhkDeAyDqkaUUd1BnkS4dp40j7VxP19G60mNgtyksmNJ3LOqfUvO/ZamL0AUem1ySx1 mVHDqaDIhL8Lg6HWm9oHly6muC7N4WsdPuCgOGIihv92Orwv5RDvh7orQ0WUNmE+a7Pl ar5s0YzxlS6KMLBMfZcw38PEGJ1dSFVlYObCW6JzZcNCFRriJjjY3EM1jjQjpLePzK0O lQhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719244559; x=1719849359; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FfWZn1YU3dRvQeweqJc9tWpIC2Gz+zz9bEPN4e86euI=; b=e0Pg0oSryLcxM/GWpRpB0t6Td7Qc3JVVNZrXxVkG6S3FjipOHiMznVqq2lyGPIjBUT vygXvHRmz2GuUNnRUpPy25jju+nDeYM5aN1SX9+F3gRoxzmlJUQcw44aaBPRWAGzMo/g NTiM+Vgp9Nx0MANZQ+KMDTPuD0ggmX9WaGzm+a2nXwHB7eFVut3ruhSbKqg3HaSyEUWr +5OERRyOhfVf1qVlzrFAt9hDt1CKU6RkJaUnyiHhU3b8RPzfqg0hPzaOk8qAqYcZLlMH Gl5GD47akXM99snDtal8477TNl7YzquAnMCfYB6Z+jXiw3IGbHJLGXMy6hM2vpjt1+EY /W+Q== X-Forwarded-Encrypted: i=1; AJvYcCXz3VYlkcmH8tzfHxa7n4GW/VortffKyBWuShTptG7bC445W2IPY2jkYjniIB9qAVGqzxTWT36fTt+zQ1kyXOnBP6A= X-Gm-Message-State: AOJu0Yx/nvuj7IOunIJzBqMElgobuSuEKMGVTKsaD0ueGZQhASH0RX/d wZpC8P/u2qfRfhWudvtFNr2lHn07N9S7atmI/oHhKbvNpc5W2v0R/mkAm/mIPA== X-Google-Smtp-Source: AGHT+IHheq8hSRwWFmH40xtZQpLDRnZQiHV6+dJIKeNGFC+oqjIVbI5vNUIQt9N20C6HOLf/IK/8dA== X-Received: by 2002:a25:ea42:0:b0:dfe:3de:87a0 with SMTP id 3f1490d57ef6-e0303f5348amr3897252276.24.1719244558581; Mon, 24 Jun 2024 08:55:58 -0700 (PDT) Received: from darker.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id 3f1490d57ef6-e02e6115bf1sm3286801276.10.2024.06.24.08.55.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jun 2024 08:55:57 -0700 (PDT) Date: Mon, 24 Jun 2024 08:55:46 -0700 (PDT) From: Hugh Dickins To: Usama Arif cc: Hugh Dickins , Yosry Ahmed , kernel test robot , oe-lkp@lists.linux.dev, lkp@intel.com, Linux Memory Management List , Andrew Morton , Chengming Zhou , Nhat Pham , David Hildenbrand , "Huang, Ying" , Johannes Weiner , Matthew Wilcox , Shakeel Butt , Andi Kleen , linux-kernel@vger.kernel.org Subject: Re: [linux-next:master] [mm] 0fa2857d23: WARNING:at_mm/page_alloc.c:#__alloc_pages_noprof In-Reply-To: <5b3e732c-d23d-41ef-ae5c-947fa3e866ab@gmail.com> Message-ID: <4b16e2bb-d0af-9a9a-3425-e937f9ecc777@google.com> References: <202406241651.963e3e78-oliver.sang@intel.com> <12fb19d1-3e57-4880-be59-0e83cdc4b7f1@gmail.com> <61d19ec8-2ba7-e156-7bb7-f746dae8e120@google.com> <5b3e732c-d23d-41ef-ae5c-947fa3e866ab@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="-1463770367-863124913-1719244557=:31879" X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B87934000B X-Stat-Signature: ezmwda7c8rh9uta9h97ge1awbeeq8iwh X-Rspam-User: X-HE-Tag: 1719244559-421990 X-HE-Meta: U2FsdGVkX1/VHHt10JX27CuHWzko3gAEHIGj/R80nTHFxs+XDSAoQPthDQnMubngfBIfm5hVFc15TYpaJu8ioPEM2LjnePehiODhscx+Ur/9+G9zK7pCJWS6c6htsSG5WO649d29R3O1rNqAsPpl9LrRmPu8jH4yYQpucms37B+DUKCfsOPdLSjl9tEo0onkx3KFHcbJYcw2bN+lJo5v8fj9kUL0s8RFxsm7yAnWFnZipkF7fkn/bSAGr8TYZCAJW3U0xp5RbNJHvcMtvX/LoQuLpDe/8T/83AVziAanGbp0XBLkMaOkoyDYrWqGogdKHeGL6KDVc9JednenWReFhp/jLQ9nji+inBi8p01/AE3DyY2fbG/jMVInohbGwmvbYii2vWUBhf+i31ae17vm4eWpXqvKIjG459ID/lAJ46P+PBzo3R3jXolG3e4d3G/IOkZfw2fncgcvT3YshPMNi+qWYbHIwzutrEEkpZ/uCb1KbauZUf8oAbrcFN50A0GTttReOQ2CdBWpo3uuCDXE4YA3qZH6wpEn8MD4lDTJ9qwp6Q+mwNjlhrtfwEXHn7OrvqhHmXGv2Xc5K1WOuESJyziLp7ZVm8F76YxAVwftBRIYOMiRcE51frv5YbSq9F7WkEYNvPgKb2OMW/Sr9notPK1sFG/nFZqthBxq5T3aEsjUs0ZUedfVdMz9fipOOHWV5qSZr5yB6LdwmdgIz/4XcB7IfIW9/Je5zg5qCGhjl90PvMkstcaWVyfVNkdB/cEKDtHxjSPJzmhNesVQziRD4OVDAm+bZcqH5t/Rn06tdn+3gmvsPDg6tYTKSb3ybnlf9AwlvNXnY64b7yrse3FhzBmnpw7YfKy822TRxMJXYBJkZoq/md75VVHihI779/4k0D1B9S1MI1Jvi4gi3c923dj53eEdx4Ydjc5f1BTn0ZCVPhfkgp/ApFibJHxaYqGdV0S/Hkp8RayvSYwiv3F O95mtz9z 5D/xWJGvgF+mrnFx2Vjl1DPOFXQBETn06xhUYLFW2Wfp+qnhdqPV1PLjbrGx8C3Rgj3bYfbsCD+1+kw78P6nrhdBYp8SuyOhlvHNoQW3zJEaPfT1oZwA8/uwCHAGHtWlWZOG5lHzahZVlVBGqL3UfKkFREqBqJzvw7x2auU5TmXuPtvQjkzu/M/dau4mpaD4ftW/21oaa9ZbmodNLorsSSoakJ4U5n9H5o6nFG4dXAo3VAgvOh2nWACNLWA8H+o6OqSvPmHX/AQlMvK9bUWFCOCbAMtl2arvLBwcVYn+aLbGp3HKSyrzRTow/YzEKtLZJ3XBS+MdUggA8JB2oW1bxfnlEB7/PZTweiJDACmHf13tGlOivqFPC9sAkILm3tFjQjrPn2uikA5oOsRl77B/F3P1scpUqZbrDeP3AJQ0qISIY+pGhq2LiA4NSsNB8GMzpqUHZF2kra2feTgUFrrR6Qmn9Lykjq44CbjOtZvzwww8D6XbIiCP9atBuSg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---1463770367-863124913-1719244557=:31879 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE On Mon, 24 Jun 2024, Usama Arif wrote: > On 24/06/2024 18:26, Hugh Dickins wrote: > > On Mon, 24 Jun 2024, Usama Arif wrote: > >> On 24/06/2024 15:05, Yosry Ahmed wrote: > >>> On Mon, Jun 24, 2024 at 1:49=E2=80=AFAM kernel test robot > >>> wrote: > >>>> > >>>> Hello, > >>>> > >>>> kernel test robot noticed > >>>> "WARNING:at_mm/page_alloc.c:#__alloc_pages_noprof" on: > >>>> > >>>> commit: 0fa2857d23aa170e5e28d13c467b303b0065aad8 ("mm: store zero pa= ges > >>>> to > >>>> be swapped out in a bitmap") > >>>> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git mas= ter > >>> This is coming from WARN_ON_ONCE_GFP(order > MAX_PAGE_ORDER, gfp), an= d > >>> is triggered by the new bitmap_zalloc() call in the swapon path. For = a > >>> sufficiently large swapfile, bitmap_zalloc() (which uses kmalloc() > >>> under the hood) cannot be used to allocate the bitmap. > >>> > >>> Usama, I think we want to use a variant of kvmalloc() here. > > Yes, I hit the same problem with swapon in my testing, > > and had been intending to send a patch. > > > >> Yes, just testing with below diff now. The patch is not in mm-stable y= et, > >> so > >> will just send another revision with below diff included. Thanks! > >> > >> > >> diff --git a/mm/swapfile.c b/mm/swapfile.c > >> index 0b8270359bcf..2263f71baa31 100644 > >> --- a/mm/swapfile.c > >> +++ b/mm/swapfile.c > >> @@ -2643,7 +2643,7 @@ SYSCALL_DEFINE1(swapoff, const char __user *, > >> specialfile) > >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 free_percpu(p->cluster_nex= t_cpu); > >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 p->cluster_next_cpu =3D NU= LL; > >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 vfree(swap_map); > >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 bitmap_free(p->zeromap); > >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kvfree(p->zeromap); > > Yes. > > > >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kvfree(cluster_info); > >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* Destroy swap account in= formation */ > >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 swap_cgroup_swapoff(p->typ= e); > >> @@ -3170,7 +3170,7 @@ SYSCALL_DEFINE2(swapon, const char __user *, > >> specialfile, int, swap_flags) > >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 goto bad_swap_unlock_inode; > >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } > >> > >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 p->zeromap =3D bitmap_zalloc(max= pages, GFP_KERNEL); > >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 p->zeromap =3D kvzalloc(DIV_ROUN= D_UP(maxpages, 8), GFP_KERNEL); > > No, 8 is not right for 32-bit kernels. I think you want > > =09p->zeromap =3D kvzalloc(BITS_TO_LONGS(maxpages), GFP_KERNEL); > > but please check it carefully, I'm easily confused by such conversions. > > > > Hugh >=20 > Ah yes, didnt take into account 32-bit kernel. I think its supposed to be >=20 > =C2=A0p->zeromap =3D kvzalloc(BITS_TO_LONGS(maxpages) * sizeof(unsigned l= ong), > GFP_KERNEL); >=20 > if using BITS_TO_LONGS. No doubt you're right (I'm glad I already admitted to being confused). Personally, I'd just say sizeof(long), but whatever you prefer. Hugh >=20 > Will wait sometime incase there are more comments and will send out anoth= er > version. >=20 > Thanks! >=20 > >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (!p->zeromap) { > >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 error =3D -ENOMEM; > >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 goto bad_swap_unlock_inode; ---1463770367-863124913-1719244557=:31879--