From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B18DFCD11DD for ; Wed, 27 Mar 2024 02:01:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3C94C6B007B; Tue, 26 Mar 2024 22:00:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 379AF6B0082; Tue, 26 Mar 2024 22:00:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 241D66B0083; Tue, 26 Mar 2024 22:00:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 163336B007B for ; Tue, 26 Mar 2024 22:00:59 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A030A4023A for ; Wed, 27 Mar 2024 02:00:58 +0000 (UTC) X-FDA: 81941165796.29.E412F92 Received: from mail-oo1-f41.google.com (mail-oo1-f41.google.com [209.85.161.41]) by imf16.hostedemail.com (Postfix) with ESMTP id 10536180003 for ; Wed, 27 Mar 2024 02:00:55 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=YpxlSJKF; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf16.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.161.41 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711504856; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cmf5UAQ88z5Xj0UbZhmF0l+sQTmyxOxjOsynEFySfzw=; b=BjH+ophN5/aMMJLRYJYyF65aVEoIjN7XP3s2PvmxGVaw4Q0S02rXwZARQ3878CfA6e1zXG b4uYUakNnHspDaVq7OS60YPt9GJ8IyaeSBhVIAbiI+rd4E+TIMDKlTISdHnsJV/T/Na4l4 vwGVRnsZbrz/NZnwg0vD9Lwcz+F9Bgw= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=YpxlSJKF; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf16.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.161.41 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711504856; a=rsa-sha256; cv=none; b=npHbpselJpngu+5c8raUJ17wFgLAZr+x8iB6o4nKW3YP/X4yxuk3WDHBEdM9EnCiG4py4l +6MMg7Nakc/17DLwXzeSgIn0www7jyc7fLqzfGDRZzT7U0o6X1Q6WaxtzHPBolDzQ0gK0t uJVGc/HE/ds+TRCuG5/QpAA0UVqvCQM= Received: by mail-oo1-f41.google.com with SMTP id 006d021491bc7-5a47a3786dbso1867220eaf.0 for ; Tue, 26 Mar 2024 19:00:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1711504855; x=1712109655; darn=kvack.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cmf5UAQ88z5Xj0UbZhmF0l+sQTmyxOxjOsynEFySfzw=; b=YpxlSJKFBV4l70WtDKBBbcljMh/9QOT7iuf22rEceFs/g4Vjy2fS+4eIm0UgxI1R55 TmZqQv7i/Xzbm+hV2wcADnQD/65m5RRgxxDQkhOAFVCL+IwdRBjjd6pOjelEgyFKuZyO AAwng3FulO80ruw7SEh2E2RFz5dQAB52ppM4OiYheIvJ+g9aEKe7jNAs4InbpshZtHcT 2Pxzl+kr7ds5vXlRx0hW+oF5toj3cwKS8oTwlegC4tn3HqslUPmIPxYOGzRgWBcqYUJE 5nsyDkcohJgmvffeB9saIFOLa6enXMDxfZMKwP78oZdp/4jtIB+Sroiu3JkaNcCeQWjU J4lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711504855; x=1712109655; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cmf5UAQ88z5Xj0UbZhmF0l+sQTmyxOxjOsynEFySfzw=; b=I3HQ/9iWEYHi8+fz4cQnCiwkEO+V+WgNPW9ovWl5hUZCBkMbheV8Tz5BGbKFb4jAyo aoveQgbzF78jkHPvcqzuOqvWtrxe5SPX5I0lnSDYV7nc95vqXieSajuzFSVoIv9Th33d YSGIiKUtwFIVjQCy3kMVYvAEVP6uupFIIBuim2U3Pp7Lc+FXUKr4AGwa6UwDZxuJvuR3 pQZcYZbQFDDfiDAbhfaC7DEaCR6sAZt96fpW/4nGJxgrq3UbEwPF1L0cBeNirqM+Z1S0 roweo1JlKh1VtRr1xyqUeVqe8sXvQAbP0pKTwRqiNytMpSWjWVm3itoACUWROZbw105+ yFjA== X-Forwarded-Encrypted: i=1; AJvYcCUvkpt0GoUXf7A/oI0Oh5+3dY+EmsCeFJuNQo3kXRvZCwDK8O5KQs9NxO0+GC2kDbDAnmSDxTZtTPBHo0dfkn+m914= X-Gm-Message-State: AOJu0YzfWOc5fy1w/jflR5XsE/K7G7Qg5p6vhk6ogMp6cLXy3k8T94Uj IAnULTKDrQA+00XW8QkKBVsn9C/TAakpKmg4wtx6iSTUV6fZlFc9Udb4rswIe1c= X-Google-Smtp-Source: AGHT+IF73fHO/Z6YyBpVFlKropkN3bskeJkIca7oJegD2t0qhUuIWsgeiz974jHcO5ljSN73dLPIBg== X-Received: by 2002:a05:6870:65a0:b0:229:ee6d:77da with SMTP id fp32-20020a05687065a000b00229ee6d77damr11635219oab.2.1711504854810; Tue, 26 Mar 2024 19:00:54 -0700 (PDT) Received: from [10.254.105.249] ([139.177.225.230]) by smtp.gmail.com with ESMTPSA id p23-20020a056a000a1700b006eaafccff73sm3585242pfh.212.2024.03.26.19.00.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Mar 2024 19:00:54 -0700 (PDT) Message-ID: <4b0d600e-654b-488f-8ac7-2a83d71d91d0@bytedance.com> Date: Wed, 27 Mar 2024 10:00:46 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] mm: pgtable: correct the wrong comment about ptdesc->__page_flags To: Vishal Moola Cc: akpm@linux-foundation.org, hughd@google.com, david@redhat.com, rppt@kernel.org, willy@infradead.org, muchun.song@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: From: Qi Zheng Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 10536180003 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: jhczpm4ej84r9td7sntzqz9kqaodzi48 X-HE-Tag: 1711504855-650580 X-HE-Meta: U2FsdGVkX1/ao1IvamzC9CqBP+OH42rVFyCnCz8H2MmLdrGfUOD4+nPeyurvSxnADkbPDEGpPqwdNOPHrqO9vN7bLAZ0ZbG0QDRDfZhvbgu+OL3wMaXjvhhzu5j1DYn1qssxnZva7zp4CkJJ8bxVR3rBE5bBgqtaQqfx4oR2Ni9QH/zpwpmykP28WsSGFf9PUVl6md3xe5g2kIfRy28OGbvARB0S3uAmTqeuI2pGSWn1+dCiBXtsUDpGFcKmGAQn9jjsn6IB0lz7NP1vCNd5ujZR1kJcjCngYkvI5+MyqlqWg8HKTNziaqQifohEYwHKS7s1yMM27FBaQfWDmbF/7IupRbnBwHXGF+nOd3E4sbpPsx91qr8ESeYryo5da0qIbmiaxSuTh6KuTidvYOtDfkSMH/ZG/w8tAzKFW7SehSBYsmLC5uI6U/AjsgF9R9+dsktdb2nS2hifNKs9r7UX6QDiNAuwWBnBosRfdvdgDJcE1dj0NUIsoIqQbvKA95/pcIon5Po1a9V8WaSaUZ6hPPb5HdKnCLsOiPUSxKNU44dnNk5QtjNQgz97Q5iejmR4/ov7JMR/anPVHiDjtzno7GozL149gvmvWElhAZt74E9jq4C0gr2DaWiv4VhRFoxSvinBpCEeyj7W/9rj3IT7AYdlqt9UJTNaFrLa2D8uAjLw7mEni0YZjUms70YfQrQCNQt3ByPknJaf00daJFVAcKJOYoXjixm6sWJMyDCMGTeI8NtVFic5IiElft7lRvcKytrofKTqtHJTisybjOg0UZPnREXW3O1VcN0vxilF1hxH6HKNT2nkmj9++gngUp41YyWoypNhkJtRBo9h46fVNC90WQgF9vjZ1miSat7Cm0kA8I3MwrCEvTwVGX8+ZJ0fbv4D2tKlBQLnPXBHk7gs0/dphhRUseLixli8weOlxPEufYRX16+uoDB0xodeToG1jDuQErPnXapUwn1wk21 QJ/0Ud5X P5MWAllzYje5uI1ZTS4tv/Tx8G6YM/J39woaLxTh91+IO9eHszYDeaSVzS/lnzpIGa94m5eo8pfWrruUhcOZtxS1CbGalSTT5UrXTLj+z85Se27kYfE2ywYfUnJmK0ADNJk7ZNTNwMgxM146De4iu61xLimryMzaKw2y2ICq+NQogRRiXBnKhwLQOOYqvDNyfK3oocjukShhZVqtlGJ8jmCo5hliZMS5keyKeYbwx2ZiRtENLyA5Iu8dT0Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/3/27 03:12, Vishal Moola wrote: > On Mon, Mar 04, 2024 at 07:07:18PM +0800, Qi Zheng wrote: >> The commit 32cc0b7c9d50 ("powerpc: add pte_free_defer() for pgtables >> sharing page") introduced the use of PageActive flag to page table >> fragments tracking, so the ptdesc->__page_flags is not unused, so >> correct the wrong comment. > > Thanks for catching this! > > In regards to naming, we're trying to prefix unused variables with > __underscores so I'd prefer to see the __ eliminated from the > ptdesc->page_flags field here as well. This doesn't warrant a fix > as it is already in 6.9-rc1, but is something to keep in > mind for the future. Got it. > Aside from that, LGTM. > > Reviewed-by: Vishal Moola (Oracle) Thanks! >> Signed-off-by: Qi Zheng >> --- >> include/linux/mm_types.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h >> index a7223ba3ea1e..5ea77969daae 100644 >> --- a/include/linux/mm_types.h >> +++ b/include/linux/mm_types.h >> @@ -419,7 +419,7 @@ FOLIO_MATCH(compound_head, _head_2a); >> >> /** >> * struct ptdesc - Memory descriptor for page tables. >> - * @__page_flags: Same as page flags. Unused for page tables. >> + * @__page_flags: Same as page flags. Powerpc only. >> * @pt_rcu_head: For freeing page table pages. >> * @pt_list: List of used page tables. Used for s390 and x86. >> * @_pt_pad_1: Padding that aliases with page's compound head. >> -- >> 2.30.2 >>