From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F593C433EF for ; Wed, 18 May 2022 22:23:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C7B06B0072; Wed, 18 May 2022 18:23:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 976856B0073; Wed, 18 May 2022 18:23:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8157F6B0074; Wed, 18 May 2022 18:23:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7087E6B0072 for ; Wed, 18 May 2022 18:23:49 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 388B6607C1 for ; Wed, 18 May 2022 22:23:49 +0000 (UTC) X-FDA: 79480292178.19.1DA2D56 Received: from mail-il1-f174.google.com (mail-il1-f174.google.com [209.85.166.174]) by imf14.hostedemail.com (Postfix) with ESMTP id EF0011000E2 for ; Wed, 18 May 2022 22:23:45 +0000 (UTC) Received: by mail-il1-f174.google.com with SMTP id l15so2496541ilh.3 for ; Wed, 18 May 2022 15:23:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=w5RfX8/Rv7yQPUAnH5qBKrcDO1Mm9mdpkNqUpF+8goU=; b=Vp6aagYWx+xbz9SJTBgZR0G9TrlTmXBPwdVDNVlS/jP6tMxTDONTEtXxFFMACKHQ92 e4DhrJbFSk/A8EVBl+jyJZHPz88EhUnxgn4YhPZ/R8KR3kwLnl9YHshvCJfNKCuBW6YA vVVxZNiKJrNAjD7ii58tkXT+SNlhWxQMXwKtM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=w5RfX8/Rv7yQPUAnH5qBKrcDO1Mm9mdpkNqUpF+8goU=; b=6Lw7R5eBanctyGkNTKBBUz9TrLN4FgBNgoxixT37seMnq9fN143bHTUsRBCl8jOzZw N9EePsl7Wj1qWrUDUF+ZfrLJFotUwp9kicHJh3STMx2qI2R+wfGp09izdV2aORQNxHtJ TvXuTchehP3ovdQxTUmnOFcj+a7e5hqmmhG4FJbOsGMftk/WoAdOXHNMrgi4vvDCntTg SNnZH6ewSQSZj269eMNg6kKkRhKTece/7uDn0TLu9aM/+xUOxt7uFWbeXjQtIUR9kmA8 EoG7OCjpNx/kM/fo/2lmGXxlPeAJJKuOV83xvgBXoTyRi4VaYpEVlUH73Tg1NUMg0Lbn lAtg== X-Gm-Message-State: AOAM532SXc8E++tQq1Q/P33wD8Tmq+gzEt6tAnh2Nt3w9+87QdJHnEJr Mg9VqzOydPO5bDiItpCKwPs8YA== X-Google-Smtp-Source: ABdhPJzKCuF7JRxOdyp5CvlBmcPHkPFHNXjwd+grkUrJqygaKaMSoob85tO7D69QkE403CTm54Cqqg== X-Received: by 2002:a05:6e02:1c4e:b0:2d1:a8d:e94d with SMTP id d14-20020a056e021c4e00b002d10a8de94dmr1020917ilg.194.1652912627881; Wed, 18 May 2022 15:23:47 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id d5-20020a05663802a500b0032e15dfbf13sm201221jaq.113.2022.05.18.15.23.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 May 2022 15:23:47 -0700 (PDT) Subject: Re: [PATCH v3 1/1] selftests: vm: add process_mrelease tests To: Suren Baghdasaryan , akpm@linux-foundation.org Cc: mhocko@suse.com, rientjes@google.com, willy@infradead.org, hannes@cmpxchg.org, guro@fb.com, minchan@kernel.org, kirill@shutemov.name, aarcange@redhat.com, brauner@kernel.org, hch@infradead.org, oleg@redhat.com, david@redhat.com, jannh@google.com, shakeelb@google.com, peterx@redhat.com, jhubbard@nvidia.com, shuah@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, Shuah Khan References: <20220518204316.13131-1-surenb@google.com> From: Shuah Khan Message-ID: <4b05f63a-c1b7-1b36-4305-8ee9e34f0e04@linuxfoundation.org> Date: Wed, 18 May 2022 16:23:46 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20220518204316.13131-1-surenb@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Stat-Signature: 3d5ihuyq7pyhf37gqr916xgrygc866ci X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: EF0011000E2 Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=Vp6aagYW; spf=pass (imf14.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.174 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org X-Rspam-User: X-HE-Tag: 1652912625-32359 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/18/22 2:43 PM, Suren Baghdasaryan wrote: > Introduce process_mrelease syscall sanity tests which include tests > which expect to fail: > - process_mrelease with invalid pidfd and flags inputs > - process_mrelease on a live process with no pending signals > and valid process_mrelease usage which is expected to succeed. > Because process_mrelease has to be used against a process with a pending > SIGKILL, it's possible that the process exits before process_mrelease > gets called. In such cases we retry the test with a victim that allocates > twice more memory up to 1GB. This would require the victim process to > spend more time during exit and process_mrelease has a better chance of > catching the process before it exits and succeeding. > > On success the test reports the amount of memory the child had to > allocate for reaping to succeed. Sample output: > > $ mrelease_test > Success reaping a child with 1MB of memory allocations > > On failure the test reports the failure. Sample outputs: > > $ mrelease_test > All process_mrelease attempts failed! > > $ mrelease_test > process_mrelease: Invalid argument > > Signed-off-by: Suren Baghdasaryan > --- > Changes in v3: > - Applied on git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm mm-stable, > per Andrew > - Fixed formatting for sample outputs in the description, per Shuah > - Removed pidfd_open, process_mrelease, write_fault_pages functions, per Shuah > - Moved child main routine into its own function, per Shuah > - Followed tools/testing/selftests/pidfd/pidfd.h as a model to deal with > undefined syscall numbers, per Shuah > Looks good to me Suren. Thank you. Reviewed-by: Shuah Khan thanks, -- Shuah