From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95BE0C36002 for ; Mon, 24 Mar 2025 17:48:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8705B280002; Mon, 24 Mar 2025 13:48:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 81EA0280001; Mon, 24 Mar 2025 13:48:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6BF75280002; Mon, 24 Mar 2025 13:48:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4E831280001 for ; Mon, 24 Mar 2025 13:48:01 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 48F8B806EC for ; Mon, 24 Mar 2025 17:48:01 +0000 (UTC) X-FDA: 83257177962.28.56DBB3A Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by imf04.hostedemail.com (Postfix) with ESMTP id 3D07E40011 for ; Mon, 24 Mar 2025 17:47:58 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=b+j9lUfK; spf=pass (imf04.hostedemail.com: domain of mkoutny@suse.com designates 209.85.128.65 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742838479; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5dGcOKqdR8f2aJ+Dor9wDx9jrRk6G6izyiZhwniZkPk=; b=uZvMM1+aACzwPAuxAFT1MGujRsTlWUTIgKPPpaW5OQSNNlPlP4DUF0dchESD1XhrCL45Ne ALLwtLugHYQTQ3UxhfTNbCI9fhVOADklPt4YUKvRaZyezmxMRZd4REAyGKWf+ZJoRfImua eKqEQXu3+TmutvJKGrLZr+xMAVI3/VI= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=b+j9lUfK; spf=pass (imf04.hostedemail.com: domain of mkoutny@suse.com designates 209.85.128.65 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742838479; a=rsa-sha256; cv=none; b=DUPHDzxRSK4Q0/0oxrN+nFt2lWMsCkMtvSKHVOuPpOgC4Pndk6wnm+xo5hS5C4Bnfav8Z6 Y9Yed7IpUxt5rolS8gB5yv57m6AxeCfdSidtsiuYZnj5+/Z9qTAuQ1qrH5BplMp9+rNOzP uyzpZc++uvs0GwxGGuBuQQCdwQSfDlo= Received: by mail-wm1-f65.google.com with SMTP id 5b1f17b1804b1-4394a0c65fcso43383795e9.1 for ; Mon, 24 Mar 2025 10:47:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1742838477; x=1743443277; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=5dGcOKqdR8f2aJ+Dor9wDx9jrRk6G6izyiZhwniZkPk=; b=b+j9lUfK+Ce4C23L3DaZ/NZ02mcfDOeQW3DtbpzfTSViTWVMQE4uCjO9QEmyifQGW3 2C2c51u4r59pOWbE+xV7+HSKVLYYX7PEKU1jZkgzZPaj2dG7t6r8EWDElcE0RFUODKLJ uzxOqAXhUgWsCgunvN13nXCGpiYu4yKsANnQWxBdzRAY+6ukPMDH+yAobHTxC/j+9uCT hoXAjYnnsUg6WxaxAM9fvqHmmxOb/v5qjcI9MkNmFQrez9p2KcZ51pefYeigX3+9k6+3 Pzmf9sdoHWMyg3DmKELSYO8KhUlt0QWUTQw6ViPGrYXVQdfoLolkEwYLaYbk8TROXqDu fEkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742838477; x=1743443277; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5dGcOKqdR8f2aJ+Dor9wDx9jrRk6G6izyiZhwniZkPk=; b=ezeAVg41DCfwiJglWcLDn0khU4d5KoAjP9PxNppkw0x9rlxpstkgrlnUl13HlIPZdx 1kyjy9Ntl+znJpORhgd34fOgTHHSxxvuBouQIAp8O6lWYt+YOk2fJKeWHw0TW3spvmKB 9w8lzgG7rNG0YRT7egrnGp2JmcFHMzATEe7zmfayRhEHVrLWU109qKfowfAxM8vdmPoi ae5Zym4nYZz/nWvEyz9Q3FKo3U/Do6Db6E7xw6N/vs5Vnnya1BvfJ72VonoqrYL+6QMG 0vO7RBAHm6K3jRDVNZNI9B5B6TL1sei9saQre5lYLX8ED6rlKNOU4Ya2WHhSOvZKMAGq kFqQ== X-Forwarded-Encrypted: i=1; AJvYcCU7xGCbGiE2JzZO2fZ24svVwTRfNHsZRsMl5gFoBFdrLcRly2BbqIU7mt4Xm3tPcBfCN7LsO/CXEw==@kvack.org X-Gm-Message-State: AOJu0YyGaVVFTDhY8LVp8zGkBI7ImN1+fBcdgycypoXzXOUJ7eG4hRkd OUGWz00kKqENt5F0eSweTAHmF8OmftP1S3hcBFIjAdkmyiUWVSRKJr8CtlUXdIk= X-Gm-Gg: ASbGncsMHNNGMeLchF1yLwyrrP1HHjF8aZu68jVL+uM24FyRw5UKX/APn9Z0fuGHWd2 ygUh4VvmasV7LKYasXiOnUVnt6uXYZNolAoG5eRcl9tHKlZ1NVc9uKLXVrSLy6qXQ37jG3t5SJZ NPSl88g47YgXcz7/eaK2P190x/TNmIkslEPDN8PSXOPM3eHLYr6qvfnhu1SH8Mf6B/xyqxAhGXd DA8MAHsk8N/eNaV6pLHKgZkjc/yQgh3H+e3itgULmytt5j/Z9eBKeXKBUvw0M4y8xQvMsA4zs86 zH9Lcf65y1DKRMmEUTBSMYslytSyzDWms655+hAuAYb04hg= X-Google-Smtp-Source: AGHT+IGY96hhv1Pe89mvA2qg2E5EAjuzK2ndQsFz4Semuq/cymUUVStyqHWqEpfEcK4fhjLqzJMpyw== X-Received: by 2002:a05:600c:4693:b0:43c:ea36:9840 with SMTP id 5b1f17b1804b1-43d50a3780fmr107044285e9.22.1742838477389; Mon, 24 Mar 2025 10:47:57 -0700 (PDT) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39abe4971b0sm6495658f8f.26.2025.03.24.10.47.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Mar 2025 10:47:56 -0700 (PDT) Date: Mon, 24 Mar 2025 18:47:55 +0100 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: JP Kobryn Cc: tj@kernel.org, shakeel.butt@linux.dev, yosryahmed@google.com, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH 1/4 v3] cgroup: use separate rstat api for bpf programs Message-ID: <4akwk5uurrhqo4mb7rxijnwsgy35sotygnr5ugvp7xvwyofwn2@v6jx3qzq66ln> References: <20250319222150.71813-1-inwardvessel@gmail.com> <20250319222150.71813-2-inwardvessel@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="t2gp4crhufhfbb47" Content-Disposition: inline In-Reply-To: <20250319222150.71813-2-inwardvessel@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 3D07E40011 X-Stat-Signature: 36tpkndmayodz1om49p4k7xy98nj91ti X-HE-Tag: 1742838478-365924 X-HE-Meta: U2FsdGVkX19tteEGkIkLCIUbcFRWTalIBB8gyqfttfa6hy5JXgO0FoMF6y5G1CKtBpCOaMg40DtDsL8xdO9x9DagZyg1c/hHk61YDKyUBj7OOww6EvNqI1z/qhW+vNq0vZ8yU5z2veTm7ywdtpTjfTYpPq4tqyB6JtAPDiyn19Axg9wxVEtE5wkFChADvmUpvaXD0XYUq6Ekd0Sj1OsS3eKyPY8zmadRmheOOTjbvy5NphwOckmgQ2N9WKmwQbLmSjRos0G7FHPZ19YKTgs6YOnh9/ARTnbbt+X7Gq5GeZFLFfCbZcPD1E8kUPXdT3zQ+JXx76cO8RBedvcsI07WBB9prtYXFfnbx514oEJnhFgmQyt2xsVUB+kQ4wvl0nmz7Yw2tv7rNpJSpDpm8eTNFc7BwUNIqROl9tBHNVCEVDFqPKRgKLx5OWngaKlh+Hdn2PUPtdaz8SmdtTJFusinDL8ln1vJpEqcK0FMNpY8BxrJ3g23TQNQKwt9+N25GS5KedXyYhCOJSPQ/mU1o6ZUvgMbPDESrsptvFlc80FuE1AGZlAjceCMkRoBzUU/5RqqG81aD3Jvl3VNPwtQ4D/ESnIvM9uUUbyBXpPaAVHVsrdoWFsX2m66tOcEQNfj6UyG4GQWFhqL+OjUG7vGSbXL/vX6a4sHN/Z1UnLx4H5iJzWhgjjDfv/vASjmv6oescnOKM/oTOwnRSIvwFerekhsz/Kc4t29Myo5E93ndWznwPX896ObLgHfar5Sh7bwHxPiCCkfeUdZ1DWCjcWMWYcsJJ9J0Ibp03Wcscosvmlvzw23zxiD/zbLZdPsOK4s74M2uxbbGcA6uOkEcVzMC3YjR9ELGw03qyEb4ZD3ImJrVg6Sh+ujmp23JDRNRGHMUAmXxPS0h1O7zkSHoYVK8dhLzXOaGwjPKiyJPUmmEenjgoUOYucSu1LiUKsFYIBtm+J9n1DJ4vR1VqpWGBROeVG CBCUf37M vmGRVNObbLWI/1wKc5QnLcGb1481AJtVICvD4MoqDVe9OpLaOAFSI53jIQxMyW4VixJ21/5LBrINLEKyuNFoPlZ1bdge7sr1W6+PloKCcDV9lOgbW610jOauaUB78KjAF8MMkeCRiz7NjX/Qf2ind9tNT+R+f73QfnmXAh6/sRQ/nSvJTLbA62Go/0Oj2bMBpCaO8dWkW14rx7HUNsWXcwGcd3TDqN9cWL1ZTtqUbg7E3A6Ci3bJQ9xqpuq2/Gqx925O+7sko2sKtIW4jdVfn2oBR3QmRSBBVBSijFb/h6hkKi60BivE48pWaFBt/6FZgTawt/uVS7yTKHC+euIonQPWB88stdf8ikvkG8xGaW5hBmfI94IhEMaxeeVcKOZYTWksOJiLhXwTjHKss4wnvd9zdpiPHdN+b1bZYOoibSNrODYZn8aiDZF8Fovovt9Fdp9UmkJUBnuQY5qV10D8wpTKeTdtGE1RN4ULialiOGSpMLKJBYi0P8lECYDpzdBDI82M+zGvvjNAVOyhx8BeCVBuo1ghHQr8PgLWNqpEBO13e6f1Wi8VEAISHNbTY3MaHTi1n8V1FWOq2wsAdjsjSew5yPw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.001559, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --t2gp4crhufhfbb47 Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Subject: Re: [PATCH 1/4 v3] cgroup: use separate rstat api for bpf programs MIME-Version: 1.0 On Wed, Mar 19, 2025 at 03:21:47PM -0700, JP Kobryn wrote: > The rstat updated/flush API functions are exported as kfuncs so bpf > programs can make the same calls that in-kernel code can. Split these API > functions into separate in-kernel and bpf versions. Function signatures > remain unchanged. The kfuncs are named with the prefix "bpf_". This > non-functional change allows for future commits which will modify the > signature of the in-kernel API without impacting bpf call sites. The > implementations of the kfuncs serve as adapters to the in-kernel API. This made me look up https://docs.kernel.org/bpf/kfuncs.html#bpf-kfunc-lifecycle-expectations The series reworks existing kfuncs anyway, is it necessary to have the bpf_ versions? The semantics is changed too from base+all subsystems flush to only base flush (bpf_rstat_flush()). I'd perhaps do the changes freely w/out taking kfuncs into account and then add possible reconstructive patches towards the end of the series. (I'm not unsure whether the modified btf_type_tag_percpu.c selftest survives the latest unionization of base stats.) Michal --t2gp4crhufhfbb47 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTd6mfF2PbEZnpdoAkt3Wney77BSQUCZ+GayQAKCRAt3Wney77B Sf4aAQDjaV9fsIxeiOTJ3vG0+oTDundo09sTe/5vFK18VJVxbgEAn4OABiJDsyHA EdNDdndGE9dhTKUhhS3l0DmtMuLdAQM= =QYGL -----END PGP SIGNATURE----- --t2gp4crhufhfbb47--