From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF633C76196 for ; Fri, 31 Mar 2023 09:38:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E3E7D6B0071; Fri, 31 Mar 2023 05:38:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DEE6C6B0072; Fri, 31 Mar 2023 05:38:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D043C6B0074; Fri, 31 Mar 2023 05:38:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C486C6B0071 for ; Fri, 31 Mar 2023 05:38:36 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8C29340F33 for ; Fri, 31 Mar 2023 09:38:36 +0000 (UTC) X-FDA: 80628693432.29.A0EA0BF Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf25.hostedemail.com (Postfix) with ESMTP id 95B8AA000C for ; Fri, 31 Mar 2023 09:38:32 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of zhangpeng362@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=zhangpeng362@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680255513; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PypaH9FnVG3lhoasTRusV1qt8DmjGp5OmW3Gus6TGoo=; b=AU76DGmHCqfQNYx4qlP6EM8cpgQAerOCKj2F1Islv6FDgsyvvLr5CdjJemGwha4cgqNXkg BChEmqI+ap9KXMMiawIh0CLeZTjuESuCOOGGuGNxup6sQnObSbpN6Q2fwNtqG5SVnM3KAg 4JFYcKBRCdnREPAe1O5X4kxgXrmFcwM= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of zhangpeng362@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=zhangpeng362@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680255513; a=rsa-sha256; cv=none; b=Hj5Qf2aBhiOxTPFC6z/6a04YCgKcOkty00v8eKtqXub2dCMS8nwPjwBi3tI366FPTTyUJY hsF5saX2sfXTHA5SSMVhPS4H/6W+GrqqDO6gC+jV6bVPV06mKAddO9FbnL28BjQBUx6IAD h/EsSRav1BsDFAXcew596nRexq5ys/k= Received: from kwepemm600020.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4PnwDV1MH4zrVZj; Fri, 31 Mar 2023 17:37:14 +0800 (CST) Received: from [10.174.179.160] (10.174.179.160) by kwepemm600020.china.huawei.com (7.193.23.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Fri, 31 Mar 2023 17:38:23 +0800 Message-ID: <4ada1fa1-4d03-50bb-dfd7-5f0d1b08cbfd@huawei.com> Date: Fri, 31 Mar 2023 17:38:23 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v4 1/6] userfaultfd: convert mfill_atomic_pte_copy() to use a folio Content-Language: en-US To: Matthew Wilcox , Sidhartha Kumar CC: , , , , , , , References: <20230330134045.375163-1-zhangpeng362@huawei.com> <20230330134045.375163-2-zhangpeng362@huawei.com> <765d450c-2ff6-1420-b94f-528d56bffee4@oracle.com> From: "zhangpeng (AS)" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.160] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemm600020.china.huawei.com (7.193.23.147) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: skcgcw1hoq8rhht6c9sasjsbhcimdqkc X-Rspamd-Queue-Id: 95B8AA000C X-HE-Tag: 1680255512-242067 X-HE-Meta: U2FsdGVkX1/SVGhhSlWfEN1kXPLGPOBQcLpuJ82NB+4hBd2+uI7W6CUg8+kI1o+8FDZRBsLnvxHTE1qtbnWDfifMBJ/i456g0gnKWF/Wl/3+BDReKBU6HGEXrVy8p1PU8vb5qtJzburI5bF3YFHlMzjulur07lahcLf5TUYk/BlGNqSq1NZnnZyMCBHLJ7nmUVgjqJLicxyr+XqVfhnr7TP3mA+1n1LEidAStyDPRwuc/cHErWtnsq6EwT3wGzSALyws2+LDzKqvdKvS6NH5yNqVTaNr85V7sSFw/B+e1RZwGHUYSiDfKgqBzJpegy9WVgmPfZ2UNasrUfpMjIc+NPOp0c51GE0pG6EKyFFecAfykKNDE9ZN8GaZpDaj9ixy1SyB0Yyyfj+yReIdBW/GGV4318cUw5BdTQQFOSQXRAQgQs2z/Aj1lYbCH02BRB5BO03Y26dY7DHZEaZFk7s95xvObeGu0AQd/Ua8LWNUGxDUTJU+sPapHwdl8FUJqmXsxZxAsPFQU1vm6qY4yTlTPtbZjCYHHE9qDW0zASSHNqB0+EbqYHBUeuZhDliwyJjWcNCG+05gXc/NE3GAwQZz9mQ3MIKlx7/dxOUrArGAKqkYTgcHhvLcPBgiSXonVnesJsyGzsXgMc5uNK+itHd0NhtXJKx/vduhE9X5wy9NvxR2BE/C95mh1GqWlJceG0Tf0G/PjnpU96rP+TbfbKHFfXhIcfU8jbJFKKC7xgaX1iEDRy8dPKYdnjbkXo7qFjoVrfP6J7z49eYl018fJwDMJrL4hMnCQJrnO//tm4k9pY7YFEvFZkWN5h5pYacYMZoeIaJd5q2ufjEl0zpV/7yL4Udlg+8xZYK36Yakzj4GY/rnaUBWP5RMBsqG2s90zj8coIv6zwJnqvTEjp9eo5VFN3YKtE63xNkeGpvgTgiMNfvbk9YqQsd+K61VzBTLLDAO5Acj/ijHr1y0Z0chXQ+ XyqPZFxd IXmBpCQUx5JcAmA8GfITe+M54d93qDbFSnFPSGUXMDd0jc1fKar1XGMVESNS2upszTtkXk1FmTuwaOA5QCBH3eESgAKJeAdPC30e8kev6o3ETUspdp77zBe4/NkhyYdQ2O9UWUSrFt2zRd+PAXlBK1m3YgrklOrtI7O2llZUuCAhhZcXWq23SYiG2/ilO8PRDNkw01n3QMOopTHoEWQYoeIsJxG4e63LRGFo8Lghd42xcsTi7aTYOdxkcNFFjFfabrtqBrWrrQZubuKx6WxelEadc/0Upenqp9Qje X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/3/31 2:02, Matthew Wilcox wrote: > On Thu, Mar 30, 2023 at 10:02:52AM -0700, Sidhartha Kumar wrote: >> On 3/30/23 6:40 AM, Peng Zhang wrote: >>> From: ZhangPeng >>> >>> Call vma_alloc_folio() directly instead of alloc_page_vma(). Add an >>> assertion that this is a single-page folio and removes several calls to >>> compound_head(). > There's no added assertion in this patch any more, so I'd drop that > part of the description. Thanks. I'll update this description. >>> if (!*pagep) { >>> ret = -ENOMEM; >>> - page = alloc_page_vma(GFP_HIGHUSER_MOVABLE, dst_vma, dst_addr); >>> - if (!page) >>> + folio = vma_alloc_folio(GFP_HIGHUSER_MOVABLE, 0, dst_vma, dst_addr, false); >>> + if (!folio) >>> goto out; >>> - page_kaddr = kmap_local_page(page); >>> + page_kaddr = kmap_local_folio(folio, 0); >> Should this variable name be kept as page_kaddr or should it be changed to >> something like folio_kaddr? kmap_local_folio() returns page_address(), so >> maybe page_kaddr is better. > I'd just call it 'kaddr'. Or 'addr'. Agreed. I'll change page_kaddr to kaddr. Thanks for your review. Best Regards, Peng