From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 609E4C71136 for ; Fri, 13 Jun 2025 13:54:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F10A86B009C; Fri, 13 Jun 2025 09:54:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EC1626B00A0; Fri, 13 Jun 2025 09:54:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D8ACD6B00A1; Fri, 13 Jun 2025 09:54:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B8E7F6B009C for ; Fri, 13 Jun 2025 09:54:06 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 425495B80D for ; Fri, 13 Jun 2025 13:54:06 +0000 (UTC) X-FDA: 83550521292.04.48886DA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id B4354A0007 for ; Fri, 13 Jun 2025 13:54:03 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=A1FHkI3E; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749822843; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BU5JyOHWosQhM/6S0NPkSCkvdLM9aueb+w9hBh6xwnE=; b=HjpBxsjXnW0vE8+I0Gh10i54uqBEmxKkMlYwx3e1YZed0bhSU9XLWkf3I3ptofn9Ubmrdu Wa/O67rGLx6DuZWQ0dipVfYkmHSIwz063Y/w3qq9scD8bOlPrgaD7OzW3QJWav5j+erjFM TsHfoG2vi6pOyxIPsljbl1+Q9NAQjDk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749822843; a=rsa-sha256; cv=none; b=u/oBRT6+IilZ/TXpgzs7mtGBbv7FfTihiC4Do9p/Is1mXc8npsMXjBe89shf8isgU+jVKJ Ay7MYumfpNnMMnU73wSweHTCMomw6ihg37cQmhV8Bt/RdBcCIZvYRVb69HSMXb5FllNbNH ANQklL9CEpz8WwD71UWWfbQXCriRrGg= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=A1FHkI3E; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749822843; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=BU5JyOHWosQhM/6S0NPkSCkvdLM9aueb+w9hBh6xwnE=; b=A1FHkI3EJuN5fP0W6hU0kP0xbru3j4b1VBHTeeknkr+hqtZPrubfy1312hWw5/6QL0Ofnj 1QvEt7TLn487qaOR4ADciNFQc+htLCR+TiBym791E9BedGHvHU/kEf8LLc+bjChI3CTCpy yLiSqxxcI6MSkccbbzxkkPTujJBtlsI= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-280-K0I1Il7tNOmPep2Im_ZuZA-1; Fri, 13 Jun 2025 09:54:02 -0400 X-MC-Unique: K0I1Il7tNOmPep2Im_ZuZA-1 X-Mimecast-MFC-AGG-ID: K0I1Il7tNOmPep2Im_ZuZA_1749822841 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3a52bfda108so1090876f8f.3 for ; Fri, 13 Jun 2025 06:54:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749822841; x=1750427641; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=BU5JyOHWosQhM/6S0NPkSCkvdLM9aueb+w9hBh6xwnE=; b=sFXrjdxENYtRG9cVDYZDB0M+GyvC2n368LyP5k/7W7f4Pu9uGJM8qhA7tZaDFIrrnB c9O19L3djNXXt3GidutPDOD5iz1k/OTn1KB5OrU/beTcoKhjmqQpiFQsasklwT728NT4 aB6Z8C2UoNQhis2RI7w0xptQBuFge310nS161cB713eqBGUp6uEdvOKfafQYMg1EcwEE pPE+Z+HDltf6bUiwKdRnv3kWSgleSH4o4VmpT8WaK0HqZB4cHee3vyqQlDfbVJFQ3zhS rkeZOrMaVMn+f2Sq7mh/kPY06di5JSZgya1L4GLxESbpKmVWMi2gcxcwgauswp5qNrwH sjFw== X-Forwarded-Encrypted: i=1; AJvYcCUY44cQzzD3zlevSJyheMrpsHpIl9Bb2cz/OpjqT6D1f8xtVWmLrXk4Jx+CsbZY0/Ju0sjHzX/gaw==@kvack.org X-Gm-Message-State: AOJu0YxHYfq0kMySVLFYsAHekia1EaIh39mA0QuMzltRF5MoO8WbLPLz k+bXgp7+TDD6C0p/fIbndwt/eCxTvqjSpLPjxJI9/1lYmNivd8abYmEl+03HBCQQxdi2m063Fqc uaPiPlJCK9zczGGp96FEJxdMQgLywnweB5kvYTNYa5IQy0jIozpcn X-Gm-Gg: ASbGncvzPKbqFjltFzF020JAsU+Xbxyjv18Hiu/LjdIIiMdnXp8fsQFQOEfr7JTnbSM R4ySJ8+3TitHTOf4tY1O7wywKEQaFCdOeYKHQcbwbh7evx4hZIVwgJAtbp0LIgT0WXXGIQRkp1b mSFLhLFwPRBd1io5zhI+TMp4l6YfBiB4rzN/Wm48NPhmf1BVMsGv3lZ5IAx4NOGHeQ1lNTKXMyp 51oNnWLATsk55F4juBLzXSXkbsNyL+2Bw3d9EaQmkC6E6MNV6gJxWv24n4v17n1zjW4uoUrYGOa ZNBPa7o17aTIRu2ABi0rRuivC5ZrvSAx9EuFW1+Bxr+VggD0i4n8iwTE+8wahiQzGCwdGb2+SyD 2mk/mK2g5BWJNGZYTyVsSonxzcgShpabdyswDBqQW8ifWiNTg5g== X-Received: by 2002:a5d:5c84:0:b0:3a4:ee40:6c85 with SMTP id ffacd0b85a97d-3a568782a9dmr2754758f8f.54.1749822840852; Fri, 13 Jun 2025 06:54:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IET2fbn9FBBIkd7aBt+1E8zNBbPyT+ISzzLAkF7LjOk3Wnlvm3OEjK8bvUbn25abxKjOlKU0w== X-Received: by 2002:a5d:5c84:0:b0:3a4:ee40:6c85 with SMTP id ffacd0b85a97d-3a568782a9dmr2754728f8f.54.1749822840315; Fri, 13 Jun 2025 06:54:00 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1a:3700:2982:b5f7:a04e:4cb4? (p200300d82f1a37002982b5f7a04e4cb4.dip0.t-ipconnect.de. [2003:d8:2f1a:3700:2982:b5f7:a04e:4cb4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568b6debasm2463786f8f.93.2025.06.13.06.53.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Jun 2025 06:53:59 -0700 (PDT) Message-ID: <4acaa46f-f856-4116-917e-08e7c1f3156a@redhat.com> Date: Fri, 13 Jun 2025 15:53:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/3] mm/huge_memory: don't mark refcounted folios special in vmf_insert_folio_pmd() To: Oscar Salvador Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, Andrew Morton , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Dan Williams , Jason Gunthorpe References: <20250613092702.1943533-1-david@redhat.com> <20250613092702.1943533-3-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: gRxqRV1-J8FO8C2-XqjhdRocOiFigVgKL3EXiPkrQxU_1749822841 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: btxde3rbawyxqrmyc995trnywox38kmy X-Rspamd-Queue-Id: B4354A0007 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1749822843-261041 X-HE-Meta: U2FsdGVkX18ntluY+Lx3KDB6xXThBNlI55y+7Ky7bWoJ5igiYpBZS6/BHf7F8RcLLgZenssep9rnJREhhOe5JS7ltS2kWU0aYJ19Qf4rW8OQpvlXehj+4rGA60AfAczEkFlLr8cY5WE31jCMkPM0t4I0PnpnndwS3ZRlDXVQ3ZreXQCaU0qXedoAfOg5iGwGS3A3CZgRzR9d67sX5IB/qN10YeUa97Es5tz7knXiuThvgWyZAAYZ62wxrSaGuC97wk/E6BLO5PggmiWCRroQrDZwqdBFs4FHaDlaxCP4zlfGgAy4sYJPu35gmAIHEBl9ZxoHEiHFdaUZGwQX4OLJ/1CDqG85lZPhP8GFl+lKnPAHIxOtokKR5coH8HVqQ9EEfol7FD0lgJoFBNajv0q447/erbM2Mr9E5LbcrvbMeadakycd6sryxgxF6S658qwkVhiwtaJeR4Q49ppKB2gi2exZtqj4iqphqktgGsXRXPH/YNyAe4sFXNzP24PnhGCpiT9kFE0qzvVjl99yxB66LOZInsSyscHj+9jW3/1dIFlytyc9n7wA6QTZxOdR0u73SSuzMSDMlJXOj2jARhOAfpwzA+MSv/C4Ssd0mWYKPeMyV+jZnu2D8PBn3UWFkp8HpynEKTzKwLCNeYApb1RwFRVcNY7QafsJGYqikpSiSJTxyyMW4yJZrtbEeYKfuvhOm5AG8+aGByd5Ag+HQ+716leNzC/Ot4B95kheLiPe8SNYxOrG9YZW8zC+cSVM2fJ54e/UG6JR3qiKTHeI/D5Yr8UUnSvhJcMAwe2nkNB4WejnAwzpTUMpdkiJdngQ0D64d+7mIo6QBXINqGf+yHz7mifCmvzmZmAyrRl7MU2mwd2L8EbdedsFdV2Rzdq1LnqNjdhFujjPQ9FoGxI574yahZngqm4M+6cbW0zb6vD1JeFXaCojvlR+mQveLIh6P3LxwdRlA/TLKawxcddbi3i GqRZ6WHZ cT1vgh4iDE2U508k2MYXCbld3MlBP1k/wN5lxm1ZNnYcLKnZ9dW22ekSnSNp8LFbYMUZQJ84EfyGbDrKOJl/2CLjlKe4u7fPBSqydSw8WPh09EEkgtDU8b37uU77dUynBk6HNfiMqHdrh1jgaSQSUXcF8/OvpdmCHNCMMJVtP9fV+F2g7rF7aIvIuUgrWgpcqcIZ58NB7UGdthPYx+SjJnH5FHjoK9e6oJqDJsfXxlwysixJ8/+PuWp1y87vBnBIflM6NOidS1Q4QO+QPc9QOFeKV4mwyUEJ9dyrzrbjS9njZ/oTabY5VWhaKd91OOojvoWVxgkfveP5s1X8XoioDx9k8htRkVL7KNWXXa8Xvch0B+vMpRGeorGfeTI6kTvWV6+1DGpVl8RgxV4QoCa2zvZKtSjaRq/H0Ycyou0GeHu+D6Bj6vmTzKN/U4ZJ7J+mBtPNGnhK3T4muaYLC1gfcW41Uiao4aP9pI+Whlakqbt32bGqhWydUPiSiAksIdvxcxXy4Tsqi6Kh3v0toV2jfOG25/RgPmS4jH9cp67rsLhJ4x8Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13.06.25 15:49, Oscar Salvador wrote: > On Fri, Jun 13, 2025 at 11:27:01AM +0200, David Hildenbrand wrote: >> Marking PMDs that map a "normal" refcounted folios as special is >> against our rules documented for vm_normal_page(): normal (refcounted) >> folios shall never have the page table mapping marked as special. >> >> Fortunately, there are not that many pmd_special() check that can be >> mislead, and most vm_normal_page_pmd()/vm_normal_folio_pmd() users that >> would get this wrong right now are rather harmless: e.g., none so far >> bases decisions whether to grab a folio reference on that decision. >> >> Well, and GUP-fast will fallback to GUP-slow. All in all, so far no big >> implications as it seems. >> >> Getting this right will get more important as we use >> folio_normal_page_pmd() in more places. >> >> Fix it by teaching insert_pfn_pmd() to properly handle folios and >> pfns -- moving refcount/mapcount/etc handling in there, renaming it to >> insert_pmd(), and distinguishing between both cases using a new simple >> "struct folio_or_pfn" structure. >> >> Use folio_mk_pmd() to create a pmd for a folio cleanly. >> >> Fixes: 6c88f72691f8 ("mm/huge_memory: add vmf_insert_folio_pmd()") >> Reviewed-by: Jason Gunthorpe >> Reviewed-by: Lorenzo Stoakes >> Reviewed-by: Dan Williams >> Tested-by: Dan Williams >> Signed-off-by: David Hildenbrand > > Altough we have it quite well explained here in the changelog, maybe > having a little comment in insert_pmd() noting why pmds mapping normal > folios cannot be marked special would be nice. Well, I don't think we should be replicating that all over the place. The big comment above vm_normal_page() is currently our source of truth (which I will teak soon further). Thanks! -- Cheers, David / dhildenb