From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E592C35274 for ; Fri, 15 Dec 2023 15:16:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EABEB8D0133; Fri, 15 Dec 2023 10:16:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E5C0C8D0121; Fri, 15 Dec 2023 10:16:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD5D88D0133; Fri, 15 Dec 2023 10:16:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BD1278D0121 for ; Fri, 15 Dec 2023 10:16:42 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 823C5A0D85 for ; Fri, 15 Dec 2023 15:16:42 +0000 (UTC) X-FDA: 81569404644.07.7314E20 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 31E771C0022 for ; Fri, 15 Dec 2023 15:16:38 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CDxSEGaY; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702653399; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=asun5SQoVzNEadbgSuV5IwpyX4NIYMVVqDbKSzKYW00=; b=Cca4jb9mr1pubYuIRdObeR1Qd8LZOYEsv9Of1kTFy9tN0x6E+zr/4UkvOnDUZzoh1oWqN7 NsVU3Cn4N3W7Yjj5fXLbBnQ9HxBroOhGwFR5OrkvlEBpkY0NZh51P3mox9VM+Q9I5eaT/c LmC03fsCbEkdEwG9/tI6KPdCNe5iAzU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702653399; a=rsa-sha256; cv=none; b=GPforxD/AHTl836Oy7RNLhF17w4Cyk4p19sJzrObC7myn0SxU3YTBJr3+sgUf8U4Yk4cgk c52ihMLTYU1W5n5UBDS0id1GhCLZsWEHVITwUbZycp+uIBlJs8qzcx+HNTJ90SzkfnHROu O1nY3NfDqMdQ8BfTKm4iOMvFy/GJj9U= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CDxSEGaY; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702653398; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=asun5SQoVzNEadbgSuV5IwpyX4NIYMVVqDbKSzKYW00=; b=CDxSEGaYharFCt1KmwdQZkbQRNyAVU91NG1j8RXPUJbudHmafmhBhG6B6lApKS0fByBTQh mEE5lPzuk+TAOesxfr3QNmem/M9JgbBpWNPKIk8aA76H6cLzyBiLD+E3YwazErtBKe0AhT WF7bhJC3jAq4AmE3ciu2Mb4X+ECGuWg= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-491-MkXF-hN0MA2Ie96Rzt2ivw-1; Fri, 15 Dec 2023 10:16:36 -0500 X-MC-Unique: MkXF-hN0MA2Ie96Rzt2ivw-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-33652ced20fso398103f8f.1 for ; Fri, 15 Dec 2023 07:16:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702653395; x=1703258195; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=asun5SQoVzNEadbgSuV5IwpyX4NIYMVVqDbKSzKYW00=; b=INDkEMiH5n8k97OC4P93e+a2vNhp8lRrOnykg1kdKUHlgmAml3b92rU4y+zKLEaTVI mtg3pWDWUwBXciNAvmYe0g3AZ320axnq+6WqfQ2ZM2di0jOEegrpEf2ltfL+jz9gaj5Z RjA4do56uT5WVM+GrzD4RbKh0LegUEzlh5RVoTnOaHgG2AiG/GBA4plCDve68x2qQoPZ FODhySc8lOlc3sX7GsiBSz8nKtH4M8pkTDpyK/r3Z/7iED5m9JkosAMamTz4x/scTh0N Uj/XeTZTrKPWvgc9aJreWpDRwi2UYxEiwGLUicRfnE/m+d+Ct28XP379IOW9BUmWDQvg DgDA== X-Gm-Message-State: AOJu0YxIBhKDM8kV5dQTzYwnJUETSUIBbP5gK+6c3TD0OHvkRby3OTOB iB+IPJJEPRz0NHQ5irJrs8tm+lvmoOZmDe2R0AdeiBgW02DT6ekPofuCfYqN2YDRe+jSDpiBKXc nXhz+diXbYPI= X-Received: by 2002:a05:600c:20d:b0:40c:37e9:dcb2 with SMTP id 13-20020a05600c020d00b0040c37e9dcb2mr6170751wmi.74.1702653395611; Fri, 15 Dec 2023 07:16:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IHQf3IjuNDtC3izg4zYeAl77WfHRboOn7Tw13yf8yN5k+5/Ue7l5vXvCrR84LEtzS9NMOigbw== X-Received: by 2002:a05:600c:20d:b0:40c:37e9:dcb2 with SMTP id 13-20020a05600c020d00b0040c37e9dcb2mr6170733wmi.74.1702653395075; Fri, 15 Dec 2023 07:16:35 -0800 (PST) Received: from ?IPV6:2003:cb:c708:2c00:5a30:a88d:5f06:da45? (p200300cbc7082c005a30a88d5f06da45.dip0.t-ipconnect.de. [2003:cb:c708:2c00:5a30:a88d:5f06:da45]) by smtp.gmail.com with ESMTPSA id h2-20020a05600c350200b0040c44b4a282sm21572071wmq.43.2023.12.15.07.16.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Dec 2023 07:16:34 -0800 (PST) Message-ID: <4ac7912e-724a-448b-b396-960956a46b37@redhat.com> Date: Fri, 15 Dec 2023 16:16:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 14/39] mm/rmap: introduce folio_add_anon_rmap_[pte|ptes|pmd]() To: "Yin, Fengwei" , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Andrew Morton , "Matthew Wilcox (Oracle)" , Hugh Dickins , Ryan Roberts , Mike Kravetz , Muchun Song , Peter Xu References: <20231211155652.131054-1-david@redhat.com> <20231211155652.131054-15-david@redhat.com> <941c2269-98f0-43a7-a516-cb5b4909ae7f@intel.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <941c2269-98f0-43a7-a516-cb5b4909ae7f@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: cbm6jty6du97bdxegoskzytonubt5wsy X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 31E771C0022 X-Rspam-User: X-HE-Tag: 1702653398-451696 X-HE-Meta: U2FsdGVkX19x3T3Yt2N5jhldHVLEg/E8u+53bt+Z4hg7Pmh8lcgNuumXKhscOLejgK16ggIuB8fvd9jq+8jWLyib2X1iVwVbQGLHjOsEoZnnzM41VLic52YKS8h2+iY0Bbmp/GQ0cfefdtoSY8PIW+mu81ngW556fKG9tP3vBF4sbUHj7ID1ey0Hxyxlx9Xe2U2JFexnEKqDs2FTkh67FE4UzWyRNnyMqeMzPddydC5a9nSxKCqJbJM665foLlZNcWU9/+3B/APUGx8Xn25hXKcBPtuPBlWxEF63nhnq+3r/gPUEXulktGxxVh8n3D7r4EpkZzJjFGQ4dnkuss9zsmDLbwLpbua8mPjw6XODvuhEjOTY5CLXnxdT4+YkmpH7XwuVdMCtIbpQ+Ma+B0EpZBXkps9KPG4Syeu+xJbZrj3Z9gfwSXiTucpbWRjqt2N2LeOnGOmWmLl9oSbbuIb1Xcn4SLP6vDcokePsK/xisDqlUBFudgHlM1wObVNVmQKjKIIYgRwBgVpmHSa9F+mjYlTNGILoCpHzqSVpz+DgNsKwLXupQvRd+6PMq/IiiwqSsvsutRLJsIFCJlJOIzDepq155zqd927rLZt81Aq0KMdOufVpGfwXkuUJtxqrHydr+1Za0FRY5ISdX9zX2Y1vlJIiR6r6O7rgVyG+2v5PjKVWCIN0CDhQJNNKy3u9uEXjjkSZntHxIQ6uis720FYqZeNBam+UnSGkFyDmTF1iIA0OrGnQl/QJ2Bbsy7loeKhKxkILDuC41PNH+L4csUz2ue3QPlTVfSECOQKxKny1zJQd1FxSV4lFSkKcBpBkWQj4oBNtzRLUZvc2ufhpsdUjnY4egHOqEKdun9bOAYb5VEU+sSNAzrSnlCWDwxYURIO7rIZbshhqk47sjoP/+/K8dhHAy0jMz2bk439gyirvalkqRqMi4H+3f9zV8yUztGAwv2ZtOcy0vZtYn1puFWz emeTyAXo /OIDLVpuByyhOzPeSWSAlkp1uXNwY425eWYo6bhRVD0RGX8r+DXC7yp7PUI5WLiU0qoKticC6CI1+DysHCvcwEBLMzCmTrG61qBDy9O9UU9wVo68ItFnAlV88pSfy8PP/ly5lzLdgQCMhv74Huv21fRdjfDvKfTke9mqk/RX7MzQqK3YIeJa3sPfqWcpbDUEKOc+Lzxtx0/krTIzI0y8wIbhn5yBzzodWM8Uu4+omihr/DJoIgGdJsJTduZso7ujGRL6avIn6Z9FSR3fmEorFlTxAwimGl3XSJYhb8HOp7C8f8vzaYFRSJfUso7k3nQj+S5cxjXsz/b5DqZ02pdkYeoYKCwLfyE59Zcg1QzhXcq2wgqYsr1K56DVxLRPvSELVB5J8Px/Bm8dZw2fs/gJK9W9MWcwJSTQw/kJ2w1bYSfFlODKepdYBvkn+mPF57cVr7NWVsGCX75c+kQjkriWRlnZrr+SYGUyq3VYYMtrQS9qGDCRDquxie6EzX1n/c65x9EwjG7ltFsHT6EM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 15.12.23 03:26, Yin, Fengwei wrote: > > > On 12/11/2023 11:56 PM, David Hildenbrand wrote: >> Let's mimic what we did with folio_add_file_rmap_*() so we can similarly >> replace page_add_anon_rmap() next. >> >> Make the compiler always special-case on the granularity by using >> __always_inline. >> >> Note that the new functions ignore the RMAP_COMPOUND flag, which we will >> remove as soon as page_add_anon_rmap() is gone. >> >> Signed-off-by: David Hildenbrand > Reviewed-by: Yin Fengwei > > With a small question below. > Thanks! [...] >> + if (flags & RMAP_EXCLUSIVE) { >> + switch (mode) { >> + case RMAP_MODE_PTE: >> + for (i = 0; i < nr_pages; i++) >> + SetPageAnonExclusive(page + i); >> + break; >> + case RMAP_MODE_PMD: >> + SetPageAnonExclusive(page); >> + break; >> + } >> + } >> + for (i = 0; i < nr_pages; i++) { >> + struct page *cur_page = page + i; >> + >> + /* While PTE-mapping a THP we have a PMD and a PTE mapping. */ >> + VM_WARN_ON_FOLIO((atomic_read(&cur_page->_mapcount) > 0 || >> + (folio_test_large(folio) && >> + folio_entire_mapcount(folio) > 1)) && >> + PageAnonExclusive(cur_page), folio); >> + } > This change will iterate all pages for PMD case. The original behavior > didn't check all pages. Is this change by purpose? Thanks. Yes, on purpose. I first thought about also separating the code paths here, but realized that it makes much more sense to check each individual subpage that is effectively getting mapped by that PMD, instead of only the head page. I'll add a comment to the patch description. -- Cheers, David / dhildenb