From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6549C3DA78 for ; Tue, 17 Jan 2023 11:14:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2BB016B0078; Tue, 17 Jan 2023 06:14:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 244556B007B; Tue, 17 Jan 2023 06:14:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 097326B007D; Tue, 17 Jan 2023 06:14:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id EAF4E6B0078 for ; Tue, 17 Jan 2023 06:14:37 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id BDD821A09F0 for ; Tue, 17 Jan 2023 11:14:37 +0000 (UTC) X-FDA: 80364032994.23.56D234C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 51957180002 for ; Tue, 17 Jan 2023 11:14:34 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GccErK2y; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673954075; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AZ99tWIQfiVtOBhXs6iRfqQWLkG99GmDtKwZHwV3+6A=; b=a7BCXh3yHdpXwNgKmcbAlFZYS4AHFU7r/knzK0m+BHFHoj00RrqdiM7E4cOPwaSXGO623I bBv4ha2668wOgv3n39B45h58CWL7TTZ5Lp22llh4Fav8wNYz7z7vwgaqwyDzmXZZJ5vtUr aJP8kDxSnrJ6bkVOKSKoJ/6qEV8CLn0= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GccErK2y; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673954075; a=rsa-sha256; cv=none; b=b+N9FbAeGHOP8LqUF4OeuKIECtgDKXCMnlz+m4Kb5VLAlFsLZtz1kHSROG5R7Ouamdern/ a6q7f8GN29blZy5mU0zyS+oQAPEroj0wf0I0Jt27oGHI1qsRqk12RwzVgRZHKpbn6maGIo rsvEcFx3jzzVX4ubs6UQEjy3JEF/0u0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673954074; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AZ99tWIQfiVtOBhXs6iRfqQWLkG99GmDtKwZHwV3+6A=; b=GccErK2y+dbFIT6pPhSx7a7ERElTmsvpl/Q2RKXBEBpIBHlMbqXlRbxufZXmFDgoIRPlCN NeoXmpGyoM4zh7s6i5ZfGPU5D3rrhIMMDc/cEBlvgdZTyPXkQMOgXq62yI71/F/VXP89CL 7e6k4ehLVKuoFyVpmrMn/O6YpV4OUmk= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-41-Xyc_izOJOgSbDorjXBkLTg-1; Tue, 17 Jan 2023 06:14:33 -0500 X-MC-Unique: Xyc_izOJOgSbDorjXBkLTg-1 Received: by mail-wm1-f69.google.com with SMTP id ay38-20020a05600c1e2600b003da7c41fafcso4619395wmb.7 for ; Tue, 17 Jan 2023 03:14:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AZ99tWIQfiVtOBhXs6iRfqQWLkG99GmDtKwZHwV3+6A=; b=PpJsZNpqYKmFkccji5S2l2bmHG5z5cVTeR95cmc8lCvbMQC8UYIMHX28DlMly7K6Bq THyRqWh3C8EmtWh7olxcJOkaAcokwlTZfSDtupNC7LmFS1+Ajz+4iMIZxCjnlaj7/VbP z/KC4sCyziS1K4JdUN2GXhOwEvpTOU4Z+tz33ATCf5gpH5OOHPQu2S+JkPgVXCAk/xeK kGQMajA2RkjouDlxaJeMCk9wJcJieOxtOHlqrZ3qhhN0Zp+o7viaLBKP4am42lvTND3F ja2N7n5FlYnZJe4+3iOLplIHSZLz30MKpXXeHL4QW9SX8yS7pt+ngSO2CLosN+/wEGa7 JH8Q== X-Gm-Message-State: AFqh2kr6Lkc9j0B5OeZ+gzEmR59gDkDz60YdgUM6basx5NmnnJhclP9I Udu6tjSg0flHpe2O6ahTGu+f7dONsJioeCdXUFCAeZUmNBMpjtTr1ExTh/W8ATyvRFCxqCGX3Vd ylPSiulZTu+k= X-Received: by 2002:a05:600c:1604:b0:3c6:e61e:ae74 with SMTP id m4-20020a05600c160400b003c6e61eae74mr2727340wmn.4.1673954072040; Tue, 17 Jan 2023 03:14:32 -0800 (PST) X-Google-Smtp-Source: AMrXdXujcYUwdW4dfyBijkjHTTqNZxJZzlbVppyFUeXexBHyixLVwkcHsQAv5xOwBAruMCrX37Bpdg== X-Received: by 2002:a05:600c:1604:b0:3c6:e61e:ae74 with SMTP id m4-20020a05600c160400b003c6e61eae74mr2727314wmn.4.1673954071761; Tue, 17 Jan 2023 03:14:31 -0800 (PST) Received: from ?IPV6:2003:cb:c708:f00:323e:5956:8da1:9237? (p200300cbc7080f00323e59568da19237.dip0.t-ipconnect.de. [2003:cb:c708:f00:323e:5956:8da1:9237]) by smtp.gmail.com with ESMTPSA id s7-20020a1cf207000000b003d98438a43asm34758449wmc.34.2023.01.17.03.14.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Jan 2023 03:14:31 -0800 (PST) Message-ID: <4ac11b6a-284c-c763-f3c6-45a53c272f47@redhat.com> Date: Tue, 17 Jan 2023 12:14:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [RFC PATCH V1 1/1] sched/numa: Enhance vma scanning logic To: Raghavendra K T , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , Andrew Morton , Matthew Wilcox , Vlastimil Babka , "Liam R . Howlett" , Peter Xu , xu xin , Yu Zhao , Colin Cross , Arnd Bergmann , Hugh Dickins , Bharata B Rao , Disha Talreja References: <67bf778d592c39d02444825c416c2ed11d2ef4b2.1673610485.git.raghavendra.kt@amd.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <67bf778d592c39d02444825c416c2ed11d2ef4b2.1673610485.git.raghavendra.kt@amd.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 51957180002 X-Stat-Signature: t6896xkiqbdgp7nsaz9ccbkes4txaij6 X-HE-Tag: 1673954074-213550 X-HE-Meta: U2FsdGVkX1+VQexa5nywUrtkSrHvKP2Wg5gVCQYRqmFgXNCW6vFv7TckBKjtg9KNjZX7hBt3zeIjzqwXimFoR5L83GYiY8j7y1LAyPlyvhLLNal8dg0FCu+p3sAip1qyC9OvKPgvNMt3tPBXeI6DB6mo+0iu0URWAZhEaOxzsnAgui7jam5+Ek33ADi01RDW+Jqs9RDF+/6gMC5nPWTfmSN+y4umxTd2ddjx9HK9yfqerrQuhxhnXupMlnfMUaanqczFJk9PXXUju+cOMy2+AO5yS42XAkbnj/rAf914greTcSaZQ3R2t6+H0pqKyyGQgTjhBbEB7pjsvtf+mvy3zd5COhs3ry7chCr5lpxRhyDnbMdDgJaJXz4VI8MVL9TNFFH+aVp4IOkdSg27GtGB/Ccgx84Km+7VwHJ0YXyDObqxkiN9U+hhms8vSN0UMLPj/ym3TzqlCF4IRy5Gb+7zL3cd6TJUpoTW1nzooKqPn+ctI7Jc/D78CNGwbYYZCSochj8sSWW8w4BbCe5Ih5XwdKTUsGbij9X22zY/bi7/p3qkUHL1ke0+W+DkwL1eOMh//bqZQJa2Qed2CvQ8mMFf5yuMZ1OeUXna/HXiogsFCocvWqydcS+m0bvfxEPCUYwsBQL3Pwaa0x9Ma/MWAHYaVjtvTeV1iKxFgHKNlay++8WuWNAC7U/kp2KNpLsIFxwucdoOwuOm/i/wSfDaGNofB7GpQNrE2HEq4bLdKGxw84vNxoj0E3XqSxEGi0CKQ0ddM0d36s9H2/XUr+jO6P9kVz3zQ9BfEdqa1zZz2XDbr1puJ+uQclY8tfQU53Jm6H4WT+8yucV8tZZ1CaO6+GESn/2iKylT2yj2bmCXE3smdGt9ZH3OYafSkwNQ5Evba3kjm16ILeCcyt/INVUSbxZwOJBYGGS/aAxr1f3VhvbTbSB6plH/RWsg83Os8SR23c9+MM5IXk4/lKV8Vf3kuEe EvB+UZyK cZHcQcKoYSUaixcffyHGWux27Qt5B5iW2sZIct1zRoGFOd3aYCy5GHUT1V/gO8L52odiHl8tmrrs593oiEvlxY97fO0PYu9vJO+sI4nximkDocoCwoYCzWpejrP/Pi52DQmECMpZMMc5HhzbNLbx7dKnN5/iat92fyBFLminOj15MQMZ/TarUQw0LNyloF3oAWHD1tvqAPFLRlwuTYgZ9hKqBMw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 16.01.23 03:25, Raghavendra K T wrote: > During the Numa scanning make sure only relevant vmas of the > tasks are scanned. > > Logic: > 1) For the first two time allow unconditional scanning of vmas > 2) Store recent 4 unique tasks (last 8bits of PIDs) accessed the vma. > False negetives in case of collison should be fine here. > 3) If more than 4 pids exist assume task indeed accessed vma to > to avoid false negetives > > Co-developed-by: Bharata B Rao > (initial patch to store pid information) > > Suggested-by: Mel Gorman > Signed-off-by: Bharata B Rao > Signed-off-by: Raghavendra K T > --- > include/linux/mm_types.h | 2 ++ > kernel/sched/fair.c | 32 ++++++++++++++++++++++++++++++++ > mm/memory.c | 21 +++++++++++++++++++++ > 3 files changed, 55 insertions(+) > > diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h > index 500e536796ca..07feae37b8e6 100644 > --- a/include/linux/mm_types.h > +++ b/include/linux/mm_types.h > @@ -506,6 +506,8 @@ struct vm_area_struct { > struct mempolicy *vm_policy; /* NUMA policy for the VMA */ > #endif > struct vm_userfaultfd_ctx vm_userfaultfd_ctx; > + unsigned int accessing_pids; > + int next_pid_slot; > } __randomize_layout; What immediately jumps at me is the unconditional grow of a VMA by 8 bytes. A process with 64k mappings consumes 512 KiB more of memory, possibly completely unnecessarily. This at least needs to be fenced by CONFIG_NUMA_BALANCING. -- Thanks, David / dhildenb