From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F4A2C433E7 for ; Mon, 19 Oct 2020 10:30:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7EE082225A for ; Mon, 19 Oct 2020 10:30:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=windriversystems.onmicrosoft.com header.i=@windriversystems.onmicrosoft.com header.b="LQRwW2SQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7EE082225A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=windriver.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 832846B005D; Mon, 19 Oct 2020 06:30:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E2156B0062; Mon, 19 Oct 2020 06:30:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 683A16B0068; Mon, 19 Oct 2020 06:30:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0201.hostedemail.com [216.40.44.201]) by kanga.kvack.org (Postfix) with ESMTP id 39F236B005D for ; Mon, 19 Oct 2020 06:30:01 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id B400F180AD811 for ; Mon, 19 Oct 2020 10:30:00 +0000 (UTC) X-FDA: 77388304560.02.ray08_1611d8327236 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id 895921021285E for ; Mon, 19 Oct 2020 10:30:00 +0000 (UTC) X-HE-Tag: ray08_1611d8327236 X-Filterd-Recvd-Size: 9711 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2058.outbound.protection.outlook.com [40.107.94.58]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Mon, 19 Oct 2020 10:29:58 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CjiQ8P5yB8mTQ9/ksd//eDmlHZ9dL7NXsF6t4Z5yYRZhhkoNRCCeJtHUFFJrXJf73bEwKecV/TTFcT3vP1qmjoygeR+0GeefDxqaGt6WHec73LecGIBXZGrfW8YlFFgRg0X0UIter6M+inuSQhk9KeSrZEvHTL3MdHZqwFuxbfANGX1xXOZfbG4KELVXAiNs6uUoZa5rCVPJOhen+/2rPRzIAlmS0D7302mNE9a4RvTYqcIsmSZHFPg1iMjV3d38eBXawwen7XnDLilBy+Bs9R6PkmdCqVssU0Cjc5MwtJQLuO4wYdiaHDLTyTC0ZLU3/4CHZiN7SpQF6vCaql4x1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y39+0+MdeRZbDExeNbPHrPk/wkgzmOYxxPBy9qiKtbc=; b=j0SQj26AEGi0IjeBP3a55I36vPWkXju02FWR6jFKBHcAE++ap6OMmxw+RZasjGZJgnLJagXNlbSNM4nAPWp/YmPq/AcOpOEH2+3optaIR5B5tOvXhGoppRRMrxDNXLoCt+Sy61mIszvfzM4TRXQi/8JsgOeXyGcNOxMRXGQBbcYqZjAb1iWWn0h7LjpPh51+vZaHzirkgLv7qzweGTJbTtcpqC9Xr28P+K1lpx9qMmturB8m9228Xf8YrjqD0ntdY+x6BDb3Em/Hv0BJfrzw1ma5KgQdNAKIgfyj9ikmpOztusjFh0pBgXuHSlgR5aVD4/pIothIop7q+rBioYh+ag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=windriver.com; dmarc=pass action=none header.from=windriver.com; dkim=pass header.d=windriver.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriversystems.onmicrosoft.com; s=selector2-windriversystems-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y39+0+MdeRZbDExeNbPHrPk/wkgzmOYxxPBy9qiKtbc=; b=LQRwW2SQ89NCAiUPBUar+F1ihtR8lK/OhKpXr527v0LQdCp7IY70d7HWwDlLQYaLO45u/QjBfELIj06nxz66Abv+OjeQtgngt5O7Ac7GByIG4LJnLxAJJ7bl2TM0IMlXVEfQZANkRHOwDK1OI/K1AGdOfGaGTOQ8yilpHuzv4Ko= Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=windriver.com; Received: from BY5PR11MB4241.namprd11.prod.outlook.com (2603:10b6:a03:1ca::13) by BYAPR11MB3767.namprd11.prod.outlook.com (2603:10b6:a03:fd::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.25; Mon, 19 Oct 2020 10:29:55 +0000 Received: from BY5PR11MB4241.namprd11.prod.outlook.com ([fe80::adbd:559a:4a78:f09b]) by BY5PR11MB4241.namprd11.prod.outlook.com ([fe80::adbd:559a:4a78:f09b%6]) with mapi id 15.20.3477.028; Mon, 19 Oct 2020 10:29:54 +0000 Subject: Re: [PATCH v2] mm/compaction: Rename 'start_pfn' to 'iteration_start_pfn' in compact_zone() To: Vlastimil Babka , akpm@linux-foundation.org, david@redhat.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20201019083632.25417-1-yanfei.xu@windriver.com> <57730b8a-f5d7-d6c7-3961-3fa95701aba5@suse.cz> From: "Xu, Yanfei" Message-ID: <4aa294a0-c256-7e89-55af-6a7c790eec4d@windriver.com> Date: Mon, 19 Oct 2020 18:29:49 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 In-Reply-To: <57730b8a-f5d7-d6c7-3961-3fa95701aba5@suse.cz> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Originating-IP: [60.247.85.82] X-ClientProxiedBy: BYAPR07CA0040.namprd07.prod.outlook.com (2603:10b6:a03:60::17) To BY5PR11MB4241.namprd11.prod.outlook.com (2603:10b6:a03:1ca::13) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [128.224.162.160] (60.247.85.82) by BYAPR07CA0040.namprd07.prod.outlook.com (2603:10b6:a03:60::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.20 via Frontend Transport; Mon, 19 Oct 2020 10:29:53 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9e658b36-365a-4bcd-f64b-08d87419eb49 X-MS-TrafficTypeDiagnostic: BYAPR11MB3767: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:949; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Opn4NTIiAPR4IK3yfVoNvnYAENnXfVRuw72UJMIliSWoJpSMaRkmqOyTzrZoDCqCOX9D83uchcZrismyr6i8Zovo8k5ObRyUrOzaAeP4gzNzTSRaxileGAuyprsr465XkYBupwblz+JW5c48s6HG6KlODoG0FYN0J8j7aB7LJjC5RiudU/LO+i0Jh0gHRSf34Ohr/DqgEZGthNJ2OxQJiXtuY07HyA+co3T9jIPT19hYtUuhGhFpQq+PM3whkfvt4VSDk24EdYOJuYsEnSe/x8RUmso9CniRMZUqmuSAHpkazQ5CgNrxbI+2aWnRCD3HXteUa+DapyL49MlVTZzPJSQyFup6Ps50VKDhyTeFJ3GD4Btki7AzKzmoC1Y6+7TbMsKHOL5hFd3JpNFVfynt+Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR11MB4241.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(39850400004)(396003)(366004)(346002)(136003)(16526019)(8676002)(5660300002)(186003)(6706004)(956004)(16576012)(2906002)(36756003)(2616005)(478600001)(316002)(66946007)(6486002)(86362001)(83380400001)(6666004)(31686004)(66556008)(26005)(52116002)(53546011)(66476007)(4326008)(8936002)(31696002)(78286007)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: zciUVxPyOOJSG+NRFpuWhfVWj0H0gg5H2/CS/Ts//zrKnOqpP9SZKdtCJ7AnNFhQ1bCwNJQLZWSzZ386lZvVi5vQ4Eve9Ksz/LX26/jxUQ1KSuyTpGV1hGTaLWFAQ2l8hwEty0wr1I35I/uD9K0RUgIfCcOSDZ3uIbqKeNWhJ66ZiPyAa/33oOblBC5ksaqcSuxEDWKH68jMuybXQurtOH+849OwbSzk4RcWlzwLkt3zNCF+0BddJIY+BE3xZ31pUqm28I0QBvdEgapNpQPZIMZzJCV/LuWppfxSKRWz9BOqHRzOcKzreytd39pGMuI3Xf+JzimCBDDcUmjcpJilBodFiOoJCeCqgsWDJBeQmeIfI2XG3PQhL3criGniPyUvGHo0Igq0GYa9bWAOGbw/sY89vCj05yywKRDhvANa9m3cQWXBftck4qalJmY0Aak4aPHZoCop8ERR+RwdNlbFfFSAqj2sQWiXYjvWf2gRzpcj6vLL/u8rtp9nbWlEpv89xXOY577VzlLNWYuuFSScapliJaAvXJUu5g4n7pzeI+KGB0edbzq1sOXzHsNSOBnOnthw6DC7FWbV/i+OF3l+9iQ5vafvup04ZY94cOfPRU1nNMn/cm0uunTYQ/06ToUK1lQ0BWpybha8oq6Bs7IRug== X-OriginatorOrg: windriver.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9e658b36-365a-4bcd-f64b-08d87419eb49 X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4241.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2020 10:29:54.7030 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: imzlBt4dsKGPp54jED2Osynfn2UFoUeiZ4AbwXJKhVpCKdnTKydez8HXcuD4ZjFnzgEQRbXXzze6/eQ6ejFqZg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3767 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/19/20 5:40 PM, Vlastimil Babka wrote: > On 10/19/20 10:36 AM, yanfei.xu@windriver.com wrote: >> From: Yanfei Xu >> >> There are two 'start_pfn' declared in compact_zone() which have >> different meaning. Rename the second one to 'iteration_start_pfn' >> to prevent trace_mm_compaction_end() from tracing an undesirable >> value. >=20 > "to prevent confusion.", because trace_mm_compaction_end() has the > correct value even before the patch - the second start_pfn is out > of scope at that point. >=20 > Thanks > In the while-statement, the second start_pfn is always be reassigned the=20 value of cc->migrate_pfn in every loop, also the cc->migrate_pfn might=20 be changed in the loop. Does trace_mm_compaction_end() really want to=20 trace the new assinged start_pfn? Without the patch=EF=BC=9A 566e54e11=EF=BC=88mm, compaction: remove last_= migrated_pfn=20 from compact_control=EF=BC=89, there is only one start_pfn which has a fi= xed=20 value. The trace_mm_compaction_end() trace it too. Thus, I think the tracepoint might get an undesireble value.:) Thanks, Yanfei >> BTW, remove an useless semicolon. >> >> Acked-by: David Hildenbrand >> Acked-by: Vlastimil Babka >> Signed-off-by: Yanfei Xu >> --- >> v1->v2: >> Rename 'start_pfn' to 'iteration_start_pfn' and change commit messages= . >> >> =C2=A0 mm/compaction.c | 7 +++---- >> =C2=A0 1 file changed, 3 insertions(+), 4 deletions(-) >> >> diff --git a/mm/compaction.c b/mm/compaction.c >> index 176dcded298e..ccd27c739fd6 100644 >> --- a/mm/compaction.c >> +++ b/mm/compaction.c >> @@ -2272,7 +2272,7 @@ compact_zone(struct compact_control *cc, struct=20 >> capture_control *capc) >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 while ((ret =3D compact_finished(cc)) =3D= =3D COMPACT_CONTINUE) { >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 int err; >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned long start_pfn =3D= cc->migrate_pfn; >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned long iteration_st= art_pfn =3D cc->migrate_pfn; >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * Avoid m= ultiple rescans which can happen if a page cannot be >> @@ -2284,7 +2284,7 @@ compact_zone(struct compact_control *cc, struct=20 >> capture_control *capc) >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 */ >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 cc->rescan =3D = false; >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (pageblock_s= tart_pfn(last_migrated_pfn) =3D=3D >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pa= geblock_start_pfn(start_pfn)) { >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pa= geblock_start_pfn(iteration_start_pfn)) { >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 cc->rescan =3D true; >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } >> @@ -2308,8 +2308,7 @@ compact_zone(struct compact_control *cc, struct=20 >> capture_control *capc) >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 goto check_drain; >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 case ISOLATE_SU= CCESS: >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 update_cached =3D false; >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 la= st_migrated_pfn =3D start_pfn; >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ; >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 la= st_migrated_pfn =3D iteration_start_pfn; >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 err =3D migrate= _pages(&cc->migratepages, compaction_alloc, >> >=20 >=20