From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7342CC25B4F for ; Wed, 8 May 2024 06:03:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A93646B0083; Wed, 8 May 2024 02:03:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A43056B0089; Wed, 8 May 2024 02:03:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 958DF6B008A; Wed, 8 May 2024 02:03:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 788896B0083 for ; Wed, 8 May 2024 02:03:44 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id EC4D6A1257 for ; Wed, 8 May 2024 06:03:43 +0000 (UTC) X-FDA: 82094187126.02.9E830E3 Received: from out30-119.freemail.mail.aliyun.com (out30-119.freemail.mail.aliyun.com [115.124.30.119]) by imf19.hostedemail.com (Postfix) with ESMTP id B7EED1A0021 for ; Wed, 8 May 2024 06:03:40 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=M0dC76PS; spf=pass (imf19.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.119 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715148222; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=quezWr5QuXsegJOKyc01UZwoa4UGQB+lMfqaDG5ySt4=; b=FonOa8OwQDeiJKR80FL2NVsSSRQYZY5c7h4V1JteClc2iQ7SNBKzGgfQwyzb/eNk+xDArA wpq0UO4RcsILjKIcWWyULkKExNk0t8rwmULH6yJAbPmY2IDePR5aRCjYKbZTN5igCbPtDo lgdJZmTxYBa9UbrjNCW9kidgy2Wfnko= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=M0dC76PS; spf=pass (imf19.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.119 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715148222; a=rsa-sha256; cv=none; b=gkWNeL/DPEAws/M5yvA06zj2/3Zysx+5jgpZaWmxtZ1cLY61hn1Q1QKsUK22VAey1+SO4r NbAgHorHYUiC/V8p661bAU2napT4Mz0ZuGPKwMy9unRzes3fFXGxGAkjLh6J18KfPfX0DQ tRgJIZ+z0EgsVGPk/Gr7ri/G3Zdudpo= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1715148217; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=quezWr5QuXsegJOKyc01UZwoa4UGQB+lMfqaDG5ySt4=; b=M0dC76PSi5EJU+kfyDhPKEE/dF4SPcbeDfaMMu/z14myLJy/Ks0SylhLhtbTlegEv5b1bXKWS+17yLrU1NZrRbKFMfwIFTHIRLyeBeK/eBAXnqSfc9Rnfums6yk6Y+tTuYHR/4ZToXElUsDFleu8vtcysg+p4ubFUfS55orR1cg= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R181e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033032014031;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=16;SR=0;TI=SMTPD_---0W62W8yi_1715148214; Received: from 30.97.56.69(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0W62W8yi_1715148214) by smtp.aliyun-inc.com; Wed, 08 May 2024 14:03:35 +0800 Message-ID: <4a6c6c90-04bd-4a02-9080-0f98e8cf5ebe@linux.alibaba.com> Date: Wed, 8 May 2024 14:03:34 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/8] mm: shmem: add mTHP support for anonymous shmem To: kernel test robot , akpm@linux-foundation.org, hughd@google.com Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, willy@infradead.org, david@redhat.com, ioworker0@gmail.com, wangkefeng.wang@huawei.com, ying.huang@intel.com, 21cnbao@gmail.com, ryan.roberts@arm.com, shy828301@gmail.com, ziy@nvidia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <202405071820.2KY0UnDu-lkp@intel.com> From: Baolin Wang In-Reply-To: <202405071820.2KY0UnDu-lkp@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: f5t98y77384t7fobkhrdzriph7fzo4on X-Rspam-User: X-Rspamd-Queue-Id: B7EED1A0021 X-Rspamd-Server: rspam05 X-HE-Tag: 1715148220-617986 X-HE-Meta: U2FsdGVkX19Lqr186OVQ2a3AnSevVJQHnL9uOHU5V4YOeyU0yh5FH/j3jTN88sN57rSS+gfOV8wOEkbNEyY0pn1DwjDn7pPlEDFlbDC7yqrs5dSQHyGCcz85zXh3YsShgqwutFYXX3PutF6RnF/DHrfVqrOpwYcDJ35X+oeJUdr/SF3I5JHnYAdFEh/8zII6zU0rfbznifXrU8brYfDWI71Knf4Fu/N/nrJjA8T2862qYZ29M52qM8o3mjUR4JkOS6QOwfcuRstXNdDG5VFVbwJHWidUR2NR69zWC2l+eEoM/hAo2TzXvd5f5ZF5WC5b7JdK30UOjI3d5GZ5kkoHLlxSKMyFp4GhVT2lPSakXYRSj1EpCUzNfYvJgWZJ1R7PnMdX6iv6VExAgrigg3G64iHPQAvEkH3JTe5NyFnlpBN5xEk7nEJMVAH1EjJonbafMVDVCJSJ6MZ9IlTXz18A3tlz6NizlUyRxxnFX9/CA6SnDaDtD+bMqy+72gSmmnfkR//bSwrea3mO1TVK7xyzhK7FszjmYIYYHtqxAQGd4a5t+a3LEpvDPx1K8tKr30ZGgvM85M6nhTagyTni49sqzQx+HCX1TzWoEncKlHvr76GgMqxynm4sn2Tuseq/I3iOlrghvlk8tTUdOvLqd9arqT6AeXO5bP3xP7eP+o8ysJIzCCwVSRMze4XR/8AyapmKOC74gfC8ZCTaayOrKmbASFyDDgwev82V5v60Du6rN/GTQ7u2OZVwQbO80dek/pPJcQH7yvOT2L68XH54hqkX5VQiHQvBidIYhAwOp4S3eWdNdShXLTYmSJ0dOM6pGusJBQauNL6Neg773NkOnf/JQGCHY7EyiNgJ4jmgyu/tiht4c7sVgqeRRNY7JUco6fuuNUuGFQGu+Elv9RSQ5AfRJ/9V4rxPs4UlptL4C9A94bIb/L2IwdWzJb3jHDOLvEHa751gyodL/2EpCOg3UTM EfkGVHv5 sOErNkMMrrPRxOAiWT4HnUEoLanLhhIpRzHuNDpb1J+xpSNUzHAIQESV4vL0p6Xoks4pqN0ZvQz9DU1ykYhSKCjbfGHUM84Rh4QYezbb9qwLMbNQFPAXXqb1zdgyG2XbjBYNPO2WKfdjvye4e5A6c+yEpI9kNamrUBNyOepjowYKotldU2JmJDZanq3i169Zcq9fB9DQeOUgttUvqImxi/Su/2JaincBgaMLIYY2Baai1KuLctIYSe0UwaSYlObdYITXKFYvlY4ynwJ2oVUi68ZFeT752WAdPIHJ70ZBmnSf/Ovg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On 2024/5/7 18:46, kernel test robot wrote: >>> mm/shmem.c:1780:10: warning: variable 'folio' is used uninitialized whenever 'while' loop exits because its condition is false [-Wsometimes-uninitialized] > 1780 | while (suitable_orders) { > | ^~~~~~~~~~~~~~~ > mm/shmem.c:1795:7: note: uninitialized use occurs here > 1795 | if (!folio) > | ^~~~~ > mm/shmem.c:1780:10: note: remove the condition if it is always true > 1780 | while (suitable_orders) { > | ^~~~~~~~~~~~~~~ > | 1 > mm/shmem.c:1750:21: note: initialize the variable 'folio' to silence this warning > 1750 | struct folio *folio; > | ^ > | = NULL > mm/shmem.c:1564:20: warning: unused function 'shmem_show_mpol' [-Wunused-function] > 1564 | static inline void shmem_show_mpol(struct seq_file *seq, struct mempolicy *mpol) Thanks for reporting. Will add below change to avoid the warning: diff --git a/mm/shmem.c b/mm/shmem.c index d603e36e0f4f..fd2cb2e73a21 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -1747,7 +1747,7 @@ static struct folio *shmem_alloc_and_add_folio(struct vm_fault *vmf, struct shmem_inode_info *info = SHMEM_I(inode); struct vm_area_struct *vma = vmf ? vmf->vma : NULL; unsigned long suitable_orders; - struct folio *folio; + struct folio *folio = NULL; long pages; int error, order;