From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 448E3ECAAA1 for ; Tue, 6 Sep 2022 08:42:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D27808026E; Tue, 6 Sep 2022 04:42:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CD61080224; Tue, 6 Sep 2022 04:42:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC5E48026E; Tue, 6 Sep 2022 04:42:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id AEF2080224 for ; Tue, 6 Sep 2022 04:42:03 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 89887160CE7 for ; Tue, 6 Sep 2022 08:42:03 +0000 (UTC) X-FDA: 79881018126.21.576A46C Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by imf10.hostedemail.com (Postfix) with ESMTP id EDC05C0065 for ; Tue, 6 Sep 2022 08:42:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662453723; x=1693989723; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=8Y/bjET5zZ30la5m327NqJfIsBDroX957IXK6TjR0Kk=; b=ZeVP+SZzTEc4HvWgxkHTcI3xWAn4bxW3ACGKPd39G3QPnYYHzRlIbtXk DpR1HJigZy6fHXOwt7zzpZzTSCi6Cr+FeIS+nD8kCiyeMoPq8JRoD3psy TX4jzwHkPH3LQKrMqgGoq/vCp2xSc4RGtUNotmxsN51dZggIbcfHV3Uql l70qguUuj87c5QLPoMEYyj460avsAtBzKanxSPmE4VFNxt7JhO1MoKpoH 4WinBonTQ9wdhB9Q7AA08cjW63eisooI8u+I9rbI9IgFQZWuDDlcqqtnb 1Gwzl3GHXTCLrXCBcc96HvgCWRXfHApV8IBRHbF7EMC2F+4nxCFV+KHqW Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10461"; a="296541405" X-IronPort-AV: E=Sophos;i="5.93,293,1654585200"; d="scan'208";a="296541405" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Sep 2022 01:42:01 -0700 X-IronPort-AV: E=Sophos;i="5.93,293,1654585200"; d="scan'208";a="644077988" Received: from jiebinsu-mobl.ccr.corp.intel.com (HELO [10.238.0.228]) ([10.238.0.228]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Sep 2022 01:41:57 -0700 Message-ID: <4a6937b9-08b1-0f52-18db-13e17e344786@intel.com> Date: Tue, 6 Sep 2022 16:41:55 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.1.1 Subject: Re: [PATCH v2 1/2] percpu: Add percpu_counter_add_local Content-Language: en-US To: Shakeel Butt Cc: akpm@linux-foundation.org, vasily.averin@linux.dev, dennis@kernel.org, tj@kernel.org, cl@linux.com, ebiederm@xmission.com, legion@kernel.org, manfred@colorfullife.com, alexander.mikhalitsyn@virtuozzo.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, tim.c.chen@intel.com, feng.tang@intel.com, ying.huang@intel.com, tianyou.li@intel.com, wangyang.guo@intel.com, jiebin.sun@intel.com References: <20220902152243.479592-1-jiebin.sun@intel.com> <20220905193516.846647-1-jiebin.sun@intel.com> <20220905193516.846647-3-jiebin.sun@intel.com> <20220905193159.eeu2xmqj6743kzxv@google.com> From: "Sun, Jiebin" In-Reply-To: <20220905193159.eeu2xmqj6743kzxv@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662453723; a=rsa-sha256; cv=none; b=ig1ycxuIXSk9CKS5Pwd4X80fCXrT2ev7xxEi9mrGwprLb3bZ7kTJ72MwYRGubsVMm4bALg ZS3RnEiBZAdBN9FPJYegIY0eh8rl/5VPMH73e3e889kYL+o2rzytVWDbBePiyG/RJeb0/B R9PAys/5ckJX+JpPRwxA4736Zg1t0Gk= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=ZeVP+SZz; spf=softfail (imf10.hostedemail.com: 192.55.52.115 is neither permitted nor denied by domain of jiebin.sun@intel.com) smtp.mailfrom=jiebin.sun@intel.com; dmarc=fail reason="No valid SPF" header.from=intel.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662453723; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lvVi9eRO8nK6WiRaUUEq6PdXDxzkRoi8PjJXr+OCwLw=; b=5CvBvYdi8ZvoQP3KTjoxYq8fxRKhLjMuOlbkRFpsWS+otb3DmUqykLLKt6qAw7TpfPDgkE /6FPFZK1p2iEYjlXRtU72vAfOxi0cibYYuejBrFBO3a20laMswArdtAV8ki+ArU+/q4o9P EB62NCiq39tA5e6qbNfZIPkQqKkWjgc= X-Stat-Signature: ickg1jhnj56pxrstpu5qrsr6kxztgy4j X-Rspamd-Queue-Id: EDC05C0065 X-Rspam-User: Authentication-Results: imf10.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=ZeVP+SZz; spf=softfail (imf10.hostedemail.com: 192.55.52.115 is neither permitted nor denied by domain of jiebin.sun@intel.com) smtp.mailfrom=jiebin.sun@intel.com; dmarc=fail reason="No valid SPF" header.from=intel.com (policy=none) X-Rspamd-Server: rspam08 X-HE-Tag: 1662453722-715191 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/6/2022 3:31 AM, Shakeel Butt wrote: > On Tue, Sep 06, 2022 at 03:35:16AM +0800, Jiebin Sun wrote: >> Add percpu_counter_add_local for only updating local counter >> without aggregating to global counter. > Please add why do we need this. Who should use this and who shouldn't. Thanks. I have added the code comment and change log in patch v3 and provided the info who should use it and who shouldn't. > >> Signed-off-by: Jiebin Sun > [...] > >> diff --git a/lib/percpu_counter.c b/lib/percpu_counter.c >> index ed610b75dc32..d33cb750962a 100644 >> --- a/lib/percpu_counter.c >> +++ b/lib/percpu_counter.c >> @@ -72,6 +72,12 @@ void percpu_counter_set(struct percpu_counter *fbc, s64 amount) >> } >> EXPORT_SYMBOL(percpu_counter_set); >> > Add a doc comment here on why someone want to use this? > >> +void percpu_counter_add_local(struct percpu_counter *fbc, s64 amount) >> +{ >> + this_cpu_add(*fbc->counters, amount); >> +} >> +EXPORT_SYMBOL(percpu_counter_add_local); >> + >> /* >> * This function is both preempt and irq safe. The former is due to explicit >> * preemption disable. The latter is guaranteed by the fact that the slow path >> -- >> 2.31.1 >>