From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55321C25B76 for ; Sat, 1 Jun 2024 15:34:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A66C6B0098; Sat, 1 Jun 2024 11:34:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 953666B009A; Sat, 1 Jun 2024 11:34:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F3756B009E; Sat, 1 Jun 2024 11:34:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 60A4F6B0098 for ; Sat, 1 Jun 2024 11:34:48 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B6B89120716 for ; Sat, 1 Jun 2024 15:34:47 +0000 (UTC) X-FDA: 82182717414.05.4F660D0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 79A361C000B for ; Sat, 1 Jun 2024 15:34:45 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=g0B5+T35; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717256085; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2QacpLrWBt2KXDo0hOhXCAz+jwCknJSRzclX8saHx00=; b=XrQq9ygsYXY8c6q5/48EUhylAlpXDOkzrE38NvtVcDdvW6KkbnPgWZPy7wos0/mt8qxD+c R0jF+6QgPu7HmAFHymLBHNNjI1yvD0tqDFpMhcugMoec5itygAC3cIsu+La8j1LfMc+jbw 1WCc+6E5CHQspYMZHuBMx89YWysRElg= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=g0B5+T35; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717256085; a=rsa-sha256; cv=none; b=GJmX1SJxj6MmFz+jQgBxnnFe9ma4i1mC/KVuWzxh5jVWr6uP86W+oEA2BkKaZwxLqnLi9n zmTVIYa4suzlGgNYnQ9WBlA4GtBQPB2icIzTlhUS3as69CfJNdmXbRqeseK0ZDh0wHt+Ku U4XvCchcplwzEaQOkUZ2LKicePEEH1U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717256084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=2QacpLrWBt2KXDo0hOhXCAz+jwCknJSRzclX8saHx00=; b=g0B5+T35zr7F8fRtuM5TrPMV5DKgp1GtUVjjT003A5a4cHlWZMJAQ0JigPcKPd7UbYUQOh 1SDhArJO5MJHCi73iN+uGAVRaRIkoH1Tn46WOhg0oWpCpi+D3/rSacAY5CVt7NT+94CdoB cgQI0w4Fiq3XvEc0hJpecK+hJUW0+DU= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-339-yUXYMdgEMU6dbpTkio7J4w-1; Sat, 01 Jun 2024 11:34:39 -0400 X-MC-Unique: yUXYMdgEMU6dbpTkio7J4w-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-35dcd39c6ebso1555784f8f.1 for ; Sat, 01 Jun 2024 08:34:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717256078; x=1717860878; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=2QacpLrWBt2KXDo0hOhXCAz+jwCknJSRzclX8saHx00=; b=YQ64GIoYv6rRmLW61rDgO5YFS9vPTSccE/6twKJK1ShhLCou3YIKDmZ0dywGkYCiIO Ht016sOgKfYGFAp81UBVBGs3LtTvFR7Fy2jTUcVQjfKecR9McWTgK/ZhWnmAs5404hFx qqEoG7AUsAVHxMozVYkc2zVm9hsf2kTu2tcLtVeaEFSk+uUdIFc2YMVy9V3CgDNnW4Rj rCbtsXSourMD7wAxtevoLNWpv6I+iXq0YwYopOJd50A8sK0zD35+n3m4h4iVITHVSIUx tDOQwrqw41KsJtPDxPuW2yxUDqLljRP4WsTRrHtfFPWXbb1nvrQ6efnGadCUN1YgFBBc 1pfw== X-Forwarded-Encrypted: i=1; AJvYcCVWBAW3oI04bpYMmhGcbjZXz45ZV2ApJUEUyK/LVum6MLWSZL0v7l3psygDRrGIzUAhL4oxKUBxXfVZ91pokMrmwXE= X-Gm-Message-State: AOJu0YwIEXSWwNdrV/HWRlFu5dA4qzxGWwhcquaqSgoLARvY3R3SBISY uHyXFKyDAV+qVL2Nlb02GrvD/QUlk0wNnuJpz28lpbHNtQBcEMNDoInJXXNjTe0SD0hRVoa+1y7 GDSfgB4+HOyobVD/giaOtmv+0FdJXBLiI2hWtGzhbQ3aU6ekN X-Received: by 2002:a5d:5267:0:b0:354:f144:43e6 with SMTP id ffacd0b85a97d-35e0e5f5b94mr4522595f8f.30.1717256078347; Sat, 01 Jun 2024 08:34:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGA5cNtcDXSFaiYMlBj29RjQBo7zIkx8+s9BoybwEP0kR8HKL0lvOwd4zyavyjfQ3ucFiVKLg== X-Received: by 2002:a5d:5267:0:b0:354:f144:43e6 with SMTP id ffacd0b85a97d-35e0e5f5b94mr4522584f8f.30.1717256077930; Sat, 01 Jun 2024 08:34:37 -0700 (PDT) Received: from ?IPV6:2003:cb:c71f:b300:1d59:157a:ba27:f7e0? (p200300cbc71fb3001d59157aba27f7e0.dip0.t-ipconnect.de. [2003:cb:c71f:b300:1d59:157a:ba27:f7e0]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35dd04da967sm4263993f8f.63.2024.06.01.08.34.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 01 Jun 2024 08:34:37 -0700 (PDT) Message-ID: <4a62a028-570f-43f9-bee2-d91276e075c0@redhat.com> Date: Sat, 1 Jun 2024 17:34:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: init_mlocked_on_free_v3 To: Lance Yang , akpm@linux-foundation.org, yjnworkstation@gmail.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, willy@infradead.org, 00107082@163.com, libang.li@antgroup.com References: <8118eabf-de9c-41a7-9892-3a1a5bd2071c@redhat.com> <20240601140917.43562-1-ioworker0@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240601140917.43562-1-ioworker0@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 79A361C000B X-Stat-Signature: x58kdctr8d4op7umd7n576z8drfp376j X-Rspam-User: X-HE-Tag: 1717256085-112286 X-HE-Meta: U2FsdGVkX1+d1LchecRpOZMoRH2MR40xfs6p/20wllKmybxihoqBfqg0Ku7Bm5oMCEXcdcCClHdAJof+Y4RhvM403aO17WVigd6FTk/+HycAh0GvEgLoXi2zfhBuQ1b+eVvM3+lGcb6A/p9eSI10K4AIwvCsSgbwuOmI14tQazRRep6mUTM7P3wRkmf1uI8v7gOQPVwO+0gBUosqjQIlu1Lm4WPxVks2WaQZQx+DIgLsx/nzvBhJie6Ff2++CohJU99fE9Tr6+Q+rOTuwOmLogpJsklUevMuFLT8RO4crn9ws8CqM6TrKs7bCR+ZFV3HRcDDAlHWCiuXyGDooQlY0pXhxFjtKOnz+lftI08Z9rDXLYvIbKz2i3A27Ea4okVx2IfJitoMGppUTwYdS3MR7xUTCHhjNn0lGoTYW3tRTq40qqAL9dQEr9aBdfHfDtQQgjxTqqhJlHcdkfyxcY5PKnE/s8FEOSzQo+/O1wXrLCduk9d8GMRu9jJZBK4KQXx6F03GpSMj99T1NJxTWrLvUc4lDVR6DQDL/z0Xkor83sde5OM+rHThGONJc+5w3IJTdFtHvt95Kx1zdPs4vAewHMd1Qmcr+Uet1yq8TrSrIKRwFKxl6sAzfI3PilN+/ilznGhzoiHbjdTGLwTUPrGZaD9Hf5f76eMrHQTjWJv1JjWwJ0Ylp8Ic7nPl1zHrdhg3yId9onesKvDt17yRi9bX/EUYCX/aKg1J68oNngGYAiMaX7xOh0uLN85NeY2gzh45oC46shCh6JSN9aYWvsyOpT3BJZeadm5W0VWfoFNotnyuNk8mK+rPltgPWte+0PvfbMw+jYxMjQ+Km+Btjzs1GvPoDAurCQwTraRQIteUQDEntdrac8f2ja1iA96k7pb1HRhDUw+GtkdiXnUABv4aFln9ty+lWTW8GooPqqjtoJIykpdOyyvmZlX/JfHspbhM83/CHKDfQr+xIAfW6k5 nLaUi0dU AoFoBUf6jBeBqiTcIsve1xV4CTzGACglm89xR2Lps4MggVLz1FKR4RRFA1rdfpf0Dgc8lL3jqCojkGj3jFTntdv5zUM/lHpFU5eg9m8XpXcCtCFc8aOSJ9k823OkWWyfdzsc0uPw7MvuT5cosS09TGYXqPt/fnB4uq93MwRFaVT5Qbt9Z0bJa/Kp+5h9AeNZwTANfqd4Rmn1Z2aOHoeVqUtXEyNNji8XyN9oxHT/MyzrGKrZ4OqJcKwJHj5c9E1trrxuU7nQBpFcR12oTp+8PO31QajYKzTJBHNhHV7OkJeaGIcVKbQkEVBA4GmBvw+nVN6NFoYj3sTAqZnAoT8JZ4UlnpTyFBGTJBw9TbOLhH4bRaP3vDMvutkl+7oZ5PZo6V290fdJcpUDZT4XjMK0cHewektoDQlydq1C1AOUyRZP6v5ak10mWlTnj86qMvWzxBs9dLD1rT9+x/5yCmjLHbAIgwzEbowjlPBL2+kESBEmT4PkkHCvu6/iIAKCVUwru0PzgaiTPltJyeeOjnf7odOkdsdwFPdKMV38b X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 01.06.24 16:09, Lance Yang wrote: > Completely agree with David's point[1]. I'm also not convinced that this is the > right approach :) > > It seems like this patch won't handle all cases, as David mentioned[1] before. > folio_remove_rmap_ptes() will immediately munlock a large folio (as large folios > are not allowed to be batch-added to the LRU list) via munlock_vma_folio() when > it is fully unmapped, so this patch does not work in this case. Even worse, if > we encounter a COW mlocked folio, we would run into trouble (data corruption). > > Hi Andrew, I just noticed that this patch has become part of v6.10-rc1, but it > has not been acked/reviewed yet. Is there any chance to revert it? Thanks Lance, for paying attention. I think I spotted this on LWN and thought "I don't recall that we agreed this is the right approach" but didn't have time to follow up. My opinion on this did not change. -- Cheers, David / dhildenb