From: David Hildenbrand <david@redhat.com>
To: Lance Yang <ioworker0@gmail.com>,
akpm@linux-foundation.org, yjnworkstation@gmail.com
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
willy@infradead.org, 00107082@163.com, libang.li@antgroup.com
Subject: Re: [PATCH] mm: init_mlocked_on_free_v3
Date: Sat, 1 Jun 2024 17:34:36 +0200 [thread overview]
Message-ID: <4a62a028-570f-43f9-bee2-d91276e075c0@redhat.com> (raw)
In-Reply-To: <20240601140917.43562-1-ioworker0@gmail.com>
On 01.06.24 16:09, Lance Yang wrote:
> Completely agree with David's point[1]. I'm also not convinced that this is the
> right approach :)
>
> It seems like this patch won't handle all cases, as David mentioned[1] before.
> folio_remove_rmap_ptes() will immediately munlock a large folio (as large folios
> are not allowed to be batch-added to the LRU list) via munlock_vma_folio() when
> it is fully unmapped, so this patch does not work in this case. Even worse, if
> we encounter a COW mlocked folio, we would run into trouble (data corruption).
>
> Hi Andrew, I just noticed that this patch has become part of v6.10-rc1, but it
> has not been acked/reviewed yet. Is there any chance to revert it?
Thanks Lance, for paying attention. I think I spotted this on LWN and
thought "I don't recall that we agreed this is the right approach" but
didn't have time to follow up.
My opinion on this did not change.
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2024-06-01 15:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 14:56 York Jasper Niebuhr
2024-04-01 22:34 ` Yuanchu Xie
2024-04-02 10:43 ` David Hildenbrand
2024-06-01 14:09 ` Lance Yang
2024-06-01 15:34 ` David Hildenbrand [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-03-29 11:54 York Jasper Niebuhr
2024-03-29 12:26 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a62a028-570f-43f9-bee2-d91276e075c0@redhat.com \
--to=david@redhat.com \
--cc=00107082@163.com \
--cc=akpm@linux-foundation.org \
--cc=ioworker0@gmail.com \
--cc=libang.li@antgroup.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
--cc=yjnworkstation@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox