From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33446C433EF for ; Mon, 13 Jun 2022 15:40:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4761D8D019F; Mon, 13 Jun 2022 11:40:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FE198D0171; Mon, 13 Jun 2022 11:40:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 251108D019F; Mon, 13 Jun 2022 11:40:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0FFBF8D0171 for ; Mon, 13 Jun 2022 11:40:07 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id D2768120A20 for ; Mon, 13 Jun 2022 15:40:06 +0000 (UTC) X-FDA: 79573623612.25.EBD420F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 5EE6440092 for ; Mon, 13 Jun 2022 15:40:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655134803; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9O1sbdf2ij2vjNGIB5kmQiO/dPYFEEYuNBpIJztkYLI=; b=HMNBmrl/tOfR9RJWjN7fUQS1ynIh/8k2dSvDQENFsKcBCPIsNr8JDBHRLC8JIvFllZQ1Cl Yz0t7bhA+kOKXV8Ir+rwZpOxSjRuMF5wuEwjbrO6BeVSWLXCIB0kc3yw18AMiese5QjmMn Hbl3zVneGMAnf6V2dV25sMcvs9gLr+Y= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-373-1L8kkWhAP7Woh33nkoxFuQ-1; Mon, 13 Jun 2022 11:40:02 -0400 X-MC-Unique: 1L8kkWhAP7Woh33nkoxFuQ-1 Received: by mail-wm1-f72.google.com with SMTP id p42-20020a05600c1daa00b0039c62488f7eso6052181wms.7 for ; Mon, 13 Jun 2022 08:40:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=9O1sbdf2ij2vjNGIB5kmQiO/dPYFEEYuNBpIJztkYLI=; b=JRm5u/mZ2ZqzijKGQzdim+Bdax0DChdY9wxJKvcoh3k1y5KEui/ryhW52Fnip5J8r+ /QvGXxvSb4SB674PrA2xfwI27TGe8+JCk4UB5WuvCbFS8WYFtF2TdRl7Pumlehbw883Z vFGjYYGwgPl0eAF3OREIW83+YhYja3csupwqTpfC05Ri86UCMJnKPGagNlktAoO9IYS0 vEeHFZoKf2NzAWU3UwnDYMYTMkaAh/E5KXziOQRWydtjj5qGR61d1SZeucy0J10skyav 5nWjC5kep42vT0GyvpeF28k8vREcKkWEfdbsdp750u/DSB3knkgPO9Qg4jPpIBt0gF+r Qj0Q== X-Gm-Message-State: AOAM5309ovUmB93toqh9tMmBUZeFEvWNn7LR/aIH5MViRVTv6RBqiaQo PK7ZQC5tMfcxflv2pGqYAsoUZtl183wY/O/saDUNyWrc/qJaenO7qs+4k26C1GTl5QKYj0JBFj1 1pQeqWgbCve0= X-Received: by 2002:a1c:7418:0:b0:39c:6ead:321c with SMTP id p24-20020a1c7418000000b0039c6ead321cmr54842wmc.171.1655134801559; Mon, 13 Jun 2022 08:40:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzd53JP6ehA2t0cS3jtwwK9+a0CJFs7Y0/eewsb9jvYGyOfgxsScdBrMX3bH7wHA4OxcpYqyA== X-Received: by 2002:a1c:7418:0:b0:39c:6ead:321c with SMTP id p24-20020a1c7418000000b0039c6ead321cmr54821wmc.171.1655134801302; Mon, 13 Jun 2022 08:40:01 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:bd00:963c:5455:c10e:fa6f? (p200300cbc706bd00963c5455c10efa6f.dip0.t-ipconnect.de. [2003:cb:c706:bd00:963c:5455:c10e:fa6f]) by smtp.gmail.com with ESMTPSA id l15-20020a05600c4f0f00b003942a244f39sm18189229wmq.18.2022.06.13.08.39.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jun 2022 08:40:00 -0700 (PDT) Message-ID: <4a6023f3-0fbd-32cf-7e52-bc72e2b4a407@redhat.com> Date: Mon, 13 Jun 2022 17:39:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 3/6] mm: hugetlb_vmemmap: introduce the name HVO To: Muchun Song , mike.kravetz@oracle.com, akpm@linux-foundation.org, corbet@lwn.net Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org References: <20220613063512.17540-1-songmuchun@bytedance.com> <20220613063512.17540-4-songmuchun@bytedance.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220613063512.17540-4-songmuchun@bytedance.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655134804; a=rsa-sha256; cv=none; b=nnptjzb80IkS5pFnalQKHtFkYvqEiPCIWXhFi01Vwynl3+buvr4WWbWLzPx+8pMn10j5rR KWkypXvHUixiPhu1uwQBLFar1+ZVVN21ExXFWXue+x8IjIoE7xBSu0F6uQEqff90bdf18T Jf1MnYLUwrFFZ48VBrWCn/P/dBSWA6c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655134804; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9O1sbdf2ij2vjNGIB5kmQiO/dPYFEEYuNBpIJztkYLI=; b=kiCKbCBI9FMruP2g/RS5Hw4sePtKKDPI5IjAtpN9DxRjbX2/wfmNfdYymveuzXRsyvD9nb D0bluGzgGlwT0dJL5Tck5BLZHeNjaw088PcjBs60rUhTdpcLvrDn/ou7BD3dkor3uwgSzV mHic/zZO3T9WBkbCCDDGYAWWz9pxWUY= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="HMNBmrl/"; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf04.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="HMNBmrl/"; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf04.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 5EE6440092 X-Stat-Signature: hq73rz3os8iozm68tiopoockw1s6s4sj X-HE-Tag: 1655134804-488787 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 13.06.22 08:35, Muchun Song wrote: > It it inconvenient to mention the feature of optimizing vmemmap pages associated > with HugeTLB pages when communicating with others since there is no specific or > abbreviated name for it when it is first introduced. Let us give it a name HVO > (HugeTLB Vmemmap Optimization) from now. > > This commit also updates the document about "hugetlb_free_vmemmap" by the way > discussed in thread [1]. > > Link: https://lore.kernel.org/all/21aae898-d54d-cc4b-a11f-1bb7fddcfffa@redhat.com/ [1] > Signed-off-by: Muchun Song > --- > Documentation/admin-guide/kernel-parameters.txt | 7 ++++--- > Documentation/admin-guide/mm/hugetlbpage.rst | 3 +-- > Documentation/admin-guide/sysctl/vm.rst | 3 +-- > fs/Kconfig | 13 ++++++------- > mm/hugetlb_vmemmap.c | 8 ++++---- > mm/hugetlb_vmemmap.h | 4 ++-- > 6 files changed, 18 insertions(+), 20 deletions(-) > > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt > index 391b43fee93e..7539553b3fb0 100644 > --- a/Documentation/admin-guide/kernel-parameters.txt > +++ b/Documentation/admin-guide/kernel-parameters.txt > @@ -1725,12 +1725,13 @@ > hugetlb_free_vmemmap= > [KNL] Reguires CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP > enabled. > + Control if HugeTLB Vmemmap Optimization (HVO) is enabled. > Allows heavy hugetlb users to free up some more > memory (7 * PAGE_SIZE for each 2MB hugetlb page). > - Format: { [oO][Nn]/Y/y/1 | [oO][Ff]/N/n/0 (default) } > + Format: { on | off (default) } > > - [oO][Nn]/Y/y/1: enable the feature > - [oO][Ff]/N/n/0: disable the feature > + on: enable HVO > + off: disable HVO > > Built with CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON=y, > the default is on. > diff --git a/Documentation/admin-guide/mm/hugetlbpage.rst b/Documentation/admin-guide/mm/hugetlbpage.rst > index a90330d0a837..64e0d5c512e7 100644 > --- a/Documentation/admin-guide/mm/hugetlbpage.rst > +++ b/Documentation/admin-guide/mm/hugetlbpage.rst > @@ -164,8 +164,7 @@ default_hugepagesz > will all result in 256 2M huge pages being allocated. Valid default > huge page size is architecture dependent. > hugetlb_free_vmemmap > - When CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP is set, this enables optimizing > - unused vmemmap pages associated with each HugeTLB page. > + When CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP is set, this enables HVO. Heh, it would be convenient to call this CONFIG_HUGETLB_PAGE_VMEMMAP_OPTIMIZATION (HVO) then. -- Thanks, David / dhildenb