From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F8ADD591AC for ; Mon, 18 Nov 2024 18:07:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED5F96B0088; Mon, 18 Nov 2024 13:07:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E914E6B008A; Mon, 18 Nov 2024 13:07:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CFF7B6B008C; Mon, 18 Nov 2024 13:07:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AF4616B0088 for ; Mon, 18 Nov 2024 13:07:39 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 6000A1A0413 for ; Mon, 18 Nov 2024 18:07:39 +0000 (UTC) X-FDA: 82799997588.18.58F947E Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by imf21.hostedemail.com (Postfix) with ESMTP id EF5B91C0018 for ; Mon, 18 Nov 2024 18:06:03 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux.microsoft.com header.s=default header.b=U8YJ5MEB; dmarc=pass (policy=none) header.from=linux.microsoft.com; spf=pass (imf21.hostedemail.com: domain of eahariha@linux.microsoft.com designates 13.77.154.182 as permitted sender) smtp.mailfrom=eahariha@linux.microsoft.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731953123; a=rsa-sha256; cv=none; b=oq1+u7eUP+tIEI8c9JlHGMv1up6gPntt0urT2RnUoHZGN4wtk42i3ilVvOnW5eJvp0o9+L suYF5osAmeTQNCxh33Ojg9rf+F2rROddyqW7qBymRoBc4p0GT63QFV2WwJ/jBZhvV9JH/f 8ikgqEEvfYwlrqFvSdo58psyCoblEu0= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux.microsoft.com header.s=default header.b=U8YJ5MEB; dmarc=pass (policy=none) header.from=linux.microsoft.com; spf=pass (imf21.hostedemail.com: domain of eahariha@linux.microsoft.com designates 13.77.154.182 as permitted sender) smtp.mailfrom=eahariha@linux.microsoft.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731953123; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lP0Zntp+HRWENCbPjrc9G2lDoefH/1cMkwirwj5j8Pw=; b=vv8myWT/KMdCBLXxvmBAb5JIWPUs1wlU+bjzVHoxesL5dBjaZsJ6pGolhucNjZD2bVtmQP vZxd9pCnulNzNyLFu1mqo2jjYgIXMjamAvMGkQZIN4WySricaYBPAapjEBdlc8ligzaUcT ZY2HuoG+IBSQzs9iOISnE2UYu9O4lPE= Received: from [192.168.35.166] (c-73-118-245-227.hsd1.wa.comcast.net [73.118.245.227]) by linux.microsoft.com (Postfix) with ESMTPSA id 3DD17206BCF9; Mon, 18 Nov 2024 10:07:25 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 3DD17206BCF9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1731953247; bh=lP0Zntp+HRWENCbPjrc9G2lDoefH/1cMkwirwj5j8Pw=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=U8YJ5MEB+lC4gUMBqZ4Gz30eL5pByQSSZkvP1DxkMnTP1qlIes9QjQ3oHvl0/spjY zaV4G+9kqg2wB6l6cY05sRrhV/1+2NwT0Di3E3r4OqgFDSinGSRYQd2YjZAhmOdf7k pgtoi2CJWleSz5F2PF0YMgIK9D4gDdAFvwZB2ktQ= Message-ID: <4a3e6cfe-35ef-4865-8b43-c002679455f3@linux.microsoft.com> Date: Mon, 18 Nov 2024 10:07:24 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Pablo Neira Ayuso , Jozsef Kadlecsik , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Julia Lawall , Nicolas Palix , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Ofir Bitton , Oded Gabbay , Lucas De Marchi , =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= , Rodrigo Vivi , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jeroen de Borst , Praveen Kaligineedi , Shailend Chand , Andrew Lunn , James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Jens Axboe , Kalle Valo , Jeff Johnson , Catalin Marinas , Andrew Morton , Jack Wang , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Greg Kroah-Hartman , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Xiubo Li , Ilya Dryomov , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , Joe Lawrence , Jaroslav Kysela , Takashi Iwai , Lucas Stach , Russell King , Christian Gmeiner , Louis Peens , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Madhavan Srinivasan , eahariha@linux.microsoft.com, "netfilter-devel@vger.kernel.org" , "coreteam@netfilter.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "cocci@inria.fr" , "linux-arm-kernel@lists.infradead.org" , "linux-s390@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "intel-xe@lists.freedesktop.org" , "linux-scsi@vger.kernel.org" , "xen-devel@lists.xenproject.org" , "linux-block@vger.kernel.org" , "linux-wireless@vger.kernel.org" , "ath11k@lists.infradead.org" , "linux-mm@kvack.org" , "linux-bluetooth@vger.kernel.org" , "linux-staging@lists.linux.dev" , "linux-rpi-kernel@lists.infradead.org" , "ceph-devel@vger.kernel.org" , "live-patching@vger.kernel.org" , "linux-sound@vger.kernel.org" , "etnaviv@lists.freedesktop.org" , "oss-drivers@corigine.com" , "linuxppc-dev@lists.ozlabs.org" , Anna-Maria Behnsen Subject: Re: [PATCH v2 00/21] Converge on using secs_to_jiffies() To: LEROY Christophe References: <20241115-converge-secs-to-jiffies-v2-0-911fb7595e79@linux.microsoft.com> From: Easwar Hariharan Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: EF5B91C0018 X-Stat-Signature: bsqkqb5hbxxkhdboqyfonofsj67rfbaw X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1731953163-519605 X-HE-Meta: U2FsdGVkX18uINLAWfPuz2fnIDS6n5vHHHKm+zmz8KzchcZfESMVO21O3c0SDukSRQWMxtA3n9CYccjfFqKRtSifR6V4+lbBFN9lW7HRzkLTdq8CU3grDRDNVoUrx936Lcsa5VvQpPWiBTnWSM9E1a3XQbmzKgF8X6H3XqNN+M2XQCOUNSyb8RxeTLrFIYZ2XuHILhy9oDUo23Isak8nUotKkfB5Ms7Mg9vixaQ8u5rNzUp5lTAR/4MSPh+Qbbq+MfoEajRgBr+M8EIoq9txVto5FcJDRuNdNP84HSTgEBwbvMDgGG5SVFJSnrkQm/CJYXptmDQZ6K0ytiu5u1xR09Q+16AmTt+guF2g1qkJxZ9y9ktUZH2KN1OjqDmEto48ljjacaSkBA63C6PeO+OVcVfUpWl4LRFulN1TvP04rTobKA2WlCJdKOr6Rbubvq/snsSZgfzmZrIKv8RUG2NBRiBRqGocGiCtj5KgCXOYurkoYcLhsDhzhmAeyU6pTUfL1D/otlJluZ564YFsoRZ4R3rqveHnXBIbaxGmpo3v8a+9jkd3SDoKx0SCPtTSjFE1oqdQU+gzLl5Y45KVd4fiXnIrWhYcXTptPXq+ncNvghB8VLKhIEwr8dLeM44VPbrVTw9127qVWV0bJAXHrct7n4owvwemM3+DYMY4NTndYL+jqmWP39/mmuSKgvoNNIMf9f3gAGlmRfSrQYIuSk8StIj80UsHo9OgYJgm63voDA7NlZy1+6Lb3ZIVGQXYysOmjdyENUvaU2/9l4dkzb681TjRBlaOX4d4ndCKke0oooZMxFOI1Gz51lpRGpGn+tIo7mbxCBNWMI56quauo9nrQDnJvcw5UUwfOvHV8Fbj9IfCI231bQUEBHyx7lZSiPj/prH6LoKFwSUW5ieEL1UxIiPoJ+ef/hfODGDp1r7hiSvhfe6mFLTmtQRzGHcRdk2jPUqSwWn1i+frLUpI6hP p9E93rG8 cfT9Yy3UASxgg4QDj+62k673iK7KTohoF/CN45NmOCE8P74BJmPIqnI3QHfpNu6Zb7HOqeGW+nywKQqSGMOKmgAaEgI76hixa1oKQN5rOnq0+NlPQrqjGoNsgBA9JG/qch50KzmPJnsxuhj+lKD7NiZqp9eJVtJu1S6yLJ97RjnC0L66lxCjkg8Mx5JF175J+ZU5JenZVPIrAtRO2u801B1Q/VVxnzwOf5grMWmuwR7CydPh5scY1ygl1EMXBdOV3YPS5yM6lz0Pf6mrh8cE54BS4htr86eKpa+AamtzGZaOC+85meuatRzKH8uKVkdXudZy0VevZhaQtyb2fQBz0uuh/10MTiDy5HfniKFQXsPpOFe072JvVTsHub1pz/3Ry2RkDKrHFN9+KnsP++WicSxZDeRCWbD7xoO9EelBezWCxr+ej/9A4FY/HUNY1nzbGNjDFt91XVXbYoxmqkZGuHP4ndMbsfrYEL3Tw9jyfXswwDozUfsOVHx0dV/0rKHOhWBvmvhEXkQH+cCmtsgvrqdRm3jJMO4UrCsR/MVvmljfuFWuPcaYToGV8AccmiddMaHkXVWZdDzO7vuqlXhYDXWvGOA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/16/2024 2:23 AM, LEROY Christophe wrote: > > > Le 15/11/2024 à 22:26, Easwar Hariharan a écrit : >> [Vous ne recevez pas souvent de courriers de eahariha@linux.microsoft.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] >> >> This is a series that follows up on my previous series to introduce >> secs_to_jiffies() and convert a few initial users.[1] In the review for >> that series, Anna-Maria requested converting other users with >> Coccinelle. This is part 1 that converts users of msecs_to_jiffies() >> that use the multiply pattern of either of: >> - msecs_to_jiffies(N*1000), or >> - msecs_to_jiffies(N*MSEC_PER_SEC) > > After applying this series on top of tip/timers/core tree, I still find > a lot of candidates to the conversion: > Thanks for looking, that pattern of seconds-denominated msecs_to_jiffies() calls will be addressed in a later part. As mentioned in my reply to Anna-Maria[1], I'm not super-familiar with Coccinelle. I sent this out as part 1 as mentioned in the cover letter above to make incremental progress as much as I could. Julia has sent me a message with a rule that could possibly address the pattern you point out. I also see there are some instances in the grep results that appear to be expression * 1000 rather than constant * 1000. I'll address those in one of the later parts as well. Thanks, Easwar